Skip to contentSkip to conversation

ath10k: Enhance logging for vdev pdev & peer set param

PATCH In review Rakesh Pillai 2 participants 3 messages Feb 15, 2019 – Feb 26, 2019 Qualcomm Atheros ATH10K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath10k: Enhance logging for vdev pdev & peer set param

Currently after enabling the WMI debug logging, there is no detail printed about the param id and the param value for the pdev, vdev and peer params which are set.

Enhance the WMI logging to print the param id and the param value for pdev, vdev and peer set param wmi commands.

Tested HW: WCN3990
Tested FW: WLAN.HL.2.0-01387-QCAHLSWMTPLZ-1

		WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1
---
 drivers/net/wireless/ath/ath10k/wmi-tlv.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/ath10k/wmi-tlv.c +7 -3
index 90617e1..98d8992 100644
@@ -1576,7 +1576,8 @@ ath10k_wmi_tlv_op_gen_pdev_set_param(struct ath10k *ar, u32 param_id,
 	cmd->param_id = __cpu_to_le32(param_id);
 	cmd->param_value = __cpu_to_le32(param_value);
 
-	ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv pdev set param\n");
+	ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv pdev set param %d value 0x%x\n",
+		   param_id, param_value);
 	return skb;
 }
 
@@ -2046,7 +2047,8 @@ ath10k_wmi_tlv_op_gen_vdev_set_param(struct ath10k *ar, u32 vdev_id,
 	cmd->param_id = __cpu_to_le32(param_id);
 	cmd->param_value = __cpu_to_le32(param_value);
 
-	ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv vdev set param\n");
+	ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv vdev %d set param %d value 0x%x\n",
+		   vdev_id, param_id, param_value);
 	return skb;
 }
 
@@ -2360,7 +2362,9 @@ ath10k_wmi_tlv_op_gen_peer_set_param(struct ath10k *ar, u32 vdev_id,
 	cmd->param_value = __cpu_to_le32(param_value);
 	ether_addr_copy(cmd->peer_macaddr.addr, peer_addr);
 
-	ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi tlv peer set param\n");
+	ath10k_dbg(ar, ATH10K_DBG_WMI,
+		   "wmi tlv vdev %d peer %pM set param %d value 0x%x\n",
+		   vdev_id, peer_addr, param_id, param_value);
 	return skb;
 }
 
Signature · 7 lines
2.7.4


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#1 lore raw
Quoted 9 lines · Rakesh Pillai

Currently after enabling the WMI debug logging, there is no detail printed about the param id and the param value for the pdev, vdev and peer params which are set.

Enhance the WMI logging to print the param id and the param value for pdev, vdev and peer set param wmi commands.

Quoted 6 lines

Tested HW: WCN3990
Tested FW: WLAN.HL.2.0-01387-QCAHLSWMTPLZ-1

		WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1

Patch applied to ath-next branch of ath.git, thanks.

1c136e41fb77 ath10k: enhance logging for vdev pdev & peer set param

Signature · 9 lines
https://patchwork.kernel.org/patch/10814285/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#2 lore raw
In reply to Rakesh Pillai
Quoted 9 lines · Rakesh Pillai

Currently after enabling the WMI debug logging, there is no detail printed about the param id and the param value for the pdev, vdev and peer params which are set.

Enhance the WMI logging to print the param id and the param value for pdev, vdev and peer set param wmi commands.

Quoted 6 lines

Tested HW: WCN3990
Tested FW: WLAN.HL.2.0-01387-QCAHLSWMTPLZ-1

		WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1

Patch applied to ath-next branch of ath.git, thanks.

1c136e41fb77 ath10k: enhance logging for vdev pdev & peer set param

Signature · 3 lines
https://patchwork.kernel.org/patch/10814285/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches