Skip to contentSkip to conversation

ath10k: remove the calibration data fetch for sdio

PATCH In review Wen Gong 2 participants 3 messages Feb 18, 2019 – Feb 26, 2019 Qualcomm Atheros ATH10K wireless driver

lore
Share & tools
lore

Wen Gong

author
#0 lore raw

PATCH 1/1 ath10k: remove the calibration data fetch for sdio

The calibration data fetch will trigger sdio error, then sdio will become fail untill reboot system.

If happens when run ifconfig wlan down, then ifconfig wlan up will fail untill reboot system.Remove it fix the ifconfig wlan issue.

Tested with QCA6174 SDIO with firmware
WLAN.RMH.4.4.1-00005-QCARMSWP-1.

---
 drivers/net/wireless/ath/ath10k/debug.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/net/wireless/ath/ath10k/debug.c +3 -0
index 15964b3..c33a51f 100644
@@ -1263,6 +1263,9 @@ static int ath10k_debug_cal_data_fetch(struct ath10k *ar)
 	if (WARN_ON(ar->hw_params.cal_data_len > ATH10K_DEBUG_CAL_DATA_LEN))
 		return -EINVAL;
 
+	if (ar->hw_params.cal_data_len == 0)
+		return -EOPNOTSUPP;
+
 	hi_addr = host_interest_item_address(HI_ITEM(hi_board_data));
 
 	ret = ath10k_hif_diag_read(ar, hi_addr, &addr, sizeof(addr));
Signature · 1 line
1.9.1
#1 lore raw
Quoted 11 lines · Wen Gong

The calibration data fetch will trigger sdio error, then sdio will become fail untill reboot system.

If happens when run ifconfig wlan down, then ifconfig wlan up will fail untill reboot system.Remove it fix the ifconfig wlan issue.

Tested with QCA6174 SDIO with firmware
WLAN.RMH.4.4.1-00005-QCARMSWP-1.

Patch applied to ath-next branch of ath.git, thanks.

6566abea0b97 ath10k: remove the calibration data fetch for sdio

Signature · 9 lines
https://patchwork.kernel.org/patch/10817363/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#2 lore raw
In reply to Wen Gong
Quoted 11 lines · Wen Gong

The calibration data fetch will trigger sdio error, then sdio will become fail untill reboot system.

If happens when run ifconfig wlan down, then ifconfig wlan up will fail untill reboot system.Remove it fix the ifconfig wlan issue.

Tested with QCA6174 SDIO with firmware
WLAN.RMH.4.4.1-00005-QCARMSWP-1.

Patch applied to ath-next branch of ath.git, thanks.

6566abea0b97 ath10k: remove the calibration data fetch for sdio

Signature · 3 lines
https://patchwork.kernel.org/patch/10817363/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches