Fixes for Tegra soctherm
Subsystems (2)
v8 cover Fixes for Tegra soctherm
This series fixed some issues for Tegra soctherm,
and add get_trend().
Main changes from v7:
1. use READ_ONCE to get temperature in get_trend()
Main changes from v6:
1. Per Eduardo's comment, we can remove the change:
"thermal: tegra: parse sensor id before sensor register"
Main changes from v5:
1. Move the get_trend() patch https://lkml.org/lkml/2018/11/20/643
into this serial.
Main changes from v4:
1. fixed for the parsing sensor id.
2. keep warning for missing critical trips.
Main changes from v3:
1. updated codes for parsing sensor id, per Thierry's comments
Main changes from v2:
1. add codes to parse sensor id to avoid registration failure.
Main changes from v1:
1. Acked by Thierry Reding <[email protected]> for the patch "thermal: tegra: fix memory allocation".
2. Print out the sensor name when register failed.
2. Remove patch "thermal: tegra: fix coverity defect"
*** BLURB HERE ***
Wei Ni (3):
thermal: tegra: remove unnecessary warnings
thermal: tegra: fix memory allocation
thermal: tegra: add get_trend ops
drivers/thermal/tegra/soctherm.c | 38 +++++++++++++++++++++++++++++++++++--- 1 file changed, 35 insertions(+), 3 deletions(-)
Signature · 1 line
2.7.4
PATCH v8 1/3 thermal: tegra: remove unnecessary warnings
Convert warnings to info as not all platforms may
have all the thresholds and sensors enabled.
--- drivers/thermal/tegra/soctherm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/thermal/tegra/soctherm.c +2 -2
@@ -569,7 +569,7 @@ static int tegra_soctherm_set_hwtrips(struct device *dev, set_throttle: ret =get_hot_temp (tz, &trip, &temperature);if (ret) { -dev_warn (dev,"throttrip: %s: missing hot temperature\n" , +dev_info (dev,"throttrip: %s: missing hot temperature\n" , sg->name);return 0 ; }
@@ -600,7 +600,7 @@ static int tegra_soctherm_set_hwtrips(struct device *dev, }if (i ==THROTTLE_SIZE ) -dev_warn (dev,"throttrip: %s: missing throttle cdev\n" , +dev_info (dev,"throttrip: %s: missing throttle cdev\n" , sg->name);return 0 ;
Signature · 1 line
2.7.4
PATCH v8 2/3 thermal: tegra: fix memory allocation
In reply to Wei NiFix memory allocation to store the pointers tothermal_zone_device.
--- drivers/thermal/tegra/soctherm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/tegra/soctherm.c +1 -1
@@ -1329,7 +1329,7 @@ static int tegra_soctherm_probe(struct platform_device *pdev) } tegra->thermctl_tzs =devm_kcalloc (&pdev->dev, - soc->num_ttgs,sizeof (*z), + soc->num_ttgs,sizeof (z),GFP_KERNEL );if (!tegra->thermctl_tzs)return -ENOMEM ;
Signature · 1 line
2.7.4
PATCH v8 3/3 thermal: tegra: add get_trend ops
In reply to Wei NiAdd support for get_trend ops that allows soctherm sensors to be used with the step-wise governor.
--- drivers/thermal/tegra/soctherm.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+)
drivers/thermal/tegra/soctherm.c +32 -0
@@ -488,9 +488,41 @@ static int tegra_thermctl_set_trip_temp(void *data, int trip, int temp)return 0 ; } +static int tegra_thermctl_get_trend (void *data,int trip, +enum thermal_trend *trend) +{ +struct tegra_thermctl_zone *zone = data; +struct thermal_zone_device *tz = zone->tz; +int trip_temp, temp, last_temp, ret; + +if (!tz) +return -EINVAL ; + + ret = tz->ops->get_trip_temp (zone->tz, trip, &trip_temp); +if (ret) +return ret; + + temp =READ_ONCE (tz->temperature); + last_temp =READ_ONCE (tz->last_temperature); + +if (temp > trip_temp) { +if (temp >= last_temp) + *trend =THERMAL_TREND_RAISING ; +else + *trend =THERMAL_TREND_STABLE ; + }else if (temp < trip_temp) { + *trend =THERMAL_TREND_DROPPING ; + }else { + *trend =THERMAL_TREND_STABLE ; + } + +return 0 ; +} +static const struct thermal_zone_of_device_ops tegra_of_thermal_ops = { .get_temp = tegra_thermctl_get_temp, .set_trip_temp = tegra_thermctl_set_trip_temp, + .get_trend = tegra_thermctl_get_trend, };static int get_hot_temp (struct thermal_zone_device *tz,int *trip,int *temp)
Signature · 1 line
2.7.4