Skip to contentSkip to conversation

HID: roccat: Mark expected switch fall-through

PATCH Applied Gustavo A. R. Silva 3 participants 4 messages Feb 11, 2019 – Feb 20, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HID: roccat: Mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/hid/hid-roccat-kone.c: In function ‘kone_keep_values_up_to_date’:
drivers/hid/hid-roccat-kone.c:784:20: warning: this statement may fall through [-Wimplicit-fallthrough=]
kone->actual_dpi = kone->profiles[event->value - 1]. ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

     startup_dpi;
     ~~~~~~~~~~~

drivers/hid/hid-roccat-kone.c:786:2: note: here
case kone_mouse_event_osd_profile:
^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.

---
 drivers/hid/hid-roccat-kone.c | 1 +
 1 file changed, 1 insertion(+)
drivers/hid/hid-roccat-kone.c +1 -0
index bf4675a27396..c4dd6162c1d6 100644
@@ -783,6 +783,7 @@ static void kone_keep_values_up_to_date(struct kone_device *kone,
 	case kone_mouse_event_switch_profile:
 		kone->actual_dpi = kone->profiles[event->value - 1].
 				startup_dpi;
+		/* fall through */
 	case kone_mouse_event_osd_profile:
 		kone->actual_profile = event->value;
 		break;
Signature · 1 line
2.20.1
maintainer
#1 lore raw
Quoted 30 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/hid/hid-roccat-kone.c: In function ‘kone_keep_values_up_to_date’:
drivers/hid/hid-roccat-kone.c:784:20: warning: this statement may fall through [-Wimplicit-fallthrough=]
kone->actual_dpi = kone->profiles[event->value - 1]. ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

     startup_dpi;
     ~~~~~~~~~~~

drivers/hid/hid-roccat-kone.c:786:2: note: here
case kone_mouse_event_osd_profile:
^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.

---
 drivers/hid/hid-roccat-kone.c | 1 +
 1 file changed, 1 insertion(+)
drivers/hid/hid-roccat-kone.c +0 -0
index bf4675a27396..c4dd6162c1d6 100644

drivers/hid/hid-roccat-kone.c static void kone_keep_values_up_to_date(struct kone_device *kone, · line 789

Quoted 7 lines
drivers/hid/hid-roccat-kone.c +1 -0
@@ -783,6 +783,7 @@ static void kone_keep_values_up_to_date(struct kone_device *kone,
 	case kone_mouse_event_switch_profile:
 		kone->actual_dpi = kone->profiles[event->value - 1].
 				startup_dpi;
+		/* fall through */
 	case kone_mouse_event_osd_profile:
 		kone->actual_profile = event->value;
 		break;

Stefan, could you please confirm that this is intended behavior?

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs
#2 lore raw

Am Dienstag, den 19.02.2019, 14:16 +0100 schrieb Jiri Kosina:

Quoted 47 lines · Gustavo A. R. Silva
Quoted 38 lines

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/hid/hid-roccat-kone.c: In function ‘kone_keep_values_up_to_date’:
drivers/hid/hid-roccat-kone.c:784:20: warning: this statement may fall through [-Wimplicit-fallthrough=]
kone->actual_dpi = kone->profiles[event->value - 1]. ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

     startup_dpi;
     ~~~~~~~~~~~

drivers/hid/hid-roccat-kone.c:786:2: note: here
case kone_mouse_event_osd_profile:
^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.

---
 drivers/hid/hid-roccat-kone.c | 1 +
 1 file changed, 1 insertion(+)
drivers/hid/hid- renamed from drivers/hid/hid-roccat-kone.c +0 -0

roccat-kone.c
index bf4675a27396..c4dd6162c1d6 100644

drivers/hid/hid-roccat-kone.c +0 -0
@@ -783,6 +783,7 @@ static void kone_keep_values_up_to_date(struct
 kone_device *kone,
 	case kone_mouse_event_switch_profile:
 		kone->actual_dpi = kone->profiles[event->value -

1].

drivers/hid/hid-roccat-kone.c static void kone_keep_values_up_to_date(struct kone_device *kone, · line 789

Quoted 5 lines
drivers/hid/hid-roccat-kone.c +1 -0
 				startup_dpi;
+		/* fall through */
 	case kone_mouse_event_osd_profile:
 		kone->actual_profile = event->value;
 		break;

Stefan, could you please confirm that this is intended behavior?

Quoted 1 line

Thanks,

I already confirmed this 7 months ago but as I see only in a reply to you.
Yes, this patch is correct.
Stefan

maintainer Applied
#3 lore raw
Quoted 2 lines · Stefan Achatz

I already confirmed this 7 months ago but as I see only in a reply to you.

I guess that fell in between cracks somewhere.

Quoted 1 line

Yes, this patch is correct.

Applied, thanks.

Signature · 2 lines
Jiri Kosina
SUSE Labs