clk: samsung: Fix kfree() of const memory on setting driver_override
Subsystems (4)
Krzysztof Kozlowski
maintainerv2 cover clk: samsung: Fix kfree() of const memory on setting driver_override
Hi,
Changes since v1:
1. Split clock-related fixes out of bigger platform patchset.
2. Remove usage of driver_override.
Best regards,
Krzysztof
Krzysztof Kozlowski (2):
clk: samsung: exynos5: Fix possible NULL pointer exception on
platform_device_alloc() failure
clk: samsung: exynos5: Fix kfree() of const memory on setting
driver_override
drivers/clk/samsung/clk-exynos5-subcmu.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)
Signature · 1 line
2.7.4
Krzysztof Kozlowski
maintainerPATCH v2 1/2 clk: samsung: exynos5: Fix possible NULL pointer exception on platform_device_alloc() failure
During initialization of subdevices if platform_device_alloc() failed, returned NULL pointer will be later dereferenced. Add proper error paths to exynos5_clk_register_subcmu(). The return value of this function is still ignored because at this stage of init there is nothing we can do.
--- drivers/clk/samsung/clk-exynos5-subcmu.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/clk/samsung/clk-exynos5-subcmu.c +8 -2
@@ -136,15 +136,21 @@ static int __init exynos5_clk_register_subcmu(struct device *parent, {struct of_phandle_args genpdspec = { .np = pd_node };struct platform_device *pdev; +int ret; pdev =platform_device_alloc (info->pd_name,-1 ); +if (!pdev) +return -ENOMEM ; + pdev->dev.parent = parent; pdev->driver_override ="exynos5-subcmu" ;platform_set_drvdata (pdev, (void *)info);of_genpd_add_device (&genpdspec, &pdev->dev); -platform_device_add (pdev); + ret =platform_device_add (pdev); +if (ret) +platform_device_put (pdev); -return 0 ; +return ret; }static int __init exynos5_clk_probe (struct platform_device *pdev)
Signature · 1 line
2.7.4
Re: [PATCH v2 1/2] clk: samsung: exynos5: Fix possible NULL pointer exception on platform_device_alloc() failure
Quoted 9 lines · Krzysztof Kozlowski
During initialization of subdevices if
platform_device_alloc()failed, returned NULL pointer will be later dereferenced. Add proper error paths toexynos5_clk_register_subcmu(). The return value of this function is still ignored because at this stage of init there is nothing we can do.Fixes b06a532bf1fa ("clk: samsung: Add Exynos5 sub-CMU clock driver")Cc <[email protected]>Signed-off-by Krzysztof Kozlowski <[email protected]>
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH v2 1/2] clk: samsung: exynos5: Fix possible NULL pointer exception on platform_device_alloc() failure
In reply to Krzysztof KozlowskiQuoting Krzysztof Kozlowski (2019-02-21 03:45:51)
Quoted 10 lines
During initialization of subdevices if
platform_device_alloc()failed, returned NULL pointer will be later dereferenced. Add proper error paths toexynos5_clk_register_subcmu(). The return value of this function is still ignored because at this stage of init there is nothing we can do.Fixes b06a532bf1fa ("clk: samsung: Add Exynos5 sub-CMU clock driver")Cc <[email protected]>Signed-off-by Krzysztof Kozlowski <[email protected]>---
Applied to clk-next
Krzysztof Kozlowski
maintainerPATCH v2 2/2 clk: samsung: exynos5: Fix kfree() of const memory on setting driver_override
In reply to Krzysztof KozlowskiPlatform driver driver_override field should not be initialized from const memory because the core later kfree() it. If driver_override is manually set later through sysfs, kfree() of old value leads to:
$ echo "new_value" > /sys/bus/platform/drivers/.../driver_override
kernel BUG at ../mm/slub.c:3960!
Internal error: Oops - BUG: 0 [#1] PREEMPT SMP ARM
...
(kfree) from [<c058e8c0>] (platform_set_driver_override+0x84/0xac)
(platform_set_driver_override) from [<c058e908>] (driver_override_store+0x20/0x34)
(driver_override_store) from [<c031f778>] (kernfs_fop_write+0x100/0x1dc)
(kernfs_fop_write) from [<c0296de8>] (__vfs_write+0x2c/0x17c)
(__vfs_write) from [<c02970c4>] (vfs_write+0xa4/0x188)
(vfs_write) from [<c02972e8>] (ksys_write+0x4c/0xac)
(ksys_write) from [<c0101000>] (ret_fast_syscall+0x0/0x28)The clk-exynos5-subcmu driver uses override only for the purpose of creating meaningful names for children devices (matching names of power domains, e.g. DISP, MFC). The driver_override was not developed for this purpose so just switch to default names of devices to fix the issue.
--- drivers/clk/samsung/clk-exynos5-subcmu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/clk/samsung/clk-exynos5-subcmu.c +1 -2
@@ -138,12 +138,11 @@ static int __init exynos5_clk_register_subcmu(struct device *parent,struct platform_device *pdev;int ret; - pdev =platform_device_alloc (info->pd_name,-1 ); + pdev =platform_device_alloc ("exynos5-subcmu" ,PLATFORM_DEVID_AUTO );if (!pdev)return -ENOMEM ; pdev->dev.parent = parent; - pdev->driver_override ="exynos5-subcmu" ;platform_set_drvdata (pdev, (void *)info);of_genpd_add_device (&genpdspec, &pdev->dev); ret =platform_device_add (pdev);
Signature · 1 line
2.7.4
Re: [PATCH v2 2/2] clk: samsung: exynos5: Fix kfree() of const memory on setting driver_override
Quoted 23 lines · Krzysztof Kozlowski
Platform driver
driver_overridefield should not be initialized from const memory because the core laterkfree()it. Ifdriver_overrideis manually set later through sysfs,kfree()of old value leads to:$ echo "new_value" > /sys/bus/platform/drivers/.../driver_overridekernel BUG at ../mm/slub.c:3960! Internal error: Oops - BUG: 0 [#1] PREEMPT SMP ARM ... (kfree) from [<c058e8c0>] (platform_set_driver_override+0x84/0xac) (platform_set_driver_override) from [<c058e908>] (driver_override_store+0x20/0x34) (driver_override_store) from [<c031f778>] (kernfs_fop_write+0x100/0x1dc) (kernfs_fop_write) from [<c0296de8>] (__vfs_write+0x2c/0x17c) (__vfs_write) from [<c02970c4>] (vfs_write+0xa4/0x188) (vfs_write) from [<c02972e8>] (ksys_write+0x4c/0xac) (ksys_write) from [<c0101000>] (ret_fast_syscall+0x0/0x28)The clk-exynos5-subcmu driver uses override only for the purpose of creating meaningful names for children devices (matching names of power domains, e.g. DISP, MFC). The
driver_overridewas not developed for this purpose so just switch to default names of devices to fix the issue.
Quoted 3 lines
Fixes b06a532bf1fa ("clk: samsung: Add Exynos5 sub-CMU clock driver")Cc <[email protected]>Signed-off-by Krzysztof Kozlowski <[email protected]>
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH v2 2/2] clk: samsung: exynos5: Fix kfree() of const memory on setting driver_override
In reply to Krzysztof KozlowskiQuoting Krzysztof Kozlowski (2019-02-21 03:45:52)
Quoted 23 lines
Platform driver
driver_overridefield should not be initialized from const memory because the core laterkfree()it. Ifdriver_overrideis manually set later through sysfs,kfree()of old value leads to:$ echo "new_value" > /sys/bus/platform/drivers/.../driver_overridekernel BUG at ../mm/slub.c:3960! Internal error: Oops - BUG: 0 [#1] PREEMPT SMP ARM ... (kfree) from [<c058e8c0>] (platform_set_driver_override+0x84/0xac) (platform_set_driver_override) from [<c058e908>] (driver_override_store+0x20/0x34) (driver_override_store) from [<c031f778>] (kernfs_fop_write+0x100/0x1dc) (kernfs_fop_write) from [<c0296de8>] (__vfs_write+0x2c/0x17c) (__vfs_write) from [<c02970c4>] (vfs_write+0xa4/0x188) (vfs_write) from [<c02972e8>] (ksys_write+0x4c/0xac) (ksys_write) from [<c0101000>] (ret_fast_syscall+0x0/0x28)The clk-exynos5-subcmu driver uses override only for the purpose of creating meaningful names for children devices (matching names of power domains, e.g. DISP, MFC). The
driver_overridewas not developed for this purpose so just switch to default names of devices to fix the issue.
Quoted 4 lines
Fixes b06a532bf1fa ("clk: samsung: Add Exynos5 sub-CMU clock driver")Cc <[email protected]>Signed-off-by Krzysztof Kozlowski <[email protected]>---
Applied to clk-next