ath10k: Add support to provide higher range mem chunks in wmi init command
PATCH v3 1/1 ath10k: Add support to provide higher range mem chunks in wmi init command
With the current implementation of wmi init command, there is no provision for the host driver to provide mem chunks addresses with more than 32-bit, to the firmware. WCN3990 is a 35-bit target and can accept mem chunks addresses which are above 32-bit.
If firmware supports address range more than 32 bit, it advertises the support by setting the WMI_SERVICE_EXTEND_ADDRESS service. Based on this service fill the upper bits of paddr while providing the mem chunks in the wmi init command.
Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1
---
This patch is dependent on following patch:
ath10k: correct the format of host memory chunks in wmi init command (https://patchwork.kernel.org/patch/10811669/)
--- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 10 ++++++-- drivers/net/wireless/ath/ath10k/wmi-tlv.h | 42 +++++++++++++++++++++++++++++++ drivers/net/wireless/ath/ath10k/wmi.h | 1 + 3 files changed, 51 insertions(+), 2 deletions(-)
drivers/net/wireless/ath/ath10k/wmi-tlv.c +8 -2
@@ -1572,7 +1572,7 @@ static enum wmi_txbf_conf ath10k_wmi_tlv_txbf_conf_scheme(struct ath10k *ar)static void ath10k_wmi_tlv_put_host_mem_chunks (struct ath10k *ar,void *host_mem_chunks) { -struct host_memory_chunk *chunk; +struct host_memory_chunk_tlv *chunk;struct wmi_tlv *tlv;int i;__le16 tlv_len, tlv_tag;
@@ -1589,6 +1589,12 @@ static enum wmi_txbf_conf ath10k_wmi_tlv_txbf_conf_scheme(struct ath10k *ar) chunk->size =__cpu_to_le32 (ar->wmi.mem_chunks[i].len); chunk->req_id =__cpu_to_le32 (ar->wmi.mem_chunks[i].req_id); +if (test_bit (WMI_SERVICE_SUPPORT_EXTEND_ADDRESS , + ar->wmi.svc_map)) + chunk->ptr_high =__cpu_to_le32 + (upper_32_bits + (ar->wmi.mem_chunks[i].paddr)); + ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi-tlv chunk %d len %d, addr 0x%llx, id 0x%x\n", i,
@@ -1612,7 +1618,7 @@ static struct sk_buff *ath10k_wmi_tlv_op_gen_init(struct ath10k *ar)void *ptr; chunks_len = ar->wmi.num_mem_chunks * - (sizeof (struct host_memory_chunk ) +sizeof (*tlv)); + (sizeof (struct host_memory_chunk_tlv ) +sizeof (*tlv)); len = (sizeof (*tlv) +sizeof (*cmd)) + (sizeof (*tlv) +sizeof (*cfg)) + (sizeof (*tlv) + chunks_len);
drivers/net/wireless/ath/ath10k/wmi-tlv.h +42 -0
60 lines not on this page · raw message
drivers/net/wireless/ath/ath10k/wmi.h +1 -0
@@ -200,6 +200,7 @@ enum wmi_service {WMI_SERVICE_RTT_RESPONDER_ROLE ,WMI_SERVICE_PER_PACKET_SW_ENCRYPT ,WMI_SERVICE_REPORT_AIRTIME , + WMI_SERVICE_SUPPORT_EXTEND_ADDRESS,/* Remember to add the new value to wmi_service_name()! */
Signature · 1 line
1.9.1
Quoted 11 lines · Surabhi Vishnoi
With the current implementation of wmi init command, there is no provision for the host driver to provide mem chunks addresses with more than 32-bit, to the firmware. WCN3990 is a 35-bit target and can accept mem chunks addresses which are above 32-bit.
If firmware supports address range more than 32 bit, it advertises the support by setting the
WMI_SERVICE_EXTEND_ADDRESSservice. Based on this service fill the upper bits of paddr while providing the mem chunks in the wmi init command.
Quoted 5 lines
Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1Signed-off-by Surabhi Vishnoi <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
40f4ef5e9232 ath10k: Add support to provide higher range mem chunks in wmi init command
Signature · 3 lines
https://patchwork.kernel.org/patch/10828535/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 11 lines · Surabhi Vishnoi
With the current implementation of wmi init command, there is no provision for the host driver to provide mem chunks addresses with more than 32-bit, to the firmware. WCN3990 is a 35-bit target and can accept mem chunks addresses which are above 32-bit.
If firmware supports address range more than 32 bit, it advertises the support by setting the
WMI_SERVICE_EXTEND_ADDRESSservice. Based on this service fill the upper bits of paddr while providing the mem chunks in the wmi init command.
Quoted 5 lines
Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1Signed-off-by Surabhi Vishnoi <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
40f4ef5e9232 ath10k: Add support to provide higher range mem chunks in wmi init command
Signature · 9 lines
https://patchwork.kernel.org/patch/10828535/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k