Skip to contentSkip to conversation

tools/tests: Drop obsolete test infrastructure

PATCH In review Andrew Cooper 4 participants 5 messages Feb 25, 2019 – Mar 1, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools/tests: Drop obsolete test infrastructure

The regression/ directory was identified as already broken in 2012 (c/s 953953cc5). The logic is intended to test *.py files in the Xen tree against different versions of python, but every identified version is now obsolete.

---
CC: Ian Jackson <[email protected]>
CC: Wei Liu <[email protected]>
CC: Juergen Gross <[email protected]>

For 4.12, this is very safe. It has been unreachable in the source tree for 7 years, and was broken before then.

---
 tools/tests/Makefile                               |  3 -
 tools/tests/regression/Makefile                    | 95 ----------------------
 tools/tests/regression/README                      | 39 ---------
 tools/tests/regression/scripts/build_python.sh     | 24 ------
 .../regression/scripts/check_python_syntax.sh      | 22 -----
 tools/tests/regression/scripts/download_python.sh  | 12 ---
 6 files changed, 195 deletions(-)
 delete mode 100644 tools/tests/regression/Makefile
 delete mode 100644 tools/tests/regression/README
 delete mode 100644 tools/tests/regression/scripts/build_python.sh
 delete mode 100644 tools/tests/regression/scripts/check_python_syntax.sh
 delete mode 100644 tools/tests/regression/scripts/download_python.sh
tools/tests/Makefile +0 -3
index a9fc50d..2605b3b 100644
@@ -7,9 +7,6 @@ LDLIBS += $(LDLIBS_libxenctrl)
 SUBDIRS-y :=
 SUBDIRS-$(CONFIG_X86) += mce-test
 SUBDIRS-y += mem-sharing
-ifeq ($(XEN_TARGET_ARCH),__fixme__)
-SUBDIRS-y += regression
-endif
 ifneq ($(clang),y)
 SUBDIRS-$(CONFIG_X86) += x86_emulator
 endif
tools/tests/regression/Makefile deleted +0 -95

95 lines not on this page · raw message

tools/tests/regression/README deleted +0 -39
deleted file mode 100644
index 06b26b0..0000000
@@ -1,39 +0,0 @@
-
-Regression Test Environment for Xen
--------------------------------------
-
-This is an initial regression tool environment for Xen.
-
-With the help of the Makefile, it is possible to compile a couple of
-different python versions and check all .py files against all verions
-for syntax errors.  Note that due to the dynmic of python not all
-syntax errors might be detected.
-
-Currently the following versions of python are supported:
-2.3.7 2.4.6 2.5.4 2.6.2 3.1
-
-
-Usage
------
-
-To download all supported versions of python, compile them, install
-them and run a basic syntax check, run
-
-$ make
-
-(The download and compilation of python is only done if not already
-available.)
-
-To delete all automatically build files:
-
-$ make dist-clean
-
-
-
-Runing unittests with a specific version
-----------------------------------------
-
-This does not work at the moment, because a lot of additional python
-packages are needed for this (which are currently not automatically
-build).
-
tools/tests/regression/scripts/build_python.sh deleted +0 -24
deleted file mode 100644
index 603252e..0000000
@@ -1,24 +0,0 @@
-#!/bin/bash
-#
-# This script builds python in the dir 
-# installed/python-${DEST} from package downloads/Python-{PKG_VERS}.tgz
-#
-
-set -e
-
-REG_TEST_DIR=$1
-DEST=$2
-PKG_VERS=$3
-
-SUB_MAKES_MINUS_J=-j4
-
-BUILD_DIR=${REG_TEST_DIR}/build
-
-mkdir -p ${BUILD_DIR}
-(cd ${BUILD_DIR} && tar -xf ${REG_TEST_DIR}/downloads/Python-$PKG_VERS.tgz)
-(cd ${BUILD_DIR}/Python-$PKG_VERS &&
- ./configure --enable-shared --enable-ipv6 --without-cxx \
-       --with-threads --prefix=${REG_TEST_DIR}/installed/python-$DEST &&
-make ${SUB_MAKES_MINUS_J} &&
-make install)
-rm -fr ${BUILD_DIR}/Python-$PKG_VERS
tools/tests/regression/scripts/check_python_syntax.sh deleted +0 -22
deleted file mode 100644
index 2401895..0000000
@@ -1,22 +0,0 @@
-#!/bin/bash
-#
-# Checks the syntax of all .py files
-# (compiles them into .pyc files)
-#
-
-REG_TEST_DIR=$1
-# Python version, e.g. python-2.3
-PYTHON=$2
-PATH_TO_CHECK=$3
-
-echo "Syntax check for $PYTHON"
-PYTHON_EXECUTABLE=`echo $PYTHON | tr -d "-"`
-export LD_LIBRARY_PATH=${REG_TEST_DIR}/installed/$PYTHON/lib
-export PATH=${REG_TEST_DIR}/installed/$PYTHON/bin:$PATH
-
-# -m is available starting with python 2.4
-# When support for 2.3 (and earlier) is dropped,
-# the following line will do.
-# ${PYTHON_EXECUTABLE} -m compileall -f -q -x ".*\.hg.*|.*/tools/tests/regression/installed.*" ${PATH_TO_CHECK}
-${PYTHON_EXECUTABLE} ${REG_TEST_DIR}/installed/$PYTHON/lib/${PYTHON_EXECUTABLE}/compileall.py -f -q -x ".*\.hg.*|.*/installed/python-.*" ${PATH_TO_CHECK}
-exit $?
tools/tests/regression/scripts/download_python.sh deleted +0 -12
deleted file mode 100644
index 223522e..0000000
@@ -1,12 +0,0 @@
-#!/bin/bash
-#
-# Downloads python with version $1 and stores in into the downloads dir.
-#
-
-set -e
-
-REG_TEST_DIR=$1
-VERSION=$2
-
-mkdir -p ${REG_TEST_DIR}/downloads
-wget -q -O ${REG_TEST_DIR}/downloads/Python-${VERSION}.tgz http://www.python.org/ftp/python/${VERSION}/Python-${VERSION}.tgz
Signature · 7 lines
2.1.4


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Acked-by on v1 1/1
#1 lore raw

Andrew Cooper writes ("[PATCH for-4.12] tools/tests: Drop obsolete test infrastructure"):

Quoted 3 lines

The regression/ directory was identified as already broken in 2012 (c/s 953953cc5). The logic is intended to test *.py files in the Xen tree against different versions of python, but every identified version is now obsolete.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

Acked-by on v1 1/1
#2 lore raw
In reply to Andrew Cooper
Quoted 5 lines · Andrew Cooper

The regression/ directory was identified as already broken in 2012 (c/s 953953cc5). The logic is intended to test *.py files in the Xen tree against different versions of python, but every identified version is now obsolete.

Quoted 7 lines

---
CC: Ian Jackson <[email protected]>
CC: Wei Liu <[email protected]>
CC: Juergen Gross <[email protected]>

For 4.12, this is very safe. It has been unreachable in the source tree for 7 years, and was broken before then.

I agree.

Juergen?

Wei.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#3 lore raw
In reply to Andrew Cooper
Quoted 4 lines · Andrew Cooper

The regression/ directory was identified as already broken in 2012 (c/s 953953cc5). The logic is intended to test *.py files in the Xen tree against different versions of python, but every identified version is now obsolete.

Quoted 8 lines

---
CC: Ian Jackson <[email protected]>
CC: Wei Liu <[email protected]>
CC: Juergen Gross <[email protected]>

For 4.12, this is very safe. It has been unreachable in the source tree for 7 years, and was broken before then.

Ping Juergen for a 4.12 judgement?

~Andrew

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#4 lore raw
In reply to Andrew Cooper
Quoted 5 lines · Andrew Cooper

The regression/ directory was identified as already broken in 2012 (c/s 953953cc5). The logic is intended to test *.py files in the Xen tree against different versions of python, but every identified version is now obsolete.

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel