Skip to contentSkip to conversation

fs/iso9660.c: Correct error message for missing UUID

PATCH New Thomas Schmitt via Grub-devel 1 participant 3 messages Jul 1, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs/iso9660.c: Correct error message for missing UUID

The UUID emitted by function grub_iso9660_uuid is derived from the ISO 9660 Primary Volume Descriptor field "Volume Modification Date and Time". But the error message about possible invalid content of this field talks of "creation date" rather than of "modification date".

---
 grub-core/fs/iso9660.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
grub-core/fs/iso9660.c +1 -1
index 8c348b59a..a40c0fc0e 100644
@@ -1166,7 +1166,7 @@ grub_iso9660_uuid (grub_device_t device, char **uuid)
 	  && ! data->voldesc.modified.second[0] && ! data->voldesc.modified.second[1]
 	  && ! data->voldesc.modified.hundredth[0] && ! data->voldesc.modified.hundredth[1])
 	{
-	  grub_error (GRUB_ERR_BAD_NUMBER, "no creation date in filesystem to generate UUID");
+	  grub_error (GRUB_ERR_BAD_NUMBER, "no modification date in filesystem to generate UUID");
 	  *uuid = NULL;
 	}
       else

--
2.39.2

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel

#1 lore raw

PATCH 1/1 fs/iso9660.c: Correct error message for missing UUID

The UUID emitted by function grub_iso9660_uuid is derived from the ISO 9660 Primary Volume Descriptor field "Volume Modification Date and Time". But the error message about possible invalid content of this field talks of "creation date" rather than of "modification date".

---
 grub-core/fs/iso9660.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
grub-core/fs/iso9660.c +1 -1
index 8c348b59a..a40c0fc0e 100644
@@ -1166,7 +1166,7 @@ grub_iso9660_uuid (grub_device_t device, char **uuid)
 	  && ! data->voldesc.modified.second[0] && ! data->voldesc.modified.second[1]
 	  && ! data->voldesc.modified.hundredth[0] && ! data->voldesc.modified.hundredth[1])
 	{
-	  grub_error (GRUB_ERR_BAD_NUMBER, "no creation date in filesystem to generate UUID");
+	  grub_error (GRUB_ERR_BAD_NUMBER, "no modification date in filesystem to generate UUID");
 	  *uuid = NULL;
 	}
       else

--
2.39.2

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel

#2 lore raw

Hi,

sorry for goofing up "git send-email" again.
This time not by omitting the empty line after the subject of a cover letter but probably by leaving the commit id of the previous "git format-patch" in the "git send-email" command line.
git send-email [email protected] $directory $surplus_id

Shall i post the patch again as single message ?

Have a nice day :)

Thomas

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel