Skip to contentSkip to conversation

Rename dt header and move clock binding

PATCH In review Jolly Shah 2 participants 4 messages Feb 27, 2019 – Mar 18, 2019

Subsystems (3)
lore
Share & tools
lore

Jolly Shah

author
#0 lore raw

cover Rename dt header and move clock binding

This patchset renames clock dt include file to align with other incldues. Other patch moves clock binding to a separate file under clock directory to align with other firmware child binding documenetation.

Jolly Shah (1):
include: dt-binding: clock: Rename zynqmp header file

Rajan Vaja (1):
dt-bindings: xilinx: Separate clock binding from firmware doc

 .../devicetree/bindings/clock/xlnx,zynqmp-clk.txt  |  63 +++++++++++
 .../firmware/xilinx/xlnx,zynqmp-firmware.txt       |  54 +--------
 include/dt-bindings/clock/xlnx,zynqmp-clk.h        | 116 -------------------
 include/dt-bindings/clock/xlnx-zynqmp-clk.h        | 126 +++++++++++++++++++++
 4 files changed, 190 insertions(+), 169 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/clock/xlnx,zynqmp-clk.txt
 delete mode 100644 include/dt-bindings/clock/xlnx,zynqmp-clk.h
 create mode 100644 include/dt-bindings/clock/xlnx-zynqmp-clk.h
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 1/2 include: dt-binding: clock: Rename zynqmp header file

Rename file name of ZynqMP clk dt-bindings to align with file name of reset and power dt-bindings.

---
 .../firmware/xilinx/xlnx,zynqmp-firmware.txt       |   2 +-
 include/dt-bindings/clock/xlnx,zynqmp-clk.h        | 116 -------------------
 include/dt-bindings/clock/xlnx-zynqmp-clk.h        | 126 +++++++++++++++++++++
 3 files changed, 127 insertions(+), 117 deletions(-)
 delete mode 100644 include/dt-bindings/clock/xlnx,zynqmp-clk.h
 create mode 100644 include/dt-bindings/clock/xlnx-zynqmp-clk.h
Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt +1 -1
index 614bac5..45d259c 100644
@@ -62,7 +62,7 @@ order to provide an optional (E)MIO clock source:
 
 Output clocks are registered based on clock information received
 from firmware. Output clocks indexes are mentioned in
-include/dt-bindings/clock/xlnx,zynqmp-clk.h.
+include/dt-bindings/clock/xlnx-zynqmp-clk.h.
 
 -------
 Example
include/dt-bindings/clock/xlnx,zynqmp-clk.h deleted +0 -116

116 lines not on this page · raw message

include/dt-bindings/clock/xlnx-zynqmp-clk.h new file +126 -0

126 lines not on this page · raw message

Signature · 1 line
2.7.4
author
#2 lore raw

PATCH 2/2 dt-bindings: xilinx: Separate clock binding from firmware doc

In reply to Jolly Shah

From: Rajan Vaja <[email protected]>

Clock description is part of firmware doc. Move clock description in separate doc.

---
 .../devicetree/bindings/clock/xlnx,zynqmp-clk.txt  | 63 ++++++++++++++++++++++
 .../firmware/xilinx/xlnx,zynqmp-firmware.txt       | 54 +------------------
 2 files changed, 64 insertions(+), 53 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/clock/xlnx,zynqmp-clk.txt
Documentation/devicetree/bindings/clock/xlnx,zynqmp-clk.txt new file +63 -0
new file mode 100644
index 0000000..391ee1a6
@@ -0,0 +1,63 @@
+--------------------------------------------------------------------------
+Device Tree Clock bindings for the Zynq Ultrascale+ MPSoC controlled using
+Zynq MPSoC firmware interface
+--------------------------------------------------------------------------
+The clock controller is a h/w block of Zynq Ultrascale+ MPSoC clock
+tree. It reads required input clock frequencies from the devicetree and acts
+as clock provider for all clock consumers of PS clocks.
+
+See clock_bindings.txt for more information on the generic clock bindings.
+
+Required properties:
+ - #clock-cells:	Must be 1
+ - compatible:		Must contain:	"xlnx,zynqmp-clk"
+ - clocks:		List of clock specifiers which are external input
+			clocks to the given clock controller. Please refer
+			the next section to find the input clocks for a
+			given controller.
+ - clock-names:		List of clock names which are exteral input clocks
+			to the given clock controller. Please refer to the
+			clock bindings for more details.
+
+Input clocks for zynqmp Ultrascale+ clock controller:
+
+The Zynq UltraScale+ MPSoC has one primary and four alternative reference clock
+inputs. These required clock inputs are:
+ - pss_ref_clk (PS reference clock)
+ - video_clk (reference clock for video system )
+ - pss_alt_ref_clk (alternative PS reference clock)
+ - aux_ref_clk
+ - gt_crx_ref_clk (transceiver reference clock)
+
+The following strings are optional parameters to the 'clock-names' property in
+order to provide an optional (E)MIO clock source:
+ - swdt0_ext_clk
+ - swdt1_ext_clk
+ - gem0_emio_clk
+ - gem1_emio_clk
+ - gem2_emio_clk
+ - gem3_emio_clk
+ - mio_clk_XX		# with XX = 00..77
+ - mio_clk_50_or_51	#for the mux clock to gem tsu from 50 or 51
+
+
+Output clocks are registered based on clock information received
+from firmware. Output clocks indexes are mentioned in
+include/dt-bindings/clock/xlnx-zynqmp-clk.h.
+
+-------
+Example
+-------
+
+firmware {
+	zynqmp_firmware: zynqmp-firmware {
+		compatible = "xlnx,zynqmp-firmware";
+		method = "smc";
+		zynqmp_clk: clock-controller {
+			#clock-cells = <1>;
+			compatible = "xlnx,zynqmp-clk";
+			clocks = <&pss_ref_clk>, <&video_clk>, <&pss_alt_ref_clk>, <&aux_ref_clk>, <&gt_crx_ref_clk>;
+			clock-names = "pss_ref_clk", "video_clk", "pss_alt_ref_clk","aux_ref_clk", "gt_crx_ref_clk";
+		};
+	};
+};
Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt +1 -53

65 lines not on this page · raw message

Signature · 1 line
2.7.4
#3 lore raw
In reply to Jolly Shah
Quoted 10 lines · Jolly Shah

This patchset renames clock dt include file to align with other incldues. Other patch moves clock binding to a separate file under clock directory to align with other firmware child binding documenetation.

Jolly Shah (1):
include: dt-binding: clock: Rename zynqmp header file

Rajan Vaja (1):
dt-bindings: xilinx: Separate clock binding from firmware doc

Quoted 9 lines
 .../devicetree/bindings/clock/xlnx,zynqmp-clk.txt  |  63 +++++++++++
 .../firmware/xilinx/xlnx,zynqmp-firmware.txt       |  54 +--------
 include/dt-bindings/clock/xlnx,zynqmp-clk.h        | 116 -------------------
 include/dt-bindings/clock/xlnx-zynqmp-clk.h        | 126 +++++++++++++++++++++
 4 files changed, 190 insertions(+), 169 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/clock/xlnx,zynqmp-clk.txt
 delete mode 100644 include/dt-bindings/clock/xlnx,zynqmp-clk.h
 create mode 100644 include/dt-bindings/clock/xlnx-zynqmp-clk.h

I have applied this. Please let me know if you see any issue with it.

Thanks,
Michal