x86/hvm: Increate the triple fault log message to XENLOG_ERR
PATCH 1/1 x86/hvm: Increate the triple fault log message to XENLOG_ERR
At INFO level, it doesn't get printed out by default in release builds, leading to unqualified logging such as this:
(XEN) [ 66.995993] Freed 524kB init memory
(XEN) [ 1993.144997] *** Dumping Dom9 vcpu#2 state: ***
(XEN) [ 1993.145008] ----[ Xen-4.11.1 x86_64 debug=n Not tainted ]----
(XEN) [ 1993.145011] CPU: 21
(XEN) [ 1993.145015] RIP: 0010:[<ffffe0002ba950ef>]
(XEN) [ 1993.145018] RFLAGS: 0000000000010246 CONTEXT: hvm guest (d9v2)
(XEN) [ 1993.145026] rax: 00000000ffffe000 rbx: ffffe0002d8e1440 rcx: 0000ffffe0002ba9 (XEN) [ 1993.145031] rdx: 0000000000000000 rsi: ffffe0002ba93575 rdi: fffff803dfb9f340 (XEN) [ 1993.145035] rbp: ffffd001cd791200 rsp: ffffd001cd791140 r8: 0000000000000130 (XEN) [ 1993.145039] r9: 0000000080000000 r10: 0000000000000000 r11: 0000000000000020 (XEN) [ 1993.145043] r12: ffffe0002ba9306d r13: 0000000000000000 r14: 0000000000000001 (XEN) [ 1993.145047] r15: fffff803dfb9f200 cr0: 0000000080050031 cr4: 0000000000170678 (XEN) [ 1993.145051] cr3: 00000000001aa002 cr2: 0000020488403f70 (XEN) [ 1993.145056] fsb: 0000000060f71000 gsb: ffffd001cc1af000 gss: 0000009d60f6f000
(XEN) [ 1993.145060] ds: 002b es: 002b fs: 0053 gs: 002b ss: 0018 cs: 0010
A triple fault is fatal to the domain under all circumstances (so will print at most once), and in practice is always an error condition rather than a reboot fallback.
---
CC: Jan Beulich <[email protected]>
CC: Wei Liu <[email protected]>
CC: Roger Pau Monné <[email protected]>
CC: Juergen Gross <[email protected]>
This wants taking for Xen 4.12 and backporting to the stable releases.
--- xen/arch/x86/hvm/hvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
xen/arch/x86/hvm/hvm.c +1 -1
@@ -1627,7 +1627,7 @@ void hvm_triple_fault(void)struct domain *d = v->domain;u8 reason = d->arch.hvm.params[HVM_PARAM_TRIPLE_FAULT_REASON ]; -gprintk (XENLOG_INFO , +gprintk (XENLOG_ERR ,"Triple fault - invoking HVM shutdown action %d\n" , reason);vcpu_show_execution_state (v);
Signature · 7 lines
2.1.4 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
I think you mean "Increase" in the subject line.
Quoted 17 lines · Andrew Cooper
At INFO level, it doesn't get printed out by default in release builds, leading to unqualified logging such as this:
(XEN) [ 66.995993] Freed 524kB init memory
(XEN) [ 1993.144997] *** Dumping Dom9 vcpu#2 state: ***
(XEN) [ 1993.145008] ----[ Xen-4.11.1x86_64debug=n Not tainted ]----
(XEN) [ 1993.145011] CPU: 21
(XEN) [ 1993.145015] RIP: 0010:[<ffffe0002ba950ef>]
(XEN) [ 1993.145018] RFLAGS: 0000000000010246 CONTEXT: hvm guest (d9v2)(XEN) [ 1993.145026] rax: 00000000ffffe000 rbx: ffffe0002d8e1440 rcx: 0000ffffe0002ba9 (XEN) [ 1993.145031] rdx: 0000000000000000 rsi: ffffe0002ba93575 rdi: fffff803dfb9f340 (XEN) [ 1993.145035] rbp: ffffd001cd791200 rsp: ffffd001cd791140 r8: 0000000000000130 (XEN) [ 1993.145039] r9: 0000000080000000 r10: 0000000000000000 r11: 0000000000000020 (XEN) [ 1993.145043] r12: ffffe0002ba9306d r13: 0000000000000000 r14: 0000000000000001 (XEN) [ 1993.145047] r15: fffff803dfb9f200 cr0: 0000000080050031 cr4: 0000000000170678 (XEN) [ 1993.145051] cr3: 00000000001aa002 cr2: 0000020488403f70 (XEN) [ 1993.145056] fsb: 0000000060f71000 gsb: ffffd001cc1af000 gss: 0000009d60f6f000
Quoted 8 lines
(XEN) [ 1993.145060] ds: 002b es: 002b fs: 0053 gs: 002b ss: 0018 cs: 0010
A triple fault is fatal to the domain under all circumstances (so will print at most once), and in practice is always an error condition rather than a reboot fallback.
Reported-by Razvan Cojocaru <[email protected]>Signed-off-by Andrew Cooper <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 1 line · Wei Liu
I think you mean "Increase" in the subject line.
I do, fixed.
Quoted 21 lines · Andrew Cooper
Quoted 19 lines
At INFO level, it doesn't get printed out by default in release builds, leading to unqualified logging such as this:
(XEN) [ 66.995993] Freed 524kB init memory
(XEN) [ 1993.144997] *** Dumping Dom9 vcpu#2 state: ***
(XEN) [ 1993.145008] ----[ Xen-4.11.1x86_64debug=n Not tainted ]----
(XEN) [ 1993.145011] CPU: 21
(XEN) [ 1993.145015] RIP: 0010:[<ffffe0002ba950ef>]
(XEN) [ 1993.145018] RFLAGS: 0000000000010246 CONTEXT: hvm guest (d9v2)(XEN) [ 1993.145026] rax: 00000000ffffe000 rbx: ffffe0002d8e1440 rcx: 0000ffffe0002ba9 (XEN) [ 1993.145031] rdx: 0000000000000000 rsi: ffffe0002ba93575 rdi: fffff803dfb9f340 (XEN) [ 1993.145035] rbp: ffffd001cd791200 rsp: ffffd001cd791140 r8: 0000000000000130 (XEN) [ 1993.145039] r9: 0000000080000000 r10: 0000000000000000 r11: 0000000000000020 (XEN) [ 1993.145043] r12: ffffe0002ba9306d r13: 0000000000000000 r14: 0000000000000001 (XEN) [ 1993.145047] r15: fffff803dfb9f200 cr0: 0000000080050031 cr4: 0000000000170678 (XEN) [ 1993.145051] cr3: 00000000001aa002 cr2: 0000020488403f70 (XEN) [ 1993.145056] fsb: 0000000060f71000 gsb: ffffd001cc1af000 gss: 0000009d60f6f000(XEN) [ 1993.145060] ds: 002b es: 002b fs: 0053 gs: 002b ss: 0018 cs: 0010
Quoted 7 lines
Quoted 6 lines
A triple fault is fatal to the domain under all circumstances (so will print at most once), and in practice is always an error condition rather than a reboot fallback.
Reported-by Razvan Cojocaru <[email protected]>Signed-off-by Andrew Cooper <[email protected]>Reviewed-by Wei Liu <[email protected]>
Thanks,
~Andrew
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Jan Beulich
Acked-byQuoted 23 lines
Quoted 1 line
Quoted 1 line · On 28.02.19 at 11:58, <[email protected]> wrote:
I think you mean "Increase" in the subject line.
Quoted 19 lines · Andrew Cooper
At INFO level, it doesn't get printed out by default in release builds, leading to unqualified logging such as this:
(XEN) [ 66.995993] Freed 524kB init memory
(XEN) [ 1993.144997] *** Dumping Dom9 vcpu#2 state: ***
(XEN) [ 1993.145008] ----[ Xen-4.11.1x86_64debug=n Not tainted ]----
(XEN) [ 1993.145011] CPU: 21
(XEN) [ 1993.145015] RIP: 0010:[<ffffe0002ba950ef>]
(XEN) [ 1993.145018] RFLAGS: 0000000000010246 CONTEXT: hvm guest (d9v2)(XEN) [ 1993.145026] rax: 00000000ffffe000 rbx: ffffe0002d8e1440 rcx: 0000ffffe0002ba9 (XEN) [ 1993.145031] rdx: 0000000000000000 rsi: ffffe0002ba93575 rdi: fffff803dfb9f340 (XEN) [ 1993.145035] rbp: ffffd001cd791200 rsp: ffffd001cd791140 r8: 0000000000000130 (XEN) [ 1993.145039] r9: 0000000080000000 r10: 0000000000000000 r11: 0000000000000020 (XEN) [ 1993.145043] r12: ffffe0002ba9306d r13: 0000000000000000 r14: 0000000000000001 (XEN) [ 1993.145047] r15: fffff803dfb9f200 cr0: 0000000080050031 cr4: 0000000000170678 (XEN) [ 1993.145051] cr3: 00000000001aa002 cr2: 0000020488403f70 (XEN) [ 1993.145056] fsb: 0000000060f71000 gsb: ffffd001cc1af000 gss: 0000009d60f6f000(XEN) [ 1993.145060] ds: 002b es: 002b fs: 0053 gs: 002b ss: 0018 cs: 0010
Quoted 8 lines
Quoted 6 lines
A triple fault is fatal to the domain under all circumstances (so will print at most once), and in practice is always an error condition rather than a reboot fallback.
Reported-by Razvan Cojocaru <[email protected]>Signed-off-by Andrew Cooper <[email protected]>Reviewed-by Wei Liu <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 17 lines · Andrew Cooper
At INFO level, it doesn't get printed out by default in release builds, leading to unqualified logging such as this:
(XEN) [ 66.995993] Freed 524kB init memory
(XEN) [ 1993.144997] *** Dumping Dom9 vcpu#2 state: ***
(XEN) [ 1993.145008] ----[ Xen-4.11.1x86_64debug=n Not tainted ]----
(XEN) [ 1993.145011] CPU: 21
(XEN) [ 1993.145015] RIP: 0010:[<ffffe0002ba950ef>]
(XEN) [ 1993.145018] RFLAGS: 0000000000010246 CONTEXT: hvm guest (d9v2)(XEN) [ 1993.145026] rax: 00000000ffffe000 rbx: ffffe0002d8e1440 rcx: 0000ffffe0002ba9 (XEN) [ 1993.145031] rdx: 0000000000000000 rsi: ffffe0002ba93575 rdi: fffff803dfb9f340 (XEN) [ 1993.145035] rbp: ffffd001cd791200 rsp: ffffd001cd791140 r8: 0000000000000130 (XEN) [ 1993.145039] r9: 0000000080000000 r10: 0000000000000000 r11: 0000000000000020 (XEN) [ 1993.145043] r12: ffffe0002ba9306d r13: 0000000000000000 r14: 0000000000000001 (XEN) [ 1993.145047] r15: fffff803dfb9f200 cr0: 0000000080050031 cr4: 0000000000170678 (XEN) [ 1993.145051] cr3: 00000000001aa002 cr2: 0000020488403f70 (XEN) [ 1993.145056] fsb: 0000000060f71000 gsb: ffffd001cc1af000 gss: 0000009d60f6f000
Quoted 8 lines
(XEN) [ 1993.145060] ds: 002b es: 002b fs: 0053 gs: 002b ss: 0018 cs: 0010
A triple fault is fatal to the domain under all circumstances (so will print at most once), and in practice is always an error condition rather than a reboot fallback.
Reported-by Razvan Cojocaru <[email protected]>Signed-off-by Andrew Cooper <[email protected]>
Juergen
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel