Staging: pi433: Fix line over 80 characters issue
PATCH 1/1 Staging: pi433: Fix line over 80 characters issue
Delete extra whitespace and tab space to remove
checkpatch.pl warning:
WARNING: line over 80 characters
--- drivers/staging/pi433/pi433_if.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/pi433/pi433_if.c +4 -4
@@ -45,10 +45,10 @@#include "pi433_if.h" #include "rf69.h" -#define N_PI433_MINORS BIT(MINORBITS)/*32*/ /* ... up to 256 */ -#define MAX_MSG_SIZE 900/* min: FIFO_SIZE! */ -#define MSG_FIFO_SIZE 65536/* 65536 = 2^16 */ -#define NUM_DIO 2 +#define N_PI433_MINORS BIT(MINORBITS)/*32*/ /* ... up to 256 */ +#define MAX_MSG_SIZE 900/* min: FIFO_SIZE! */ +#define MSG_FIFO_SIZE 65536/* 65536 = 2^16 */ +#define NUM_DIO 2static dev_t pi433_dev;static DEFINE_IDR (pi433_idr);
Signature · 1 line
2.7.4
Greg KH
maintainerQuoted 14 lines · Debleena Sen
Delete extra whitespace and tab space to remove
checkpatch.pl warning:
WARNING: line over 80 charactersSigned-off-by Debleena Sen <[email protected]>--- drivers/staging/pi433/pi433_if.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/staging/pi433/pi433_if.c +0
-0
drivers/staging/pi433/pi433_if.c line 50
Quoted 10 lines
drivers/staging/pi433/pi433_if.c +3
-4@@ -45,10 +45,10 @@#include "pi433_if.h" #include "rf69.h" -#define N_PI433_MINORS BIT(MINORBITS)/*32*/ /* ... up to 256 */ -#define MAX_MSG_SIZE 900/* min: FIFO_SIZE! */ -#define MSG_FIFO_SIZE 65536/* 65536 = 2^16 */ -#define NUM_DIO 2 +#define N_PI433_MINORS BIT(MINORBITS)/*32*/ /* ... up to 256 */ +#define MAX_MSG_SIZE 900/* min: FIFO_SIZE! */ +#define MSG_FIFO_SIZE 65536/* 65536 = 2^16 */
The comment above should also use a tab, right?
thanks,
greg k-h
Quoted 29 lines · gregkh
Review
Quoted 10 lines · Debleena Sen
Delete extra whitespace and tab space to remove
checkpatch.pl warning:
WARNING: line over 80 charactersSigned-off-by Debleena Sen <[email protected] <javascript:>>---
drivers/staging/pi433/pi433_if.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)(quoted diff) +0
-0
b/drivers/staging/pi433/pi433_if.cdrivers/staging/pi433/pi433_if.c line 48
Quoted 8 lines
index b231463..53928af 100644
drivers/staging/pi433/pi433_if.c +0
-1@@ -45,10 +45,10 @@#include "pi433_if.h" #include "rf69.h" -#define N_PI433_MINORS BIT(MINORBITS)/*32*/ /* ... up to 256 */
drivers/staging/pi433/pi433_if.c line 49
Quoted 1 line
drivers/staging/pi433/pi433_if.c +0
-1-#define MAX_MSG_SIZE 900/* min:
FIFO_SIZE! */drivers/staging/pi433/pi433_if.c line 50
Quoted 1 line
drivers/staging/pi433/pi433_if.c +0
-1-#define MSG_FIFO_SIZE 65536/* 65536 = 2^16 */
drivers/staging/pi433/pi433_if.c line 48
Quoted 2 lines
drivers/staging/pi433/pi433_if.c +1
-1-#define NUM_DIO 2 +#define N_PI433_MINORS BIT(MINORBITS)/*32*/ /* ... up to 256 */
Quoted 9 lines
drivers/staging/pi433/pi433_if.c line 50
Quoted 2 lines
drivers/staging/pi433/pi433_if.c +2
-0+#define MAX_MSG_SIZE 900/* min: FIFO_SIZE! */ +#define MSG_FIFO_SIZE 65536/* 65536 = 2^16 */ The comment above should also use a tab, right?
thanks,
greg k-h
Yes. Should I resend it ?
Quoted 27 lines · On Mon, 4 Mar 2019, [email protected] wrote:
On Monday, March 4, 2019 at 1:16:54 PM UTC+5:30, gregkh wrote:
On Sun, Mar 03, 2019 at 10:05:30PM -0800, Debleena Sen wrote:
> Delete extra whitespace and tab space to remove
> checkpatch.pl warning:
> WARNING: line over 80 characters
>
> Signed-off-by: Debleena Sen <[email protected]>
> ---
> ᅵdrivers/staging/pi433/pi433_if.c | 8 ++++----
> ᅵ1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --gita/drivers/staging/pi433/pi433_if.cb/drivers/staging/pi433/pi433_if.c
> index b231463..53928af 100644
> ---a/drivers/staging/pi433/pi433_if.c
> +++b/drivers/staging/pi433/pi433_if.c
> @@ -45,10 +45,10 @@
> ᅵ#include "pi433_if.h"
> ᅵ#include "rf69.h"
> ᅵ
> -#define N_PI433_MINORSᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵBIT(MINORBITS) /*32*/ᅵᅵᅵᅵᅵᅵᅵᅵ/* ... up to 256 */ > -#define MAX_MSG_SIZEᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵ900ᅵᅵᅵᅵᅵᅵᅵᅵ/* min:FIFO_SIZE! */ > -#define MSG_FIFO_SIZEᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵ65536 ᅵ /* 65536 = 2^16 ᅵ*/
> -#define NUM_DIOᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵ2
> +#define N_PI433_MINORSᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵBIT(MINORBITS) /*32*/ᅵᅵᅵᅵᅵᅵᅵᅵ/* ... up to 256 */ > +#define MAX_MSG_SIZEᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵ900ᅵᅵᅵᅵᅵᅵᅵᅵ/* min:FIFO_SIZE! */
> +#define MSG_FIFO_SIZEᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵᅵ65536 ᅵ /* 65536 = 2^16 ᅵ*/
Quoted 8 lines
The comment above should also use a tab, right?
thanks,
greg k-h
Yes. Should I resend it ?
If someone makes a suggestion for improvement, then you should resend, unless they explicitly say that it doesnt really matter.
julia
Ok, I'll do that.
Quoted 65 lines · On Mon, 4 Mar 2019, 20:12 Julia Lawall, <[email protected]> wrote:
Quoted 12 lines · On Mon, 4 Mar 2019, [email protected] wrote:
On Monday, March 4, 2019 at 1:16:54 PM UTC+5:30, gregkh wrote:
On Sun, Mar 03, 2019 at 10:05:30PM -0800, Debleena Sen wrote: > Delete extra whitespace and tab space to remove > checkpatch.pl warning: > WARNING: line over 80 characters > > Signed-off-by: Debleena Sen <[email protected]> > --- > drivers/staging/pi433/pi433_if.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/pi433/pi433_if.c
b/drivers/staging/pi433/pi433_if.cQuoted 8 lines
> index b231463..53928af 100644 > --- a/drivers/staging/pi433/pi433_if.c > +++ b/drivers/staging/pi433/pi433_if.c > @@ -45,10 +45,10 @@ > #include "pi433_if.h" > #include "rf69.h" > > -#define N_PI433_MINORS BIT(MINORBITS)/*32*/ /* ... up to 256 */
Quoted 1 line
> -#define
MAX_MSG_SIZE900 /* min:
FIFO_SIZE! */Quoted 1 line
> -#define MSG_FIFO_SIZE 65536 /* 65536 =2^16 */
Quoted 2 lines
> -#define
NUM_DIO2
> +#defineN_PI433_MINORSBIT(MINORBITS)/*32*/ /* ... up to 256 */
Quoted 1 line
> +#define
MAX_MSG_SIZE900 /* min:
FIFO_SIZE! */Quoted 10 lines
> +#define
MSG_FIFO_SIZE65536 /* 65536 = 2^16 */The comment above should also use a tab, right?
thanks,
greg k-h
Yes. Should I resend it ?
If someone makes a suggestion for improvement, then you should resend, unless they explicitly say that it doesnt really matter.
julia
--
You received this message because you are subscribed to a topic in the Google Groups "outreachy-kernel" group.
To unsubscribe from this topic, visit
https://groups.google.com/d/topic/outreachy-kernel/KI4hZ29Z_go/unsubscribe
.
To unsubscribe from this group and all its topics, send an email to [email protected].
To post to this group, send email to [email protected]. To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.20.1903041541320.4541%40hadrien
.
For more options, visit https://groups.google.com/d/optout.
Quoted 5 lines · Debleena Sen
Delete extra whitespace and tab space to remove
checkpatch.pl warning:
WARNING: line over 80 charactersSigned-off-by Debleena Sen <[email protected]>
Quoted 33 lines
--- drivers/staging/pi433/pi433_if.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/staging/pi433/pi433_if.c +4
-5@@ -45,10 +45,10 @@#include "pi433_if.h" #include "rf69.h" -#define N_PI433_MINORS BIT(MINORBITS)/*32*/ /* ... up to 256 */ -#define MAX_MSG_SIZE 900/* min: FIFO_SIZE! */ -#define MSG_FIFO_SIZE 65536/* 65536 = 2^16 */ -#define NUM_DIO 2 +#define N_PI433_MINORS BIT(MINORBITS)/*32*/ /* ... up to 256 */ +#define MAX_MSG_SIZE 900/* min: FIFO_SIZE! */ +#define MSG_FIFO_SIZE 65536/* 65536 = 2^16 */ +#define NUM_DIO 2static dev_t pi433_dev;static DEFINE_IDR (pi433_idr); --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1551679530-2635-1-git-send-email-idebleenasen%40gmail.com.
For more options, visit https://groups.google.com/d/optout.