Skip to contentSkip to conversation

perf clang: fix semicolon code style issue

PATCH Applied Yang Wei 3 participants 3 messages Mar 4, 2019 – Mar 9, 2019 perf events

lore
Share & tools
lore

Yang Wei

author
#0 lore raw

PATCH 1/1 perf clang: fix semicolon code style issue

From: Yang Wei <[email protected]>

Delete a superfluous semicolon in getBPFObjectFromModule().

---
 tools/perf/util/c++/clang.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/c++/clang.cpp +1 -1
index 39c0004..fc361c3 100644
@@ -156,7 +156,7 @@ getBPFObjectFromModule(llvm::Module *Module)
 #endif
 	if (NotAdded) {
 		llvm::errs() << "TargetMachine can't emit a file of this type\n";
-		return std::unique_ptr<llvm::SmallVectorImpl<char>>(nullptr);;
+		return std::unique_ptr<llvm::SmallVectorImpl<char>>(nullptr);
 	}
 	PM.run(*Module);
 
Signature · 1 line
2.7.4
#1 lore raw

Em Mon, Mar 04, 2019 at 10:36:14PM +0800, Yang Wei escreveu:

Quoted 14 lines

From: Yang Wei <[email protected]>

Delete a superfluous semicolon in getBPFObjectFromModule().

---
 tools/perf/util/c++/clang.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/c++/clang.cpp +0 -0
index 39c0004..fc361c3 100644

tools/perf/util/c++/clang.cpp getBPFObjectFromModule(llvm::Module *Module) · line 161

Quoted 7 lines
tools/perf/util/c++/clang.cpp +1 -1
@@ -156,7 +156,7 @@ getBPFObjectFromModule(llvm::Module *Module)
 #endif
 	if (NotAdded) {
 		llvm::errs() << "TargetMachine can't emit a file of this type\n";
-		return std::unique_ptr<llvm::SmallVectorImpl<char>>(nullptr);;
+		return std::unique_ptr<llvm::SmallVectorImpl<char>>(nullptr);
 	}
 	PM.run(*Module);

Thanks, applied.

- Arnaldo

#2 lore raw

[tip:perf/urgent] perf clang: Remove needless extra semicolon

In reply to Yang Wei
perf clang: Remove needless extra semicolon
Commit-ID:  a53837a5458c5b84588dfa3fa510c6a29b7bd4d7
Gitweb:     https://git.kernel.org/tip/a53837a5458c5b84588dfa3fa510c6a29b7bd4d7
Author:     Yang Wei <[email protected]>
AuthorDate: Mon, 4 Mar 2019 22:36:14 +0800
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 6 Mar 2019 09:47:48 -0300

perf clang: Remove needless extra semicolon

Delete a superfluous semicolon in getBPFObjectFromModule().

---
 tools/perf/util/c++/clang.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/c++/clang.cpp +1 -1
index 39c0004f2886..fc361c3f8570 100644
@@ -156,7 +156,7 @@ getBPFObjectFromModule(llvm::Module *Module)
 #endif
 	if (NotAdded) {
 		llvm::errs() << "TargetMachine can't emit a file of this type\n";
-		return std::unique_ptr<llvm::SmallVectorImpl<char>>(nullptr);;
+		return std::unique_ptr<llvm::SmallVectorImpl<char>>(nullptr);
 	}
 	PM.run(*Module);