Skip to contentSkip to conversation

tipc: fix RDM/DGRAM connect() regression

PATCH Applied Jon Maloy 2 participants 2 messages Mar 4, 2019 – Mar 5, 2019

Subsystems (3)
lore
Share & tools
lore

Jon Maloy

author
#0 lore raw

PATCH 1/1 tipc: fix RDM/DGRAM connect() regression

From: Erik Hugne <[email protected]>

Fix regression bug introduced in
commit 365ad353c256 ("tipc: reduce risk of user starvation during link congestion")

Only signal -EDESTADDRREQ for RDM/DGRAM if we don't have a cached sockaddr.

---
 net/tipc/socket.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/tipc/socket.c +1 -1
index 70343ac..139694f 100644
@@ -1333,7 +1333,7 @@ static int __tipc_sendmsg(struct socket *sock, struct msghdr *m, size_t dlen)
 
 	if (unlikely(!dest)) {
 		dest = &tsk->peer;
-		if (!syn || dest->family != AF_TIPC)
+		if (!syn && dest->family != AF_TIPC)
 			return -EDESTADDRREQ;
 	}
 
Signature · 1 line
2.1.4
maintainer Applied
#1 lore raw

From: Jon Maloy <[email protected]>
Date: Mon, 4 Mar 2019 23:26:10 +0100

Quoted 11 lines

From: Erik Hugne <[email protected]>

Fix regression bug introduced in
commit 365ad353c256 ("tipc: reduce risk of user starvation during link congestion")

Only signal -EDESTADDRREQ for RDM/DGRAM if we don't have a cached sockaddr.

Please provide a proper Fixes: tag next time, I fixed it up for you this time around.

Applied, thanks.