Skip to contentSkip to conversation

gcc-sanitizers: fix the build with -fno-omit-frame-pointer

PATCH In review [email protected] 2 participants 4 messages Mar 6, 2019 – Mar 13, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gcc-sanitizers: fix the build with -fno-omit-frame-pointer

From: Mingli Yu <[email protected]>

Fix the below build issue for gcc-sanitizers when
both -mthumb and -fno-omit-frame-pointer configured
for arm.
| ../../../../libsanitizer/sanitizer_common/sanitizer_linux.cc: In function 'sanitizer::uptr sanitizer::internal_clone(int (*)(void*), void*, int, void*, int*, void*, int*)':
| ../../../../libsanitizer/sanitizer_common/sanitizer_linux.cc:1540:1: error: r7 cannot be used in asm here
}

Reference: https://reviews.llvm.org/D50180

---
 meta/recipes-devtools/gcc/gcc-sanitizers_8.2.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-devtools/gcc/gcc-sanitizers_8.2.bb +1 -0
index f3c7058..2f89c86 100644
@@ -5,3 +5,4 @@ require gcc-sanitizers.inc
 # sanitizer_linux.s:5749: Error: lo register required -- `ldr ip,[sp],#8'
 ARM_INSTRUCTION_SET_armv4 = "arm"
 ARM_INSTRUCTION_SET_armv5 = "arm"
+TARGET_CFLAGS_remove_arm = "${@bb.utils.contains('TUNE_CCARGS', '-mthumb', '-fno-omit-frame-pointer', '', d)}"
Signature · 1 line
2.7.4
#1 lore raw
Quoted 22 lines · On Tue, Mar 5, 2019 at 8:24 PM <[email protected]> wrote:

From: Mingli Yu <[email protected]>

Fix the below build issue for gcc-sanitizers when
both -mthumb and -fno-omit-frame-pointer configured
for arm.
| ../../../../libsanitizer/sanitizer_common/sanitizer_linux.cc: In function 'sanitizer::uptr sanitizer::internal_clone(int (*)(void*), void*, int, void*, int*, void*, int*)':
| ../../../../libsanitizer/sanitizer_common/sanitizer_linux.cc:1540:1: error: r7 cannot be used in asm here
}

Reference: https://reviews.llvm.org/D50180

---
 meta/recipes-devtools/gcc/gcc-sanitizers_8.2.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-devtools/gcc/gcc-sanitizers_8.2.bb +0 -0
index f3c7058..2f89c86 100644

meta/recipes-devtools/gcc/gcc-sanitizers_8.2.bb require gcc-sanitizers.inc · line 8

Quoted 4 lines
meta/recipes-devtools/gcc/gcc-sanitizers_8.2.bb +1 -0
@@ -5,3 +5,4 @@ require gcc-sanitizers.inc
 # sanitizer_linux.s:5749: Error: lo register required -- `ldr ip,[sp],#8'
 ARM_INSTRUCTION_SET_armv4 = "arm"
 ARM_INSTRUCTION_SET_armv5 = "arm"
+TARGET_CFLAGS_remove_arm = "${@bb.utils.contains('TUNE_CCARGS', '-mthumb', '-fno-omit-frame-pointer', '', d)}"

what target does it happen with ? since we set arm ISA for armv5 and v4 it must be something else

author
#2 lore raw
Quoted 18 lines · Khem Raj
Quoted 17 lines · On Tue, Mar 5, 2019 at 8:24 PM <[email protected]> wrote:

From: Mingli Yu <[email protected]>

Fix the below build issue for gcc-sanitizers when
both -mthumb and -fno-omit-frame-pointer configured
for arm.
| ../../../../libsanitizer/sanitizer_common/sanitizer_linux.cc: In function 'sanitizer::uptr sanitizer::internal_clone(int (*)(void*), void*, int, void*, int*, void*, int*)':
| ../../../../libsanitizer/sanitizer_common/sanitizer_linux.cc:1540:1: error: r7 cannot be used in asm here
}

Reference: https://reviews.llvm.org/D50180

---
  meta/recipes-devtools/gcc/gcc-sanitizers_8.2.bb | 1 +
  1 file changed, 1 insertion(+)
Quoted 12 lines

meta/recipes-devtools/gcc/gcc-sanitizers_8.2.bb require gcc-sanitizers.inc · line 8

Quoted 9 lines
meta/recipes-devtools/gcc/gcc-sanitizers_8.2.bb +1 -0
index f3c7058..2f89c86 100644
@@ -5,3 +5,4 @@ require gcc-sanitizers.inc
  # sanitizer_linux.s:5749: Error: lo register required -- `ldr ip,[sp],#8'
  ARM_INSTRUCTION_SET_armv4 = "arm"
  ARM_INSTRUCTION_SET_armv5 = "arm"
+TARGET_CFLAGS_remove_arm = "${@bb.utils.contains('TUNE_CCARGS', '-mthumb', '-fno-omit-frame-pointer', '', d)}"

what target does it happen with ? since we set arm ISA for armv5 and v4 it must be something else

It is armv7vethf.

Quoted 1 line
author
#3 lore raw
In reply to [email protected]

Ping.

Thanks,

Quoted 26 lines · On 2019年03月06日 12:24, [email protected] wrote:

From: Mingli Yu <[email protected]>

Fix the below build issue for gcc-sanitizers when
both -mthumb and -fno-omit-frame-pointer configured
for arm.
| ../../../../libsanitizer/sanitizer_common/sanitizer_linux.cc: In function 'sanitizer::uptr sanitizer::internal_clone(int (*)(void*), void*, int, void*, int*, void*, int*)':
| ../../../../libsanitizer/sanitizer_common/sanitizer_linux.cc:1540:1: error: r7 cannot be used in asm here
}

Reference: https://reviews.llvm.org/D50180

---
  meta/recipes-devtools/gcc/gcc-sanitizers_8.2.bb | 1 +
  1 file changed, 1 insertion(+)
meta/recipes-devtools/gcc/gcc-sanitizers_8.2.bb +1 -0
index f3c7058..2f89c86 100644
@@ -5,3 +5,4 @@ require gcc-sanitizers.inc
  # sanitizer_linux.s:5749: Error: lo register required -- `ldr ip,[sp],#8'
  ARM_INSTRUCTION_SET_armv4 = "arm"
  ARM_INSTRUCTION_SET_armv5 = "arm"
+TARGET_CFLAGS_remove_arm = "${@bb.utils.contains('TUNE_CCARGS', '-mthumb', '-fno-omit-frame-pointer', '', d)}"