drivers: watchdog: Kconfig: pedantic cleanups
PATCH 1/1 drivers: watchdog: Kconfig: pedantic cleanups
--- drivers/watchdog/Kconfig | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
drivers/watchdog/Kconfig +12 -12
@@ -279,10 +279,10 @@ config ARMADA_37XX_WATCHDOG select MFD_SYSCON select WATCHDOG_CORE help - Say Y here to include support for the watchdog timer found on - Marvell Armada 37xx SoCs. - To compile this driver as a module, choose M here: the - module will be called armada_37xx_wdt. + Say Y here to include support for the watchdog timer found on + Marvell Armada 37xx SoCs. + To compile this driver as a module, choose M here: the + module will be called armada_37xx_wdt. config ASM9260_WATCHDOG tristate "Alphascale ASM9260 watchdog"
@@ -606,10 +606,10 @@ config MAX77620_WATCHDOG tristate "Maxim Max77620 Watchdog Timer" depends on MFD_MAX77620 || COMPILE_TEST help - This is the driver for the Max77620 watchdog timer. - Say 'Y' here to enable the watchdog timer support for - MAX77620 chips. To compile this driver as a module, - choose M here: the module will be called max77620_wdt. + This is the driver for the Max77620 watchdog timer. + Say 'Y' here to enable the watchdog timer support for + MAX77620 chips. To compile this driver as a module, + choose M here: the module will be called max77620_wdt. config IMX2_WDT tristate "IMX2+ Watchdog"
@@ -1632,10 +1632,10 @@ config BCM7038_WDT depends on HAS_IOMEM depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST help - Watchdog driver for the built-in hardware in Broadcom 7038 and - later SoCs used in set-top boxes. BCM7038 was made public - during the 2004 CES, and since then, many Broadcom chips use this - watchdog block, including some cable modem chips. + Watchdog driver for the built-in hardware in Broadcom 7038 and + later SoCs used in set-top boxes. BCM7038 was made public + during the 2004 CES, and since then, many Broadcom chips use this + watchdog block, including some cable modem chips. config IMGPDC_WDT tristate "Imagination Technologies PDC Watchdog Timer"
Signature · 1 line
1.9.1
Guenter Roeck
maintainerQuoted 1 line · metux IT consult
Signed-off-by Enrico Weigelt, metux IT consult <[email protected]>
Checkpatch says:
WARNING: Missing commit description - Add an appropriate one
There needs to be some kind of description of those pedantic cleanups.
On top of that, while the affected Kconfig file generates 42 checkpatch warnings, this patch doesn't fix a single one of them. I don't really see the point of this patch.
Thanks,
Guenter
Quoted 54 lines
--- drivers/watchdog/Kconfig | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)drivers/watchdog/Kconfig +12
-12@@ -279,10 +279,10 @@ config ARMADA_37XX_WATCHDOG select MFD_SYSCON select WATCHDOG_CORE help - Say Y here to include support for the watchdog timer found on - Marvell Armada 37xx SoCs. - To compile this driver as a module, choose M here: the - module will be called armada_37xx_wdt. + Say Y here to include support for the watchdog timer found on + Marvell Armada 37xx SoCs. + To compile this driver as a module, choose M here: the + module will be called armada_37xx_wdt. config ASM9260_WATCHDOG tristate "Alphascale ASM9260 watchdog"@@ -606,10 +606,10 @@ config MAX77620_WATCHDOG tristate "Maxim Max77620 Watchdog Timer" depends on MFD_MAX77620 || COMPILE_TEST help - This is the driver for the Max77620 watchdog timer. - Say 'Y' here to enable the watchdog timer support for - MAX77620 chips. To compile this driver as a module, - choose M here: the module will be called max77620_wdt. + This is the driver for the Max77620 watchdog timer. + Say 'Y' here to enable the watchdog timer support for + MAX77620 chips. To compile this driver as a module, + choose M here: the module will be called max77620_wdt. config IMX2_WDT tristate "IMX2+ Watchdog"@@ -1632,10 +1632,10 @@ config BCM7038_WDT depends on HAS_IOMEM depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST help - Watchdog driver for the built-in hardware in Broadcom 7038 and - later SoCs used in set-top boxes. BCM7038 was made public - during the 2004 CES, and since then, many Broadcom chips use this - watchdog block, including some cable modem chips. + Watchdog driver for the built-in hardware in Broadcom 7038 and + later SoCs used in set-top boxes. BCM7038 was made public + during the 2004 CES, and since then, many Broadcom chips use this + watchdog block, including some cable modem chips. config IMGPDC_WDT tristate "Imagination Technologies PDC Watchdog Timer"
Quoted 3 lines · Guenter Roeck
On top of that, while the affected
Kconfigfile generates 42 checkpatch warnings, this patch doesn't fix a single one of them. I don't really see the point of this patch.
Well, it's just about making the identions more consistent, nothing else. I admin, I didn't run checkpatch.pl on that.
I'll rework it.
--mtx
Signature · 3 lines
Enrico Weigelt, metux IT consult Free software and Linux embedded engineering [email protected] -- +49-151-27565287
PATCH v2 1/1 drivers: watchdog: Kconfig: pedantic formatting
In reply to Guenter RoeckFormatting of Kconfig files doesn't look so pretty, so just take damp cloth and clean it up.
--- drivers/watchdog/Kconfig | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
drivers/watchdog/Kconfig +12 -12
@@ -279,10 +279,10 @@ config ARMADA_37XX_WATCHDOG select MFD_SYSCON select WATCHDOG_CORE help - Say Y here to include support for the watchdog timer found on - Marvell Armada 37xx SoCs. - To compile this driver as a module, choose M here: the - module will be called armada_37xx_wdt. + Say Y here to include support for the watchdog timer found on + Marvell Armada 37xx SoCs. + To compile this driver as a module, choose M here: the + module will be called armada_37xx_wdt. config ASM9260_WATCHDOG tristate "Alphascale ASM9260 watchdog"
@@ -606,10 +606,10 @@ config MAX77620_WATCHDOG tristate "Maxim Max77620 Watchdog Timer" depends on MFD_MAX77620 || COMPILE_TEST help - This is the driver for the Max77620 watchdog timer. - Say 'Y' here to enable the watchdog timer support for - MAX77620 chips. To compile this driver as a module, - choose M here: the module will be called max77620_wdt. + This is the driver for the Max77620 watchdog timer. + Say 'Y' here to enable the watchdog timer support for + MAX77620 chips. To compile this driver as a module, + choose M here: the module will be called max77620_wdt. config IMX2_WDT tristate "IMX2+ Watchdog"
@@ -1632,10 +1632,10 @@ config BCM7038_WDT depends on HAS_IOMEM depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST help - Watchdog driver for the built-in hardware in Broadcom 7038 and - later SoCs used in set-top boxes. BCM7038 was made public - during the 2004 CES, and since then, many Broadcom chips use this - watchdog block, including some cable modem chips. + Watchdog driver for the built-in hardware in Broadcom 7038 and + later SoCs used in set-top boxes. BCM7038 was made public + during the 2004 CES, and since then, many Broadcom chips use this + watchdog block, including some cable modem chips. config IMGPDC_WDT tristate "Imagination Technologies PDC Watchdog Timer"
Signature · 1 line
1.9.1
Re: [PATCH v2] drivers: watchdog: Kconfig: pedantic formatting
Quoted 4 lines · metux IT consult
Formatting of
Kconfigfiles doesn't look so pretty, so just take damp cloth and clean it up.Signed-off-by Enrico Weigelt, metux IT consult <[email protected]>
Having said that, I would really discourage this kind of cleanup, and I was quite close to NACKing it. It doesn't fix a single checkpatch issue in the affected Kconfig file, and that file currently reports 42 checkpatch warnings. Those would be more important issues to fix than vertical help text alignments.
I won't apply this patch to my branch, and will leave it up to Wim to decide what to do with it.
Guenter
Quoted 53 lines
--- drivers/watchdog/Kconfig | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)drivers/watchdog/Kconfig +12
-12@@ -279,10 +279,10 @@ config ARMADA_37XX_WATCHDOG select MFD_SYSCON select WATCHDOG_CORE help - Say Y here to include support for the watchdog timer found on - Marvell Armada 37xx SoCs. - To compile this driver as a module, choose M here: the - module will be called armada_37xx_wdt. + Say Y here to include support for the watchdog timer found on + Marvell Armada 37xx SoCs. + To compile this driver as a module, choose M here: the + module will be called armada_37xx_wdt. config ASM9260_WATCHDOG tristate "Alphascale ASM9260 watchdog"@@ -606,10 +606,10 @@ config MAX77620_WATCHDOG tristate "Maxim Max77620 Watchdog Timer" depends on MFD_MAX77620 || COMPILE_TEST help - This is the driver for the Max77620 watchdog timer. - Say 'Y' here to enable the watchdog timer support for - MAX77620 chips. To compile this driver as a module, - choose M here: the module will be called max77620_wdt. + This is the driver for the Max77620 watchdog timer. + Say 'Y' here to enable the watchdog timer support for + MAX77620 chips. To compile this driver as a module, + choose M here: the module will be called max77620_wdt. config IMX2_WDT tristate "IMX2+ Watchdog"@@ -1632,10 +1632,10 @@ config BCM7038_WDT depends on HAS_IOMEM depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST help - Watchdog driver for the built-in hardware in Broadcom 7038 and - later SoCs used in set-top boxes. BCM7038 was made public - during the 2004 CES, and since then, many Broadcom chips use this - watchdog block, including some cable modem chips. + Watchdog driver for the built-in hardware in Broadcom 7038 and + later SoCs used in set-top boxes. BCM7038 was made public + during the 2004 CES, and since then, many Broadcom chips use this + watchdog block, including some cable modem chips. config IMGPDC_WDT tristate "Imagination Technologies PDC Watchdog Timer"