FAILED: patch "[PATCH] staging: erofs: fix memleak of inode's shared xattr array" failed to apply to 4.19-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 4.19-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 3b1b5291f79d040d549d7c746669fc30e8045b9b Mon Sep 17 00:00:00 2001
From: Sheng Yong <[email protected]>
Date: Thu, 14 Feb 2019 14:46:36 +0800
Subject: [PATCH] staging: erofs: fix memleak of inode's shared xattr array
If it fails to read a shared xattr page, the inode's shared xattr array is not freed. The next time the inode's xattr is accessed, the previously allocated array is leaked.
Signed-off-by Sheng Yong <[email protected]>
Fixes b17500a0fdba ("staging: erofs: introduce xattr & acl support")
Cc <[email protected]> # 4.19+
Reviewed-by Gao Xiang <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
drivers/staging/erofs/xattr.c +4 -1
@@ -111,8 +111,11 @@ static int init_inode_xattrs(struct inode *inode) it.page =erofs_get_meta_page (sb, ++it.blkaddr,S_ISDIR (inode->i_mode)); -if (IS_ERR (it.page)) +if (IS_ERR (it.page)) { +kfree (vi->xattr_shared_xattrs); + vi->xattr_shared_xattrs =NULL ;return PTR_ERR (it.page); + } it.kaddr =kmap_atomic (it.page); atomic_map = true;