ath10k: Fix the tx stats bytes & packets parsing
PATCH 1/1 ath10k: Fix the tx stats bytes & packets parsing
In tx_stats debugfs, txrate->flags may contain multiple bits. For example, RATE_INFO_FLAGS_SHORT_GI could be set, and tx stats bytes and packets will be not updated correctly.
Fix this issue by using bit operation to check txrate->flags.
Tested HW: QCA9984
Tested Firmware: 10.4-3.9.0.1-00007
--- drivers/net/wireless/ath/ath10k/htt_rx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/ath10k/htt_rx.c +3 -3
@@ -2938,14 +2938,14 @@ static inline s8 ath10k_get_legacy_rate_idx(struct ath10k *ar, u8 rate)#define STATS_OP_FMT (name) tx_stats->stats[ATH10K_STATS_TYPE_##name] -if (txrate->flags ==RATE_INFO_FLAGS_VHT_MCS ) { +if (txrate->flags &RATE_INFO_FLAGS_VHT_MCS ) {STATS_OP_FMT (SUCC ).vht[0 ][mcs] += pstats->succ_bytes;STATS_OP_FMT (SUCC ).vht[1 ][mcs] += pstats->succ_pkts;STATS_OP_FMT (FAIL ).vht[0 ][mcs] += pstats->failed_bytes;STATS_OP_FMT (FAIL ).vht[1 ][mcs] += pstats->failed_pkts;STATS_OP_FMT (RETRY ).vht[0 ][mcs] += pstats->retry_bytes;STATS_OP_FMT (RETRY ).vht[1 ][mcs] += pstats->retry_pkts; - }else if (txrate->flags ==RATE_INFO_FLAGS_MCS ) { + }else if (txrate->flags &RATE_INFO_FLAGS_MCS ) {STATS_OP_FMT (SUCC ).ht[0 ][ht_idx] += pstats->succ_bytes;STATS_OP_FMT (SUCC ).ht[1 ][ht_idx] += pstats->succ_pkts;STATS_OP_FMT (FAIL ).ht[0 ][ht_idx] += pstats->failed_bytes;
@@ -2966,7 +2966,7 @@ static inline s8 ath10k_get_legacy_rate_idx(struct ath10k *ar, u8 rate)if (ATH10K_HW_AMPDU (pstats->flags)) { tx_stats->ba_fails +=ATH10K_HW_BA_FAIL (pstats->flags); -if (txrate->flags ==RATE_INFO_FLAGS_MCS ) { +if (txrate->flags &RATE_INFO_FLAGS_MCS ) {STATS_OP_FMT (AMPDU ).ht[0 ][ht_idx] += pstats->succ_bytes + pstats->retry_bytes; STATS_OP_FMT(AMPDU).ht[1][ht_idx] +=
Signature · 1 line
1.9.1
Quoted 11 lines · Brandon Huang
In
tx_statsdebugfs,txrate->flagsmay contain multiple bits. For example,RATE_INFO_FLAGS_SHORT_GIcould be set, and tx stats bytes and packets will be not updated correctly.Fix this issue by using bit operation to check
txrate->flags.Tested HW: QCA9984
Tested Firmware: 10.4-3.9.0.1-00007Signed-off-by Brandon Huang <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
9e0b341a3d66 ath10k: Fix the tx stats bytes & packets parsing
Signature · 9 lines
https://patchwork.kernel.org/patch/10848577/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 11 lines · Brandon Huang
In
tx_statsdebugfs,txrate->flagsmay contain multiple bits. For example,RATE_INFO_FLAGS_SHORT_GIcould be set, and tx stats bytes and packets will be not updated correctly.Fix this issue by using bit operation to check
txrate->flags.Tested HW: QCA9984
Tested Firmware: 10.4-3.9.0.1-00007Signed-off-by Brandon Huang <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
9e0b341a3d66 ath10k: Fix the tx stats bytes & packets parsing
Signature · 3 lines
https://patchwork.kernel.org/patch/10848577/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches