Skip to contentSkip to conversation

mci: imx-esdhc-pbl: initialize is_be

PATCH Applied Christian Hemp 2 participants 2 messages Mar 15, 2019 – Mar 18, 2019 Arm i.MX and Layerscape

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mci: imx-esdhc-pbl: initialize is_be

Initialize is_be, otherwise the value of is_be is undefined. So it is possible that the i.MX8 will not boot because the bigendian functions are used.

---
 drivers/mci/imx-esdhc-pbl.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/mci/imx-esdhc-pbl.c +2 -0
index f77530d..8a03c5f 100644
@@ -366,6 +366,7 @@ int imx6_esdhc_start_image(int instance)
 		return -EINVAL;
 	}
 
+	esdhc.is_be = 0;
 	esdhc.is_mx6 = 1;
 
 	return esdhc_start_image(&esdhc, 0x10000000, 0x10000000, 0);
@@ -398,6 +399,7 @@ int imx8_esdhc_start_image(int instance)
 		return -EINVAL;
 	}
 
+	esdhc.is_be = 0;
 	esdhc.is_mx6 = 1;
 
 	return esdhc_start_image(&esdhc, MX8MQ_DDR_CSD1_BASE_ADDR,
Signature · 7 lines
2.7.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
maintainer Applied
#1 lore raw
Quoted 8 lines · Christian Hemp

Initialize is_be, otherwise the value of is_be is undefined. So it is possible that the i.MX8 will not boot because the bigendian functions are used.

---
 drivers/mci/imx-esdhc-pbl.c | 2 ++
 1 file changed, 2 insertions(+)

Applied to master, thanks

Sascha

Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox