Add Plane Color Properties
Subsystems (4)
v6 cover Add Plane Color Properties
This is how a typical display color hardware pipeline looks like:
+-------------------------------------------+
| RAM |
| +------+ +---------+ +---------+ |
| | FB 1 | | FB 2 | | FB N | |
| +------+ +---------+ +---------+ |
+-------------------------------------------+
| Plane Color Hardware Block |
+--------------------------------------------+
| +---v-----+ +---v-------+ +---v------+ |
| | Plane A | | Plane B | | Plane N | |
| | DeGamma | | Degamma | | Degamma | |
| +---+-----+ +---+-------+ +---+------+ |
| | | | |
| +---v-----+ +---v-------+ +---v------+ |
| |Plane A | | Plane B | | Plane N | |
| |CSC/CTM | | CSC/CTM | | CSC/CTM | |
| +---+-----+ +----+------+ +----+-----+ |
| | | | |
| +---v-----+ +----v------+ +----v-----+ |
| | Plane A | | Plane B | | Plane N | |
| | Gamma | | Gamma | | Gamma | |
| +---+-----+ +----+------+ +----+-----+ |
| | | | |
+--------------------------------------------+
+------v--------------v---------------v-------|
|| ||
|| Pipe Blender ||
+--------------------+------------------------+
| | |
| +-----------v----------+ |
| | Pipe DeGamma | |
| | | |
| +-----------+----------+ |
| | Pipe Color |
| +-----------v----------+ Hardware |
| | Pipe CSC/CTM | |
| | | |
| +-----------+----------+ |
| | |
| +-----------v----------+ |
| | Pipe Gamma | |
| | | |
| +-----------+----------+ |
| | |
+---------------------------------------------+
| v
Pipe Output
This patch series adds properties for plane color features. It adds properties for degamma used to linearize data, CSC used for gamut conversion, and gamma used to again non-linearize data as per panel supported color space. These can be utilize by user space to convert planes from one format to another, one color space to another etc.
Usersapce can take smart blending decisions and utilize these hardware supported plane color features to get accurate color profile. The same can help in consistent color quality from source to panel taking advantage of advanced color features in hardware.
These patches just add the property interfaces and enable helper functions.
This series adds Intel Gen9 specific plane gamma feature. We can build up and add other platform/hardware specific implementation on top of this series
Note: This is just to get a design feedback whether these interfaces look ok. Based on community feedback on interfaces, we will implement IGT tests to validate plane color features. This is un-tested currently.
Userspace implementation using these properties have been done in drm hwcomposer by "Alexandru-Cosmin Gheorghe [email protected]" from ARM. A merge request has been opened by Alexandru for drm_hwcomposer, implementing the property changes for the same. Please review that as well:
https://gitlab.freedesktop.org/drm-hwcomposer/drm-hwcomposer/merge_requests/25
v2: Dropped legacy gamma table for plane as suggested by Maarten. Added Gen9/BDW plane gamma feature and rebase on tot.
v3: Added a new drm_color_lut_ext structure to accommodate 32 bit precision entries, pointed to by Brian, Starkey for HDR usecases. Addressed Sean,Paul comments and moved plane color properties to drm_plane instead of mode_config. Added property documentation as suggested by Daniel, Vetter. Fixed a rebase fumble which occurred in v2, pointed by Emil Velikov.
v4: Rebase
v5: Added "Display Color Hardware Pipeline" flow to kernel documentation as suggested by "Ville Syrjala" and "Brian Starkey". Moved the property creation to drm_color_mgmt.c file to consolidate all color operations at one place. Addressed Alexandru's review comments.
v6: Rebase. Added support for ICL Color features. Enhanced Lut precision to accept input values in u32.32 format. This is needed for higher precision required in HDR data processing.
Uma Shankar (16):
drm: Add Enhanced Gamma LUT precision structure
drm: Add Plane Degamma properties
drm: Add Plane CTM property
drm: Add Plane Gamma properties
drm: Define helper function for plane color enabling drm/i915: Enable plane color features
drm/i915: Implement Plane Gamma for Bdw and Gen9 platforms drm/i915: Load plane color luts from atomic flip drm/i915: Add plane color capabilities drm/i915/icl: Add ICL Plane Degamma Register definition drm/i915/icl: Enable Plane Degamma
drm/i915/icl: Add Plane Gamma Register Definitions drm/i915/icl: Implement Plane Gamma
drm/i915: Enable Plane Gamma/Degamma
drm/i915: Define Plane CSC Registers
drm/i915: Enable Plane CSC
Documentation/gpu/drm-kms.rst | 99 +++++++++ drivers/gpu/drm/drm_atomic.c | 1 + drivers/gpu/drm/drm_atomic_state_helper.c | 12 ++ drivers/gpu/drm/drm_atomic_uapi.c | 29 +++ drivers/gpu/drm/drm_color_mgmt.c | 137 ++++++++++++- drivers/gpu/drm/i915/i915_drv.h | 6 + drivers/gpu/drm/i915/i915_pci.c | 5 +- drivers/gpu/drm/i915/i915_reg.h | 153 ++++++++++++++ drivers/gpu/drm/i915/intel_atomic_plane.c | 3 + drivers/gpu/drm/i915/intel_color.c | 331 ++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_device_info.h | 5 + drivers/gpu/drm/i915/intel_display.c | 13 +- drivers/gpu/drm/i915/intel_drv.h | 11 + drivers/gpu/drm/i915/intel_sprite.c | 11 + include/drm/drm_color_mgmt.h | 6 + include/drm/drm_plane.h | 61 ++++++ include/uapi/drm/drm_mode.h | 15 ++ 17 files changed, 893 insertions(+), 5 deletions(-)
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v6 1/16 drm: Add Enhanced Gamma LUT precision structure
Existing LUT precision structure is having only 16 bit precision. This is not enough for upcoming enhanced hardwares and advance usecases like HDR processing. Hence added a new structure with 32 bit precision values. Also added the code, for extracting the same from values passed from userspace.
v4: Rebase
v5: Relocated the helper function to drm_color_mgmt.c. Declared the same in a header file (Alexandru Gheorghe)
v6: Enhanced gamma lut structure to take U32.32 format as input. This is needed for HDR usecase which require higher precision.
--- drivers/gpu/drm/drm_color_mgmt.c | 19 +++++++++++++++++++ include/drm/drm_color_mgmt.h | 1 + include/uapi/drm/drm_mode.h | 15 +++++++++++++++ 3 files changed, 35 insertions(+)
drivers/gpu/drm/drm_color_mgmt.c +19 -0
@@ -128,6 +128,25 @@ uint32_t drm_color_lut_extract(uint32_t user_input, uint32_t bit_precision) }EXPORT_SYMBOL (drm_color_lut_extract); +/* +* Added to accommodate enhanced LUT precision. +* Max LUT precision is 32 bits. +*/ +u64 drm_color_lut_extract_ext (u64 user_input,u32 bit_precision) +{ +u32 val = user_input &0xffffffff ; +u32 max =0xffffffff >> (32 - bit_precision); + +/* Round only if we're not using full precision. */ +if (bit_precision <32 ) { + val +=1UL << (32 - bit_precision -1 ); + val >>=32 - bit_precision; + } + +return ((user_input &0xffffffff ) |clamp_val (val,0 , max)); +} +EXPORT_SYMBOL (drm_color_lut_extract_ext); +/** * drm_crtc_enable_color_mgmt - enable color management properties * @crtc: DRM CRTC
include/drm/drm_color_mgmt.h +1 -0
@@ -30,6 +30,7 @@struct drm_plane ;uint32_t drm_color_lut_extract (uint32_t user_input,uint32_t bit_precision); +u64 drm_color_lut_extract_ext (u64 user_input,u32 bit_precision); void drm_crtc_enable_color_mgmt(struct drm_crtc *crtc, uint degamma_lut_size,
include/uapi/drm/drm_mode.h +15 -0
@@ -630,6 +630,21 @@ struct drm_color_lut {__u16 reserved; }; +/* +* Creating 64 bit palette entries for better data +* precision. This will be required for HDR and +* similar color processing usecases. +*/ +struct drm_color_lut_ext { +/* +* Data is U32.32 fixed point format. +*/ +__u64 red; +__u64 green; +__u64 blue; +__u64 reserved; +}; +#define DRM_MODE_PAGE_FLIP_EVENT 0x01#define DRM_MODE_PAGE_FLIP_ASYNC 0x02#define DRM_MODE_PAGE_FLIP_TARGET_ABSOLUTE 0x4
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [v6 01/16] drm: Add Enhanced Gamma LUT precision structure
tis 2019-03-19 klockan 14:14 +0530 skrev Uma Shankar:
Quoted 38 lines
Existing LUT precision structure is having only 16 bit precision. This is not enough for upcoming enhanced hardwares and advance usecases like HDR processing. Hence added a new structure with 32 bit precision values. Also added the code, for extracting the same from values passed from userspace.
v4: Rebase
v5: Relocated the helper function to
drm_color_mgmt.c. Declared the same in a header file (Alexandru Gheorghe)v6: Enhanced gamma lut structure to take U32.32 format as input. This is needed for HDR usecase which require higher precision.
Signed-off-by Uma Shankar <[email protected]>Reviewed-by Alexandru Gheorghe <[email protected]>--- drivers/gpu/drm/drm_color_mgmt.c | 19 +++++++++++++++++++ include/drm/drm_color_mgmt.h | 1 + include/uapi/drm/drm_mode.h | 15 +++++++++++++++ 3 files changed, 35 insertions(+)drivers/gpu/drm/drm_color_mgmt.c +6
-0@@ -128,6 +128,25 @@ uint32_t drm_color_lut_extract(uint32_t user_input, uint32_t bit_precision) }EXPORT_SYMBOL (drm_color_lut_extract); +/* +* Added to accommodate enhanced LUT precision. +* Max LUT precision is 32 bits. +*/ +u64 drm_color_lut_extract_ext (u64 user_input,u32 bit_precision) +{
drivers/gpu/drm/drm_color_mgmt.c uint32_t drm_color_lut_extract(uint32_t · line 147
Quoted 10 lines
drivers/gpu/drm/drm_color_mgmt.c +10
-0+u32 val = user_input &0xffffffff ; +u32 max =0xffffffff >> (32 - bit_precision); + +/* Round only if we're not using full precision. */ +if (bit_precision <32 ) { + val +=1UL << (32 - bit_precision -1 ); + val >>=32 - bit_precision; + } + +return ((user_input &0xffffffff ) |clamp_val (val,0 , max));
I thought the userspace precision was U32.32, so the precision here is max 64-bits?
Anyway the math looks wrong for a U32.32 value, it's probably:user_input >> (64ULL - precision)
Quoted 37 lines
drivers/gpu/drm/drm_color_mgmt.c +3
-0+} +EXPORT_SYMBOL (drm_color_lut_extract_ext); +/** * drm_crtc_enable_color_mgmt - enable color management properties * @crtc: DRM CRTC
include/drm/drm_color_mgmt.h +1
-0@@ -30,6 +30,7 @@struct drm_plane ;uint32_t drm_color_lut_extract (uint32_t user_input,uint32_t bit_precision); +u64 drm_color_lut_extract_ext (u64 user_input,u32 bit_precision); void drm_crtc_enable_color_mgmt(struct drm_crtc *crtc,include/drm/drm_color_mgmt.h +0
-0uint degamma_lut_size,include/uapi/drm/drm_mode.h +8
-0@@ -630,6 +630,21 @@ struct drm_color_lut {__u16 reserved; }; +/* +* Creating 64 bit palette entries for better data +* precision. This will be required for HDR and +* similar color processing usecases. +*/ +struct drm_color_lut_ext { +/* +* Data is U32.32 fixed point format.
include/uapi/drm/drm_mode.h struct drm_color_lut { · line 650
Quoted 10 lines
include/uapi/drm/drm_mode.h +7
-0+*/ +__u64 red; +__u64 green; +__u64 blue; +__u64 reserved; +}; +#define DRM_MODE_PAGE_FLIP_EVENT 0x01#define DRM_MODE_PAGE_FLIP_ASYNC 0x02#define DRM_MODE_PAGE_FLIP_TARGET_ABSOLUTE 0x4
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [v6 01/16] drm: Add Enhanced Gamma LUT precision structure
Quoted 62 lines
-----Original Message-----
From: Lankhorst, Maarten
Sent: Wednesday, March 27, 2019 5:43 PM
To: Shankar, Uma <[email protected]>; [email protected]
Cc: Sharma, Shashank <[email protected]>; Roper, Matthew D <[email protected]>; Syrjala, Ville <[email protected]>
Subject: Re: [v6 01/16] drm: Add Enhanced Gamma LUT precision structuretis 2019-03-19 klockan 14:14 +0530 skrev Uma Shankar:
Quoted 38 lines
Existing LUT precision structure is having only 16 bit precision. This is not enough for upcoming enhanced hardwares and advance usecases like HDR processing. Hence added a new structure with 32 bit precision values. Also added the code, for extracting the same from values passed from userspace.
v4: Rebase
v5: Relocated the helper function to
drm_color_mgmt.c. Declared the same in a header file (Alexandru Gheorghe)v6: Enhanced gamma lut structure to take U32.32 format as input. This is needed for HDR usecase which require higher precision.
Signed-off-by Uma Shankar <[email protected]>Reviewed-by Alexandru Gheorghe <[email protected]>--- drivers/gpu/drm/drm_color_mgmt.c | 19 +++++++++++++++++++ include/drm/drm_color_mgmt.h | 1 + include/uapi/drm/drm_mode.h | 15 +++++++++++++++ 3 files changed, 35 insertions(+)drivers/gpu/drm/drm_color_mgmt.c +6
-0@@ -128,6 +128,25 @@ uint32_t drm_color_lut_extract(uint32_t user_input, uint32_t bit_precision) }EXPORT_SYMBOL (drm_color_lut_extract); +/* +* Added to accommodate enhanced LUT precision. +* Max LUT precision is 32 bits. +*/ +u64 drm_color_lut_extract_ext (u64 user_input,u32 bit_precision) +{drivers/gpu/drm/drm_color_mgmt.c uint32_t drm_color_lut_extract(uint32_t · line 147
Quoted 10 lines
drivers/gpu/drm/drm_color_mgmt.c +10
-0+u32 val = user_input &0xffffffff ; +u32 max =0xffffffff >> (32 - bit_precision); + +/* Round only if we're not using full precision. */ +if (bit_precision <32 ) { + val +=1UL << (32 - bit_precision -1 ); + val >>=32 - bit_precision; + } + +return ((user_input &0xffffffff ) |clamp_val (val,0 , max));I thought the userspace precision was U32.32, so the precision here is max 64-bits?
Quoted 2 lines
Anyway the math looks wrong for a U32.32 value, it's probably:
user_input>> (64ULL - precision)
Hi Maarten,
Since we have a limitation of 64bit container and overflow if we left shift. My plan is to preserve the fixed value of 32bit separately and just round up the floating value ie 32bit after decimal which mostly represent values below 1.0. Kept bit precision as 32 for that purpose only.
But you are right, I need to have the val also as a long variable to make this logic work. Will update the val to long and this should work fine.
Thanks & Regards,
Uma Shankar
Quoted 40 lines
Quoted 40 lines
drivers/gpu/drm/drm_color_mgmt.c +3
-0+} +EXPORT_SYMBOL (drm_color_lut_extract_ext); +/** * drm_crtc_enable_color_mgmt - enable color management properties * @crtc: DRM CRTC
include/drm/drm_color_mgmt.h +1
-0@@ -30,6 +30,7 @@struct drm_plane ;uint32_t drm_color_lut_extract (uint32_t user_input,uint32_t bit_precision); +u64 drm_color_lut_extract_ext (u64 user_input,u32 bit_precision); void drm_crtc_enable_color_mgmt(struct drm_crtc *crtc,include/drm/drm_color_mgmt.h +0
-0uint degamma_lut_size,include/uapi/drm/drm_mode.h +10
-0@@ -630,6 +630,21 @@ struct drm_color_lut {__u16 reserved; }; +/* +* Creating 64 bit palette entries for better data +* precision. This will be required for HDR and +* similar color processing usecases. +*/ +struct drm_color_lut_ext { +/* +* Data is U32.32 fixed point format. +*/ +__u64 red;
Quoted 8 lines
include/uapi/drm/drm_mode.h struct drm_color_lut { · line 650
Quoted 8 lines
include/uapi/drm/drm_mode.h +5
-0+__u64 green; +__u64 blue; +__u64 reserved; +}; +#define DRM_MODE_PAGE_FLIP_EVENT 0x01#define DRM_MODE_PAGE_FLIP_ASYNC 0x02#define DRM_MODE_PAGE_FLIP_TARGET_ABSOLUTE 0x4
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v6 2/16 drm: Add Plane Degamma properties
In reply to Uma ShankarAdd Plane Degamma as a blob property and plane degamma size as a range property.
v2: Rebase
v3: Fixed Sean, Paul's review comments. Moved the property from mode_config to drm_plane. Created a helper function to instantiate these properties and removed from drm_mode_create_standard_properties Added property documentation as suggested by Daniel, Vetter.
v4: Rebase
v5: Added "Display Color Hardware Pipeline" flow to kernel documentation as suggested by "Ville Syrjala" and "Brian Starkey". Moved the property creation to drm_color_mgmt.c file to consolidate all color operations at one place.
v6: Fixed checkpatch issues with --strict as parameter.
--- Documentation/gpu/drm-kms.rst | 90 +++++++++++++++++++++++++++++++ drivers/gpu/drm/drm_atomic.c | 1 + drivers/gpu/drm/drm_atomic_state_helper.c | 5 ++ drivers/gpu/drm/drm_atomic_uapi.c | 10 ++++ drivers/gpu/drm/drm_color_mgmt.c | 43 +++++++++++++-- include/drm/drm_plane.h | 24 +++++++++ 6 files changed, 170 insertions(+), 3 deletions(-)
Documentation/gpu/drm-kms.rst +90 -0
@@ -473,12 +473,102 @@ FB_DAMAGE_CLIPS Color Management Properties --------------------------- +Below is how a typical hardware pipeline for color +will look like: + +.. kernel-render:: DOT + :alt: Display Color Pipeline + :caption: Display Color Pipeline Overview + + digraph "KMS" { + node [shape=box] + + subgraph cluster_static { + style=dashed + label="Display Color Hardware Blocks" + + node [bgcolor=grey style=filled] + "Plane Degamma A" -> "Plane CSC/CTM A" + "Plane CSC/CTM A" -> "Plane Gamma A" + "Pipe Blender" [color=lightblue,style=filled, width=5.25, height=0.75]; + "Plane Gamma A" -> "Pipe Blender" + "Pipe Blender" -> "Pipe DeGamma" + "Pipe DeGamma" -> "Pipe CSC/CTM" + "Pipe CSC/CTM" -> "Pipe Gamma" + "Pipe Gamma" -> "Pipe Output" + } + + subgraph cluster_static { + style=dashed + + node [shape=box] + "Plane Degamma B" -> "Plane CSC/CTM B" + "Plane CSC/CTM B" -> "Plane Gamma B" + "Plane Gamma B" -> "Pipe Blender" + } + + subgraph cluster_static { + style=dashed + + node [shape=box] + "Plane Degamma C" -> "Plane CSC/CTM C" + "Plane CSC/CTM C" -> "Plane Gamma C" + "Plane Gamma C" -> "Pipe Blender" + } + + subgraph cluster_fb { + style=dashed + label="RAM" + + node [shape=box width=1.7 height=0.2] + + "FB 1" -> "Plane Degamma A" + "FB 2" -> "Plane Degamma B" + "FB 3" -> "Plane Degamma C" + } + } + +In real world usecases, + +1. Plane Degamma can be used to linearize a non linear gamma +encoded framebuffer. This is needed to do any linear math like +color space conversion. For ex, linearize frames encoded in SRGB +or by HDR curve. + +2. Later Plane CTM block can convert the content to some different +colorspace. For ex, SRGB to BT2020 etc. + +3. Plane Gamma block can be used later to re-apply the non-linear +curve. This can also be used to apply Tone Mapping for HDR usecases. + +All the layers or framebuffers need to be converted to same color +space and format before blending. The plane color hardware blocks +can help with this. Once the Data is blended, similar color processing +can be done on blended output using pipe color hardware blocks. + +DRM Properties have been created to define and expose all these +hardware blocks to userspace. A userspace application (compositor +or any color app) can use these interfaces and define policies to +efficiently use the display hardware for such color operations. + +Pipe Color Management Properties +--------------------------------- + .. kernel-doc:: drivers/gpu/drm/drm_color_mgmt.c :doc: overview .. kernel-doc:: drivers/gpu/drm/drm_color_mgmt.c :export: +Plane Color Management Properties +--------------------------------- + +.. kernel-doc:: drivers/gpu/drm/drm_color_mgmt.c + :doc: Plane Color Properties + +.. kernel-doc:: drivers/gpu/drm/drm_color_mgmt.c + :doc: export + Tile Group Property -------------------
drivers/gpu/drm/drm_atomic.c +1 -0
@@ -655,6 +655,7 @@ static void drm_atomic_plane_print_state(struct drm_printer *p, drm_get_color_encoding_name(state->color_encoding));drm_printf (p,"\tcolor-range=%s\n" ,drm_get_color_range_name (state->color_range)); +drm_printf (p,"\tcolor_mgmt_changed=%d\n" , state->color_mgmt_changed);if (plane->funcs->atomic_print_state) plane->funcs->atomic_print_state (p, state);
drivers/gpu/drm/drm_atomic_state_helper.c +5 -0
@@ -242,6 +242,10 @@ void __drm_atomic_helper_plane_duplicate_state(struct drm_plane *plane, state->fence =NULL ; state->commit =NULL ; state->fb_damage_clips =NULL ; + +if (state->degamma_lut) +drm_property_blob_get (state->degamma_lut); + state->color_mgmt_changed = false; }EXPORT_SYMBOL (__drm_atomic_helper_plane_duplicate_state);
@@ -288,6 +292,7 @@ void __drm_atomic_helper_plane_destroy_state(struct drm_plane_state *state)drm_crtc_commit_put (state->commit);drm_property_blob_put (state->fb_damage_clips); +drm_property_blob_put (state->degamma_lut); }EXPORT_SYMBOL (__drm_atomic_helper_plane_destroy_state);
drivers/gpu/drm/drm_atomic_uapi.c +10 -0
@@ -572,6 +572,13 @@ static int drm_atomic_plane_set_property(struct drm_plane *plane, state->color_encoding = val; }else if (property == plane->color_range_property) { state->color_range = val; + }else if (property == plane->degamma_lut_property) { + ret =drm_atomic_replace_property_blob_from_id (dev, + &state->degamma_lut, + val,-1 ,sizeof (struct drm_color_lut ), + &replaced); + state->color_mgmt_changed |= replaced; +return ret; }else if (property == config->prop_fb_damage_clips) { ret = drm_atomic_replace_property_blob_from_id(dev, &state->fb_damage_clips,
@@ -635,6 +642,9 @@ static int drm_atomic_plane_set_property(struct drm_plane *plane, *val = state->color_encoding; }else if (property == plane->color_range_property) { *val = state->color_range; + }else if (property == plane->degamma_lut_property) { + *val = (state->degamma_lut) ? + state->degamma_lut->base.id :0 ; }else if (property == config->prop_fb_damage_clips) { *val = (state->fb_damage_clips) ? state->fb_damage_clips->base.id :0 ;
drivers/gpu/drm/drm_color_mgmt.c +40 -3
57 lines not on this page · raw message
include/drm/drm_plane.h +24 -0
@@ -195,6 +195,14 @@ struct drm_plane_state {*/ bool visible; +/* @degamma_lut: +* +* Lookup table for converting framebuffer pixel data before apply the +* color conversion matrix @ctm. See drm_plane_enable_color_mgmt(). The +* blob (if not NULL) is an array of &struct drm_color_lut_ext. +*/ +struct drm_property_blob *degamma_lut; +/** * @commit: Tracks the pending commit to prevent use-after-free conditions, * and for async plane updates.
@@ -205,6 +213,8 @@ struct drm_plane_state {/** @state: backpointer to global drm_atomic_state */ struct drm_atomic_state *state; + + u8 color_mgmt_changed : 1; }; static inline struct drm_rect
@@ -705,6 +715,18 @@ struct drm_plane {* See drm_plane_create_color_properties(). */ struct drm_property *color_range_property; + +/** +* @degamma_lut_property: Optional Plane property to set the LUT +* used to convert the framebuffer's colors to linear gamma. +*/ +struct drm_property *degamma_lut_property; + +/** +* @degamma_lut_size_property: Optional Plane property for the +* size of the degamma LUT as supported by the driver (read-only). +*/ +struct drm_property *degamma_lut_size_property; };#define obj_to_plane (x) container_of(x, struct drm_plane, base)
@@ -754,6 +776,8 @@ static inline u32 drm_plane_mask(const struct drm_plane *plane)int drm_mode_plane_set_obj_prop (struct drm_plane *plane,struct drm_property *property,uint64_t value); +int drm_plane_color_create_prop (struct drm_device *dev, +struct drm_plane *plane);/** * drm_plane_find - find a &drm_plane
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
kbuild test robot
build botRe: [v6 02/16] drm: Add Plane Degamma properties
Thank you for the patch! Perhaps something to improve:
Hi Uma,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v5.1-rc1 next-20190319]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Uma-Shankar/Add-Plane-Color-Properties/20190319-222429 base: git://anongit.freedesktop.org/drm-intel for-linux-next reproduce: make htmldocs
All warnings (new ones prefixed by >>):
net/mac80211/sta_info.h:590: warning: Function parameter or member 'status_stats.ack_signal_filled' not described in 'sta_info' net/mac80211/sta_info.h:590: warning: Function parameter or member 'status_stats.avg_ack_signal' not described in 'sta_info' net/mac80211/sta_info.h:590: warning: Function parameter or member 'tx_stats.packets' not described in 'sta_info' net/mac80211/sta_info.h:590: warning: Function parameter or member 'tx_stats.bytes' not described in 'sta_info' net/mac80211/sta_info.h:590: warning: Function parameter or member 'tx_stats.last_rate' not described in 'sta_info' net/mac80211/sta_info.h:590: warning: Function parameter or member 'tx_stats.msdu' not described in 'sta_info' kernel/rcu/tree.c:711: warning: Excess function parameter 'irq' description in 'rcu_nmi_exit'
include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_excl.cb' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_excl.poll' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_excl.active' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_shared.cb' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_shared.poll' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_shared.active' not described in 'dma_buf' include/linux/firmware/intel/stratix10-svc-client.h:1: warning: no structured comments found
include/linux/gpio/driver.h:371: warning: Function parameter or member 'init_valid_mask' not described in 'gpio_chip' include/linux/iio/hw-consumer.h:1: warning: no structured comments found
include/linux/input/sparse-keymap.h:46: warning: Function parameter or member 'sw' not described in 'key_entry' include/linux/regulator/machine.h:199: warning: Function parameter or member 'max_uV_step' not described in 'regulation_constraints' include/linux/regulator/driver.h:228: warning: Function parameter or member 'resume' not described in 'regulator_ops' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw0' not described in 'irb' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw1' not described in 'irb' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw2' not described in 'irb' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw3' not described in 'irb' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.eadm' not described in 'irb' drivers/slimbus/stream.c:1: warning: no structured comments found
include/linux/spi/spi.h:180: warning: Function parameter or member 'driver_override' not described in 'spi_device' drivers/target/target_core_device.c:1: warning: no structured comments found
drivers/usb/typec/bus.c:1: warning: no structured comments found
drivers/usb/typec/class.c:1: warning: no structured comments found
include/linux/w1.h:281: warning: Function parameter or member 'of_match_table' not described in 'w1_family'
fs/direct-io.c:257: warning: Excess function parameter 'offset' description in 'dio_complete'
fs/file_table.c:1: warning: no structured comments found
fs/libfs.c:477: warning: Excess function parameter 'available' description in 'simple_write_end'
fs/posix_acl.c:646: warning: Function parameter or member 'inode' not described in 'posix_acl_update_mode'
fs/posix_acl.c:646: warning: Function parameter or member 'mode_p' not described in 'posix_acl_update_mode'
fs/posix_acl.c:646: warning: Function parameter or member 'acl' not described in 'posix_acl_update_mode' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:294: warning: Excess function parameter 'mm' description in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:294: warning: Excess function parameter 'start' description in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:294: warning: Excess function parameter 'end' description in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:343: warning: Excess function parameter 'mm' description in 'amdgpu_mn_invalidate_range_end' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:343: warning: Excess function parameter 'start' description in 'amdgpu_mn_invalidate_range_end' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:343: warning: Excess function parameter 'end' description in 'amdgpu_mn_invalidate_range_end' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:183: warning: Function parameter or member 'blockable' not described in 'amdgpu_mn_read_lock' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:295: warning: Function parameter or member 'range' not described in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:295: warning: Excess function parameter 'mm' description in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:295: warning: Excess function parameter 'start' description in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:295: warning: Excess function parameter 'end' description in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:344: warning: Function parameter or member 'range' not described in 'amdgpu_mn_invalidate_range_end' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:344: warning: Excess function parameter 'mm' description in 'amdgpu_mn_invalidate_range_end' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:344: warning: Excess function parameter 'start' description in 'amdgpu_mn_invalidate_range_end' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:344: warning: Excess function parameter 'end' description in 'amdgpu_mn_invalidate_range_end' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:374: warning: cannot understand function prototype: 'struct amdgpu_vm_pt_cursor ' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:375: warning: cannot understand function prototype: 'struct amdgpu_vm_pt_cursor ' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:547: warning: Function parameter or member 'adev' not described in 'for_each_amdgpu_vm_pt_leaf' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:547: warning: Function parameter or member 'vm' not described in 'for_each_amdgpu_vm_pt_leaf' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:547: warning: Function parameter or member 'start' not described in 'for_each_amdgpu_vm_pt_leaf' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:547: warning: Function parameter or member 'end' not described in 'for_each_amdgpu_vm_pt_leaf' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:547: warning: Function parameter or member 'cursor' not described in 'for_each_amdgpu_vm_pt_leaf' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:595: warning: Function parameter or member 'adev' not described in 'for_each_amdgpu_vm_pt_dfs_safe' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:595: warning: Function parameter or member 'vm' not described in 'for_each_amdgpu_vm_pt_dfs_safe' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:595: warning: Function parameter or member 'cursor' not described in 'for_each_amdgpu_vm_pt_dfs_safe' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:595: warning: Function parameter or member 'entry' not described in 'for_each_amdgpu_vm_pt_dfs_safe' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:866: warning: Function parameter or member 'level' not described in 'amdgpu_vm_bo_param' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1346: warning: Function parameter or member 'params' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1346: warning: Function parameter or member 'bo' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1346: warning: Function parameter or member 'pe' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1346: warning: Function parameter or member 'addr' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1346: warning: Function parameter or member 'count' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1346: warning: Function parameter or member 'incr' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1346: warning: Function parameter or member 'flags' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1514: warning: Function parameter or member 'params' not described in 'amdgpu_vm_update_flags' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1514: warning: Function parameter or member 'bo' not described in 'amdgpu_vm_update_flags' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1514: warning: Function parameter or member 'level' not described in 'amdgpu_vm_update_flags' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1514: warning: Function parameter or member 'pe' not described in 'amdgpu_vm_update_flags' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1514: warning: Function parameter or member 'addr' not described in 'amdgpu_vm_update_flags' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1514: warning: Function parameter or member 'count' not described in 'amdgpu_vm_update_flags' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1514: warning: Function parameter or member 'incr' not described in 'amdgpu_vm_update_flags' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1514: warning: Function parameter or member 'flags' not described in 'amdgpu_vm_update_flags' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:3104: warning: Function parameter or member 'pasid' not described in 'amdgpu_vm_make_compute' drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c:375: warning: Excess function parameter 'entry' description in 'amdgpu_irq_dispatch' drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c:376: warning: Function parameter or member 'ih' not described in 'amdgpu_irq_dispatch' drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c:376: warning: Excess function parameter 'entry' description in 'amdgpu_irq_dispatch' drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c:1: warning: no structured comments found drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:128: warning: Incorrect use of kernel-doc format: Documentation Makefile include scripts source @atomic_obj drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:203: warning: Function parameter or member 'atomic_obj' not described in 'amdgpu_display_manager' drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:203: warning: Function parameter or member 'atomic_obj_lock' not described in 'amdgpu_display_manager' drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:203: warning: Function parameter or member 'backlight_link' not described in 'amdgpu_display_manager' drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:203: warning: Function parameter or member 'backlight_caps' not described in 'amdgpu_display_manager' drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:203: warning: Function parameter or member 'freesync_module' not described in 'amdgpu_display_manager' drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:203: warning: Function parameter or member 'fw_dmcu' not described in 'amdgpu_display_manager' drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:203: warning: Function parameter or member 'dmcu_fw_version' not described in 'amdgpu_display_manager' drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:1: warning: no structured comments found
include/drm/drm_drv.h:715: warning: Function parameter or member 'gem_prime_pin' not described in 'drm_driver' include/drm/drm_drv.h:715: warning: Function parameter or member 'gem_prime_unpin' not described in 'drm_driver' include/drm/drm_drv.h:715: warning: Function parameter or member 'gem_prime_res_obj' not described in 'drm_driver' include/drm/drm_drv.h:715: warning: Function parameter or member 'gem_prime_get_sg_table' not described in 'drm_driver' include/drm/drm_drv.h:715: warning: Function parameter or member 'gem_prime_import_sg_table' not described in 'drm_driver' include/drm/drm_drv.h:715: warning: Function parameter or member 'gem_prime_vmap' not described in 'drm_driver' include/drm/drm_drv.h:715: warning: Function parameter or member 'gem_prime_vunmap' not described in 'drm_driver' include/drm/drm_drv.h:715: warning: Function parameter or member 'gem_prime_mmap' not described in 'drm_driver'
>> include/drm/drm_plane.h:219: warning: Function parameter or member 'degamma_lut' not described in 'drm_plane_state' >> include/drm/drm_plane.h:219: warning: Function parameter or member 'color_mgmt_changed' not described in 'drm_plane_state'
drivers/gpu/drm/drm_color_mgmt.c:1: warning: no structured comments found
include/drm/drm_atomic_state_helper.h:1: warning: no structured comments found
drivers/gpu/drm/scheduler/sched_main.c:376: warning: Excess function parameter 'bad' description in 'drm_sched_stop' drivers/gpu/drm/scheduler/sched_main.c:377: warning: Excess function parameter 'bad' description in 'drm_sched_stop' drivers/gpu/drm/scheduler/sched_main.c:420: warning: Function parameter or member 'full_recovery' not described in 'drm_sched_start' drivers/gpu/drm/i915/i915_vma.h:50: warning: cannot understand function prototype: 'struct i915_vma ' drivers/gpu/drm/i915/i915_vma.h:1: warning: no structured comments found
drivers/gpu/drm/i915/intel_guc_fwif.h:536: warning: cannot understand function prototype: 'struct guc_log_buffer_state ' drivers/gpu/drm/i915/i915_trace.h:1: warning: no structured comments found
drivers/gpu/drm/i915/i915_reg.h:156: warning: bad line:
drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:126: warning: Function parameter or member 'hw_id' not described in 'komeda_component' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:126: warning: Function parameter or member 'max_active_outputs' not described in 'komeda_component' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:126: warning: Function parameter or member 'supported_outputs' not described in 'komeda_component' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:142: warning: Function parameter or member 'output_port' not described in 'komeda_component_output' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:196: warning: Function parameter or member 'component' not described in 'komeda_component_state' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:196: warning: Function parameter or member 'crtc' not described in 'komeda_component_state' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:196: warning: Function parameter or member 'plane' not described in 'komeda_component_state' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:196: warning: Function parameter or member 'wb_conn' not described in 'komeda_component_state' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:196: warning: Function parameter or member 'changed_active_inputs' not described in 'komeda_component_state' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:196: warning: Function parameter or member 'affected_inputs' not described in 'komeda_component_state' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'n_layers' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'layers' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'n_scalers' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'scalers' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'compiz' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'wb_layer' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'improc' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'ctrlr' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'funcs' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:321: warning: Function parameter or member 'pipe' not described in 'komeda_pipeline_state' drivers/gpu/drm/arm/display/komeda/komeda_dev.h:97: warning: Function parameter or member 'dev' not described in 'komeda_dev' drivers/gpu/drm/arm/display/komeda/komeda_dev.h:97: warning: Function parameter or member 'reg_base' not described in 'komeda_dev' drivers/gpu/drm/arm/display/komeda/komeda_dev.h:97: warning: Function parameter or member 'chip' not described in 'komeda_dev' drivers/gpu/drm/arm/display/komeda/komeda_dev.h:97: warning: Function parameter or member 'mclk' not described in 'komeda_dev' drivers/gpu/drm/arm/display/komeda/komeda_dev.h:97: warning: Function parameter or member 'n_pipelines' not described in 'komeda_dev' drivers/gpu/drm/arm/display/komeda/komeda_dev.h:97: warning: Function parameter or member 'pipelines' not described in 'komeda_dev' drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.h:1: warning: no structured comments found drivers/gpu/drm/arm/display/komeda/komeda_crtc.c:1: warning: no structured comments found drivers/gpu/drm/arm/display/komeda/komeda_plane.c:1: warning: no structured comments found
include/linux/skbuff.h:876: warning: Function parameter or member 'dev_scratch' not described in 'sk_buff'
include/linux/skbuff.h:876: warning: Function parameter or member 'list' not described in 'sk_buff'
include/linux/skbuff.h:876: warning: Function parameter or member 'ip_defrag_offset' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'skb_mstamp_ns' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member '__cloned_offset' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'head_frag' not described in 'sk_buff'
include/linux/skbuff.h:876: warning: Function parameter or member '__pkt_type_offset' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'encapsulation' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'encap_hdr_csum' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'csum_valid' not described in 'sk_buff'
include/linux/skbuff.h:876: warning: Function parameter or member '__pkt_vlan_present_offset' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'vlan_present' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'csum_complete_sw' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'csum_level' not described in 'sk_buff'
include/linux/skbuff.h:876: warning: Function parameter or member 'inner_protocol_type' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'remcsum_offload' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'sender_cpu' not described in 'sk_buff'
include/linux/skbuff.h:876: warning: Function parameter or member 'reserved_tailroom' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'inner_ipproto' not described in 'sk_buff'
include/net/sock.h:238: warning: Function parameter or member 'skc_addrpair' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_portpair' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_ipv6only' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_net_refcnt' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_v6_daddr' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_v6_rcv_saddr' not described in 'sock_common' include/net/sock.h:238: warning: Function parameter or member 'skc_cookie' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_listener' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_tw_dr' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_rcv_wnd' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_tw_rcv_nxt' not described in 'sock_common'
include/net/sock.h:513: warning: Function parameter or member 'sk_backlog.rmem_alloc' not described in 'sock'
include/net/sock.h:513: warning: Function parameter or member 'sk_backlog.len' not described in 'sock'
include/net/sock.h:513: warning: Function parameter or member 'sk_backlog.head' not described in 'sock'
include/net/sock.h:513: warning: Function parameter or member 'sk_backlog.tail' not described in 'sock'
include/net/sock.h:513: warning: Function parameter or member 'sk_wq_raw' not described in 'sock'
include/net/sock.h:513: warning: Function parameter or member 'tcp_rtx_queue' not described in 'sock'
include/net/sock.h:513: warning: Function parameter or member 'sk_route_forced_caps' not described in 'sock'
include/net/sock.h:513: warning: Function parameter or member 'sk_txtime_report_errors' not described in 'sock' include/net/sock.h:513: warning: Function parameter or member 'sk_validate_xmit_skb' not described in 'sock' include/linux/netdevice.h:2051: warning: Function parameter or member 'adj_list.upper' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'adj_list.lower' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'gso_partial_features' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'switchdev_ops' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'l3mdev_ops' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'xfrmdev_ops' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'tlsdev_ops' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'name_assign_type' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'ieee802154_ptr' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'mpls_ptr' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'xdp_prog' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'gro_flush_timeout' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'nf_hooks_ingress' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member '____cacheline_aligned_in_smp' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'qdisc_hash' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'xps_cpus_map' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'xps_rxqs_map' not described in 'net_device' include/linux/phylink.h:56: warning: Function parameter or member '__ETHTOOL_DECLARE_LINK_MODE_MASK(advertising' not described in 'phylink_link_state' include/linux/phylink.h:56: warning: Function parameter or member '__ETHTOOL_DECLARE_LINK_MODE_MASK(lp_advertising' not described in 'phylink_link_state' Documentation/admin-guide/cgroup-v2.rst:1509: WARNING: Block quote ends without a blank line; unexpected unindent. Documentation/admin-guide/cgroup-v2.rst:1511: WARNING: Block quote ends without a blank line; unexpected unindent. Documentation/admin-guide/cgroup-v2.rst:1512: WARNING: Block quote ends without a blank line; unexpected unindent.
vim +219 include/drm/drm_plane.h
43968d7b Daniel Vetter 2016-09-21 @219
:::::: The code at line 219 was first introduced by commit :::::: 43968d7b806d7a7e021261294c583a216fddf0e5 drm: Extract drm_plane.[hc]
:::::: TO: Daniel Vetter <[email protected]>
:::::: CC: Sean Paul <[email protected]>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v6 3/16 drm: Add Plane CTM property
In reply to Uma ShankarAdd a blob property for plane CSC usage.
v2: Rebase
v3: Fixed Sean, Paul's review comments. Moved the property from mode_config to drm_plane. Created a helper function to instantiate these properties and removed from drm_mode_create_standard_properties Added property documentation as suggested by Daniel, Vetter.
v4: Rebase
v5: Moved property creation to drm_color_mgmt.c file to have all color operations consolidated at one place. No logical change.
--- Documentation/gpu/drm-kms.rst | 3 +++ drivers/gpu/drm/drm_atomic_state_helper.c | 4 ++++ drivers/gpu/drm/drm_atomic_uapi.c | 10 ++++++++++ drivers/gpu/drm/drm_color_mgmt.c | 11 +++++++++++ include/drm/drm_plane.h | 15 +++++++++++++++ 5 files changed, 43 insertions(+)
Documentation/gpu/drm-kms.rst +3 -0
@@ -569,6 +569,9 @@ Plane Color Management Properties .. kernel-doc:: drivers/gpu/drm/drm_color_mgmt.c :doc: export +.. kernel-doc:: drivers/gpu/drm/drm_color_mgmt.c + :doc: ctm_property + Tile Group Property -------------------
drivers/gpu/drm/drm_atomic_state_helper.c +4 -0
@@ -245,6 +245,9 @@ void __drm_atomic_helper_plane_duplicate_state(struct drm_plane *plane,if (state->degamma_lut)drm_property_blob_get (state->degamma_lut); +if (state->ctm) +drm_property_blob_get (state->ctm); + state->color_mgmt_changed = false; }EXPORT_SYMBOL (__drm_atomic_helper_plane_duplicate_state);
@@ -293,6 +296,7 @@ void __drm_atomic_helper_plane_destroy_state(struct drm_plane_state *state)drm_property_blob_put (state->fb_damage_clips);drm_property_blob_put (state->degamma_lut); +drm_property_blob_put (state->ctm); }EXPORT_SYMBOL (__drm_atomic_helper_plane_destroy_state);
drivers/gpu/drm/drm_atomic_uapi.c +10 -0
@@ -579,6 +579,14 @@ static int drm_atomic_plane_set_property(struct drm_plane *plane, &replaced); state->color_mgmt_changed |= replaced;return ret; + }else if (property == plane->ctm_property) { + ret =drm_atomic_replace_property_blob_from_id (dev, + &state->ctm, + val, +sizeof (struct drm_color_ctm ),-1 , + &replaced); + state->color_mgmt_changed |= replaced; +return ret; }else if (property == config->prop_fb_damage_clips) { ret = drm_atomic_replace_property_blob_from_id(dev, &state->fb_damage_clips,
@@ -645,6 +653,8 @@ static int drm_atomic_plane_set_property(struct drm_plane *plane, }else if (property == plane->degamma_lut_property) { *val = (state->degamma_lut) ? state->degamma_lut->base.id :0 ; + }else if (property == plane->ctm_property) { + *val = (state->ctm) ? state->ctm->base.id :0 ; }else if (property == config->prop_fb_damage_clips) { *val = (state->fb_damage_clips) ? state->fb_damage_clips->base.id :0 ;
drivers/gpu/drm/drm_color_mgmt.c +11 -0
@@ -496,6 +496,11 @@ int drm_plane_create_color_properties(struct drm_plane *plane,* * degamma_lut_size_property: * Range Property to indicate size of the plane degamma LUT. +* +* ctm_property: +* Blob property which allows a userspace to provide CTM coefficients +* to do color space conversion or any other enhancement by doing a +* matrix multiplication using the h/w CTM processing engine */ int drm_plane_color_create_prop (struct drm_device *dev,struct drm_plane *plane)
@@ -515,6 +520,12 @@ int drm_plane_color_create_prop(struct drm_device *dev,return -ENOMEM ; plane->degamma_lut_size_property = prop; + prop =drm_property_create (dev,DRM_MODE_PROP_BLOB , +"PLANE_CTM" ,0 ); +if (!prop) +return -ENOMEM ; + plane->ctm_property = prop; +return 0 ; }EXPORT_SYMBOL (drm_plane_color_create_prop);
include/drm/drm_plane.h +15 -0
@@ -204,6 +204,14 @@ struct drm_plane_state {struct drm_property_blob *degamma_lut;/** +* @ctm: +* +* Color transformation matrix. See drm_plane_enable_color_mgmt(). The +* blob (if not NULL) is a &struct drm_color_ctm. +*/ +struct drm_property_blob *ctm; + +/** * @commit: Tracks the pending commit to prevent use-after-free conditions, * and for async plane updates. *
@@ -727,6 +735,13 @@ struct drm_plane {* size of the degamma LUT as supported by the driver (read-only). */ struct drm_property *degamma_lut_size_property; + +/** +* @plane_ctm_property: Optional Plane property to set the +* matrix used to convert colors after the lookup in the +* degamma LUT. +*/ +struct drm_property *ctm_property; };#define obj_to_plane (x) container_of(x, struct drm_plane, base)
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
kbuild test robot
build botRe: [v6 03/16] drm: Add Plane CTM property
Thank you for the patch! Perhaps something to improve:
Hi Uma,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v5.1-rc1 next-20190319]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Uma-Shankar/Add-Plane-Color-Properties/20190319-222429 base: git://anongit.freedesktop.org/drm-intel for-linux-next reproduce: make htmldocs
All warnings (new ones prefixed by >>):
net/mac80211/sta_info.h:590: warning: Function parameter or member 'tx_stats.packets' not described in 'sta_info' net/mac80211/sta_info.h:590: warning: Function parameter or member 'tx_stats.bytes' not described in 'sta_info' net/mac80211/sta_info.h:590: warning: Function parameter or member 'tx_stats.last_rate' not described in 'sta_info' net/mac80211/sta_info.h:590: warning: Function parameter or member 'tx_stats.msdu' not described in 'sta_info' kernel/rcu/tree.c:711: warning: Excess function parameter 'irq' description in 'rcu_nmi_exit'
include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_excl.cb' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_excl.poll' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_excl.active' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_shared.cb' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_shared.poll' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_shared.active' not described in 'dma_buf' include/linux/firmware/intel/stratix10-svc-client.h:1: warning: no structured comments found
include/linux/gpio/driver.h:371: warning: Function parameter or member 'init_valid_mask' not described in 'gpio_chip' include/linux/iio/hw-consumer.h:1: warning: no structured comments found
include/linux/input/sparse-keymap.h:46: warning: Function parameter or member 'sw' not described in 'key_entry' include/linux/regulator/machine.h:199: warning: Function parameter or member 'max_uV_step' not described in 'regulation_constraints' include/linux/regulator/driver.h:228: warning: Function parameter or member 'resume' not described in 'regulator_ops' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw0' not described in 'irb' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw1' not described in 'irb' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw2' not described in 'irb' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw3' not described in 'irb' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.eadm' not described in 'irb' drivers/slimbus/stream.c:1: warning: no structured comments found
include/linux/spi/spi.h:180: warning: Function parameter or member 'driver_override' not described in 'spi_device' drivers/target/target_core_device.c:1: warning: no structured comments found
drivers/usb/typec/bus.c:1: warning: no structured comments found
drivers/usb/typec/class.c:1: warning: no structured comments found
include/linux/w1.h:281: warning: Function parameter or member 'of_match_table' not described in 'w1_family'
fs/direct-io.c:257: warning: Excess function parameter 'offset' description in 'dio_complete'
fs/file_table.c:1: warning: no structured comments found
fs/libfs.c:477: warning: Excess function parameter 'available' description in 'simple_write_end'
fs/posix_acl.c:646: warning: Function parameter or member 'inode' not described in 'posix_acl_update_mode'
fs/posix_acl.c:646: warning: Function parameter or member 'mode_p' not described in 'posix_acl_update_mode'
fs/posix_acl.c:646: warning: Function parameter or member 'acl' not described in 'posix_acl_update_mode' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:294: warning: Excess function parameter 'mm' description in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:294: warning: Excess function parameter 'start' description in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:294: warning: Excess function parameter 'end' description in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:343: warning: Excess function parameter 'mm' description in 'amdgpu_mn_invalidate_range_end' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:343: warning: Excess function parameter 'start' description in 'amdgpu_mn_invalidate_range_end' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:343: warning: Excess function parameter 'end' description in 'amdgpu_mn_invalidate_range_end' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:183: warning: Function parameter or member 'blockable' not described in 'amdgpu_mn_read_lock' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:295: warning: Function parameter or member 'range' not described in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:295: warning: Excess function parameter 'mm' description in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:295: warning: Excess function parameter 'start' description in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:295: warning: Excess function parameter 'end' description in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:344: warning: Function parameter or member 'range' not described in 'amdgpu_mn_invalidate_range_end' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:344: warning: Excess function parameter 'mm' description in 'amdgpu_mn_invalidate_range_end' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:344: warning: Excess function parameter 'start' description in 'amdgpu_mn_invalidate_range_end' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:344: warning: Excess function parameter 'end' description in 'amdgpu_mn_invalidate_range_end' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:374: warning: cannot understand function prototype: 'struct amdgpu_vm_pt_cursor ' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:375: warning: cannot understand function prototype: 'struct amdgpu_vm_pt_cursor ' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:547: warning: Function parameter or member 'adev' not described in 'for_each_amdgpu_vm_pt_leaf' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:547: warning: Function parameter or member 'vm' not described in 'for_each_amdgpu_vm_pt_leaf' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:547: warning: Function parameter or member 'start' not described in 'for_each_amdgpu_vm_pt_leaf' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:547: warning: Function parameter or member 'end' not described in 'for_each_amdgpu_vm_pt_leaf' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:547: warning: Function parameter or member 'cursor' not described in 'for_each_amdgpu_vm_pt_leaf' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:595: warning: Function parameter or member 'adev' not described in 'for_each_amdgpu_vm_pt_dfs_safe' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:595: warning: Function parameter or member 'vm' not described in 'for_each_amdgpu_vm_pt_dfs_safe' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:595: warning: Function parameter or member 'cursor' not described in 'for_each_amdgpu_vm_pt_dfs_safe' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:595: warning: Function parameter or member 'entry' not described in 'for_each_amdgpu_vm_pt_dfs_safe' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:866: warning: Function parameter or member 'level' not described in 'amdgpu_vm_bo_param' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1346: warning: Function parameter or member 'params' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1346: warning: Function parameter or member 'bo' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1346: warning: Function parameter or member 'pe' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1346: warning: Function parameter or member 'addr' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1346: warning: Function parameter or member 'count' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1346: warning: Function parameter or member 'incr' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1346: warning: Function parameter or member 'flags' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1514: warning: Function parameter or member 'params' not described in 'amdgpu_vm_update_flags' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1514: warning: Function parameter or member 'bo' not described in 'amdgpu_vm_update_flags' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1514: warning: Function parameter or member 'level' not described in 'amdgpu_vm_update_flags' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1514: warning: Function parameter or member 'pe' not described in 'amdgpu_vm_update_flags' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1514: warning: Function parameter or member 'addr' not described in 'amdgpu_vm_update_flags' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1514: warning: Function parameter or member 'count' not described in 'amdgpu_vm_update_flags' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1514: warning: Function parameter or member 'incr' not described in 'amdgpu_vm_update_flags' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1514: warning: Function parameter or member 'flags' not described in 'amdgpu_vm_update_flags' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:3104: warning: Function parameter or member 'pasid' not described in 'amdgpu_vm_make_compute' drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c:375: warning: Excess function parameter 'entry' description in 'amdgpu_irq_dispatch' drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c:376: warning: Function parameter or member 'ih' not described in 'amdgpu_irq_dispatch' drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c:376: warning: Excess function parameter 'entry' description in 'amdgpu_irq_dispatch' drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c:1: warning: no structured comments found drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:128: warning: Incorrect use of kernel-doc format: Documentation Makefile include scripts source @atomic_obj drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:203: warning: Function parameter or member 'atomic_obj' not described in 'amdgpu_display_manager' drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:203: warning: Function parameter or member 'atomic_obj_lock' not described in 'amdgpu_display_manager' drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:203: warning: Function parameter or member 'backlight_link' not described in 'amdgpu_display_manager' drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:203: warning: Function parameter or member 'backlight_caps' not described in 'amdgpu_display_manager' drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:203: warning: Function parameter or member 'freesync_module' not described in 'amdgpu_display_manager' drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:203: warning: Function parameter or member 'fw_dmcu' not described in 'amdgpu_display_manager' drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:203: warning: Function parameter or member 'dmcu_fw_version' not described in 'amdgpu_display_manager' drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:1: warning: no structured comments found
include/drm/drm_drv.h:715: warning: Function parameter or member 'gem_prime_pin' not described in 'drm_driver' include/drm/drm_drv.h:715: warning: Function parameter or member 'gem_prime_unpin' not described in 'drm_driver' include/drm/drm_drv.h:715: warning: Function parameter or member 'gem_prime_res_obj' not described in 'drm_driver' include/drm/drm_drv.h:715: warning: Function parameter or member 'gem_prime_get_sg_table' not described in 'drm_driver' include/drm/drm_drv.h:715: warning: Function parameter or member 'gem_prime_import_sg_table' not described in 'drm_driver' include/drm/drm_drv.h:715: warning: Function parameter or member 'gem_prime_vmap' not described in 'drm_driver' include/drm/drm_drv.h:715: warning: Function parameter or member 'gem_prime_vunmap' not described in 'drm_driver' include/drm/drm_drv.h:715: warning: Function parameter or member 'gem_prime_mmap' not described in 'drm_driver' include/drm/drm_plane.h:227: warning: Function parameter or member 'degamma_lut' not described in 'drm_plane_state' include/drm/drm_plane.h:227: warning: Function parameter or member 'color_mgmt_changed' not described in 'drm_plane_state'
>> include/drm/drm_plane.h:746: warning: Function parameter or member 'ctm_property' not described in 'drm_plane'
drivers/gpu/drm/drm_color_mgmt.c:1: warning: no structured comments found
drivers/gpu/drm/drm_color_mgmt.c:1: warning: no structured comments found
include/drm/drm_atomic_state_helper.h:1: warning: no structured comments found
drivers/gpu/drm/scheduler/sched_main.c:376: warning: Excess function parameter 'bad' description in 'drm_sched_stop' drivers/gpu/drm/scheduler/sched_main.c:377: warning: Excess function parameter 'bad' description in 'drm_sched_stop' drivers/gpu/drm/scheduler/sched_main.c:420: warning: Function parameter or member 'full_recovery' not described in 'drm_sched_start' drivers/gpu/drm/i915/i915_vma.h:50: warning: cannot understand function prototype: 'struct i915_vma ' drivers/gpu/drm/i915/i915_vma.h:1: warning: no structured comments found
drivers/gpu/drm/i915/intel_guc_fwif.h:536: warning: cannot understand function prototype: 'struct guc_log_buffer_state ' drivers/gpu/drm/i915/i915_trace.h:1: warning: no structured comments found
drivers/gpu/drm/i915/i915_reg.h:156: warning: bad line:
drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:126: warning: Function parameter or member 'hw_id' not described in 'komeda_component' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:126: warning: Function parameter or member 'max_active_outputs' not described in 'komeda_component' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:126: warning: Function parameter or member 'supported_outputs' not described in 'komeda_component' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:142: warning: Function parameter or member 'output_port' not described in 'komeda_component_output' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:196: warning: Function parameter or member 'component' not described in 'komeda_component_state' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:196: warning: Function parameter or member 'crtc' not described in 'komeda_component_state' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:196: warning: Function parameter or member 'plane' not described in 'komeda_component_state' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:196: warning: Function parameter or member 'wb_conn' not described in 'komeda_component_state' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:196: warning: Function parameter or member 'changed_active_inputs' not described in 'komeda_component_state' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:196: warning: Function parameter or member 'affected_inputs' not described in 'komeda_component_state' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'n_layers' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'layers' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'n_scalers' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'scalers' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'compiz' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'wb_layer' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'improc' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'ctrlr' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'funcs' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:321: warning: Function parameter or member 'pipe' not described in 'komeda_pipeline_state' drivers/gpu/drm/arm/display/komeda/komeda_dev.h:97: warning: Function parameter or member 'dev' not described in 'komeda_dev' drivers/gpu/drm/arm/display/komeda/komeda_dev.h:97: warning: Function parameter or member 'reg_base' not described in 'komeda_dev' drivers/gpu/drm/arm/display/komeda/komeda_dev.h:97: warning: Function parameter or member 'chip' not described in 'komeda_dev' drivers/gpu/drm/arm/display/komeda/komeda_dev.h:97: warning: Function parameter or member 'mclk' not described in 'komeda_dev' drivers/gpu/drm/arm/display/komeda/komeda_dev.h:97: warning: Function parameter or member 'n_pipelines' not described in 'komeda_dev' drivers/gpu/drm/arm/display/komeda/komeda_dev.h:97: warning: Function parameter or member 'pipelines' not described in 'komeda_dev' drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.h:1: warning: no structured comments found drivers/gpu/drm/arm/display/komeda/komeda_crtc.c:1: warning: no structured comments found drivers/gpu/drm/arm/display/komeda/komeda_plane.c:1: warning: no structured comments found
include/linux/skbuff.h:876: warning: Function parameter or member 'dev_scratch' not described in 'sk_buff'
include/linux/skbuff.h:876: warning: Function parameter or member 'list' not described in 'sk_buff'
include/linux/skbuff.h:876: warning: Function parameter or member 'ip_defrag_offset' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'skb_mstamp_ns' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member '__cloned_offset' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'head_frag' not described in 'sk_buff'
include/linux/skbuff.h:876: warning: Function parameter or member '__pkt_type_offset' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'encapsulation' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'encap_hdr_csum' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'csum_valid' not described in 'sk_buff'
include/linux/skbuff.h:876: warning: Function parameter or member '__pkt_vlan_present_offset' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'vlan_present' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'csum_complete_sw' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'csum_level' not described in 'sk_buff'
include/linux/skbuff.h:876: warning: Function parameter or member 'inner_protocol_type' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'remcsum_offload' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'sender_cpu' not described in 'sk_buff'
include/linux/skbuff.h:876: warning: Function parameter or member 'reserved_tailroom' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'inner_ipproto' not described in 'sk_buff'
include/net/sock.h:238: warning: Function parameter or member 'skc_addrpair' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_portpair' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_ipv6only' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_net_refcnt' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_v6_daddr' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_v6_rcv_saddr' not described in 'sock_common' include/net/sock.h:238: warning: Function parameter or member 'skc_cookie' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_listener' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_tw_dr' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_rcv_wnd' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_tw_rcv_nxt' not described in 'sock_common'
include/net/sock.h:513: warning: Function parameter or member 'sk_backlog.rmem_alloc' not described in 'sock'
include/net/sock.h:513: warning: Function parameter or member 'sk_backlog.len' not described in 'sock'
include/net/sock.h:513: warning: Function parameter or member 'sk_backlog.head' not described in 'sock'
include/net/sock.h:513: warning: Function parameter or member 'sk_backlog.tail' not described in 'sock'
include/net/sock.h:513: warning: Function parameter or member 'sk_wq_raw' not described in 'sock'
include/net/sock.h:513: warning: Function parameter or member 'tcp_rtx_queue' not described in 'sock'
include/net/sock.h:513: warning: Function parameter or member 'sk_route_forced_caps' not described in 'sock'
include/net/sock.h:513: warning: Function parameter or member 'sk_txtime_report_errors' not described in 'sock' include/net/sock.h:513: warning: Function parameter or member 'sk_validate_xmit_skb' not described in 'sock' include/linux/netdevice.h:2051: warning: Function parameter or member 'adj_list.upper' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'adj_list.lower' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'gso_partial_features' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'switchdev_ops' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'l3mdev_ops' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'xfrmdev_ops' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'tlsdev_ops' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'name_assign_type' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'ieee802154_ptr' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'mpls_ptr' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'xdp_prog' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'gro_flush_timeout' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'nf_hooks_ingress' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member '____cacheline_aligned_in_smp' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'qdisc_hash' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'xps_cpus_map' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'xps_rxqs_map' not described in 'net_device' include/linux/phylink.h:56: warning: Function parameter or member '__ETHTOOL_DECLARE_LINK_MODE_MASK(advertising' not described in 'phylink_link_state' include/linux/phylink.h:56: warning: Function parameter or member '__ETHTOOL_DECLARE_LINK_MODE_MASK(lp_advertising' not described in 'phylink_link_state' Documentation/admin-guide/cgroup-v2.rst:1509: WARNING: Block quote ends without a blank line; unexpected unindent. Documentation/admin-guide/cgroup-v2.rst:1511: WARNING: Block quote ends without a blank line; unexpected unindent.
vim +746 include/drm/drm_plane.h
43968d7b Daniel Vetter 2016-09-21 @746
:::::: The code at line 746 was first introduced by commit :::::: 43968d7b806d7a7e021261294c583a216fddf0e5 drm: Extract drm_plane.[hc]
:::::: TO: Daniel Vetter <[email protected]>
:::::: CC: Sean Paul <[email protected]>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v6 4/16 drm: Add Plane Gamma properties
In reply to Uma ShankarAdd plane gamma as blob property and size as a
range property.
v2: Rebase
v3: Fixed Sean, Paul's review comments. Moved the property from mode_config to drm_plane. Created a helper function to instantiate these properties and removed from drm_mode_create_standard_properties Added property documentation as suggested by Daniel, Vetter.
v4: Rebase
v5: Moved property creation to drm_color_mgmt.c file to have all color operations consolidated at one place. No logical change.
--- Documentation/gpu/drm-kms.rst | 6 ++++++ drivers/gpu/drm/drm_atomic_state_helper.c | 3 +++ drivers/gpu/drm/drm_atomic_uapi.c | 9 +++++++++ drivers/gpu/drm/drm_color_mgmt.c | 22 ++++++++++++++++++++++ include/drm/drm_plane.h | 22 ++++++++++++++++++++++ 5 files changed, 62 insertions(+)
Documentation/gpu/drm-kms.rst +6 -0
@@ -572,6 +572,12 @@ Plane Color Management Properties .. kernel-doc:: drivers/gpu/drm/drm_color_mgmt.c :doc: ctm_property +.. kernel-doc:: drivers/gpu/drm/drm_color_mgmt.c + :doc: gamma_lut_property + +.. kernel-doc:: drivers/gpu/drm/drm_color_mgmt.c + :doc: gamma_lut_size_property + Tile Group Property -------------------
drivers/gpu/drm/drm_atomic_state_helper.c +3 -0
@@ -247,6 +247,8 @@ void __drm_atomic_helper_plane_duplicate_state(struct drm_plane *plane,drm_property_blob_get (state->degamma_lut);if (state->ctm)drm_property_blob_get (state->ctm); +if (state->gamma_lut) +drm_property_blob_get (state->gamma_lut); state->color_mgmt_changed = false; }
@@ -297,6 +299,7 @@ void __drm_atomic_helper_plane_destroy_state(struct drm_plane_state *state)drm_property_blob_put (state->fb_damage_clips);drm_property_blob_put (state->degamma_lut);drm_property_blob_put (state->ctm); +drm_property_blob_put (state->gamma_lut); }EXPORT_SYMBOL (__drm_atomic_helper_plane_destroy_state);
drivers/gpu/drm/drm_atomic_uapi.c +9 -0
@@ -587,6 +587,13 @@ static int drm_atomic_plane_set_property(struct drm_plane *plane, &replaced); state->color_mgmt_changed |= replaced;return ret; + }else if (property == plane->gamma_lut_property) { + ret =drm_atomic_replace_property_blob_from_id (dev, + &state->gamma_lut, + val,-1 ,sizeof (struct drm_color_lut ), + &replaced); + state->color_mgmt_changed |= replaced; +return ret; }else if (property == config->prop_fb_damage_clips) { ret = drm_atomic_replace_property_blob_from_id(dev, &state->fb_damage_clips,
@@ -655,6 +662,8 @@ static int drm_atomic_plane_set_property(struct drm_plane *plane, state->degamma_lut->base.id : 0; }else if (property == plane->ctm_property) { *val = (state->ctm) ? state->ctm->base.id :0 ; + }else if (property == plane->gamma_lut_property) { + *val = (state->gamma_lut) ? state->gamma_lut->base.id :0 ; }else if (property == config->prop_fb_damage_clips) { *val = (state->fb_damage_clips) ? state->fb_damage_clips->base.id :0 ;
drivers/gpu/drm/drm_color_mgmt.c +22 -0
@@ -501,6 +501,15 @@ int drm_plane_create_color_properties(struct drm_plane *plane,* Blob property which allows a userspace to provide CTM coefficients * to do color space conversion or any other enhancement by doing a * matrix multiplication using the h/w CTM processing engine +* +* gamma_lut_property: +* Blob property which allows a userspace to provide LUT values +* to apply gamma/tone-mapping curve using the h/w plane gamma +* processing engine, thereby making the content as non-linear +* or to perform any tone mapping operation for HDR usecases. +* +* gamma_lut_size_property: +* Range Property to indicate size of the plane gamma LUT. */ int drm_plane_color_create_prop (struct drm_device *dev,struct drm_plane *plane)
@@ -526,6 +535,19 @@ int drm_plane_color_create_prop(struct drm_device *dev,return -ENOMEM ; plane->ctm_property = prop; + prop =drm_property_create (dev,DRM_MODE_PROP_BLOB , +"PLANE_GAMMA_LUT" ,0 ); +if (!prop) +return -ENOMEM ; + plane->gamma_lut_property = prop; + + prop =drm_property_create_range (dev,DRM_MODE_PROP_IMMUTABLE , +"PLANE_GAMMA_LUT_SIZE" ,0 , +UINT_MAX ); +if (!prop) +return -ENOMEM ; + plane->gamma_lut_size_property = prop; +return 0 ; }EXPORT_SYMBOL (drm_plane_color_create_prop);
include/drm/drm_plane.h +22 -0
@@ -212,6 +212,15 @@ struct drm_plane_state {struct drm_property_blob *ctm;/** +* @gamma_lut: +* +* Lookup table for converting pixel data after the color conversion +* matrix @ctm. See drm_plane_enable_color_mgmt(). The blob (if not +* NULL) is an array of &struct drm_color_lut_ext. +*/ +struct drm_property_blob *gamma_lut; + +/** * @commit: Tracks the pending commit to prevent use-after-free conditions, * and for async plane updates. *
@@ -742,6 +751,19 @@ struct drm_plane {* degamma LUT. */ struct drm_property *ctm_property; + +/** +* @plane_gamma_lut_property: Optional Plane property to set the LUT +* used to convert the colors, after the CTM matrix, to the common +* gamma space chosen for blending. +*/ +struct drm_property *gamma_lut_property; + +/** +* @plane_gamma_lut_size_property: Optional Plane property for the size +* of the gamma LUT as supported by the driver (read-only). +*/ +struct drm_property *gamma_lut_size_property; };#define obj_to_plane (x) container_of(x, struct drm_plane, base)
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
kbuild test robot
build botRe: [v6 04/16] drm: Add Plane Gamma properties
Thank you for the patch! Perhaps something to improve:
Hi Uma,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v5.1-rc1 next-20190319]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Uma-Shankar/Add-Plane-Color-Properties/20190319-222429 base: git://anongit.freedesktop.org/drm-intel for-linux-next reproduce: make htmldocs
All warnings (new ones prefixed by >>):
net/mac80211/sta_info.h:590: warning: Function parameter or member 'tx_stats.bytes' not described in 'sta_info' net/mac80211/sta_info.h:590: warning: Function parameter or member 'tx_stats.last_rate' not described in 'sta_info' net/mac80211/sta_info.h:590: warning: Function parameter or member 'tx_stats.msdu' not described in 'sta_info' kernel/rcu/tree.c:711: warning: Excess function parameter 'irq' description in 'rcu_nmi_exit'
include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_excl.cb' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_excl.poll' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_excl.active' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_shared.cb' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_shared.poll' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_shared.active' not described in 'dma_buf' include/linux/firmware/intel/stratix10-svc-client.h:1: warning: no structured comments found
include/linux/gpio/driver.h:371: warning: Function parameter or member 'init_valid_mask' not described in 'gpio_chip' include/linux/iio/hw-consumer.h:1: warning: no structured comments found
include/linux/input/sparse-keymap.h:46: warning: Function parameter or member 'sw' not described in 'key_entry' include/linux/regulator/machine.h:199: warning: Function parameter or member 'max_uV_step' not described in 'regulation_constraints' include/linux/regulator/driver.h:228: warning: Function parameter or member 'resume' not described in 'regulator_ops' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw0' not described in 'irb' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw1' not described in 'irb' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw2' not described in 'irb' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw3' not described in 'irb' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.eadm' not described in 'irb' drivers/slimbus/stream.c:1: warning: no structured comments found
include/linux/spi/spi.h:180: warning: Function parameter or member 'driver_override' not described in 'spi_device' drivers/target/target_core_device.c:1: warning: no structured comments found
drivers/usb/typec/bus.c:1: warning: no structured comments found
drivers/usb/typec/class.c:1: warning: no structured comments found
include/linux/w1.h:281: warning: Function parameter or member 'of_match_table' not described in 'w1_family'
fs/direct-io.c:257: warning: Excess function parameter 'offset' description in 'dio_complete'
fs/file_table.c:1: warning: no structured comments found
fs/libfs.c:477: warning: Excess function parameter 'available' description in 'simple_write_end'
fs/posix_acl.c:646: warning: Function parameter or member 'inode' not described in 'posix_acl_update_mode'
fs/posix_acl.c:646: warning: Function parameter or member 'mode_p' not described in 'posix_acl_update_mode'
fs/posix_acl.c:646: warning: Function parameter or member 'acl' not described in 'posix_acl_update_mode' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:294: warning: Excess function parameter 'mm' description in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:294: warning: Excess function parameter 'start' description in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:294: warning: Excess function parameter 'end' description in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:343: warning: Excess function parameter 'mm' description in 'amdgpu_mn_invalidate_range_end' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:343: warning: Excess function parameter 'start' description in 'amdgpu_mn_invalidate_range_end' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:343: warning: Excess function parameter 'end' description in 'amdgpu_mn_invalidate_range_end' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:183: warning: Function parameter or member 'blockable' not described in 'amdgpu_mn_read_lock' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:295: warning: Function parameter or member 'range' not described in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:295: warning: Excess function parameter 'mm' description in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:295: warning: Excess function parameter 'start' description in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:295: warning: Excess function parameter 'end' description in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:344: warning: Function parameter or member 'range' not described in 'amdgpu_mn_invalidate_range_end' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:344: warning: Excess function parameter 'mm' description in 'amdgpu_mn_invalidate_range_end' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:344: warning: Excess function parameter 'start' description in 'amdgpu_mn_invalidate_range_end' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:344: warning: Excess function parameter 'end' description in 'amdgpu_mn_invalidate_range_end' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:374: warning: cannot understand function prototype: 'struct amdgpu_vm_pt_cursor ' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:375: warning: cannot understand function prototype: 'struct amdgpu_vm_pt_cursor ' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:547: warning: Function parameter or member 'adev' not described in 'for_each_amdgpu_vm_pt_leaf' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:547: warning: Function parameter or member 'vm' not described in 'for_each_amdgpu_vm_pt_leaf' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:547: warning: Function parameter or member 'start' not described in 'for_each_amdgpu_vm_pt_leaf' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:547: warning: Function parameter or member 'end' not described in 'for_each_amdgpu_vm_pt_leaf' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:547: warning: Function parameter or member 'cursor' not described in 'for_each_amdgpu_vm_pt_leaf' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:595: warning: Function parameter or member 'adev' not described in 'for_each_amdgpu_vm_pt_dfs_safe' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:595: warning: Function parameter or member 'vm' not described in 'for_each_amdgpu_vm_pt_dfs_safe' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:595: warning: Function parameter or member 'cursor' not described in 'for_each_amdgpu_vm_pt_dfs_safe' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:595: warning: Function parameter or member 'entry' not described in 'for_each_amdgpu_vm_pt_dfs_safe' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:866: warning: Function parameter or member 'level' not described in 'amdgpu_vm_bo_param' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1346: warning: Function parameter or member 'params' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1346: warning: Function parameter or member 'bo' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1346: warning: Function parameter or member 'pe' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1346: warning: Function parameter or member 'addr' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1346: warning: Function parameter or member 'count' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1346: warning: Function parameter or member 'incr' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1346: warning: Function parameter or member 'flags' not described in 'amdgpu_vm_update_func' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1514: warning: Function parameter or member 'params' not described in 'amdgpu_vm_update_flags' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1514: warning: Function parameter or member 'bo' not described in 'amdgpu_vm_update_flags' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1514: warning: Function parameter or member 'level' not described in 'amdgpu_vm_update_flags' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1514: warning: Function parameter or member 'pe' not described in 'amdgpu_vm_update_flags' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1514: warning: Function parameter or member 'addr' not described in 'amdgpu_vm_update_flags' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1514: warning: Function parameter or member 'count' not described in 'amdgpu_vm_update_flags' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1514: warning: Function parameter or member 'incr' not described in 'amdgpu_vm_update_flags' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1514: warning: Function parameter or member 'flags' not described in 'amdgpu_vm_update_flags' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:3104: warning: Function parameter or member 'pasid' not described in 'amdgpu_vm_make_compute' drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c:375: warning: Excess function parameter 'entry' description in 'amdgpu_irq_dispatch' drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c:376: warning: Function parameter or member 'ih' not described in 'amdgpu_irq_dispatch' drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c:376: warning: Excess function parameter 'entry' description in 'amdgpu_irq_dispatch' drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c:1: warning: no structured comments found drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:128: warning: Incorrect use of kernel-doc format: Documentation Makefile include scripts source @atomic_obj drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:203: warning: Function parameter or member 'atomic_obj' not described in 'amdgpu_display_manager' drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:203: warning: Function parameter or member 'atomic_obj_lock' not described in 'amdgpu_display_manager' drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:203: warning: Function parameter or member 'backlight_link' not described in 'amdgpu_display_manager' drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:203: warning: Function parameter or member 'backlight_caps' not described in 'amdgpu_display_manager' drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:203: warning: Function parameter or member 'freesync_module' not described in 'amdgpu_display_manager' drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:203: warning: Function parameter or member 'fw_dmcu' not described in 'amdgpu_display_manager' drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:203: warning: Function parameter or member 'dmcu_fw_version' not described in 'amdgpu_display_manager' drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:1: warning: no structured comments found
include/drm/drm_drv.h:715: warning: Function parameter or member 'gem_prime_pin' not described in 'drm_driver' include/drm/drm_drv.h:715: warning: Function parameter or member 'gem_prime_unpin' not described in 'drm_driver' include/drm/drm_drv.h:715: warning: Function parameter or member 'gem_prime_res_obj' not described in 'drm_driver' include/drm/drm_drv.h:715: warning: Function parameter or member 'gem_prime_get_sg_table' not described in 'drm_driver' include/drm/drm_drv.h:715: warning: Function parameter or member 'gem_prime_import_sg_table' not described in 'drm_driver' include/drm/drm_drv.h:715: warning: Function parameter or member 'gem_prime_vmap' not described in 'drm_driver' include/drm/drm_drv.h:715: warning: Function parameter or member 'gem_prime_vunmap' not described in 'drm_driver' include/drm/drm_drv.h:715: warning: Function parameter or member 'gem_prime_mmap' not described in 'drm_driver' include/drm/drm_plane.h:236: warning: Function parameter or member 'degamma_lut' not described in 'drm_plane_state' include/drm/drm_plane.h:236: warning: Function parameter or member 'color_mgmt_changed' not described in 'drm_plane_state' include/drm/drm_plane.h:768: warning: Function parameter or member 'ctm_property' not described in 'drm_plane'
>> include/drm/drm_plane.h:768: warning: Function parameter or member 'gamma_lut_property' not described in 'drm_plane' >> include/drm/drm_plane.h:768: warning: Function parameter or member 'gamma_lut_size_property' not described in 'drm_plane'
drivers/gpu/drm/drm_color_mgmt.c:1: warning: no structured comments found
drivers/gpu/drm/drm_color_mgmt.c:1: warning: no structured comments found
drivers/gpu/drm/drm_color_mgmt.c:1: warning: no structured comments found
drivers/gpu/drm/drm_color_mgmt.c:1: warning: no structured comments found
include/drm/drm_atomic_state_helper.h:1: warning: no structured comments found
drivers/gpu/drm/scheduler/sched_main.c:376: warning: Excess function parameter 'bad' description in 'drm_sched_stop' drivers/gpu/drm/scheduler/sched_main.c:377: warning: Excess function parameter 'bad' description in 'drm_sched_stop' drivers/gpu/drm/scheduler/sched_main.c:420: warning: Function parameter or member 'full_recovery' not described in 'drm_sched_start' drivers/gpu/drm/i915/i915_vma.h:50: warning: cannot understand function prototype: 'struct i915_vma ' drivers/gpu/drm/i915/i915_vma.h:1: warning: no structured comments found
drivers/gpu/drm/i915/intel_guc_fwif.h:536: warning: cannot understand function prototype: 'struct guc_log_buffer_state ' drivers/gpu/drm/i915/i915_trace.h:1: warning: no structured comments found
drivers/gpu/drm/i915/i915_reg.h:156: warning: bad line:
drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:126: warning: Function parameter or member 'hw_id' not described in 'komeda_component' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:126: warning: Function parameter or member 'max_active_outputs' not described in 'komeda_component' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:126: warning: Function parameter or member 'supported_outputs' not described in 'komeda_component' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:142: warning: Function parameter or member 'output_port' not described in 'komeda_component_output' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:196: warning: Function parameter or member 'component' not described in 'komeda_component_state' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:196: warning: Function parameter or member 'crtc' not described in 'komeda_component_state' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:196: warning: Function parameter or member 'plane' not described in 'komeda_component_state' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:196: warning: Function parameter or member 'wb_conn' not described in 'komeda_component_state' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:196: warning: Function parameter or member 'changed_active_inputs' not described in 'komeda_component_state' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:196: warning: Function parameter or member 'affected_inputs' not described in 'komeda_component_state' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'n_layers' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'layers' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'n_scalers' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'scalers' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'compiz' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'wb_layer' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'improc' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'ctrlr' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:300: warning: Function parameter or member 'funcs' not described in 'komeda_pipeline' drivers/gpu/drm/arm/display/komeda/komeda_pipeline.h:321: warning: Function parameter or member 'pipe' not described in 'komeda_pipeline_state' drivers/gpu/drm/arm/display/komeda/komeda_dev.h:97: warning: Function parameter or member 'dev' not described in 'komeda_dev' drivers/gpu/drm/arm/display/komeda/komeda_dev.h:97: warning: Function parameter or member 'reg_base' not described in 'komeda_dev' drivers/gpu/drm/arm/display/komeda/komeda_dev.h:97: warning: Function parameter or member 'chip' not described in 'komeda_dev' drivers/gpu/drm/arm/display/komeda/komeda_dev.h:97: warning: Function parameter or member 'mclk' not described in 'komeda_dev' drivers/gpu/drm/arm/display/komeda/komeda_dev.h:97: warning: Function parameter or member 'n_pipelines' not described in 'komeda_dev' drivers/gpu/drm/arm/display/komeda/komeda_dev.h:97: warning: Function parameter or member 'pipelines' not described in 'komeda_dev' drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.h:1: warning: no structured comments found drivers/gpu/drm/arm/display/komeda/komeda_crtc.c:1: warning: no structured comments found drivers/gpu/drm/arm/display/komeda/komeda_plane.c:1: warning: no structured comments found
include/linux/skbuff.h:876: warning: Function parameter or member 'dev_scratch' not described in 'sk_buff'
include/linux/skbuff.h:876: warning: Function parameter or member 'list' not described in 'sk_buff'
include/linux/skbuff.h:876: warning: Function parameter or member 'ip_defrag_offset' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'skb_mstamp_ns' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member '__cloned_offset' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'head_frag' not described in 'sk_buff'
include/linux/skbuff.h:876: warning: Function parameter or member '__pkt_type_offset' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'encapsulation' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'encap_hdr_csum' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'csum_valid' not described in 'sk_buff'
include/linux/skbuff.h:876: warning: Function parameter or member '__pkt_vlan_present_offset' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'vlan_present' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'csum_complete_sw' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'csum_level' not described in 'sk_buff'
include/linux/skbuff.h:876: warning: Function parameter or member 'inner_protocol_type' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'remcsum_offload' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'sender_cpu' not described in 'sk_buff'
include/linux/skbuff.h:876: warning: Function parameter or member 'reserved_tailroom' not described in 'sk_buff' include/linux/skbuff.h:876: warning: Function parameter or member 'inner_ipproto' not described in 'sk_buff'
include/net/sock.h:238: warning: Function parameter or member 'skc_addrpair' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_portpair' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_ipv6only' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_net_refcnt' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_v6_daddr' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_v6_rcv_saddr' not described in 'sock_common' include/net/sock.h:238: warning: Function parameter or member 'skc_cookie' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_listener' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_tw_dr' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_rcv_wnd' not described in 'sock_common'
include/net/sock.h:238: warning: Function parameter or member 'skc_tw_rcv_nxt' not described in 'sock_common'
include/net/sock.h:513: warning: Function parameter or member 'sk_backlog.rmem_alloc' not described in 'sock'
include/net/sock.h:513: warning: Function parameter or member 'sk_backlog.len' not described in 'sock'
include/net/sock.h:513: warning: Function parameter or member 'sk_backlog.head' not described in 'sock'
include/net/sock.h:513: warning: Function parameter or member 'sk_backlog.tail' not described in 'sock'
include/net/sock.h:513: warning: Function parameter or member 'sk_wq_raw' not described in 'sock'
include/net/sock.h:513: warning: Function parameter or member 'tcp_rtx_queue' not described in 'sock'
include/net/sock.h:513: warning: Function parameter or member 'sk_route_forced_caps' not described in 'sock'
include/net/sock.h:513: warning: Function parameter or member 'sk_txtime_report_errors' not described in 'sock' include/net/sock.h:513: warning: Function parameter or member 'sk_validate_xmit_skb' not described in 'sock' include/linux/netdevice.h:2051: warning: Function parameter or member 'adj_list.upper' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'adj_list.lower' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'gso_partial_features' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'switchdev_ops' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'l3mdev_ops' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'xfrmdev_ops' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'tlsdev_ops' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'name_assign_type' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'ieee802154_ptr' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'mpls_ptr' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'xdp_prog' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'gro_flush_timeout' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'nf_hooks_ingress' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member '____cacheline_aligned_in_smp' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'qdisc_hash' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'xps_cpus_map' not described in 'net_device' include/linux/netdevice.h:2051: warning: Function parameter or member 'xps_rxqs_map' not described in 'net_device' include/linux/phylink.h:56: warning: Function parameter or member '__ETHTOOL_DECLARE_LINK_MODE_MASK(advertising' not described in 'phylink_link_state' include/linux/phylink.h:56: warning: Function parameter or member '__ETHTOOL_DECLARE_LINK_MODE_MASK(lp_advertising' not described in 'phylink_link_state'
vim +768 include/drm/drm_plane.h
43968d7b Daniel Vetter 2016-09-21 @768
:::::: The code at line 768 was first introduced by commit :::::: 43968d7b806d7a7e021261294c583a216fddf0e5 drm: Extract drm_plane.[hc]
:::::: TO: Daniel Vetter <[email protected]>
:::::: CC: Sean Paul <[email protected]>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v6 5/16 drm: Define helper function for plane color enabling
In reply to Uma ShankarDefine helper function to enable Plane color features to attach plane color properties to plane structure.
v2: Rebase
v3: Modiefied the function to use updated property names.
v4: Rebase
v5: Moved helper function to drm_color_mgmt.c file to have all color operations consolidated at one place. No logical change.
--- drivers/gpu/drm/drm_color_mgmt.c | 42 ++++++++++++++++++++++++++++++++++++++++ include/drm/drm_color_mgmt.h | 5 +++++ 2 files changed, 47 insertions(+)
drivers/gpu/drm/drm_color_mgmt.c +42 -0
@@ -483,6 +483,48 @@ int drm_plane_create_color_properties(struct drm_plane *plane,EXPORT_SYMBOL (drm_plane_create_color_properties);/** +* drm_plane_enable_color_mgmt - enable color management properties +* @plane: DRM Plane +* @plane_degamma_lut_size: the size of the degamma lut (before CSC) +* @plane_has_ctm: whether to attach ctm_property for CSC matrix +* @plane_gamma_lut_size: the size of the gamma lut (after CSC) +* +* This function lets the driver enable the color correction +* properties on a plane. This includes 3 degamma, csc and gamma +* properties that userspace can set and 2 size properties to inform +* the userspace of the lut sizes. Each of the properties are +* optional. The gamma and degamma properties are only attached if +* their size is not 0 and ctm_property is only attached if has_ctm is +* true. +*/ +void drm_plane_enable_color_mgmt (struct drm_plane *plane, +u32 plane_degamma_lut_size, +bool plane_has_ctm, +u32 plane_gamma_lut_size) +{ +if (plane_degamma_lut_size) { +drm_object_attach_property (&plane->base, + plane->degamma_lut_property,0 ); +drm_object_attach_property (&plane->base, + plane->degamma_lut_size_property, + plane_degamma_lut_size); + } + +if (plane_has_ctm) +drm_object_attach_property (&plane->base, + plane->ctm_property,0 ); + +if (plane_gamma_lut_size) { +drm_object_attach_property (&plane->base, + plane->gamma_lut_property,0 ); +drm_object_attach_property (&plane->base, + plane->gamma_lut_size_property, + plane_gamma_lut_size); + } +} +EXPORT_SYMBOL (drm_plane_enable_color_mgmt); + +/** * DOC: Plane Color Properties * * Plane Color management or color space adjustments is supported
include/drm/drm_color_mgmt.h +5 -0
@@ -71,6 +71,11 @@ int drm_plane_create_color_properties(struct drm_plane *plane,enum drm_color_encoding default_encoding, enum drm_color_range default_range); +void drm_plane_enable_color_mgmt (struct drm_plane *plane, +u32 plane_degamma_lut_size, +bool plane_has_ctm, +u32 plane_gamma_lut_size); +/** * enum drm_color_lut_tests - hw-specific LUT tests to perform *
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v6 6/16 drm/i915: Enable plane color features
In reply to Uma ShankarEnable and initialize plane color features.
v2: Rebase and some cleanup
v3: Updated intel_plane_color_init to calldrm_plane_color_create_prop function, which will
in turn create plane color properties.
v4: Rebase
v5: Rebase
--- drivers/gpu/drm/i915/i915_drv.h | 6 ++++++ drivers/gpu/drm/i915/intel_color.c | 15 +++++++++++++++ drivers/gpu/drm/i915/intel_device_info.h | 5 +++++ drivers/gpu/drm/i915/intel_drv.h | 9 +++++++++ 4 files changed, 35 insertions(+)
drivers/gpu/drm/i915/i915_drv.h +6 -0
@@ -55,6 +55,7 @@#include <drm/drm_util.h> #include <drm/drm_dsc.h> #include <drm/drm_connector.h> +#include <drm/drm_plane.h> #include <drm/i915_mei_hdcp_interface.h> #include "i915_fixed.h"
@@ -334,6 +335,11 @@ struct drm_i915_display_funcs {* involved with the same commit. */ void (*load_luts)(const struct intel_crtc_state *crtc_state); +/* Add Plane Color callbacks */ +void (*load_plane_csc_matrix)(const struct drm_plane_state + *plane_state); +void (*load_plane_luts)(const struct drm_plane_state + *plane_state); };#define CSR_VERSION (major, minor) ((major) << 16 | (minor))
drivers/gpu/drm/i915/intel_color.c +15 -0
@@ -869,6 +869,21 @@ int intel_color_check(struct intel_crtc_state *crtc_state)return 0 ; } +void intel_plane_color_init (struct drm_plane *plane) +{ +struct drm_i915_private *dev_priv =to_i915 (plane->dev); + +drm_plane_color_create_prop (plane->dev, plane); + +/* Enable color management support when we have degamma or gamma LUTs. */ +if (INTEL_INFO (dev_priv)->plane_color.plane_degamma_lut_size !=0 || +INTEL_INFO (dev_priv)->plane_color.plane_gamma_lut_size !=0 ) +drm_plane_enable_color_mgmt (plane, +INTEL_INFO (dev_priv)->plane_color.plane_degamma_lut_size, + true, +INTEL_INFO (dev_priv)->plane_color.plane_gamma_lut_size); +} +void intel_color_init (struct intel_crtc *crtc) {struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev);
drivers/gpu/drm/i915/intel_device_info.h +5 -0
@@ -193,6 +193,11 @@ struct intel_device_info {u32 degamma_lut_tests;u32 gamma_lut_tests; } color; + +struct plane_color_luts { +u16 plane_degamma_lut_size; +u16 plane_gamma_lut_size; + } plane_color; };struct intel_runtime_info {
drivers/gpu/drm/i915/intel_drv.h +9 -0
@@ -658,6 +658,14 @@ struct intel_plane_state {*/ u32 slave; +/* +* Use reduced/limited/broadcast rbg range, compressing from the full +* range fed into the crtcs. +*/ +bool limited_color_range; +/* Gamma mode programmed on the plane */ +u32 gamma_mode; +struct drm_intel_sprite_colorkey ckey; };
@@ -2518,6 +2526,7 @@ int intel_plane_atomic_check_with_state(const struct intel_crtc_state *old_crtc_int intel_color_check (struct intel_crtc_state *crtc_state);void intel_color_commit (const struct intel_crtc_state *crtc_state);void intel_color_load_luts (const struct intel_crtc_state *crtc_state); +void intel_plane_color_init (struct drm_plane *plane);/* intel_lspcon.c */ bool lspcon_init (struct intel_digital_port *intel_dig_port);
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v6 7/16 drm/i915: Implement Plane Gamma for Bdw and Gen9 platforms
In reply to Uma ShankarImplement Plane Gamma feature for BDW and Gen9 platforms.
v2: Used newly added drm_color_lut_ext structure for enhanced precision for Gamma LUT entries.
v3: Rebase
v4: Used extended function for LUT extraction (pointed by Alexandru).
v5: Rebase
--- drivers/gpu/drm/i915/i915_pci.c | 5 +++- drivers/gpu/drm/i915/i915_reg.h | 25 ++++++++++++++++ drivers/gpu/drm/i915/intel_color.c | 57 ++++++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_display.c | 4 +++ drivers/gpu/drm/i915/intel_sprite.c | 4 +++ 5 files changed, 94 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_pci.c +4 -1
@@ -117,7 +117,10 @@ }#define BDW_COLORS \ - .color = { .degamma_lut_size = 512, .gamma_lut_size = 512 } + .color = { .degamma_lut_size = 512, .gamma_lut_size = 512 }, \ + .plane_color = { .plane_degamma_lut_size = 0, \ + .plane_gamma_lut_size = 16 } +#define CHV_COLORS \ .color = { .degamma_lut_size = 65, .gamma_lut_size = 257, \ .degamma_lut_tests = DRM_COLOR_LUT_NON_DECREASING, \
drivers/gpu/drm/i915/i915_reg.h +25 -0
@@ -257,6 +257,10 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg) INTEL_INFO(dev_priv)->cursor_offsets[PIPE_A] + (reg) + \ DISPLAY_MMIO_BASE(dev_priv)) +/* Plane Gamma Registers */ +#define _MMIO_PLANE_GAMC (plane, i, a, b) _MMIO(_PIPE(plane, a, b) + (i) * 4) +#define _MMIO_PLANE_GAMC16 (plane, i, a, b) _MMIO(_PIPE(plane, a, b) + (i) * 4) +#define __MASKED_FIELD (mask, value) ((mask) << 16 | (value))#define _MASKED_FIELD (mask, value) ({ \ if (__builtin_constant_p(mask)) \
@@ -10156,6 +10160,27 @@ enum skl_power_gate {#define PRE_CSC_GAMC_INDEX (pipe) _MMIO_PIPE(pipe, _PRE_CSC_GAMC_INDEX_A, _PRE_CSC_GAMC_INDEX_B)#define PRE_CSC_GAMC_DATA (pipe) _MMIO_PIPE(pipe, _PRE_CSC_GAMC_DATA_A, _PRE_CSC_GAMC_DATA_B) +/* Plane Gamma in Gen9+ */ +#define _PLANE_GAMC_1_A 0x701d0 +#define _PLANE_GAMC_1_B 0x711d0 +#define _PLANE_GAMC_2_A 0x702d0 +#define _PLANE_GAMC_2_B 0x712d0 +#define _PLANE_GAMC_1 (pipe) _PIPE(pipe, _PLANE_GAMC_1_A, _PLANE_GAMC_1_B) +#define _PLANE_GAMC_2 (pipe) _PIPE(pipe, _PLANE_GAMC_2_A, _PLANE_GAMC_2_B) +#define PLANE_GAMC (pipe, plane, i) \ + _MMIO_PLANE_GAMC(plane, i, _PLANE_GAMC_1(pipe), _PLANE_GAMC_2(pipe)) + +#define _PLANE_GAMC16_1_A 0x70210 +#define _PLANE_GAMC16_1_B 0x71210 +#define _PLANE_GAMC16_2_A 0x70310 +#define _PLANE_GAMC16_2_B 0x71310 +#define _PLANE_GAMC16_1 (pipe) _PIPE(pipe, _PLANE_GAMC16_1_A, \ + _PLANE_GAMC16_1_B) +#define _PLANE_GAMC16_2 (pipe) _PIPE(pipe, _PLANE_GAMC16_2_A, \ + _PLANE_GAMC16_2_B) +#define PLANE_GAMC16 (pipe, plane, i) _MMIO_PLANE_GAMC16(plane, i, \ + _PLANE_GAMC16_1(pipe), _PLANE_GAMC16_2(pipe)) +/* pipe CSC & degamma/gamma LUTs on CHV */ #define _CGM_PIPE_A_CSC_COEFF01 (VLV_DISPLAY_BASE + 0x67900)#define _CGM_PIPE_A_CSC_COEFF23 (VLV_DISPLAY_BASE + 0x67904)
drivers/gpu/drm/i915/intel_color.c +57 -0
69 lines not on this page · raw message
drivers/gpu/drm/i915/intel_display.c +4 -0
@@ -14395,6 +14395,10 @@ static bool i9xx_plane_has_fbc(struct drm_i915_private *dev_priv,DRM_MODE_ROTATE_0 , supported_rotations); +/* Add Plane Color properties */ +if (IS_BROADWELL (dev_priv) ||INTEL_GEN (dev_priv) >=9 ) +intel_plane_color_init (&plane->base); +drm_plane_helper_add (&plane->base, &intel_plane_helper_funcs);return plane;
drivers/gpu/drm/i915/intel_sprite.c +4 -0
@@ -2319,6 +2319,10 @@ struct intel_plane *BIT (DRM_MODE_BLEND_PREMULTI ) | BIT(DRM_MODE_BLEND_COVERAGE)); +/* Add Plane Color properties */ +if (IS_BROADWELL (dev_priv) ||INTEL_GEN (dev_priv) >=9 ) +intel_plane_color_init (&plane->base); +drm_plane_helper_add (&plane->base, &intel_plane_helper_funcs);return plane;
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v6 8/16 drm/i915: Load plane color luts from atomic flip
In reply to Uma ShankarLoad plane color luts as part of atomic plane updates. This will be done only if the plane color luts are changed.
v4: Rebase
v5: Rebase
--- drivers/gpu/drm/i915/intel_atomic_plane.c | 3 +++ drivers/gpu/drm/i915/intel_color.c | 8 ++++++++ drivers/gpu/drm/i915/intel_drv.h | 1 + 3 files changed, 12 insertions(+)
drivers/gpu/drm/i915/intel_atomic_plane.c +3 -0
@@ -271,6 +271,9 @@ void skl_update_planes_on_crtc(struct intel_atomic_state *state,struct intel_plane_state *new_plane_state =intel_atomic_get_new_plane_state (state, plane); +if (new_plane_state->base.color_mgmt_changed) +intel_color_load_plane_luts (&new_plane_state->base); +if (new_plane_state->base.visible) {intel_update_plane (plane, new_crtc_state, new_plane_state); }else if (new_plane_state->slave) {
drivers/gpu/drm/i915/intel_color.c +8 -0
@@ -841,6 +841,14 @@ static u32 chv_cgm_mode(const struct intel_crtc_state *crtc_state)return cgm_mode; } +void intel_color_load_plane_luts (const struct drm_plane_state *plane_state) +{ +struct drm_device *dev = plane_state->plane->dev; +struct drm_i915_private *dev_priv =to_i915 (dev); + + dev_priv->display.load_plane_luts (plane_state); +} +int intel_color_check (struct intel_crtc_state *crtc_state) {struct drm_i915_private *dev_priv =to_i915 (crtc_state->base.crtc->dev);
drivers/gpu/drm/i915/intel_drv.h +1 -0
@@ -2527,6 +2527,7 @@ int intel_plane_atomic_check_with_state(const struct intel_crtc_state *old_crtc_void intel_color_commit (const struct intel_crtc_state *crtc_state);void intel_color_load_luts (const struct intel_crtc_state *crtc_state);void intel_plane_color_init (struct drm_plane *plane); +void intel_color_load_plane_luts (const struct drm_plane_state *plane_state);/* intel_lspcon.c */ bool lspcon_init (struct intel_digital_port *intel_dig_port);
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v6 9/16 drm/i915: Add plane color capabilities
In reply to Uma ShankarAdd Plane color capabilties, support for
degamma and gamma added.
--- drivers/gpu/drm/i915/intel_color.c | 12 +++++------- drivers/gpu/drm/i915/intel_display.c | 4 ++-- drivers/gpu/drm/i915/intel_drv.h | 3 ++- drivers/gpu/drm/i915/intel_sprite.c | 11 +++++++++-- 4 files changed, 18 insertions(+), 12 deletions(-)
drivers/gpu/drm/i915/intel_color.c +5 -7
@@ -930,7 +930,8 @@ int intel_color_check(struct intel_crtc_state *crtc_state)return 0 ; } -void intel_plane_color_init (struct drm_plane *plane) +void intel_plane_color_init (struct drm_plane *plane,u32 degamma_lut_size, +u32 gamma_lut_size) {struct drm_i915_private *dev_priv =to_i915 (plane->dev);
@@ -941,12 +942,9 @@ void intel_plane_color_init(struct drm_plane *plane)drm_plane_color_create_prop (plane->dev, plane);/* Enable color management support when we have degamma or gamma LUTs. */ -if (INTEL_INFO (dev_priv)->plane_color.plane_degamma_lut_size !=0 || -INTEL_INFO (dev_priv)->plane_color.plane_gamma_lut_size !=0 ) -drm_plane_enable_color_mgmt (plane, -INTEL_INFO (dev_priv)->plane_color.plane_degamma_lut_size, - true, -INTEL_INFO (dev_priv)->plane_color.plane_gamma_lut_size); +if (degamma_lut_size !=0 || gamma_lut_size !=0 ) +drm_plane_enable_color_mgmt (plane, degamma_lut_size, + true, gamma_lut_size); }void intel_color_init (struct intel_crtc *crtc)
drivers/gpu/drm/i915/intel_display.c +2 -2
@@ -14396,8 +14396,8 @@ static bool i9xx_plane_has_fbc(struct drm_i915_private *dev_priv, supported_rotations);/* Add Plane Color properties */ -if (IS_BROADWELL (dev_priv) ||INTEL_GEN (dev_priv) >=9 ) -intel_plane_color_init (&plane->base); +if (IS_BROADWELL (dev_priv)) +intel_plane_color_init (&plane->base,0 ,16 );drm_plane_helper_add (&plane->base, &intel_plane_helper_funcs);
drivers/gpu/drm/i915/intel_drv.h +2 -1
@@ -2526,7 +2526,8 @@ int intel_plane_atomic_check_with_state(const struct intel_crtc_state *old_crtc_int intel_color_check (struct intel_crtc_state *crtc_state);void intel_color_commit (const struct intel_crtc_state *crtc_state);void intel_color_load_luts (const struct intel_crtc_state *crtc_state); -void intel_plane_color_init (struct drm_plane *plane); +void intel_plane_color_init (struct drm_plane *plane,u32 degamma_lut_size, +u32 gamma_lut_size);void intel_color_load_plane_luts (const struct drm_plane_state *plane_state);/* intel_lspcon.c */
drivers/gpu/drm/i915/intel_sprite.c +9 -2
@@ -2320,8 +2320,15 @@ struct intel_plane * BIT(DRM_MODE_BLEND_COVERAGE));/* Add Plane Color properties */ -if (IS_BROADWELL (dev_priv) ||INTEL_GEN (dev_priv) >=9 ) -intel_plane_color_init (&plane->base); +if (INTEL_GEN (dev_priv) <=10 ) +intel_plane_color_init (&plane->base,0 ,16 ); + +if (INTEL_GEN (dev_priv) >=11 ) { +if (icl_is_hdr_plane (dev_priv, plane_id)) +intel_plane_color_init (&plane->base,128 ,33 ); +else +intel_plane_color_init (&plane->base,33 ,33 ); + }drm_plane_helper_add (&plane->base, &intel_plane_helper_funcs);
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v6 10/16 drm/i915/icl: Add ICL Plane Degamma Register definition
In reply to Uma ShankarAdd register definitions for ICL Plane Degamma.
--- drivers/gpu/drm/i915/i915_reg.h | 42 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +42 -0
@@ -10181,6 +10181,48 @@ enum skl_power_gate {#define PLANE_GAMC16 (pipe, plane, i) _MMIO_PLANE_GAMC16(plane, i, \ _PLANE_GAMC16_1(pipe), _PLANE_GAMC16_2(pipe)) +/* Plane Color Register for Gen11+ */ +/* Plane Degamma Registers */ +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_1_A 0x70100 +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_1_B 0x71100 +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_2_A 0x70200 +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_2_B 0x71200 +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_1 (pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_INDEX_ENH_1_A, _PLANE_PRE_CSC_GAMC_INDEX_ENH_1_B) +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_2 (pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_INDEX_ENH_2_A, _PLANE_PRE_CSC_GAMC_INDEX_ENH_2_B) + +#define PLANE_PRE_CSC_GAMC_INDEX_ENH (pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_INDEX_ENH_1(pipe),\ + _PLANE_PRE_CSC_GAMC_INDEX_ENH_2(pipe)) + +#define _PLANE_PRE_CSC_GAMC_INDEX_4_A 0x70400 +#define _PLANE_PRE_CSC_GAMC_INDEX_4_B 0x71400 +#define _PLANE_PRE_CSC_GAMC_INDEX_5_A 0x70500 +#define _PLANE_PRE_CSC_GAMC_INDEX_5_B 0x71500 +#define _PLANE_PRE_CSC_GAMC_INDEX_4 (pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_INDEX_4_A, _PLANE_PRE_CSC_GAMC_INDEX_4_B) +#define _PLANE_PRE_CSC_GAMC_INDEX_5 (pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_INDEX_5_A, _PLANE_PRE_CSC_GAMC_INDEX_5_B) + +#define PLANE_PRE_CSC_GAMC_INDEX (pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_INDEX_4(pipe),\ + _PLANE_PRE_CSC_GAMC_INDEX_5(pipe)) + +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_1_A 0x701D4 +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_1_B 0x711D4 +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_2_A 0x702D4 +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_2_B 0x712D4 +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_1 (pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_DATA_ENH_1_A, _PLANE_PRE_CSC_GAMC_DATA_ENH_1_B) +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_2 (pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_DATA_ENH_2_A, _PLANE_PRE_CSC_GAMC_DATA_ENH_2_B) + +#define PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_DATA_ENH_1(pipe),\ + _PLANE_PRE_CSC_GAMC_DATA_ENH_2(pipe)) + +#define _PLANE_PRE_CSC_GAMC_DATA_4_A 0x704D4 +#define _PLANE_PRE_CSC_GAMC_DATA_4_B 0x714D4 +#define _PLANE_PRE_CSC_GAMC_DATA_5_A 0x705D4 +#define _PLANE_PRE_CSC_GAMC_DATA_5_B 0x715D4 +#define _PLANE_PRE_CSC_GAMC_DATA_4 (pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_DATA_4_A, _PLANE_PRE_CSC_GAMC_DATA_4_B) +#define _PLANE_PRE_CSC_GAMC_DATA_5 (pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_DATA_5_A, _PLANE_PRE_CSC_GAMC_DATA_5_B) + +#define PLANE_PRE_CSC_GAMC_DATA (pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_DATA_4(pipe),\ + _PLANE_PRE_CSC_GAMC_DATA_5(pipe)) +/* pipe CSC & degamma/gamma LUTs on CHV */ #define _CGM_PIPE_A_CSC_COEFF01 (VLV_DISPLAY_BASE + 0x67900)#define _CGM_PIPE_A_CSC_COEFF23 (VLV_DISPLAY_BASE + 0x67904)
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [v6 10/16] drm/i915/icl: Add ICL Plane Degamma Register definition
Quoted 3 lines · Uma Shankar
Add register definitions for ICL Plane Degamma.
Signed-off-by Uma Shankar <[email protected]>
Haven't reviewed the series in detail yet, just a couple drive-by comment below.
Quoted 9 lines
--- drivers/gpu/drm/i915/i915_reg.h | 42 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+)drivers/gpu/drm/i915/i915_reg.h +0
-0
drivers/gpu/drm/i915/i915_reg.h enum skl_power_gate { · line 10189
Quoted 9 lines
drivers/gpu/drm/i915/i915_reg.h +6
-0@@ -10181,6 +10181,48 @@ enum skl_power_gate {#define PLANE_GAMC16 (pipe, plane, i) _MMIO_PLANE_GAMC16(plane, i, \ _PLANE_GAMC16_1(pipe), _PLANE_GAMC16_2(pipe)) +/* Plane Color Register for Gen11+ */ +/* Plane Degamma Registers */ +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_1_A 0x70100 +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_1_B 0x71100 +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_2_A 0x70200 +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_2_B 0x71200
Can you double check these ones? I'm seeing them in the bspec at 0x701D0 and such.
drivers/gpu/drm/i915/i915_reg.h enum skl_power_gate { · line 10199
Quoted 10 lines
drivers/gpu/drm/i915/i915_reg.h +10
-0+#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_1 (pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_INDEX_ENH_1_A, _PLANE_PRE_CSC_GAMC_INDEX_ENH_1_B) +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_2 (pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_INDEX_ENH_2_A, _PLANE_PRE_CSC_GAMC_INDEX_ENH_2_B) + +#define PLANE_PRE_CSC_GAMC_INDEX_ENH (pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_INDEX_ENH_1(pipe),\ + _PLANE_PRE_CSC_GAMC_INDEX_ENH_2(pipe)) + +#define _PLANE_PRE_CSC_GAMC_INDEX_4_A 0x70400 +#define _PLANE_PRE_CSC_GAMC_INDEX_4_B 0x71400 +#define _PLANE_PRE_CSC_GAMC_INDEX_5_A 0x70500 +#define _PLANE_PRE_CSC_GAMC_INDEX_5_B 0x71500
I think these ones are 0x704D0 and such as well.
Matt
Quoted 32 lines
drivers/gpu/drm/i915/i915_reg.h +26
-0+#define _PLANE_PRE_CSC_GAMC_INDEX_4 (pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_INDEX_4_A, _PLANE_PRE_CSC_GAMC_INDEX_4_B) +#define _PLANE_PRE_CSC_GAMC_INDEX_5 (pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_INDEX_5_A, _PLANE_PRE_CSC_GAMC_INDEX_5_B) + +#define PLANE_PRE_CSC_GAMC_INDEX (pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_INDEX_4(pipe),\ + _PLANE_PRE_CSC_GAMC_INDEX_5(pipe)) + +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_1_A 0x701D4 +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_1_B 0x711D4 +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_2_A 0x702D4 +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_2_B 0x712D4 +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_1 (pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_DATA_ENH_1_A, _PLANE_PRE_CSC_GAMC_DATA_ENH_1_B) +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_2 (pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_DATA_ENH_2_A, _PLANE_PRE_CSC_GAMC_DATA_ENH_2_B) + +#define PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_DATA_ENH_1(pipe),\ + _PLANE_PRE_CSC_GAMC_DATA_ENH_2(pipe)) + +#define _PLANE_PRE_CSC_GAMC_DATA_4_A 0x704D4 +#define _PLANE_PRE_CSC_GAMC_DATA_4_B 0x714D4 +#define _PLANE_PRE_CSC_GAMC_DATA_5_A 0x705D4 +#define _PLANE_PRE_CSC_GAMC_DATA_5_B 0x715D4 +#define _PLANE_PRE_CSC_GAMC_DATA_4 (pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_DATA_4_A, _PLANE_PRE_CSC_GAMC_DATA_4_B) +#define _PLANE_PRE_CSC_GAMC_DATA_5 (pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_DATA_5_A, _PLANE_PRE_CSC_GAMC_DATA_5_B) + +#define PLANE_PRE_CSC_GAMC_DATA (pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_DATA_4(pipe),\ + _PLANE_PRE_CSC_GAMC_DATA_5(pipe)) +/* pipe CSC & degamma/gamma LUTs on CHV */ #define _CGM_PIPE_A_CSC_COEFF01 (VLV_DISPLAY_BASE + 0x67900)#define _CGM_PIPE_A_CSC_COEFF23 (VLV_DISPLAY_BASE + 0x67904)Signature · 1 line
1.9.1
Signature · 9 lines
Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [v6 10/16] drm/i915/icl: Add ICL Plane Degamma Register definition
Quoted 32 lines
-----Original Message-----
From: Roper, Matthew D
Sent: Monday, March 25, 2019 11:07 PM
To: Shankar, Uma <[email protected]>
Cc: [email protected]; Lankhorst, Maarten <[email protected]>; Syrjala, Ville <[email protected]>; Sharma, Shashank <[email protected]>
Subject: Re: [v6 10/16] drm/i915/icl: Add ICL Plane Degamma Register definitionQuoted 3 lines · Uma Shankar
Add register definitions for ICL Plane Degamma.
Signed-off-by Uma Shankar <[email protected]>Haven't reviewed the series in detail yet, just a couple drive-by comment below.
drivers/gpu/drm/i915/i915_reg.h enum skl_power_gate { #define · line 10182
Quoted 12 lines
--- drivers/gpu/drm/i915/i915_reg.h | 42 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+)(quoted diff) +0
-0
b/drivers/gpu/drm/i915/i915_reg.hindex 0beed42..b9a2084 100644drivers/gpu/drm/i915/i915_reg.h +0
-0@@ -10181,6 +10181,48 @@ enum skl_power_gate { #define PLANE_GAMC16(pipe, plane, i) _MMIO_PLANE_GAMC16(plane, i, \ _PLANE_GAMC16_1(pipe),
_PLANE_GAMC16_2(pipe))Quoted 1 line
Quoted 9 lines
drivers/gpu/drm/i915/i915_reg.h enum skl_power_gate { · line 10189
Quoted 6 lines
drivers/gpu/drm/i915/i915_reg.h +6
-0+/* Plane Color Register for Gen11+ */ +/* Plane Degamma Registers */ +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_1_A 0x70100 +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_1_B 0x71100 +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_2_A 0x70200 +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_2_B 0x71200Can you double check these ones? I'm seeing them in the bspec at
0x701D0and such.
Yeah, looks like I clicked on the address definition to get more details and webpage took me to a different page:
https://gfxspecs.intel.com/Predator/Home/Index/19766
I will fix this. Was wondering how I got these addresses wrong :) Thanks Matt !!!
Regards,
Uma Shankar
Quoted 72 lines
Quoted 2 lines
+#define
_PLANE_PRE_CSC_GAMC_INDEX_ENH_1(pipe)_PIPE(pipe,
_PLANE_PRE_CSC_GAMC_INDEX_ENH_1_A,_PLANE_PRE_CSC_GAMC_INDEX_ENH_1_B)Quoted 1 line
+#define
_PLANE_PRE_CSC_GAMC_INDEX_ENH_2(pipe)_PIPE(pipe,
_PLANE_PRE_CSC_GAMC_INDEX_ENH_2_A,_PLANE_PRE_CSC_GAMC_INDEX_ENH_2_B)drivers/gpu/drm/i915/i915_reg.h
Quoted 2 lines
drivers/gpu/drm/i915/i915_reg.h +2
-0+ +#define PLANE_PRE_CSC_GAMC_INDEX_ENH (pipe, plane, i)_MMIO_PLANE_GAMC(plane, i,
_PLANE_PRE_CSC_GAMC_INDEX_ENH_1(pipe),\Quoted 1 line
+
_PLANE_PRE_CSC_GAMC_INDEX_ENH_2(pipe))drivers/gpu/drm/i915/i915_reg.h enum skl_power_gate { · line 10199
Quoted 5 lines
drivers/gpu/drm/i915/i915_reg.h +5
-0+ +#define _PLANE_PRE_CSC_GAMC_INDEX_4_A 0x70400 +#define _PLANE_PRE_CSC_GAMC_INDEX_4_B 0x71400 +#define _PLANE_PRE_CSC_GAMC_INDEX_5_A 0x70500 +#define _PLANE_PRE_CSC_GAMC_INDEX_5_B 0x71500I think these ones are
0x704D0and such as well.Matt
Quoted 1 line
+#define
_PLANE_PRE_CSC_GAMC_INDEX_4(pipe)_PIPE(pipe,
_PLANE_PRE_CSC_GAMC_INDEX_4_A,_PLANE_PRE_CSC_GAMC_INDEX_4_B)Quoted 1 line
+#define
_PLANE_PRE_CSC_GAMC_INDEX_5(pipe)_PIPE(pipe,
_PLANE_PRE_CSC_GAMC_INDEX_5_A,_PLANE_PRE_CSC_GAMC_INDEX_5_B)drivers/gpu/drm/i915/i915_reg.h
Quoted 2 lines
drivers/gpu/drm/i915/i915_reg.h +2
-0+ +#define PLANE_PRE_CSC_GAMC_INDEX (pipe, plane, i)_MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_INDEX_4(pipe),\Quoted 1 line
+
_PLANE_PRE_CSC_GAMC_INDEX_5(pipe))drivers/gpu/drm/i915/i915_reg.h enum skl_power_gate {
Quoted 6 lines
drivers/gpu/drm/i915/i915_reg.h +6
-0+ +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_1_A 0x701D4 +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_1_B 0x711D4 +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_2_A 0x702D4 +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_2_B 0x712D4 +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_1 (pipe) _PIPE(pipe,
_PLANE_PRE_CSC_GAMC_DATA_ENH_1_A,_PLANE_PRE_CSC_GAMC_DATA_ENH_1_B)Quoted 1 line
+#define
_PLANE_PRE_CSC_GAMC_DATA_ENH_2(pipe)_PIPE(pipe,
_PLANE_PRE_CSC_GAMC_DATA_ENH_2_A,_PLANE_PRE_CSC_GAMC_DATA_ENH_2_B)drivers/gpu/drm/i915/i915_reg.h
Quoted 2 lines
drivers/gpu/drm/i915/i915_reg.h +2
-0+ +#define PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane, i)_MMIO_PLANE_GAMC(plane, i,
_PLANE_PRE_CSC_GAMC_DATA_ENH_1(pipe),\Quoted 1 line
+
_PLANE_PRE_CSC_GAMC_DATA_ENH_2(pipe))drivers/gpu/drm/i915/i915_reg.h enum skl_power_gate {
Quoted 6 lines
drivers/gpu/drm/i915/i915_reg.h +6
-0+ +#define _PLANE_PRE_CSC_GAMC_DATA_4_A 0x704D4 +#define _PLANE_PRE_CSC_GAMC_DATA_4_B 0x714D4 +#define _PLANE_PRE_CSC_GAMC_DATA_5_A 0x705D4 +#define _PLANE_PRE_CSC_GAMC_DATA_5_B 0x715D4 +#define _PLANE_PRE_CSC_GAMC_DATA_4 (pipe) _PIPE(pipe,
_PLANE_PRE_CSC_GAMC_DATA_4_A,_PLANE_PRE_CSC_GAMC_DATA_4_B)Quoted 1 line
+#define
_PLANE_PRE_CSC_GAMC_DATA_5(pipe)_PIPE(pipe,
_PLANE_PRE_CSC_GAMC_DATA_5_A,_PLANE_PRE_CSC_GAMC_DATA_5_B)drivers/gpu/drm/i915/i915_reg.h
Quoted 2 lines
drivers/gpu/drm/i915/i915_reg.h +2
-0+ +#define PLANE_PRE_CSC_GAMC_DATA (pipe, plane, i)_MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_DATA_4(pipe),\Quoted 1 line
+
_PLANE_PRE_CSC_GAMC_DATA_5(pipe))Quoted 7 lines
+
/* pipe CSC & degamma/gamma LUTs on CHV */
#define_CGM_PIPE_A_CSC_COEFF01(VLV_DISPLAY_BASE+0x67900)
#define_CGM_PIPE_A_CSC_COEFF23(VLV_DISPLAY_BASE+0x67904)
--
1.9.1
Quoted 6 lines
--
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v6 11/16 drm/i915/icl: Enable Plane Degamma
In reply to Uma ShankarEnable Plane Degamma for ICL.
--- drivers/gpu/drm/i915/intel_color.c | 86 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 86 insertions(+)
drivers/gpu/drm/i915/intel_color.c +86 -0
@@ -615,6 +615,89 @@ static void broadwell_load_plane_luts(const struct drm_plane_state *state) INTEL_INFO(dev_priv)->plane_color.plane_degamma_lut_size); } +static void icl_load_plane_degamma_lut (const struct drm_plane_state *state, +u32 offset) +{ +struct drm_i915_private *dev_priv =to_i915 (state->plane->dev); +enum pipe pipe =to_intel_plane (state->plane)->pipe; +enum plane_id plane =to_intel_plane (state->plane)->id; +u32 i, lut_size; + +if (icl_is_hdr_plane (dev_priv, plane)) { + lut_size =128 ; +if (state->degamma_lut) { +struct drm_color_lut_ext *lut = + (struct drm_color_lut_ext *)state->gamma_lut->data; + +for (i =0 ; i < lut_size; i++) { +u64 word =drm_color_lut_extract_ext (lut[i].red, +24 ); +u32 lut_val = (word &0x7ffffffff ) >>8 ; + +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane, i), + lut_val); + } + +/* Program the max register to clamp values > 1.0. */ +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane,0 ), +drm_color_lut_extract_ext (lut[i].red,24 )); +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane,1 ), +drm_color_lut_extract_ext (lut[i].green,24 )); +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane,2 ), +drm_color_lut_extract_ext (lut[i].blue,24 )); + }else { +for (i =0 ; i < lut_size; i++) { +u32 v = (i * ((1 <<24 ) -1 )) / (lut_size -1 ); +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane, i), v); + } + +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane,0 ), + (1 <<24 ) -1 ); +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane,1 ), + (1 <<24 ) -1 ); +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane,2 ), + (1 <<24 ) -1 ); + } + }else { + lut_size =32 ; +if (state->degamma_lut) { +struct drm_color_lut *lut = + (struct drm_color_lut *)state->gamma_lut->data; + +for (i =0 ; i < lut_size; i++) +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA (pipe, plane, i), + lut[i].green); + +/* Program the max register to clamp values > 1.0. */ +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA (pipe, plane,0 ), + (1 <<16 )); +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA (pipe, plane,1 ), + (1 <<16 )); +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA (pipe, plane,2 ), + (1 <<16 )); + }else { +for (i =0 ; i < lut_size; i++) { +u32 v = (i * ((1 <<24 ) -1 )) / (lut_size -1 ); + +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA (pipe, plane, i), v); + } + +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA (pipe, plane,0 ), + (1 <<16 )); +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA (pipe, plane,1 ), + (1 <<16 )); +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA (pipe, plane,2 ), + (1 <<16 )); + } + } +} + +/* Loads the palette/gamma unit for the CRTC on Gen11+. */ +static void icl_load_plane_luts (const struct drm_plane_state *state) +{ +icl_load_plane_degamma_lut (state,0 ); +} +static void glk_load_degamma_lut (const struct intel_crtc_state *crtc_state) {struct intel_crtc *crtc =to_intel_crtc (crtc_state->base.crtc);
@@ -978,6 +1061,9 @@ void intel_color_init(struct intel_crtc *crtc) dev_priv->display.color_commit = ilk_color_commit; } +if (INTEL_GEN (dev_priv) >=11 ) + dev_priv->display.load_plane_luts = icl_load_plane_luts; +/* Enable color management support when we have degamma & gamma LUTs. */ if (INTEL_INFO (dev_priv)->color.degamma_lut_size !=0 &&INTEL_INFO (dev_priv)->color.gamma_lut_size !=0 )
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
kbuild test robot
build botRe: [v6 11/16] drm/i915/icl: Enable Plane Degamma
Thank you for the patch! Perhaps something to improve:
Hi Uma,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20190319]
[cannot apply to v5.1-rc1]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Uma-Shankar/Add-Plane-Color-Properties/20190319-222429 base: git://anongit.freedesktop.org/drm-intel for-linux-next reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
sparse warnings: (new ones prefixed by >>)
include/uapi/linux/perf_event.h:147:56: sparse: cast truncates bits from constant value (8000000000000000 becomes 0)
>> drivers/gpu/drm/i915/intel_color.c:635:55: sparse: constant 0x7ffffffff is so big it is long
drivers/gpu/drm/i915/intel_color.c:119:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:119:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:119:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:119:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:119:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:119:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:119:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:225:29: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:225:29: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:225:29: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:225:29: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:225:29: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:225:29: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:225:29: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:235:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:235:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:235:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:235:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:235:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:235:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:235:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:238:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:238:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:238:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:238:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:238:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:238:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:238:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:241:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:241:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:241:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:241:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:241:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:241:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:241:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:243:38: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:243:38: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:243:38: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:243:38: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:243:38: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:243:38: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:243:38: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:246:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:246:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:246:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:246:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:246:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:246:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:246:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:249:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:249:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:249:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:249:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:249:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:249:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:249:33: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:331:37: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:331:37: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:331:37: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:331:37: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:331:37: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:331:37: sparse: expression using sizeof(void) drivers/gpu/drm/i915/intel_color.c:331:37: sparse: expression using sizeof(void)
vim +635 drivers/gpu/drm/i915/intel_color.c
617
618 static void icl_load_plane_degamma_lut(const struct drm_plane_state *state,
619 u32 offset)
620 {
621 struct drm_i915_private *dev_priv = to_i915(state->plane->dev);
622 enum pipe pipe = to_intel_plane(state->plane)->pipe;
623 enum plane_id plane = to_intel_plane(state->plane)->id;
624 u32 i, lut_size;
625
626 if (icl_is_hdr_plane(dev_priv, plane)) {
627 lut_size = 128;
628 if (state->degamma_lut) {
629 struct drm_color_lut_ext *lut =
630 (struct drm_color_lut_ext *)state->gamma_lut->data;
631
632 for (i = 0; i < lut_size; i++) {
633 u64 word = drm_color_lut_extract_ext(lut[i].red,
634 24);
> 635 u32 lut_val = (word & 0x7ffffffff) >> 8;
636
637 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, i),
638 lut_val);
639 }
640
641 /* Program the max register to clamp values > 1.0. */
642 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),
643 drm_color_lut_extract_ext(lut[i].red, 24));
644 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 1),
645 drm_color_lut_extract_ext(lut[i].green, 24));
646 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 2),
647 drm_color_lut_extract_ext(lut[i].blue, 24));
648 } else {
649 for (i = 0; i < lut_size; i++) {
650 u32 v = (i * ((1 << 24) - 1)) / (lut_size - 1);
651 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, i), v);
652 }
653
654 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),
655 (1 << 24) - 1);
656 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 1),
657 (1 << 24) - 1);
658 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 2),
659 (1 << 24) - 1);
660 }
661 } else {
662 lut_size = 32;
663 if (state->degamma_lut) {
664 struct drm_color_lut *lut =
665 (struct drm_color_lut *)state->gamma_lut->data;
666
667 for (i = 0; i < lut_size; i++)
668 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA(pipe, plane, i),
669 lut[i].green);
670
671 /* Program the max register to clamp values > 1.0. */
672 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA(pipe, plane, 0),
673 (1 << 16));
674 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA(pipe, plane, 1),
675 (1 << 16));
676 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA(pipe, plane, 2),
677 (1 << 16));
678 } else {
679 for (i = 0; i < lut_size; i++) {
680 u32 v = (i * ((1 << 24) - 1)) / (lut_size - 1);
681
682 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA(pipe, plane, i), v);
683 }
684
685 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA(pipe, plane, 0),
686 (1 << 16));
687 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA(pipe, plane, 1),
688 (1 << 16));
689 I915_WRITE(PLANE_PRE_CSC_GAMC_DATA(pipe, plane, 2),
690 (1 << 16));
691 }
692 }
693 }
694
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v6 12/16 drm/i915/icl: Add Plane Gamma Register Definitions
In reply to Uma ShankarAdd Plane Gamma Register definitions for ICL+
--- drivers/gpu/drm/i915/i915_reg.h | 42 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 41 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_reg.h +41 -1
@@ -10222,7 +10222,47 @@ enum skl_power_gate {#define PLANE_PRE_CSC_GAMC_DATA (pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_DATA_4(pipe),\ _PLANE_PRE_CSC_GAMC_DATA_5(pipe)) - +/* Plane Gamma Registers */ +#define _PLANE_POST_CSC_GAMC_INDEX_ENH_1_A 0x701D8 +#define _PLANE_POST_CSC_GAMC_INDEX_ENH_1_B 0x711D8 +#define _PLANE_POST_CSC_GAMC_INDEX_ENH_2_A 0x702D8 +#define _PLANE_POST_CSC_GAMC_INDEX_ENH_2_B 0x712D8 +#define _PLANE_POST_CSC_GAMC_INDEX_ENH_1 (pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_INDEX_ENH_1_A, _PLANE_POST_CSC_GAMC_INDEX_ENH_1_B) +#define _PLANE_POST_CSC_GAMC_INDEX_ENH_2 (pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_INDEX_ENH_2_A, _PLANE_POST_CSC_GAMC_INDEX_ENH_2_B) + +#define PLANE_POST_CSC_GAMC_INDEX_ENH (pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_INDEX_ENH_1(pipe),\ + _PLANE_POST_CSC_GAMC_INDEX_ENH_2(pipe)) + +#define _PLANE_POST_CSC_GAMC_INDEX_4_A 0x704D8 +#define _PLANE_POST_CSC_GAMC_INDEX_4_B 0x714D8 +#define _PLANE_POST_CSC_GAMC_INDEX_5_A 0x705D8 +#define _PLANE_POST_CSC_GAMC_INDEX_5_B 0x715D8 +#define _PLANE_POST_CSC_GAMC_INDEX_4 (pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_INDEX_4_A, _PLANE_POST_CSC_GAMC_INDEX_4_B) +#define _PLANE_POST_CSC_GAMC_INDEX_5 (pipe) _PIPE(pipe, _PLANE_POSt_CSC_GAMC_INDEX_5_A, _PLANE_POST_CSC_GAMC_INDEX_5_B) + +#define PLANE_POST_CSC_GAMC_INDEX (pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_INDEX_4(pipe),\ + _PLANE_POSt_CSC_GAMC_INDEX_5(pipe)) + +#define _PLANE_POST_CSC_GAMC_DATA_ENH_1_A 0x701DC +#define _PLANE_POST_CSC_GAMC_DATA_ENH_1_B 0x711DC +#define _PLANE_POST_CSC_GAMC_DATA_ENH_2_A 0x702DC +#define _PLANE_POST_CSC_GAMC_DATA_ENH_2_B 0x712DC +#define _PLANE_POST_CSC_GAMC_DATA_ENH_1 (pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_DATA_ENH_1_A, _PLANE_POST_CSC_GAMC_DATA_ENH_1_B) +#define _PLANE_POST_CSC_GAMC_DATA_ENH_2 (pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_DATA_ENH_2_A, _PLANE_POST_CSC_GAMC_DATA_ENH_2_B) + +#define PLANE_POST_CSC_GAMC_DATA_ENH (pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_DATA_ENH_1(pipe),\ + _PLANE_POST_CSC_GAMC_DATA_ENH_2(pipe)) + +#define _PLANE_POST_CSC_GAMC_DATA_4_A 0x704DC +#define _PLANE_POST_CSC_GAMC_DATA_4_B 0x714DC +#define _PLANE_POST_CSC_GAMC_DATA_5_A 0x705DC +#define _PLANE_POST_CSC_GAMC_DATA_5_B 0x715DC +#define _PLANE_POST_CSC_GAMC_DATA_4 (pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_DATA_4_A, _PLANE_POST_CSC_GAMC_DATA_4_B) +#define _PLANE_POST_CSC_GAMC_DATA_5 (pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_DATA_5_A, _PLANE_POST_CSC_GAMC_DATA_5_B) + +#define PLANE_POST_CSC_GAMC_DATA (pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_DATA_4(pipe),\ + _PLANE_POST_CSC_GAMC_DATA_5(pipe)) +/* Plane Gamma Registers */ /* pipe CSC & degamma/gamma LUTs on CHV */ #define _CGM_PIPE_A_CSC_COEFF01 (VLV_DISPLAY_BASE + 0x67900)#define _CGM_PIPE_A_CSC_COEFF23 (VLV_DISPLAY_BASE + 0x67904)
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v6 13/16 drm/i915/icl: Implement Plane Gamma
In reply to Uma ShankarImplement Plane Gamma on ICL.
--- drivers/gpu/drm/i915/intel_color.c | 75 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 75 insertions(+)
drivers/gpu/drm/i915/intel_color.c +75 -0
@@ -692,10 +692,85 @@ static void icl_load_plane_degamma_lut(const struct drm_plane_state *state, } } +static void icl_load_plane_gamma_lut (const struct drm_plane_state *state, +u32 offset) +{ +struct drm_i915_private *dev_priv =to_i915 (state->plane->dev); +enum pipe pipe =to_intel_plane (state->plane)->pipe; +enum plane_id plane =to_intel_plane (state->plane)->id; +u32 i, lut_size; + + lut_size =32 ; +if (icl_is_hdr_plane (dev_priv, plane)) { +if (state->degamma_lut) { +struct drm_color_lut_ext *lut = + (struct drm_color_lut_ext *)state->gamma_lut->data; + +for (i =0 ; i < lut_size; i++) { +u64 word =drm_color_lut_extract_ext (lut[i].red,24 ); +u32 lut_val = (word &0x7ffffffff ) >>8 ; + +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane, i), lut_val); + } + +/* Program the max register to clamp values > 1.0. */ +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane,0 ), +drm_color_lut_extract_ext (lut[i].red,24 )); +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane,1 ), +drm_color_lut_extract_ext (lut[i].green,24 )); +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane,2 ), +drm_color_lut_extract_ext (lut[i].blue,24 )); + }else { +for (i =0 ; i < lut_size; i++) { +u32 v = (i * ((1 <<24 ) -1 )) / (lut_size -1 ); +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane, i), v); + } + +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane,0 ), + (1 <<24 ) -1 ); +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane,1 ), + (1 <<24 ) -1 ); +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane,2 ), + (1 <<24 ) -1 ); + } + }else { +if (state->degamma_lut) { +struct drm_color_lut *lut = + (struct drm_color_lut *)state->gamma_lut->data; + +for (i =0 ; i < lut_size; i++) +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA (pipe, plane, i), + lut[i].green); + +/* Program the max register to clamp values > 1.0. */ +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA (pipe, plane,0 ), + (1 <<16 )); +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA (pipe, plane,1 ), + (1 <<16 )); +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA (pipe, plane,2 ), + (1 <<16 )); + }else { +for (i =0 ; i < lut_size; i++) { +u32 v = (i * ((1 <<24 ) -1 )) / (lut_size -1 ); + +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA (pipe, plane, i), v); + } + +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA (pipe, plane,0 ), + (1 <<16 )); +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA (pipe, plane,1 ), + (1 <<16 )); +I915_WRITE (PLANE_PRE_CSC_GAMC_DATA (pipe, plane,2 ), + (1 <<16 )); + } + } +} +/* Loads the palette/gamma unit for the CRTC on Gen11+. */ static void icl_load_plane_luts (const struct drm_plane_state *state) {icl_load_plane_degamma_lut (state,0 ); +icl_load_plane_gamma_lut (state,0 ); }static void glk_load_degamma_lut (const struct intel_crtc_state *crtc_state)
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v6 14/16 drm/i915: Enable Plane Gamma/Degamma
In reply to Uma ShankarUpdate the plane gamma and degamma feature in the plane state and eventually program to PLANE_COLOR_CTL.
--- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_color.c | 6 ++++++ drivers/gpu/drm/i915/intel_display.c | 6 +++++- 3 files changed, 12 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_reg.h +1 -0
@@ -6757,6 +6757,7 @@ enum {#define PLANE_COLOR_CSC_MODE_YUV709_TO_RGB709 (2 << 17)#define PLANE_COLOR_CSC_MODE_YUV2020_TO_RGB2020 (3 << 17)#define PLANE_COLOR_CSC_MODE_RGB709_TO_RGB2020 (4 << 17) +#define PLANE_COLOR_PLANE_PRECSC_GAMMA_ENABLE (1 << 14)#define PLANE_COLOR_PLANE_GAMMA_DISABLE (1 << 13)#define PLANE_COLOR_ALPHA_MASK (0x3 << 4)#define PLANE_COLOR_ALPHA_DISABLE (0 << 4)
drivers/gpu/drm/i915/intel_color.c +6 -0
@@ -769,8 +769,14 @@ static void icl_load_plane_gamma_lut(const struct drm_plane_state *state,/* Loads the palette/gamma unit for the CRTC on Gen11+. */ static void icl_load_plane_luts (const struct drm_plane_state *state) { +struct intel_plane_state *plane_state = +to_intel_plane_state (state); +icl_load_plane_degamma_lut (state,0 );icl_load_plane_gamma_lut (state,0 ); + + plane_state->gamma_mode |=PLANE_COLOR_PLANE_PRECSC_GAMMA_ENABLE ; + plane_state->gamma_mode |= ~PLANE_COLOR_PLANE_GAMMA_DISABLE ; }static void glk_load_degamma_lut (const struct intel_crtc_state *crtc_state)
drivers/gpu/drm/i915/intel_display.c +5 -1
@@ -3805,7 +3805,11 @@ u32 glk_plane_color_ctl(const struct intel_crtc_state *crtc_state,struct intel_plane *plane =to_intel_plane (plane_state->base.plane);u32 plane_color_ctl =0 ; - plane_color_ctl |=PLANE_COLOR_PLANE_GAMMA_DISABLE ; +if (INTEL_GEN (dev_priv) <=11 ) + plane_color_ctl |=PLANE_COLOR_PLANE_GAMMA_DISABLE ; +else + plane_color_ctl |= plane_state->gamma_mode; + plane_color_ctl |=glk_plane_color_ctl_alpha (plane_state);if (fb->format->is_yuv && !icl_is_hdr_plane (dev_priv, plane->id)) {
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v6 15/16 drm/i915: Define Plane CSC Registers
In reply to Uma ShankarDefine Register macros for plane CSC.
--- drivers/gpu/drm/i915/i915_reg.h | 44 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +44 -0
@@ -10263,6 +10263,50 @@ enum skl_power_gate {#define PLANE_POST_CSC_GAMC_DATA (pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_DATA_4(pipe),\ _PLANE_POST_CSC_GAMC_DATA_5(pipe)) + +/* Plane CSC Registers */ +#define _PLANE_CSC_RY_GY_1_A 0x70210 +#define _PLANE_CSC_RY_GY_2_A 0x70310 + +#define _PLANE_CSC_RY_GY_1_B 0x71210 +#define _PLANE_CSC_RY_GY_2_B 0x71310 + +#define _PLANE_CSC_RY_GY_1 (pipe) _PIPE(pipe, _PLANE_CSC_RY_GY_1_A, \ + _PLANE_CSC_RY_GY_1_B) +#define _PLANE_CSC_RY_GY_2 (pipe) _PIPE(pipe, _PLANE_INPUT_CSC_RY_GY_2_A, \ + _PLANE_INPUT_CSC_RY_GY_2_B) + +#define PLANE_CSC_COEFF (pipe, plane, index) _MMIO_PLANE(plane, \ + _PLANE_CSC_RY_GY_1(pipe) + (index) * 4, \ + _PLANE_CSC_RY_GY_2(pipe) + (index) * 4) + +#define _PLANE_CSC_PREOFF_HI_1_A 0x70228 +#define _PLANE_CSC_PREOFF_HI_2_A 0x70328 + +#define _PLANE_CSC_PREOFF_HI_1_B 0x71228 +#define _PLANE_CSC_PREOFF_HI_2_B 0x71328 + +#define _PLANE_CSC_PREOFF_HI_1 (pipe) _PIPE(pipe, _PLANE_CSC_PREOFF_HI_1_A, \ + _PLANE_CSC_PREOFF_HI_1_B) +#define _PLANE_CSC_PREOFF_HI_2 (pipe) _PIPE(pipe, _PLANE_CSC_PREOFF_HI_2_A, \ + _PLANE_CSC_PREOFF_HI_2_B) +#define PLANE_CSC_PREOFF (pipe, plane, index) _MMIO_PLANE(plane, _PLANE_CSC_PREOFF_HI_1(pipe) + \ + (index) * 4, _PLANE_CSC_PREOFF_HI_2(pipe) + \ + (index) * 4) + +#define _PLANE_CSC_POSTOFF_HI_1_A 0x70234 +#define _PLANE_CSC_POSTOFF_HI_2_A 0x70334 + +#define _PLANE_CSC_POSTOFF_HI_1_B 0x71234 +#define _PLANE_CSC_POSTOFF_HI_2_B 0x71334 + +#define _PLANE_CSC_POSTOFF_HI_1 (pipe) _PIPE(pipe, _PLANE_CSC_POSTOFF_HI_1_A, \ + _PLANE_CSC_POSTOFF_HI_1_B) +#define _PLANE_CSC_POSTOFF_HI_2 (pipe) _PIPE(pipe, _PLANE_CSC_POSTOFF_HI_2_A, \ + _PLANE_CSC_POSTOFF_HI_2_B) +#define PLANE_CSC_POSTOFF (pipe, plane, index) _MMIO_PLANE(plane, _PLANE_CSC_POSTOFF_HI_1(pipe) + \ + (index) * 4, _PLANE_CSC_POSTOFF_HI_2(pipe) + \ + (index) * 4)/* Plane Gamma Registers */ /* pipe CSC & degamma/gamma LUTs on CHV */ #define _CGM_PIPE_A_CSC_COEFF01 (VLV_DISPLAY_BASE + 0x67900)
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v6 16/16 drm/i915: Enable Plane CSC
In reply to Uma ShankarImplement plane CSC on ICL.
--- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_color.c | 86 ++++++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_display.c | 3 ++ 3 files changed, 90 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +1 -0
@@ -6750,6 +6750,7 @@ enum {#define _PLANE_COLOR_CTL_3_A 0x703CC/* GLK+ */ #define PLANE_COLOR_PIPE_GAMMA_ENABLE (1 << 30)/* Pre-ICL */ #define PLANE_COLOR_YUV_RANGE_CORRECTION_DISABLE (1 << 28) +#define PLANE_COLOR_PLANE_CSC_ENABLE (1 << 21)/* ICL+ */ #define PLANE_COLOR_INPUT_CSC_ENABLE (1 << 20)/* ICL+ */ #define PLANE_COLOR_PIPE_CSC_ENABLE (1 << 23)/* Pre-ICL */ #define PLANE_COLOR_CSC_MODE_BYPASS (0 << 17)
drivers/gpu/drm/i915/intel_color.c +86 -0
98 lines not on this page · raw message
drivers/gpu/drm/i915/intel_display.c +3 -0
@@ -3824,6 +3824,9 @@ u32 glk_plane_color_ctl(const struct intel_crtc_state *crtc_state, plane_color_ctl |=PLANE_COLOR_INPUT_CSC_ENABLE ; } +if (plane_state->base.ctm) + plane_color_ctl |=PLANE_COLOR_PLANE_CSC_ENABLE ; +return plane_color_ctl; }
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for Add Plane Color Properties (rev6)
In reply to Uma Shankar== Series Details ==
== Series Details ==
Series: Add Plane Color Properties (rev6)
URL : https://patchwork.freedesktop.org/series/30875/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip ac8ffabdea94 drm: Add Enhanced Gamma LUT precision structure cb4da76aa060 drm: Add Plane Degamma properties -:180: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #180: FILE: drivers/gpu/drm/drm_atomic_uapi.c:577: + ret = drm_atomic_replace_property_blob_from_id(dev, + &state->degamma_lut,
total: 0 errors, 0 warnings, 1 checks, 253 lines checked 6d1310f593e8 drm: Add Plane CTM property
-:69: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #69: FILE: drivers/gpu/drm/drm_atomic_uapi.c:584:
+ ret = drm_atomic_replace_property_blob_from_id(dev,
+ &state->ctm,
total: 0 errors, 0 warnings, 1 checks, 97 lines checked 874066e51de7 drm: Add Plane Gamma properties
-:72: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #72: FILE: drivers/gpu/drm/drm_atomic_uapi.c:592:
+ ret = drm_atomic_replace_property_blob_from_id(dev,
+ &state->gamma_lut,
total: 0 errors, 0 warnings, 1 checks, 116 lines checked aa2c66edd9cb drm: Define helper function for plane color enabling a469bd374d08 drm/i915: Enable plane color features -:62: WARNING:LONG_LINE: line over 100 characters
#62: FILE: drivers/gpu/drm/i915/intel_color.c:882:
+ INTEL_INFO(dev_priv)->plane_color.plane_degamma_lut_size,
total: 0 errors, 1 warnings, 0 checks, 71 lines checked3b9c169dbec3 drm/i915: Implement Plane Gamma for Bdw and Gen9 platforms -:62: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #62: FILE: drivers/gpu/drm/i915/i915_reg.h:10170:
+#define PLANE_GAMC(pipe, plane, i) \
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_GAMC_1(pipe), _PLANE_GAMC_2(pipe))
-:73: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #73: FILE: drivers/gpu/drm/i915/i915_reg.h:10181:
+#define PLANE_GAMC16(pipe, plane, i) _MMIO_PLANE_GAMC16(plane, i, \
+ _PLANE_GAMC16_1(pipe), _PLANE_GAMC16_2(pipe))
total: 0 errors, 0 warnings, 2 checks, 137 lines checked fe57d6db3259 drm/i915: Load plane color luts from atomic flip eba9f1c9b828 drm/i915: Add plane color capabilities 415f57b6a941 drm/i915/icl: Add ICL Plane Degamma Register definition -:24: WARNING:LONG_LINE: line over 100 characters
#24: FILE: drivers/gpu/drm/i915/i915_reg.h:10190:
+#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_1(pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_INDEX_ENH_1_A, _PLANE_PRE_CSC_GAMC_INDEX_ENH_1_B)
-:25: WARNING:LONG_LINE: line over 100 characters #25: FILE: drivers/gpu/drm/i915/i915_reg.h:10191:
+#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_2(pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_INDEX_ENH_2_A, _PLANE_PRE_CSC_GAMC_INDEX_ENH_2_B)
-:27: WARNING:LONG_LINE: line over 100 characters #27: FILE: drivers/gpu/drm/i915/i915_reg.h:10193:
+#define PLANE_PRE_CSC_GAMC_INDEX_ENH(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_INDEX_ENH_1(pipe),\
-:27: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #27: FILE: drivers/gpu/drm/i915/i915_reg.h:10193:
+#define PLANE_PRE_CSC_GAMC_INDEX_ENH(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_INDEX_ENH_1(pipe),\
+ _PLANE_PRE_CSC_GAMC_INDEX_ENH_2(pipe))
-:28: WARNING:LONG_LINE: line over 100 characters #28: FILE: drivers/gpu/drm/i915/i915_reg.h:10194:
+ _PLANE_PRE_CSC_GAMC_INDEX_ENH_2(pipe))
-:34: WARNING:LONG_LINE: line over 100 characters #34: FILE: drivers/gpu/drm/i915/i915_reg.h:10200:
+#define _PLANE_PRE_CSC_GAMC_INDEX_4(pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_INDEX_4_A, _PLANE_PRE_CSC_GAMC_INDEX_4_B)
-:35: WARNING:LONG_LINE: line over 100 characters #35: FILE: drivers/gpu/drm/i915/i915_reg.h:10201:
+#define _PLANE_PRE_CSC_GAMC_INDEX_5(pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_INDEX_5_A, _PLANE_PRE_CSC_GAMC_INDEX_5_B)
-:37: WARNING:LONG_LINE: line over 100 characters #37: FILE: drivers/gpu/drm/i915/i915_reg.h:10203:
+#define PLANE_PRE_CSC_GAMC_INDEX(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_INDEX_4(pipe),\
-:37: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #37: FILE: drivers/gpu/drm/i915/i915_reg.h:10203:
+#define PLANE_PRE_CSC_GAMC_INDEX(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_INDEX_4(pipe),\
+ _PLANE_PRE_CSC_GAMC_INDEX_5(pipe))
-:38: WARNING:LONG_LINE: line over 100 characters #38: FILE: drivers/gpu/drm/i915/i915_reg.h:10204:
+ _PLANE_PRE_CSC_GAMC_INDEX_5(pipe))
-:44: WARNING:LONG_LINE: line over 100 characters #44: FILE: drivers/gpu/drm/i915/i915_reg.h:10210:
+#define _PLANE_PRE_CSC_GAMC_DATA_ENH_1(pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_DATA_ENH_1_A, _PLANE_PRE_CSC_GAMC_DATA_ENH_1_B)
-:45: WARNING:LONG_LINE: line over 100 characters #45: FILE: drivers/gpu/drm/i915/i915_reg.h:10211:
+#define _PLANE_PRE_CSC_GAMC_DATA_ENH_2(pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_DATA_ENH_2_A, _PLANE_PRE_CSC_GAMC_DATA_ENH_2_B)
-:47: WARNING:LONG_LINE: line over 100 characters #47: FILE: drivers/gpu/drm/i915/i915_reg.h:10213:
+#define PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_DATA_ENH_1(pipe),\
-:47: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #47: FILE: drivers/gpu/drm/i915/i915_reg.h:10213:
+#define PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_DATA_ENH_1(pipe),\
+ _PLANE_PRE_CSC_GAMC_DATA_ENH_2(pipe))
-:48: WARNING:LONG_LINE: line over 100 characters #48: FILE: drivers/gpu/drm/i915/i915_reg.h:10214:
+ _PLANE_PRE_CSC_GAMC_DATA_ENH_2(pipe))
-:54: WARNING:LONG_LINE: line over 100 characters #54: FILE: drivers/gpu/drm/i915/i915_reg.h:10220:
+#define _PLANE_PRE_CSC_GAMC_DATA_4(pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_DATA_4_A, _PLANE_PRE_CSC_GAMC_DATA_4_B)
-:55: WARNING:LONG_LINE: line over 100 characters #55: FILE: drivers/gpu/drm/i915/i915_reg.h:10221:
+#define _PLANE_PRE_CSC_GAMC_DATA_5(pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_DATA_5_A, _PLANE_PRE_CSC_GAMC_DATA_5_B)
-:57: WARNING:LONG_LINE: line over 100 characters #57: FILE: drivers/gpu/drm/i915/i915_reg.h:10223:
+#define PLANE_PRE_CSC_GAMC_DATA(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_DATA_4(pipe),\
-:57: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #57: FILE: drivers/gpu/drm/i915/i915_reg.h:10223:
+#define PLANE_PRE_CSC_GAMC_DATA(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_DATA_4(pipe),\
+ _PLANE_PRE_CSC_GAMC_DATA_5(pipe))
-:58: WARNING:LONG_LINE: line over 100 characters #58: FILE: drivers/gpu/drm/i915/i915_reg.h:10224:
+ _PLANE_PRE_CSC_GAMC_DATA_5(pipe))
total: 0 errors, 16 warnings, 4 checks, 48 lines checked 6db8c958bceb drm/i915/icl: Enable Plane Degamma
-:51: WARNING:LINE_SPACING: Missing a blank line after declarations #51: FILE: drivers/gpu/drm/i915/intel_color.c:651:
+ u32 v = (i * ((1 << 24) - 1)) / (lut_size - 1);
+ I915_WRITE(PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, i), v);
total: 0 errors, 1 warnings, 0 checks, 98 lines checked dc49d1b1bc11 drm/i915/icl: Add Plane Gamma Register Definitions -:24: WARNING:LONG_LINE: line over 100 characters #24: FILE: drivers/gpu/drm/i915/i915_reg.h:10230:
+#define _PLANE_POST_CSC_GAMC_INDEX_ENH_1(pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_INDEX_ENH_1_A, _PLANE_POST_CSC_GAMC_INDEX_ENH_1_B)
-:25: WARNING:LONG_LINE: line over 100 characters #25: FILE: drivers/gpu/drm/i915/i915_reg.h:10231:
+#define _PLANE_POST_CSC_GAMC_INDEX_ENH_2(pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_INDEX_ENH_2_A, _PLANE_POST_CSC_GAMC_INDEX_ENH_2_B)
-:27: WARNING:LONG_LINE: line over 100 characters #27: FILE: drivers/gpu/drm/i915/i915_reg.h:10233:
+#define PLANE_POST_CSC_GAMC_INDEX_ENH(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_INDEX_ENH_1(pipe),\
-:27: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #27: FILE: drivers/gpu/drm/i915/i915_reg.h:10233:
+#define PLANE_POST_CSC_GAMC_INDEX_ENH(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_INDEX_ENH_1(pipe),\
+ _PLANE_POST_CSC_GAMC_INDEX_ENH_2(pipe))
-:28: WARNING:LONG_LINE: line over 100 characters #28: FILE: drivers/gpu/drm/i915/i915_reg.h:10234:
+ _PLANE_POST_CSC_GAMC_INDEX_ENH_2(pipe))
-:34: WARNING:LONG_LINE: line over 100 characters #34: FILE: drivers/gpu/drm/i915/i915_reg.h:10240:
+#define _PLANE_POST_CSC_GAMC_INDEX_4(pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_INDEX_4_A, _PLANE_POST_CSC_GAMC_INDEX_4_B)
-:35: WARNING:LONG_LINE: line over 100 characters #35: FILE: drivers/gpu/drm/i915/i915_reg.h:10241:
+#define _PLANE_POST_CSC_GAMC_INDEX_5(pipe) _PIPE(pipe, _PLANE_POSt_CSC_GAMC_INDEX_5_A, _PLANE_POST_CSC_GAMC_INDEX_5_B)
-:35: CHECK:CAMELCASE: Avoid CamelCase: <_PLANE_POSt_CSC_GAMC_INDEX_5_A> #35: FILE: drivers/gpu/drm/i915/i915_reg.h:10241:
+#define _PLANE_POST_CSC_GAMC_INDEX_5(pipe) _PIPE(pipe, _PLANE_POSt_CSC_GAMC_INDEX_5_A, _PLANE_POST_CSC_GAMC_INDEX_5_B)
-:37: WARNING:LONG_LINE: line over 100 characters #37: FILE: drivers/gpu/drm/i915/i915_reg.h:10243:
+#define PLANE_POST_CSC_GAMC_INDEX(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_INDEX_4(pipe),\
-:37: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #37: FILE: drivers/gpu/drm/i915/i915_reg.h:10243:
+#define PLANE_POST_CSC_GAMC_INDEX(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_INDEX_4(pipe),\
+ _PLANE_POSt_CSC_GAMC_INDEX_5(pipe))
-:38: WARNING:LONG_LINE: line over 100 characters #38: FILE: drivers/gpu/drm/i915/i915_reg.h:10244:
+ _PLANE_POSt_CSC_GAMC_INDEX_5(pipe))
-:38: CHECK:CAMELCASE: Avoid CamelCase: <_PLANE_POSt_CSC_GAMC_INDEX_5> #38: FILE: drivers/gpu/drm/i915/i915_reg.h:10244:
+ _PLANE_POSt_CSC_GAMC_INDEX_5(pipe))
-:44: WARNING:LONG_LINE: line over 100 characters #44: FILE: drivers/gpu/drm/i915/i915_reg.h:10250:
+#define _PLANE_POST_CSC_GAMC_DATA_ENH_1(pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_DATA_ENH_1_A, _PLANE_POST_CSC_GAMC_DATA_ENH_1_B)
-:45: WARNING:LONG_LINE: line over 100 characters #45: FILE: drivers/gpu/drm/i915/i915_reg.h:10251:
+#define _PLANE_POST_CSC_GAMC_DATA_ENH_2(pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_DATA_ENH_2_A, _PLANE_POST_CSC_GAMC_DATA_ENH_2_B)
-:47: WARNING:LONG_LINE: line over 100 characters #47: FILE: drivers/gpu/drm/i915/i915_reg.h:10253:
+#define PLANE_POST_CSC_GAMC_DATA_ENH(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_DATA_ENH_1(pipe),\
-:47: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #47: FILE: drivers/gpu/drm/i915/i915_reg.h:10253:
+#define PLANE_POST_CSC_GAMC_DATA_ENH(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_DATA_ENH_1(pipe),\
+ _PLANE_POST_CSC_GAMC_DATA_ENH_2(pipe))
-:48: WARNING:LONG_LINE: line over 100 characters #48: FILE: drivers/gpu/drm/i915/i915_reg.h:10254:
+ _PLANE_POST_CSC_GAMC_DATA_ENH_2(pipe))
-:54: WARNING:LONG_LINE: line over 100 characters #54: FILE: drivers/gpu/drm/i915/i915_reg.h:10260:
+#define _PLANE_POST_CSC_GAMC_DATA_4(pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_DATA_4_A, _PLANE_POST_CSC_GAMC_DATA_4_B)
-:55: WARNING:LONG_LINE: line over 100 characters #55: FILE: drivers/gpu/drm/i915/i915_reg.h:10261:
+#define _PLANE_POST_CSC_GAMC_DATA_5(pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_DATA_5_A, _PLANE_POST_CSC_GAMC_DATA_5_B)
-:57: WARNING:LONG_LINE: line over 100 characters #57: FILE: drivers/gpu/drm/i915/i915_reg.h:10263:
+#define PLANE_POST_CSC_GAMC_DATA(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_DATA_4(pipe),\
-:57: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #57: FILE: drivers/gpu/drm/i915/i915_reg.h:10263:
+#define PLANE_POST_CSC_GAMC_DATA(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_DATA_4(pipe),\
+ _PLANE_POST_CSC_GAMC_DATA_5(pipe))
-:58: WARNING:LONG_LINE: line over 100 characters #58: FILE: drivers/gpu/drm/i915/i915_reg.h:10264:
+ _PLANE_POST_CSC_GAMC_DATA_5(pipe))
total: 0 errors, 16 warnings, 6 checks, 48 lines checked d2c749cba6ef drm/i915/icl: Implement Plane Gamma
-:49: WARNING:LINE_SPACING: Missing a blank line after declarations #49: FILE: drivers/gpu/drm/i915/intel_color.c:726:
+ u32 v = (i * ((1 << 24) - 1)) / (lut_size - 1);
+ I915_WRITE(PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, i), v);
total: 0 errors, 1 warnings, 0 checks, 85 lines checkedd4c386908867 drm/i915: Enable Plane Gamma/Degamma723fb9c0bb23 drm/i915: Define Plane CSC Registers
-:31: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #31: FILE: drivers/gpu/drm/i915/i915_reg.h:10279:
+#define PLANE_CSC_COEFF(pipe, plane, index) _MMIO_PLANE(plane, \
+ _PLANE_CSC_RY_GY_1(pipe) + (index) * 4, \
+ _PLANE_CSC_RY_GY_2(pipe) + (index) * 4)
-:31: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects? #31: FILE: drivers/gpu/drm/i915/i915_reg.h:10279:
+#define PLANE_CSC_COEFF(pipe, plane, index) _MMIO_PLANE(plane, \
+ _PLANE_CSC_RY_GY_1(pipe) + (index) * 4, \
+ _PLANE_CSC_RY_GY_2(pipe) + (index) * 4)
-:32: WARNING:LONG_LINE: line over 100 characters #32: FILE: drivers/gpu/drm/i915/i915_reg.h:10280:
+ _PLANE_CSC_RY_GY_1(pipe) + (index) * 4, \
-:45: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #45: FILE: drivers/gpu/drm/i915/i915_reg.h:10293:
+#define PLANE_CSC_PREOFF(pipe, plane, index) _MMIO_PLANE(plane, _PLANE_CSC_PREOFF_HI_1(pipe) + \
+ (index) * 4, _PLANE_CSC_PREOFF_HI_2(pipe) + \
+ (index) * 4)
-:45: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects? #45: FILE: drivers/gpu/drm/i915/i915_reg.h:10293:
+#define PLANE_CSC_PREOFF(pipe, plane, index) _MMIO_PLANE(plane, _PLANE_CSC_PREOFF_HI_1(pipe) + \
+ (index) * 4, _PLANE_CSC_PREOFF_HI_2(pipe) + \
+ (index) * 4)
-:46: WARNING:LONG_LINE: line over 100 characters #46: FILE: drivers/gpu/drm/i915/i915_reg.h:10294:
+ (index) * 4, _PLANE_CSC_PREOFF_HI_2(pipe) + \
-:59: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #59: FILE: drivers/gpu/drm/i915/i915_reg.h:10307:
+#define PLANE_CSC_POSTOFF(pipe, plane, index) _MMIO_PLANE(plane, _PLANE_CSC_POSTOFF_HI_1(pipe) + \
+ (index) * 4, _PLANE_CSC_POSTOFF_HI_2(pipe) + \
+ (index) * 4)
-:59: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects? #59: FILE: drivers/gpu/drm/i915/i915_reg.h:10307:
+#define PLANE_CSC_POSTOFF(pipe, plane, index) _MMIO_PLANE(plane, _PLANE_CSC_POSTOFF_HI_1(pipe) + \
+ (index) * 4, _PLANE_CSC_POSTOFF_HI_2(pipe) + \
+ (index) * 4)
-:60: WARNING:LONG_LINE: line over 100 characters #60: FILE: drivers/gpu/drm/i915/i915_reg.h:10308:
+ (index) * 4, _PLANE_CSC_POSTOFF_HI_2(pipe) + \
total: 0 errors, 3 warnings, 6 checks, 50 lines checked 0193721b12d3 drm/i915: Enable Plane CSC
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.SPARSE: warning for Add Plane Color Properties (rev6)
In reply to Uma Shankar== Series Details ==
== Series Details ==
Series: Add Plane Color Properties (rev6)
URL : https://patchwork.freedesktop.org/series/30875/
State : warning
== Summary ==
$ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm: Add Enhanced Gamma LUT precision structure +drivers/gpu/drm/drm_color_mgmt.c:146:45: warning: expression using sizeof(void) +drivers/gpu/drm/drm_color_mgmt.c:146:45: warning: expression using sizeof(void) +drivers/gpu/drm/drm_color_mgmt.c:146:45: warning: expression using sizeof(void) +drivers/gpu/drm/drm_color_mgmt.c:146:45: warning: expression using sizeof(void) +drivers/gpu/drm/drm_color_mgmt.c:146:45: warning: expression using sizeof(void) +drivers/gpu/drm/drm_color_mgmt.c:146:45: warning: expression using sizeof(void) +drivers/gpu/drm/drm_color_mgmt.c:146:45: warning: expression using sizeof(void) +drivers/gpu/drm/drm_color_mgmt.c:146:45: warning: expression using sizeof(void)
Commit: drm: Add Plane Degamma properties
Okay!
Commit: drm: Add Plane CTM property
Okay!
Commit: drm: Add Plane Gamma properties
Okay!
Commit: drm: Define helper function for plane color enabling Okay!
Commit: drm/i915: Enable plane color features -drivers/gpu/drm/i915/selftests/../i915_drv.h:3558:16: warning: expression using sizeof(void) +drivers/gpu/drm/i915/selftests/../i915_drv.h:3564:16: warning: expression using sizeof(void)
Commit: drm/i915: Implement Plane Gamma for Bdw and Gen9 platforms Okay!
Commit: drm/i915: Load plane color luts from atomic flip Okay!
Commit: drm/i915: Add plane color capabilities
Okay!
Commit: drm/i915/icl: Add ICL Plane Degamma Register definition Okay!
Commit: drm/i915/icl: Enable Plane Degamma +drivers/gpu/drm/i915/intel_color.c:635:55: warning: constant 0x7ffffffff is so big it is long
Commit: drm/i915/icl: Add Plane Gamma Register Definitions Okay!
Commit: drm/i915/icl: Implement Plane Gamma +drivers/gpu/drm/i915/intel_color.c:711:55: warning: constant 0x7ffffffff is so big it is long
Commit: drm/i915: Enable Plane Gamma/Degamma
Okay!
Commit: drm/i915: Define Plane CSC Registers
Okay!
Commit: drm/i915: Enable Plane CSC +drivers/gpu/drm/i915/intel_color.c:635:37: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:635:37: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:635:37: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:635:37: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:635:37: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:635:37: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:635:37: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:643:41: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:643:41: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:643:41: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:643:41: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:643:41: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:643:41: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:643:41: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:646:41: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:646:41: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:646:41: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:646:41: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:646:41: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:646:41: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:646:41: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:649:41: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:649:41: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:649:41: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:649:41: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:649:41: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:649:41: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:649:41: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:651:46: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:651:46: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:651:46: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:651:46: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:651:46: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_color.c:651:46: warning: too many warnings
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for Add Plane Color Properties (rev6)
In reply to Uma Shankar== Series Details ==
== Series Details ==
Series: Add Plane Color Properties (rev6)
URL : https://patchwork.freedesktop.org/series/30875/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5771 -> Patchwork_12510
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/30875/revisions/6/mbox/
Known issues
------------
Here are the changes found in Patchwork_12510 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: PASS -> DMESG-WARN [fdo#108965]
* igt@amdgpu/amd_cs_nop@sync-gfx0:
- fi-kbl-7567u: NOTRUN -> SKIP [fdo#109271] +33
* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: PASS -> FAIL [fdo#103167]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
- fi-byt-clapper: PASS -> FAIL [fdo#107362]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-skl-6260u: PASS -> INCOMPLETE [fdo#104108]
#### Possible fixes ####
* igt@i915_selftest@live_execlists:
- fi-apl-guc: INCOMPLETE [fdo#103927] / [fdo#109720] -> PASS
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS +1
* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-byt-clapper: FAIL [fdo#107362] -> PASS
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
Participating hosts (47 -> 37)
------------------------------
Additional (1): fi-kbl-7567u
Missing (11): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bxt-j4205 fi-icl-y fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_5771 -> Patchwork_12510
CI_DRM_5771: c1500eaf9d004539bbc2b7458c6cbe3f6a6147dc @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4888: 71ad19eb8fe4f0eecae3bf063e107293b90b9abc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12510: 0193721b12d3e2e551e496c40ebf312a2ad8d577 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
0193721b12d3 drm/i915: Enable Plane CSC723fb9c0bb23 drm/i915: Define Plane CSC Registers d4c386908867 drm/i915: Enable Plane Gamma/Degamma d2c749cba6ef drm/i915/icl: Implement Plane Gamma dc49d1b1bc11 drm/i915/icl: Add Plane Gamma Register Definitions 6db8c958bceb drm/i915/icl: Enable Plane Degamma415f57b6a941 drm/i915/icl: Add ICL Plane Degamma Register definition eba9f1c9b828 drm/i915: Add plane color capabilities fe57d6db3259 drm/i915: Load plane color luts from atomic flip 3b9c169dbec3 drm/i915: Implement Plane Gamma for Bdw and Gen9 platforms a469bd374d08 drm/i915: Enable plane color features aa2c66edd9cb drm: Define helper function for plane color enabling 874066e51de7 drm: Add Plane Gamma properties6d1310f593e8 drm: Add Plane CTM propertycb4da76aa060 drm: Add Plane Degamma propertiesac8ffabdea94 drm: Add Enhanced Gamma LUT precision structure
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12510/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for Add Plane Color Properties (rev6)
In reply to Uma Shankar== Series Details ==
== Series Details ==
Series: Add Plane Color Properties (rev6)
URL : https://patchwork.freedesktop.org/series/30875/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5771_full -> Patchwork_12510_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_12510_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_param@invalid-param-get:
- shard-apl: NOTRUN -> FAIL [fdo#109559]
* igt@gem_ctx_param@invalid-param-set:
- shard-apl: NOTRUN -> FAIL [fdo#109674]
* igt@gem_exec_parse@basic-allowed:
- shard-iclb: NOTRUN -> SKIP [fdo#109289] +1
* igt@gem_exec_schedule@wide-render:
- shard-iclb: PASS -> FAIL [fdo#109633]
* igt@gem_mocs_settings@mocs-reset-vebox:
- shard-iclb: NOTRUN -> SKIP [fdo#109287]
* igt@gem_pwrite@huge-gtt-backwards:
- shard-iclb: NOTRUN -> SKIP [fdo#109290]
* igt@gem_softpin@noreloc-s3:
- shard-apl: PASS -> DMESG-WARN [fdo#108566]
* igt@gem_stolen@stolen-no-mmap:
- shard-iclb: NOTRUN -> SKIP [fdo#109277]
* igt@i915_pm_rpm@modeset-lpsp-stress:
- shard-apl: NOTRUN -> SKIP [fdo#105602] / [fdo#109271] +15
* igt@i915_selftest@live_workarounds:
- shard-iclb: PASS -> DMESG-FAIL [fdo#108954]
* igt@kms_atomic_transition@plane-toggle-modeset-transition:
- shard-apl: PASS -> DMESG-FAIL [fdo#103558] / [fdo#105602]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-apl: NOTRUN -> DMESG-WARN [fdo#107956] +3
* igt@kms_busy@extended-modeset-hang-oldfb-with-reset-render-e:
- shard-apl: NOTRUN -> SKIP [fdo#105602] / [fdo#109271] / [fdo#109278]
* igt@kms_chamelium@hdmi-crc-abgr8888:
- shard-iclb: NOTRUN -> SKIP [fdo#109284] +1
* igt@kms_color@pipe-a-ctm-max:
- shard-skl: PASS -> FAIL [fdo#108147]
* igt@kms_color@pipe-c-degamma:
- shard-iclb: NOTRUN -> FAIL [fdo#104782]
* igt@kms_cursor_crc@cursor-128x128-onscreen:
- shard-skl: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-512x512-dpms:
- shard-iclb: NOTRUN -> SKIP [fdo#109279]
* igt@kms_cursor_crc@cursor-64x21-random:
- shard-apl: PASS -> FAIL [fdo#103232] +4
* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-apl: PASS -> FAIL [fdo#109350]
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-ytiled:
- shard-apl: PASS -> DMESG-WARN [fdo#103558] / [fdo#105602] +32
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled:
- shard-skl: PASS -> FAIL [fdo#103184]
* igt@kms_flip@2x-modeset-vs-vblank-race:
- shard-iclb: NOTRUN -> SKIP [fdo#109274]
* igt@kms_flip@2x-plain-flip-ts-check:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +193
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-pwrite:
- shard-iclb: PASS -> FAIL [fdo#103167] +6
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-apl: NOTRUN -> DMESG-FAIL [fdo#103167] / [fdo#103558] / [fdo#105602]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-apl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-apl: NOTRUN -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-gtt:
- shard-iclb: PASS -> FAIL [fdo#109247] +16
* igt@kms_frontbuffer_tracking@fbcpsr-2p-indfb-fliptrack:
- shard-skl: NOTRUN -> SKIP [fdo#109271] +1
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-gtt:
- shard-iclb: NOTRUN -> SKIP [fdo#109280] +7
* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-wc:
- shard-iclb: PASS -> FAIL [fdo#105682] / [fdo#109247]
* igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-gtt:
- shard-skl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-blt:
- shard-iclb: NOTRUN -> FAIL [fdo#109247] +2
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +16
* igt@kms_pipe_crc_basic@read-crc-pipe-e:
- shard-iclb: NOTRUN -> SKIP [fdo#109278] +2
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-apl: NOTRUN -> DMESG-FAIL [fdo#103558] / [fdo#105602] / [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: PASS -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb:
- shard-apl: NOTRUN -> FAIL [fdo#108145] +2
* igt@kms_psr2_su@page_flip:
- shard-iclb: NOTRUN -> SKIP [fdo#109642]
* igt@kms_psr@primary_blt:
- shard-iclb: PASS -> FAIL [fdo#107383] +4
* igt@kms_psr@psr2_basic:
- shard-iclb: PASS -> SKIP [fdo#109441] +1
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: PASS -> DMESG-FAIL [fdo#105763]
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-d:
- shard-skl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-iclb: PASS -> FAIL [fdo#104894]
* igt@kms_vblank@pipe-c-query-busy:
- shard-apl: NOTRUN -> DMESG-WARN [fdo#103558] / [fdo#105602] +14
* igt@kms_vblank@pipe-c-ts-continuation-modeset-rpm:
- shard-apl: NOTRUN -> FAIL [fdo#104894]
* igt@prime_nv_api@nv_self_import_to_different_fd:
- shard-iclb: NOTRUN -> SKIP [fdo#109291]
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: NOTRUN -> SKIP [fdo#109276] +3
* igt@sw_sync@sync_busy_fork_unixsocket:
- shard-apl: NOTRUN -> FAIL [fdo#110150 ]
* igt@tools_test@tools_test:
- shard-skl: PASS -> SKIP [fdo#109271]
#### Possible fixes ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-skl: INCOMPLETE [fdo#104108] / [fdo#107773] -> PASS
* igt@kms_busy@extended-modeset-hang-newfb-render-b:
- shard-hsw: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_cursor_crc@cursor-128x42-offscreen:
- shard-skl: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-apl: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-glk: FAIL [fdo#109350] -> PASS
* igt@kms_fbcon_fbt@fbc:
- shard-iclb: DMESG-WARN [fdo#109593] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-iclb: FAIL [fdo#103167] -> PASS +9
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: FAIL [fdo#103167] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: FAIL [fdo#103375] -> PASS
* igt@kms_frontbuffer_tracking@fbcpsr-1p-rte:
- shard-iclb: FAIL [fdo#105682] / [fdo#109247] -> PASS
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-fullscreen:
- shard-iclb: FAIL [fdo#109247] -> PASS +19
* {igt@kms_plane@pixel-format-pipe-c-planes-source-clamping}:
- shard-iclb: FAIL -> PASS
* {igt@kms_plane@plane-position-covered-pipe-a-planes}:
- shard-iclb: FAIL [fdo#110038] -> PASS
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: FAIL [fdo#108145] -> PASS
* {igt@kms_plane_multiple@atomic-pipe-a-tiling-y}:
- shard-iclb: FAIL [fdo#110037] -> PASS +1
* {igt@kms_plane_multiple@atomic-pipe-c-tiling-none}:
- shard-apl: FAIL [fdo#110037] -> PASS
* igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping:
- shard-glk: SKIP [fdo#109271] / [fdo#109278] -> PASS
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: SKIP [fdo#109441] -> PASS +2
* igt@kms_psr@sprite_mmap_gtt:
- shard-iclb: FAIL [fdo#107383] -> PASS +4
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: FAIL [fdo#109016] -> PASS
* igt@kms_setmode@basic:
- shard-kbl: FAIL [fdo#99912] -> PASS
#### Warnings ####
* igt@kms_content_protection@atomic:
- shard-apl: FAIL [fdo#108597] / [fdo#108739] -> DMESG-FAIL [fdo#103558] / [fdo#105602]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-apl: FAIL [fdo#108145] -> DMESG-FAIL [fdo#103558] / [fdo#105602] / [fdo#108145]
* igt@kms_plane_scaling@pipe-a-scaler-with-pixel-format:
- shard-glk: FAIL [fdo#110098] -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@runner@aborted:
- shard-apl: ( 9 FAIL ) [fdo#109373] -> ( 2 FAIL ) [fdo#109373]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108597]: https://bugs.freedesktop.org/show_bug.cgi?id=108597
[fdo#108739]: https://bugs.freedesktop.org/show_bug.cgi?id=108739
[fdo#108954]: https://bugs.freedesktop.org/show_bug.cgi?id=108954
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109277]: https://bugs.freedesktop.org/show_bug.cgi?id=109277
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109287]: https://bugs.freedesktop.org/show_bug.cgi?id=109287
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109290]: https://bugs.freedesktop.org/show_bug.cgi?id=109290
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[fdo#109373]: https://bugs.freedesktop.org/show_bug.cgi?id=109373
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109559]: https://bugs.freedesktop.org/show_bug.cgi?id=109559
[fdo#109593]: https://bugs.freedesktop.org/show_bug.cgi?id=109593
[fdo#109633]: https://bugs.freedesktop.org/show_bug.cgi?id=109633
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#109674]: https://bugs.freedesktop.org/show_bug.cgi?id=109674
[fdo#110037]: https://bugs.freedesktop.org/show_bug.cgi?id=110037
[fdo#110038]: https://bugs.freedesktop.org/show_bug.cgi?id=110038
[fdo#110098]: https://bugs.freedesktop.org/show_bug.cgi?id=110098
[fdo#110150 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110150
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_5771 -> Patchwork_12510
CI_DRM_5771: c1500eaf9d004539bbc2b7458c6cbe3f6a6147dc @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4888: 71ad19eb8fe4f0eecae3bf063e107293b90b9abc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12510: 0193721b12d3e2e551e496c40ebf312a2ad8d577 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12510/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx