Skip to contentSkip to conversation

net/i40e: add warning info when no perfect RSS key

PATCH Superseded Wei Zhao 5 participants 11 messages Mar 20, 2019 – Mar 26, 2019 Network drivers

lore
Share & tools
lore

Wei Zhao

author
#0 lore raw

PATCH 1/1 net/i40e: add warning info when no perfect RSS key

There need a warning info when no perfect RSS key is config, so i40e will use default key.

Fixes ecad87d22383 ("net/i40e: move RSS to flow API")
---
 drivers/net/i40e/i40e_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/i40e/i40e_ethdev.c +1 -0
index dca61f0..9235b08 100644
@@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
 		rss_conf.rss_key = (uint8_t *)rss_key_default;
 		rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
 							sizeof(uint32_t);
+		PMD_DRV_LOG(INFO, "Warning! No perfect RSS key config for i40e, so use default configuration\n");
 	}
 
 	i40e_hw_rss_hash_set(pf, &rss_conf);
Signature · 1 line
2.7.5
Tested-by on v1 1/1
#1 lore raw

- Tested Branch: master
- Tested Commit: 239912fa798e6e671072ca7ff987afd74c1e506c
- OS: 4.13.9-300.fc27.x86_64
- GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
- CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz
- NIC: Intel Corporation Device Fortville [8086:1583]
- Default x86_64-native-linuxapp-gcc configuration
- Prerequisites:
- Total 1 case1, 1 passed, 0 failed

- Case steps:
1. Bind the pf port to dpdk driver:
./usertools/dpdk-devbind.py -b igb_uio 05:00.0 05:00.1
2. start testpmd:
./x86_64-native-linuxapp-gcc/app/testpmd --log-level=*:8 -c 1ffff -n 4 - -i --nb-cores=8 --rxq=4 --txq=4 --port-topology=chained

3. set an invalid RSS-key
testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end key 67108863 / end i40e_config_rss_filter(): Max of contiguous 4 PF queues are configured i40e_config_rss_filter(): Warning! No perfect RSS key config for i40e, so use default configuration

Flow rule #0 created
there is a device warning reported.

-----Original Message-----
From: Zhao1, Wei
Sent: Wednesday, March 20, 2019 11:31 AM
To: [email protected]
Cc: Peng, Yuan <[email protected]>; [email protected]; Zhang, Qi Z <[email protected]>; Zhao1, Wei <[email protected]>
Subject: [PATCH] net/i40e: add warning info when no perfect RSS key

There need a warning info when no perfect RSS key is config, so i40e will use default key.

Fixes ecad87d22383 ("net/i40e: move RSS to flow API")
---
 drivers/net/i40e/i40e_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/i40e/i40e_ethdev.c +2 -0
@@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
 		rss_conf.rss_key = (uint8_t *)rss_key_default;
 		rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
 							sizeof(uint32_t);
+		PMD_DRV_LOG(INFO, "Warning! No perfect RSS key config for i40e, so 
+use default configuration\n");
 	}
 

i40e_hw_rss_hash_set(pf, &rss_conf);
--
2.7.5

author
#2 lore raw

Thank you!

Quoted 71 lines

-----Original Message-----
From: Peng, Yuan
Sent: Wednesday, March 20, 2019 5:21 PM
To: Zhao1, Wei <[email protected]>; [email protected]
Cc: [email protected]; Zhang, Qi Z <[email protected]>
Subject: RE: [PATCH] net/i40e: add warning info when no perfect RSS key

- Tested Branch: master
- Tested Commit: 239912fa798e6e671072ca7ff987afd74c1e506c
- OS: 4.13.9-300.fc27.x86_64
- GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
- CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz
- NIC: Intel Corporation Device Fortville [8086:1583]
- Default x86_64-native-linuxapp-gcc configuration
- Prerequisites:
- Total 1 case1, 1 passed, 0 failed

- Case steps:
1. Bind the pf port to dpdk driver:
./usertools/dpdk-devbind.py -b igb_uio 05:00.0 05:00.1 2. start testpmd:
./x86_64-native-linuxapp-gcc/app/testpmd --log-level=*:8 -c 1ffff -n 4 - -i -- nb-cores=8 --rxq=4 --txq=4 --port-topology=chained

3. set an invalid RSS-key
testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end
key 67108863 / end
i40e_config_rss_filter(): Max of contiguous 4 PF queues are configured i40e_config_rss_filter(): Warning! No perfect RSS key config for i40e, so use
default configuration

Flow rule #0 created
there is a device warning reported.

-----Original Message-----
From: Zhao1, Wei
Sent: Wednesday, March 20, 2019 11:31 AM
To: [email protected]
Cc: Peng, Yuan <[email protected]>; [email protected]; Zhang, Qi Z <[email protected]>; Zhao1, Wei <[email protected]>
Subject: [PATCH] net/i40e: add warning info when no perfect RSS key

There need a warning info when no perfect RSS key is config, so i40e will use default key.

Fixes ecad87d22383 ("net/i40e: move RSS to flow API")
---
 drivers/net/i40e/i40e_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/i40e/i40e_ethdev.c +1 -0
index dca61f0..9235b08 100644
@@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
 		rss_conf.rss_key = (uint8_t *)rss_key_default;
 		rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
 							sizeof(uint32_t);
+		PMD_DRV_LOG(INFO, "Warning! No perfect RSS key config

for i40e, so

drivers/net/i40e/i40e_ethdev.c +1 -1
+use default configuration\n");
 	}
 
 	i40e_hw_rss_hash_set(pf, &rss_conf);
--

2.7.5

#3 lore raw
In reply to Wei Zhao
Quoted 1 line · Wei Zhao

There need a warning info when no perfect RSS key is config,

It is mixing info and warning levels in the description and log. Better to be consistent and use one (I think info).

Quoted 15 lines

so i40e will use default key.

Fixes ecad87d22383 ("net/i40e: move RSS to flow API")
---
 drivers/net/i40e/i40e_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/i40e/i40e_ethdev.c +0 -0
index dca61f0..9235b08 100644

drivers/net/i40e/i40e_ethdev.c i40e_config_rss_filter(struct i40e_pf *pf, · line 12747

Quoted 4 lines
drivers/net/i40e/i40e_ethdev.c +1 -0
@@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
 		rss_conf.rss_key = (uint8_t *)rss_key_default;
 		rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
 							sizeof(uint32_t);
+		PMD_DRV_LOG(INFO, "Warning! No perfect RSS key config for i40e, so use default configuration\n");

It's an info log, so remove "Warning!" and the message can be a little clearer so user doesn't interpret as an instruction. Suggest "No RSS key config for i40e provided, using default"

Quoted 4 lines
drivers/net/i40e/i40e_ethdev.c +0 -0
 	}
 
 	i40e_hw_rss_hash_set(pf, &rss_conf);
author
#4 lore raw
Quoted 11 lines

-----Original Message-----
From: Kevin Traynor [mailto:[email protected]]
Sent: Wednesday, March 20, 2019 8:21 PM
To: Zhao1, Wei <[email protected]>; [email protected]
Cc: Peng, Yuan <[email protected]>; [email protected]; Zhang, Qi Z <[email protected]>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key

Quoted 6 lines
Quoted 1 line · Wei Zhao

There need a warning info when no perfect RSS key is config,

It is mixing info and warning levels in the description and log. Better to be consistent and use one (I think info).

Ok, we will use dev info.

Quoted 20 lines
Quoted 15 lines

so i40e will use default key.

Fixes ecad87d22383 ("net/i40e: move RSS to flow API")
---
 drivers/net/i40e/i40e_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/drivers/net/i40e/i40e_ethdev.c index dca61f0..9235b08 100644

drivers/net/i40e/i40e_ethdev.c i40e_config_rss_filter(struct i40e_pf *pf, · line 12747

Quoted 4 lines
drivers/net/i40e/i40e_ethdev.c +1 -0
@@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
 		rss_conf.rss_key = (uint8_t *)rss_key_default;
 		rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
 							sizeof(uint32_t);
+		PMD_DRV_LOG(INFO, "Warning! No perfect RSS key config

for i40e, so

Quoted 5 lines

drivers/net/i40e/i40e_ethdev.c i40e_config_rss_filter(struct i40e_pf *pf, · line 12748

Quoted 1 line
drivers/net/i40e/i40e_ethdev.c +1 -0
+use default configuration\n");

It's an info log, so remove "Warning!" and the message can be a little clearer so user doesn't interpret as an instruction. Suggest "No RSS key config for i40e provided, using default"

Ok , change in v2

Quoted 5 lines
Quoted 5 lines
drivers/net/i40e/i40e_ethdev.c +0 -0
 	}
 
 	i40e_hw_rss_hash_set(pf, &rss_conf);
author
#5 lore raw

PATCH v2 1/1 net/i40e: add warning info when no perfect RSS key

In reply to Wei Zhao

There need a warning info when no perfect RSS key is config, so i40e will use default key.

Fixes ecad87d22383 ("net/i40e: move RSS to flow API")

---

v2:
--update dev info message

---
 drivers/net/i40e/i40e_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/i40e/i40e_ethdev.c +1 -0
index dca61f0..89a55c1 100644
@@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
 		rss_conf.rss_key = (uint8_t *)rss_key_default;
 		rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
 							sizeof(uint32_t);
+		PMD_DRV_LOG(INFO, "No perfect RSS key config for i40e, using default\n");
 	}
 
 	i40e_hw_rss_hash_set(pf, &rss_conf);
Signature · 1 line
2.7.5
author
#6 lore raw

PATCH v2 1/1 net/i40e: add warning info when no perfect RSS key

In reply to Wei Zhao

There need a warning info when no perfect RSS key is config, so i40e will use default key.

Fixes ecad87d22383 ("net/i40e: move RSS to flow API")

---

v2:
--update dev info message

---
 drivers/net/i40e/i40e_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/i40e/i40e_ethdev.c +1 -0
index dca61f0..89a55c1 100644
@@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
 		rss_conf.rss_key = (uint8_t *)rss_key_default;
 		rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
 							sizeof(uint32_t);
+		PMD_DRV_LOG(INFO, "No perfect RSS key config for i40e, using default\n");
 	}
 
 	i40e_hw_rss_hash_set(pf, &rss_conf);
Signature · 1 line
2.7.5
Acked-by on v2 1/1 Applied
#7 lore raw
Quoted 10 lines

-----Original Message-----
From: Zhao1, Wei
Sent: Friday, March 22, 2019 11:07 AM
To: [email protected]
Cc: [email protected]; Zhang, Qi Z <[email protected]>; [email protected]; Zhao1, Wei <[email protected]>
Subject: [PATCH v2] net/i40e: add warning info when no perfect RSS key

Quoted 8 lines

There need a warning info when no perfect RSS key is config, so i40e will use default key.

Fixes ecad87d22383 ("net/i40e: move RSS to flow API")

Applied to dpdk-next-net-intel.

Thanks
Qi

author
#8 lore raw

PATCH v3 1/1 net/i40e: log when provided RSS key is not valid

In reply to Wei Zhao

A log message is required when provided RSS key is not valid so that driver will use the default RSS key.

Fixes ecad87d22383 ("net/i40e: move RSS to flow API")

---

v2:
update dev info message

v3:
update log info

---
 drivers/net/i40e/i40e_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/i40e/i40e_ethdev.c +1 -0
index 63ec813..5472312 100644
@@ -12745,6 +12745,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
 		rss_conf.rss_key = (uint8_t *)rss_key_default;
 		rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
 							sizeof(uint32_t);
+		PMD_DRV_LOG(INFO, "No perfect RSS key config for i40e, using default\n");
 	}
 
 	i40e_hw_rss_hash_set(pf, &rss_conf);
Signature · 1 line
2.7.5
Acked-by on v3 1/1 Applied
#9 lore raw

Re: [PATCH v3] net/i40e: log when provided RSS key is not valid

Quoted 35 lines

-----Original Message-----
From: Zhao1, Wei
Sent: Tuesday, March 26, 2019 4:35 PM
To: [email protected]
Cc: [email protected]; Zhang, Qi Z <[email protected]>; Yigit, Ferruh <[email protected]>; Zhao1, Wei <[email protected]>
Subject: [PATCH v3] net/i40e: log when provided RSS key is not valid

A log message is required when provided RSS key is not valid so that driver will use the default RSS key.

Fixes ecad87d22383 ("net/i40e: move RSS to flow API")

---

v2:
update dev info message

v3:
update log info

---
 drivers/net/i40e/i40e_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/i40e/i40e_ethdev.c +0 -0
index 63ec813..5472312 100644

drivers/net/i40e/i40e_ethdev.c i40e_config_rss_filter(struct i40e_pf *pf, · line 12749

Quoted 5 lines
drivers/net/i40e/i40e_ethdev.c +2 -0
@@ -12745,6 +12745,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
 		rss_conf.rss_key = (uint8_t *)rss_key_default;
 		rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
 							sizeof(uint32_t);
+		PMD_DRV_LOG(INFO, "No perfect RSS key config for i40e, using
+default\n");

s/perfect/valid to align with the title

Applied to dpdk-next-net-intel.

Thanks
Qi

Quoted 5 lines
drivers/net/i40e/i40e_ethdev.c +0 -1
 	}
 
 	i40e_hw_rss_hash_set(pf, &rss_conf);
--

2.7.5

#10 lore raw

Re: [PATCH v3] net/i40e: log when provided RSS key is not valid

Quoted 43 lines · Qi Z
Quoted 35 lines

-----Original Message-----
From: Zhao1, Wei
Sent: Tuesday, March 26, 2019 4:35 PM
To: [email protected]
Cc: [email protected]; Zhang, Qi Z <[email protected]>; Yigit, Ferruh <[email protected]>; Zhao1, Wei <[email protected]>
Subject: [PATCH v3] net/i40e: log when provided RSS key is not valid

A log message is required when provided RSS key is not valid so that driver will use the default RSS key.

Fixes ecad87d22383 ("net/i40e: move RSS to flow API")

---

v2:
update dev info message

v3:
update log info

---
 drivers/net/i40e/i40e_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/i40e/i40e_ethdev.c +0 -0
index 63ec813..5472312 100644

drivers/net/i40e/i40e_ethdev.c i40e_config_rss_filter(struct i40e_pf *pf, · line 12749

Quoted 5 lines
drivers/net/i40e/i40e_ethdev.c +2 -0
@@ -12745,6 +12745,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
 		rss_conf.rss_key = (uint8_t *)rss_key_default;
 		rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
 							sizeof(uint32_t);
+		PMD_DRV_LOG(INFO, "No perfect RSS key config for i40e, using
+default\n");

s/perfect/valid to align with the title

Quoted 3 lines

Applied to dpdk-next-net-intel.

Message carried into next line to keep line length < 80 while merging next-net:

    PMD_DRV_LOG(INFO,
            "No valid RSS key config for i40e, using default\n");