patch "usb: xhci: dbc: Don't free all memory with spinlock held" added to usb-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
usb: xhci: dbc: Don't free all memory with spinlock held
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
From 8867ea262196a6945c24a0fb739575af646ec0e9 Mon Sep 17 00:00:00 2001
From: Mathias Nyman <[email protected]>
Date: Fri, 22 Mar 2019 17:50:16 +0200
Subject: usb: xhci: dbc: Don't free all memory with spinlock held
The xhci debug capability (DbC) feature did its memory cleanup with spinlock held. dma_free_coherent() warns if called with interrupts disabled
move the memory cleanup outside the spinlock
--- drivers/usb/host/xhci-dbgcap.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/usb/host/xhci-dbgcap.c +3 -2
@@ -516,7 +516,6 @@ static int xhci_do_dbc_stop(struct xhci_hcd *xhci)return -1 ;writel (0 , &dbc->regs->control); -xhci_dbc_mem_cleanup (xhci); dbc->state =DS_DISABLED ;return 0 ;
@@ -562,8 +561,10 @@ static void xhci_dbc_stop(struct xhci_hcd *xhci) ret =xhci_do_dbc_stop (xhci);spin_unlock_irqrestore (&dbc->lock, flags); -if (!ret) +if (!ret) { +xhci_dbc_mem_cleanup (xhci);pm_runtime_put_sync (xhci_to_hcd (xhci)->self.controller); + } } static void
Signature · 1 line
2.21.0