Skip to contentSkip to conversation

compress/isal: fix compression stream initialization

PATCH Superseded Tomasz Cel 4 participants 9 messages Mar 26, 2019 – Mar 29, 2019

lore
Share & tools
lore

Tomasz Cel

author
#0 lore raw

PATCH 1/1 compress/isal: fix compression stream initialization

This patch fixes ISAL internal state fields initialization.

Fixes dc49e6aa4879 ("compress/isal: add ISA-L compression functionality")
---
 drivers/compress/isal/isal_compress_pmd.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/compress/isal/isal_compress_pmd.c +1 -3
index 8879a42..1e518b3 100644
@@ -412,7 +412,7 @@ process_isal_deflate(struct rte_comp_op *op, struct isal_comp_qp *qp,
 	uint8_t *temp_level_buf = qp->stream->level_buf;
 
 	/* Initialize compression stream */
-	isal_deflate_stateless_init(qp->stream);
+	isal_deflate_init(qp->stream);
 
 	qp->stream->level_buf = temp_level_buf;
 
@@ -514,8 +514,6 @@ process_isal_deflate(struct rte_comp_op *op, struct isal_comp_qp *qp,
 		op->output_chksum = qp->stream->internal_state.crc;
 	}
 
-	isal_deflate_reset(qp->stream);
-
 	return ret;
 }
 
Signature · 1 line
2.7.4
#1 lore raw

Hi Tomasz,

Quoted 35 lines

-----Original Message-----
From: Cel, TomaszX
Sent: Tuesday, March 26, 2019 9:42 AM
To: [email protected]
Cc: [email protected]; Trahe, Fiona <[email protected]>; Daly, Lee <[email protected]>; Tucker, Greg B <[email protected]>; Jozwiak, TomaszX <[email protected]>
Subject: [PATCH] compress/isal: fix compression stream initialization

This patch fixes ISAL internal state fields initialization.

Fixes dc49e6aa4879 ("compress/isal: add ISA-L compression functionality")
---
 drivers/compress/isal/isal_compress_pmd.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/compress/isal/isal_compress_pmd.c +1 -1
index 8879a42..1e518b3 100644
@@ -412,7 +412,7 @@ process_isal_deflate(struct rte_comp_op *op, struct
 isal_comp_qp *qp,
 	uint8_t *temp_level_buf = qp->stream->level_buf;
 
 	/* Initialize compression stream */
-	isal_deflate_stateless_init(qp->stream);
+	isal_deflate_init(qp->stream);
 
 	qp->stream->level_buf = temp_level_buf;

drivers/compress/isal/isal_compress_pmd.c process_isal_deflate(struct rte_comp_op *op, struct · line 518

Quoted 5 lines
drivers/compress/isal/isal_compress_pmd.c +0 -1
@@ -514,8 +514,6 @@ process_isal_deflate(struct rte_comp_op *op, struct
 isal_comp_qp *qp,
 		op->output_chksum = qp->stream->internal_state.crc;
 	}
 
-	isal_deflate_reset(qp->stream);

I have tested this and it works, removing this reset function makes sense as everything cleared here is cleared in the init function anyway, On that note, the same is to be said to isal_inflate_reset, everything cleared in reset is cleared, plus more, in isal_inflate_init. I suggest we also remove isal_inflate_reset for commonality across both functions.

Quoted 6 lines
drivers/compress/isal/isal_compress_pmd.c +0 -2
-
 	return ret;
 }
 
--

2.7.4

author
#2 lore raw

PATCH v2 1/1 This patch fix compression stream initialization

In reply to Tomasz Cel

v2:
- removed isal_inflate_reset() function because is not neccesary, everything is cleared by the isal_inflate_init function at the begining

Tomasz Cel (1):
compress/isal: fix compression stream initialization

 drivers/compress/isal/isal_compress_pmd.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
Signature · 1 line
2.7.4
author
#3 lore raw

PATCH v2 1/1 compress/isal: fix compression stream initialization

This patch fixes ISAL internal state fields initialization.

Fixes dc49e6aa4879 ("compress/isal: add ISA-L compression functionality")
---
 drivers/compress/isal/isal_compress_pmd.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/compress/isal/isal_compress_pmd.c +1 -5
index 8879a42..ca1d703 100644
@@ -412,7 +412,7 @@ process_isal_deflate(struct rte_comp_op *op, struct isal_comp_qp *qp,
 	uint8_t *temp_level_buf = qp->stream->level_buf;
 
 	/* Initialize compression stream */
-	isal_deflate_stateless_init(qp->stream);
+	isal_deflate_init(qp->stream);
 
 	qp->stream->level_buf = temp_level_buf;
 
@@ -514,8 +514,6 @@ process_isal_deflate(struct rte_comp_op *op, struct isal_comp_qp *qp,
 		op->output_chksum = qp->stream->internal_state.crc;
 	}
 
-	isal_deflate_reset(qp->stream);
-
 	return ret;
 }
 
@@ -598,8 +596,6 @@ process_isal_inflate(struct rte_comp_op *op, struct isal_comp_qp *qp,
 	op->produced = qp->state->total_out;
 	op->output_chksum = qp->state->crc;
 
-	isal_inflate_reset(qp->state);
-
 	return ret;
 }
 
Signature · 1 line
2.7.4
author
#4 lore raw

v3 cover This patch fix compression stream initialization

In reply to Tomasz Cel

v3:
- fixed cover letter

v2:
- removed isal_inflate_reset() function because is not neccesary, everything is cleared by the isal_inflate_init function at the begining

Tomasz Cel (1):
compress/isal: fix compression stream initialization

 drivers/compress/isal/isal_compress_pmd.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
Signature · 1 line
2.7.4
author
#5 lore raw

PATCH v3 1/1 compress/isal: fix compression stream initialization

This patch fixes ISAL internal state fields initialization.

Fixes dc49e6aa4879 ("compress/isal: add ISA-L compression functionality")
---
 drivers/compress/isal/isal_compress_pmd.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/compress/isal/isal_compress_pmd.c +1 -5
index 8879a42..ca1d703 100644
@@ -412,7 +412,7 @@ process_isal_deflate(struct rte_comp_op *op, struct isal_comp_qp *qp,
 	uint8_t *temp_level_buf = qp->stream->level_buf;
 
 	/* Initialize compression stream */
-	isal_deflate_stateless_init(qp->stream);
+	isal_deflate_init(qp->stream);
 
 	qp->stream->level_buf = temp_level_buf;
 
@@ -514,8 +514,6 @@ process_isal_deflate(struct rte_comp_op *op, struct isal_comp_qp *qp,
 		op->output_chksum = qp->stream->internal_state.crc;
 	}
 
-	isal_deflate_reset(qp->stream);
-
 	return ret;
 }
 
@@ -598,8 +596,6 @@ process_isal_inflate(struct rte_comp_op *op, struct isal_comp_qp *qp,
 	op->produced = qp->state->total_out;
 	op->output_chksum = qp->state->crc;
 
-	isal_inflate_reset(qp->state);
-
 	return ret;
 }
 
Signature · 1 line
2.7.4
Acked-by on v3 1/1
#6 lore raw
Quoted 11 lines

-----Original Message-----
From: Cel, TomaszX
Sent: Thursday, March 28, 2019 9:06 AM
To: [email protected]
Cc: [email protected]; Trahe, Fiona <[email protected]>; Daly, Lee <[email protected]>; Tucker, Greg B <[email protected]>; Jozwiak, TomaszX <[email protected]>; Cel, TomaszX <[email protected]>
Subject: [PATCH v3 1/1] compress/isal: fix compression stream initialization

Quoted 6 lines

This patch fixes ISAL internal state fields initialization.

Fixes dc49e6aa4879 ("compress/isal: add ISA-L compression functionality")
Acked-by
#7 lore raw
Quoted 24 lines

-----Original Message-----
From: Trahe, Fiona
Sent: Thursday, March 28, 2019 12:59 PM
To: Cel, TomaszX <[email protected]>; [email protected]
Cc: [email protected]; Daly, Lee <[email protected]>; Tucker, Greg B <[email protected]>; Jozwiak, TomaszX <[email protected]>
Subject: RE: [PATCH v3 1/1] compress/isal: fix compression stream initialization

Quoted 11 lines

-----Original Message-----
From: Cel, TomaszX
Sent: Thursday, March 28, 2019 9:06 AM
To: [email protected]
Cc: [email protected]; Trahe, Fiona <[email protected]>; Daly, Lee <[email protected]>; Tucker, Greg B <[email protected]>; Jozwiak, TomaszX <[email protected]>; Cel, TomaszX <[email protected]>
Subject: [PATCH v3 1/1] compress/isal: fix compression stream initialization

Quoted 8 lines
Quoted 7 lines

This patch fixes ISAL internal state fields initialization.

Fixes dc49e6aa4879 ("compress/isal: add ISA-L compression

functionality")
Cc: [email protected]

Applied
#8 lore raw
Quoted 25 lines · Lee
Quoted 25 lines

-----Original Message-----
From: Trahe, Fiona
Sent: Thursday, March 28, 2019 12:59 PM
To: Cel, TomaszX <[email protected]>; [email protected]
Cc: [email protected]; Daly, Lee <[email protected]>; Tucker, Greg B <[email protected]>; Jozwiak, TomaszX <[email protected]>
Subject: RE: [PATCH v3 1/1] compress/isal: fix compression stream initialization

Quoted 13 lines

-----Original Message-----
From: Cel, TomaszX
Sent: Thursday, March 28, 2019 9:06 AM
To: [email protected]
Cc: [email protected]; Trahe, Fiona <[email protected]>; Daly, Lee <[email protected]>; Tucker, Greg B <[email protected]>; Jozwiak, TomaszX <[email protected]>; Cel, TomaszX <[email protected]>
Subject: [PATCH v3 1/1] compress/isal: fix compression stream initialization

This patch fixes ISAL internal state fields initialization.

Quoted 7 lines
Quoted 6 lines
Quoted 5 lines
Fixes dc49e6aa4879 ("compress/isal: add ISA-L compression

functionality")
Cc: [email protected]

Applied to dpdk-next-crypto

Thanks.