Skip to contentSkip to conversation

clocksource: Make clocksource insert entry more efficient

PATCH New Yongkai Wu 1 participant 1 message Mar 26, 2019 Timekeeping, clocksource core, NTP, alarmtimer

lore
Share & tools
lore

Yongkai Wu

author
#0 lore raw

PATCH 1/1 clocksource: Make clocksource insert entry more efficient

In clocksource_enqueue(), it is unnecessary to do entry = &tmp->list
in every loop,do it once in the last loop is enough.

---
 kernel/time/clocksource.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
kernel/time/clocksource.c +4 -3
index 3bcc19c..da4829b 100644
@@ -829,11 +829,12 @@ static void clocksource_enqueue(struct clocksource *cs)
 
 	list_for_each_entry(tmp, &clocksource_list, list) {
 		/* Keep track of the place, where to insert */
-		if (tmp->rating < cs->rating)
+		if (tmp->rating < cs->rating) {
+			entry = &tmp->list;
 			break;
-		entry = &tmp->list;
+		}
 	}
-	list_add(&cs->list, entry);
+	list_add_tail(&cs->list, entry);
 }
 
 /**
Signature · 1 line
1.8.3.1