Skip to contentSkip to conversation

witherspoon.dts: Enable the USB vhub (device)

PATCH New Adriana Kobylak 2 participants 2 messages Mar 26, 2019 – Mar 27, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 witherspoon.dts: Enable the USB vhub (device)

The Aspeed vhub device driver is already enabled in the defconfig, make use of it in the witherspoon platform.

---
 arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts +4 -0
index b933ced..8ebe35e 100644
@@ -634,6 +634,10 @@
 	memory-region = <&gfx_memory>;
 };
 
+&vhub {
+	status = "okay";
+};
+
 &pinctrl {
 	aspeed,external-nodes = <&gfx &lhc>;
 };
Signature · 1 line
1.8.3.1
maintainer
#1 lore raw

PATCH 1/1 witherspoon.dts: Enable the USB vhub (device)

Hi Adriana,

Quoted 5 lines · Adriana Kobylak

The Aspeed vhub device driver is already enabled in the defconfig, make use of it in the witherspoon platform.

The patch looks good. However it would be good if the commit message would follow the style used by other patches. Next time, do a git log of the file and see how others format their messages.'

$ git log --oneline arch/arm/boot/dts/aspeed-*
2b66ba56dca9 ARM: dts: aspeed: Add Power9 and Power9 CFAM description
82545da4069b ARM: dts: aspeed: Rename flash-controller nodes
58e953107de1 ARM: dts: palmetto: Fix flash_memory region
3b1433fac7ec ARM: dts: aspeed: tiogapass: Add sensors
36b64bb6dfa2 ARM: dts: aspeed: tiogapass: Enable KCS
7dd7e19bed04 ARM: dts: aspeed: Add KCS support for LPC BMC

I've applied the version of this patch that Eddie sent, so it should be all good.

Cheers,

Joel