Skip to contentSkip to conversation

net: dsa: Implement flow_dissect callback for tag_qca

PATCH Applied xiaofeis 5 participants 6 messages Mar 27, 2019 – Mar 28, 2019

Subsystems (5)
lore
Share & tools
lore

xiaofeis

author
#0 lore raw

PATCH 1/1 net: dsa: Implement flow_dissect callback for tag_qca

Add flow_dissect for qca tagged packet to get the right hash.

---
 net/dsa/tag_qca.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
net/dsa/tag_qca.c +10 -0
index e886a3c..f4b4de3 100644
@@ -113,8 +113,18 @@ static struct sk_buff *qca_tag_rcv(struct sk_buff *skb, struct net_device *dev,
 	return skb;
 }
 
+static int qca_tag_flow_dissect(const struct sk_buff *skb, __be16 *proto,
+                                int *offset)
+{
+	*offset = QCA_HDR_LEN;
+	*proto = ((__be16 *)skb->data)[0];
+
+	return 0;
+}
+
 const struct dsa_device_ops qca_netdev_ops = {
 	.xmit	= qca_tag_xmit,
 	.rcv	= qca_tag_rcv,
+	.flow_dissect = qca_tag_flow_dissect,
 	.overhead = QCA_HDR_LEN,
 };
Signature · 1 line
1.9.1
Reviewed-by on v1 1/1
#2 lore raw
In reply to xiaofeis
Quoted 1 line · xiaofeis

Add flow_dissect for qca tagged packet to get the right hash.

Ideally this patch should have been tagged as V2. Anyhow the change looks fine so:

Quoted 30 lines
---
 net/dsa/tag_qca.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
net/dsa/tag_qca.c +10 -0
index e886a3c..f4b4de3 100644
@@ -113,8 +113,18 @@ static struct sk_buff *qca_tag_rcv(struct sk_buff *skb, struct net_device *dev,
 	return skb;
 }
 
+static int qca_tag_flow_dissect(const struct sk_buff *skb, __be16 *proto,
+                                int *offset)
+{
+	*offset = QCA_HDR_LEN;
+	*proto = ((__be16 *)skb->data)[0];
+
+	return 0;
+}
+
 const struct dsa_device_ops qca_netdev_ops = {
 	.xmit	= qca_tag_xmit,
 	.rcv	= qca_tag_rcv,
+	.flow_dissect = qca_tag_flow_dissect,
 	.overhead = QCA_HDR_LEN,
 };
Signature · 1 line
1.9.1
Signature · 1 line
~Vinod
#3 lore raw
Quoted 32 lines · Vinod Koul
Quoted 1 line · xiaofeis

Add flow_dissect for qca tagged packet to get the right hash.

Ideally this patch should have been tagged as V2. Anyhow the change looks fine so:

Quoted 24 lines
---
 net/dsa/tag_qca.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
net/dsa/tag_qca.c +9 -0
index e886a3c..f4b4de3 100644
@@ -113,8 +113,18 @@ static struct sk_buff *qca_tag_rcv(struct sk_buff 
 *skb, struct net_device *dev,
 	return skb;
 }
 
+static int qca_tag_flow_dissect(const struct sk_buff *skb, __be16 
 *proto,
+                                int *offset)
+{
+	*offset = QCA_HDR_LEN;
+	*proto = ((__be16 *)skb->data)[0];
+
+	return 0;
+}
+
Quoted 8 lines
Quoted 8 lines
net/dsa/tag_qca.c +1 -0
 const struct dsa_device_ops qca_netdev_ops = {
 	.xmit	= qca_tag_xmit,
 	.rcv	= qca_tag_rcv,
+	.flow_dissect = qca_tag_flow_dissect,

.overhead = QCA_HDR_LEN,
};
--
1.9.1

Thanks Vinod, will take care next time.