net/ixgbe: enable 10Mb/s link setup for x553
PATCH 1/1 net/ixgbe: enable 10Mb/s link setup for x553
There is need to eanble 10Mb/s link foixgbe NIC of x553. This new device has own device id of 0x15E4 and 0x15E5, so ixgbe PMD driver need to special check when setup link for these two types of device.
--- drivers/net/ixgbe/ixgbe_ethdev.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)
drivers/net/ixgbe/ixgbe_ethdev.c +11 -1
@@ -2701,6 +2701,9 @@ static int eth_ixgbevf_pci_remove(struct rte_pci_device *pci_dev) allowed_speeds =ETH_LINK_SPEED_100M |ETH_LINK_SPEED_1G |ETH_LINK_SPEED_2_5G |ETH_LINK_SPEED_5G |ETH_LINK_SPEED_10G ; +if (hw->device_id ==IXGBE_DEV_ID_X550EM_A_1G_T || + hw->device_id ==IXGBE_DEV_ID_X550EM_A_1G_T_L ) + allowed_speeds |=ETH_LINK_SPEED_10M ;break ;default : allowed_speeds = ETH_LINK_SPEED_100M | ETH_LINK_SPEED_1G |
@@ -2708,6 +2711,7 @@ static int eth_ixgbevf_pci_remove(struct rte_pci_device *pci_dev) } link_speeds = &dev->data->dev_conf.link_speeds; + *link_speeds =ETH_LINK_SPEED_10M ;if (*link_speeds & ~allowed_speeds) {PMD_INIT_LOG (ERR ,"Invalid link setting" ); goto error;
@@ -2742,6 +2746,8 @@ static int eth_ixgbevf_pci_remove(struct rte_pci_device *pci_dev) speed |=IXGBE_LINK_SPEED_1GB_FULL ;if (*link_speeds Ð_LINK_SPEED_100M ) speed |=IXGBE_LINK_SPEED_100_FULL ; +if (*link_speeds Ð_LINK_SPEED_10M ) + speed |=IXGBE_LINK_SPEED_10_FULL ; } err =ixgbe_setup_link (hw, speed, link_up);
@@ -4061,8 +4067,12 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,switch (link_speed) {default :case IXGBE_LINK_SPEED_UNKNOWN : +if (hw->device_id ==IXGBE_DEV_ID_X550EM_A_1G_T || + hw->device_id ==IXGBE_DEV_ID_X550EM_A_1G_T_L ) + link.link_speed =ETH_SPEED_NUM_10M ; +else + link.link_speed =ETH_SPEED_NUM_100M ; link.link_duplex =ETH_LINK_FULL_DUPLEX ; - link.link_speed =ETH_SPEED_NUM_100M ;break ;case IXGBE_LINK_SPEED_100_FULL :
Signature · 1 line
1.8.3.1
PATCH v2 1/1 net/ixgbe: enable 10Mb/s link setup for x553
There is need to eanble 10Mb/s link foixgbe NIC of x553. This new device has own device id of 0x15E4 and 0x15E5, so ixgbe PMD driver need to special check when setup link for these two types of device.
---
v2:
delete test code and change permit link speed
--- drivers/net/ixgbe/ixgbe_ethdev.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)
drivers/net/ixgbe/ixgbe_ethdev.c +11 -1
@@ -2701,6 +2701,10 @@ static int eth_ixgbevf_pci_remove(struct rte_pci_device *pci_dev) allowed_speeds =ETH_LINK_SPEED_100M |ETH_LINK_SPEED_1G |ETH_LINK_SPEED_2_5G |ETH_LINK_SPEED_5G |ETH_LINK_SPEED_10G ; +if (hw->device_id ==IXGBE_DEV_ID_X550EM_A_1G_T || + hw->device_id ==IXGBE_DEV_ID_X550EM_A_1G_T_L ) + allowed_speeds =ETH_LINK_SPEED_10M | +ETH_LINK_SPEED_100M |ETH_LINK_SPEED_1G ;break ;default : allowed_speeds = ETH_LINK_SPEED_100M | ETH_LINK_SPEED_1G |
@@ -2742,6 +2746,8 @@ static int eth_ixgbevf_pci_remove(struct rte_pci_device *pci_dev) speed |=IXGBE_LINK_SPEED_1GB_FULL ;if (*link_speeds Ð_LINK_SPEED_100M ) speed |=IXGBE_LINK_SPEED_100_FULL ; +if (*link_speeds Ð_LINK_SPEED_10M ) + speed |=IXGBE_LINK_SPEED_10_FULL ; } err =ixgbe_setup_link (hw, speed, link_up);
@@ -4061,8 +4067,12 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,switch (link_speed) {default :case IXGBE_LINK_SPEED_UNKNOWN : +if (hw->device_id ==IXGBE_DEV_ID_X550EM_A_1G_T || + hw->device_id ==IXGBE_DEV_ID_X550EM_A_1G_T_L ) + link.link_speed =ETH_SPEED_NUM_10M ; +else + link.link_speed =ETH_SPEED_NUM_100M ; link.link_duplex =ETH_LINK_FULL_DUPLEX ; - link.link_speed =ETH_SPEED_NUM_100M ;break ;case IXGBE_LINK_SPEED_100_FULL :
Signature · 1 line
1.8.3.1
Quoted 10 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Wei Zhao
Sent: Friday, March 29, 2019 1:16 AM
To: [email protected]
Cc: Lu, Wenzhuo <[email protected]>; [email protected]; Zhang, Qi Z <[email protected]>; Zhao1, Wei <[email protected]>
Subject: [dpdk-dev] [PATCH v2] net/ixgbe: enable 10Mb/s link setup for x553There is need to eanble 10Mb/s link foixgbe NIC of x553.
Couple of typos, how about:
Enable 10Mb/s link for ixgbe x553.
Quoted 61 lines
This new device has own device id of
0x15E4and0x15E5, so ixgbe PMD driver need to special check when setup link for these two types of device.Signed-off-by Wei Zhao <[email protected]>---
v2:
delete test code and change permit link speed--- drivers/net/ixgbe/ixgbe_ethdev.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)drivers/net/ixgbe/ixgbe_ethdev.c +0
-0@@ -2701,6 +2701,10 @@ static int eth_ixgbevf_pci_remove(struct rte_pci_device *pci_dev) allowed_speeds = ETH_LINK_SPEED_100M |
ETH_LINK_SPEED_1G|drivers/net/ixgbe/ixgbe_ethdev.c +2
-0ETH_LINK_SPEED_2_5G |ETH_LINK_SPEED_5G | ETH_LINK_SPEED_10G; +if (hw->device_id ==IXGBE_DEV_ID_X550EM_A_1G_T || + hw->device_id ==
IXGBE_DEV_ID_X550EM_A_1G_T_L)drivers/net/ixgbe/ixgbe_ethdev.c +2
-0+ allowed_speeds =ETH_LINK_SPEED_10M | + ETH_LINK_SPEED_100M |
ETH_LINK_SPEED_1G;drivers/net/ixgbe/ixgbe_ethdev.c +0
-0break ;default : allowed_speeds = ETH_LINK_SPEED_100M |
ETH_LINK_SPEED_1G| @@ -2742,6 +2746,8 @@ static inteth_ixgbevf_pci_remove(struct rte_pci_device *pci_dev)drivers/net/ixgbe/ixgbe_ethdev.c +2
-0speed |=IXGBE_LINK_SPEED_1GB_FULL ;if (*link_speeds Ð_LINK_SPEED_100M ) speed |=IXGBE_LINK_SPEED_100_FULL ; +if (*link_speeds Ð_LINK_SPEED_10M ) + speed |=IXGBE_LINK_SPEED_10_FULL ; } err = ixgbe_setup_link(hw, speed, link_up); @@ -4061,8 +4067,12@@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct
rte_eth_dev*dev,drivers/net/ixgbe/ixgbe_ethdev.c +2
-0switch (link_speed) { default: case IXGBE_LINK_SPEED_UNKNOWN: + if (hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T || + hw->device_id ==
IXGBE_DEV_ID_X550EM_A_1G_T_L)drivers/net/ixgbe/ixgbe_ethdev.c +3
-2+ link.link_speed =ETH_SPEED_NUM_10M ; + else + link.link_speed = ETH_SPEED_NUM_100M; link.link_duplex =ETH_LINK_FULL_DUPLEX ; - link.link_speed =ETH_SPEED_NUM_100M ;break ;case IXGBE_LINK_SPEED_100_FULL : --1.8.3.1
Quoted 21 lines
-----Original Message-----
From: Stillwell Jr, Paul M
Sent: Saturday, March 30, 2019 2:47 AM
To: Zhao1, Wei <[email protected]>; [email protected]
Cc: Lu, Wenzhuo <[email protected]>; [email protected]; Zhang, Qi Z <[email protected]>; Zhao1, Wei <[email protected]>
Subject: RE: [dpdk-dev] [PATCH v2] net/ixgbe: enable 10Mb/s link setup for x553Quoted 9 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Wei Zhao
Sent: Friday, March 29, 2019 1:16 AM
To: [email protected]
Cc: Lu, Wenzhuo <[email protected]>; [email protected]; Zhang, Qi Z <[email protected]>; Zhao1, Wei <[email protected]>
Subject: [dpdk-dev] [PATCH v2] net/ixgbe: enable 10Mb/s link setup for x553
Quoted 5 lines
Quoted 1 line
There is need to eanble 10Mb/s link foixgbe NIC of x553.
Couple of typos, how about:
Enable 10Mb/s link for ixgbe x553.
Good, update in v2
Quoted 64 lines
Quoted 20 lines
This new device has own device id of
0x15E4and0x15E5, so ixgbe PMD driver need to special check when setup link for these two types of device.Signed-off-by Wei Zhao <[email protected]>---
v2:
delete test code and change permit link speed--- drivers/net/ixgbe/ixgbe_ethdev.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)drivers/net/ixgbe/ixgbe_ethdev.c +0
-0drivers/net/ixgbe/ixgbe_ethdev.c static int eth_ixgbevf_pci_remove(struct · line 2702
Quoted 2 lines
drivers/net/ixgbe/ixgbe_ethdev.c +0
-0@@ -2701,6 +2701,10 @@ static int eth_ixgbevf_pci_remove(struct rte_pci_device *pci_dev) allowed_speeds = ETH_LINK_SPEED_100M |
ETH_LINK_SPEED_1G|drivers/net/ixgbe/ixgbe_ethdev.c static int eth_ixgbevf_pci_remove(struct rte_pci_device *pci_dev)
Quoted 11 lines
drivers/net/ixgbe/ixgbe_ethdev.c +4
-0ETH_LINK_SPEED_2_5G |ETH_LINK_SPEED_5G |ETH_LINK_SPEED_10G ; +if (hw->device_id ==IXGBE_DEV_ID_X550EM_A_1G_T || + hw->device_id ==IXGBE_DEV_ID_X550EM_A_1G_T_L ) + allowed_speeds =ETH_LINK_SPEED_10M | +ETH_LINK_SPEED_100M |ETH_LINK_SPEED_1G ;drivers/net/ixgbe/ixgbe_ethdev.c +0
-0break ;default : allowed_speeds = ETH_LINK_SPEED_100M |
ETH_LINK_SPEED_1G| @@drivers/net/ixgbe/ixgbe_ethdev.c static int eth_ixgbevf_pci_remove(struct rte_pci_device *pci_dev)
Quoted 10 lines
-2742,6 +2746,8 @@ static int
eth_ixgbevf_pci_remove(struct rte_pci_device *pci_dev)drivers/net/ixgbe/ixgbe_ethdev.c +2
-0speed |=IXGBE_LINK_SPEED_1GB_FULL ;if (*link_speeds Ð_LINK_SPEED_100M ) speed |=IXGBE_LINK_SPEED_100_FULL ; +if (*link_speeds Ð_LINK_SPEED_10M ) + speed |=IXGBE_LINK_SPEED_10_FULL ; } err = ixgbe_setup_link(hw, speed, link_up); @@ -4061,8 +4067,12@@
Quoted 18 lines
static int ixgbevf_dev_xstats_get_names(__rte_unused struct
rte_eth_dev*dev,drivers/net/ixgbe/ixgbe_ethdev.c +2
-0switch (link_speed) { default: case IXGBE_LINK_SPEED_UNKNOWN: + if (hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T || + hw->device_id ==
IXGBE_DEV_ID_X550EM_A_1G_T_L)drivers/net/ixgbe/ixgbe_ethdev.c +3
-2+ link.link_speed =ETH_SPEED_NUM_10M ; + else + link.link_speed = ETH_SPEED_NUM_100M; link.link_duplex =ETH_LINK_FULL_DUPLEX ; - link.link_speed =ETH_SPEED_NUM_100M ;break ;case IXGBE_LINK_SPEED_100_FULL : --1.8.3.1
PATCH v3 1/1 net/ixgbe: enable 10Mb/s link setup for x553
In reply to Wei ZhaoThis patch enable 10Mb/s link for ixgbe x553. This new device has own device id of 0x15E4 and 0x15E5, so ixgbe PMD driver need to special check when setup link for these two types of device.
---
v2:
delete test code and change permit link speed
V3:
update git log info
--- drivers/net/ixgbe/ixgbe_ethdev.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)
drivers/net/ixgbe/ixgbe_ethdev.c +11 -1
@@ -2701,6 +2701,10 @@ static int eth_ixgbevf_pci_remove(struct rte_pci_device *pci_dev) allowed_speeds =ETH_LINK_SPEED_100M |ETH_LINK_SPEED_1G |ETH_LINK_SPEED_2_5G |ETH_LINK_SPEED_5G |ETH_LINK_SPEED_10G ; +if (hw->device_id ==IXGBE_DEV_ID_X550EM_A_1G_T || + hw->device_id ==IXGBE_DEV_ID_X550EM_A_1G_T_L ) + allowed_speeds =ETH_LINK_SPEED_10M | +ETH_LINK_SPEED_100M |ETH_LINK_SPEED_1G ;break ;default : allowed_speeds = ETH_LINK_SPEED_100M | ETH_LINK_SPEED_1G |
@@ -2742,6 +2746,8 @@ static int eth_ixgbevf_pci_remove(struct rte_pci_device *pci_dev) speed |=IXGBE_LINK_SPEED_1GB_FULL ;if (*link_speeds Ð_LINK_SPEED_100M ) speed |=IXGBE_LINK_SPEED_100_FULL ; +if (*link_speeds Ð_LINK_SPEED_10M ) + speed |=IXGBE_LINK_SPEED_10_FULL ; } err =ixgbe_setup_link (hw, speed, link_up);
@@ -4061,8 +4067,12 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,switch (link_speed) {default :case IXGBE_LINK_SPEED_UNKNOWN : +if (hw->device_id ==IXGBE_DEV_ID_X550EM_A_1G_T || + hw->device_id ==IXGBE_DEV_ID_X550EM_A_1G_T_L ) + link.link_speed =ETH_SPEED_NUM_10M ; +else + link.link_speed =ETH_SPEED_NUM_100M ; link.link_duplex =ETH_LINK_FULL_DUPLEX ; - link.link_speed =ETH_SPEED_NUM_100M ;break ;case IXGBE_LINK_SPEED_100_FULL :
Signature · 1 line
1.8.3.1
Quoted 11 lines
-----Original Message-----
From: Zhao1, Wei
Sent: Monday, April 1, 2019 2:25 PM
To: [email protected]
Cc: [email protected]; Zhang, Qi Z <[email protected]>; Lu, Wenzhuo <[email protected]>; Stillwell Jr, Paul M <[email protected]>; Zhao1, Wei <[email protected]>
Subject: [PATCH v3] net/ixgbe: enable 10Mb/s link setup for x553
Quoted 5 lines
This patch enable 10Mb/s link for ixgbe x553.
This new device has own device id of0x15E4and0x15E5, so ixgbe PMD driver need to special check when setup link for these two types of device.Signed-off-by Wei Zhao <[email protected]>
Applied to dpdk-next-net-intel.
Thanks
Qi