Skip to contentSkip to conversation

firmware: Intel: Add Stratix10 ECC DBE SMC call

PATCH In review [email protected] 2 participants 5 messages Mar 29, 2019 – Apr 2, 2019

Subsystems (3)
EDAC-core Intel STRATIX10 firmware drivers Arm/socfpga EDAC support
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/2 firmware: Intel: Add Stratix10 ECC DBE SMC call

From: Thor Thayer <[email protected]>

Reserve ECC Double Bit Error SMC call to alert U-Boot that a DBE has occurred. Moving the call from local EDAC header file to this common file.

Reviewed-by Richard Gong <[email protected]>
Reviewed-by Alan Tull <[email protected]>
Signed-off-by Thor Thayer <[email protected]>
---
 include/linux/firmware/intel/stratix10-smc.h | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
include/linux/firmware/intel/stratix10-smc.h +19 -0
index 5be5dab50b13..01684d935580 100644
@@ -309,4 +309,23 @@ INTEL_SIP_SMC_FAST_CALL_VAL(INTEL_SIP_SMC_FUNCID_FPGA_CONFIG_COMPLETED_WRITE)
 #define INTEL_SIP_SMC_FUNCID_RSU_UPDATE 12
 #define INTEL_SIP_SMC_RSU_UPDATE \
 	INTEL_SIP_SMC_FAST_CALL_VAL(INTEL_SIP_SMC_FUNCID_RSU_UPDATE)
+
+/*
+ * Request INTEL_SIP_SMC_ECC_DBE
+ *
+ * Sync call used by service driver at EL1 to alert EL3 that a Double
+ * Bit ECC error has occurred.
+ *
+ * Call register usage:
+ * a0 INTEL_SIP_SMC_ECC_DBE
+ * a1 SysManager Double Bit Error value
+ * a2-7 not used
+ *
+ * Return status
+ * a0 INTEL_SIP_SMC_STATUS_OK
+ */
+#define INTEL_SIP_SMC_FUNCID_ECC_DBE 13
+#define INTEL_SIP_SMC_ECC_DBE \
+	INTEL_SIP_SMC_FAST_CALL_VAL(INTEL_SIP_SMC_FUNCID_ECC_DBE)
+
 #endif
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 2/2 EDAC, altera: Use global Stratix10 SMC defines

From: Thor Thayer <[email protected]>

Use the global Stratix10 SMC defines instead of the local S10 SMC defines.

Reviewed-by Richard Gong <[email protected]>
Signed-off-by Thor Thayer <[email protected]>
---
 drivers/edac/altera_edac.c |  1 +
 drivers/edac/altera_edac.h | 83 ----------------------------------------------
 2 files changed, 1 insertion(+), 83 deletions(-)
drivers/edac/altera_edac.c +1 -0
index 761199175c76..8816f74a22b4 100644
@@ -9,6 +9,7 @@
 #include <linux/ctype.h>
 #include <linux/delay.h>
 #include <linux/edac.h>
+#include <linux/firmware/intel/stratix10-smc.h>
 #include <linux/genalloc.h>
 #include <linux/interrupt.h>
 #include <linux/irqchip/chained_irq.h>
drivers/edac/altera_edac.h +0 -83

87 lines not on this page · raw message

Signature · 1 line
2.7.4
author
#3 lore raw
Quoted 10 lines · Borislav Petkov
Quoted 5 lines · On Fri, Mar 29, 2019 at 09:43:58AM -0500, [email protected] wrote:

From: Thor Thayer <[email protected]>

Reserve ECC Double Bit Error SMC call to alert U-Boot that a DBE has occurred. Moving the call from local EDAC header file to this common file.

Is there any particular reason this needs to be two patches or can I merge them into one?

Yes, they can be merged into one. I split into 2 patches since the 1st required the firmware directory sign-off and the 2nd required your EDAC sign-off. I see your point, it could have been 1 patch.

Thanks for reviewing,

Thor

maintainer
#4 lore raw
Quoted 3 lines · Thor Thayer

Yes, they can be merged into one. I split into 2 patches since the 1st required the firmware directory sign-off and the 2nd required your EDAC sign-off. I see your point, it could have been 1 patch.

Ok, merged and applied.

Thx.