Skip to contentSkip to conversation

scsi: dt-bindings: ufs: Remove "<name>-fixed-regulator" property and add VCC capability on MediaTek UFS driver

PATCH Applied Stanley Chu 2 participants 4 messages Mar 29, 2019 – Apr 4, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

cover scsi: dt-bindings: ufs: Remove "<name>-fixed-regulator" property and add VCC capability on MediaTek UFS driver

Hi,

Now we can remove custom device tree property "<name>-fixed-regulator" for UFS because,

1) It is not used anywhere in tree.
2) All handlings for "<name>-fixed-regulator" have been removed in UFS driver.
3) There is no issue if an existed regulator defined "<name>-fixed-regulator" property in device tree.

Besides, add VCC supply capability on MediaTek UFS driver.

Stanley Chu (2):
scsi: dt-bindings: ufs: Remove custom property
"<name>-fixed-regulator"
scsi: dt-bindings: ufs: Add VCC capability on MediaTek UFS driver

 Documentation/devicetree/bindings/ufs/ufs-mediatek.txt  | 3 +++
 Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt | 2 --
 2 files changed, 3 insertions(+), 2 deletions(-)
Signature · 1 line
2.18.0
#1 lore raw

PATCH 1/2 scsi: dt-bindings: ufs: Remove custom property "<name>-fixed-regulator"

Custom device tree property "<name>-fixed-regulator" can be removed because,

1) It is not used anywhere in tree.

2) All handlings for "<name>-fixed-regulator" have been removed in UFS driver.

3) There is no issue if an existed regulator defined "<name>-fixed-regulator" property in device tree.

---
 Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt | 2 --
 1 file changed, 2 deletions(-)
Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt +0 -2
index 5111e9130bc3..f3140cffc54d 100644
@@ -31,7 +31,6 @@ Optional properties:
 - vcc-max-microamp      : specifies max. load that can be drawn from vcc supply
 - vccq-max-microamp     : specifies max. load that can be drawn from vccq supply
 - vccq2-max-microamp    : specifies max. load that can be drawn from vccq2 supply
-- <name>-fixed-regulator : boolean property specifying that <name>-supply is a fixed regulator
 
 - clocks                : List of phandle and clock specifier pairs
 - clock-names           : List of clock input name strings sorted in the same
@@ -63,7 +62,6 @@ Example:
 		interrupts = <0 28 0>;
 
 		vdd-hba-supply = <&xxx_reg0>;
-		vdd-hba-fixed-regulator;
 		vcc-supply = <&xxx_reg1>;
 		vcc-supply-1p8;
 		vccq-supply = <&xxx_reg2>;
Signature · 1 line
2.18.0
#2 lore raw

PATCH 2/2 scsi: dt-bindings: ufs: Add VCC capability on MediaTek UFS driver

In reply to Stanley Chu

Add VCC supply for ufs-mediatek driver to provide power-saving operation during low-power modes, for example, VCC can be turned-off during system suspend and turned-on after system is resumed.

---
 Documentation/devicetree/bindings/ufs/ufs-mediatek.txt | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/ufs/ufs-mediatek.txt +3 -0
index e25c007b95d7..72aab8547308 100644
@@ -21,6 +21,7 @@ Required properties for UFS nodes:
                        defined or a value in the array is "0" then it is assumed
                        that the frequency is set by the parent clock or a
                        fixed rate clock source.
+- vcc-supply         : phandle to VCC supply regulator node.
 
 Example:
 
@@ -37,4 +38,6 @@ Example:
 		clocks = <&infracfg_ao INFRACFG_AO_UFS_CG>;
 		clock-names = "ufs";
 		freq-table-hz = <0 0>;
+
+		vcc-supply = <&mt_pmic_vemc_ldo_reg>;
 	};
Signature · 1 line
2.18.0
#3 lore raw
In reply to Stanley Chu

Stanley,

Quoted 4 lines

Now we can remove custom device tree property "<name>-fixed-regulator" for UFS because,

Besides, add VCC supply capability on MediaTek UFS driver.

Applied to 5.2/scsi-queue, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering