x86/resctrl: Fix typos in mba_sc mount option
Subsystems (2)
PATCH 1/1 x86/resctrl: Fix typos in mba_sc mount option
With mount option "mba_MBps", we could enable MBA Software Controller (mba_sc) to specify MBA memory bandwidth in unit MBps (Mega Bytes per second). See details in Documentation/x86/resctrl_ui.txt.
Commit 23bf1b6be9c2 ("kernfs, sysfs, cgroup, intel_rdt: Support fs_context") changes the mount option from "mba_MBps" to "mba_mpbs" by mistake.
Change back from "mba_mpbs" to "mba_MBps", and rename Opt_mba_mpbs to Opt_mba_mbps.
--- arch/x86/kernel/cpu/resctrl/rdtgroup.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/x86/kernel/cpu/resctrl/rdtgroup.c +3 -3
@@ -2039,14 +2039,14 @@ static int rdt_get_tree(struct fs_context *fc)enum rdt_param { Opt_cdp, Opt_cdpl2, - Opt_mba_mpbs, + Opt_mba_mbps, nr__rdt_params };static const struct fs_parameter_spec rdt_param_specs[] = {fsparam_flag ("cdp" , Opt_cdp),fsparam_flag ("cdpl2" , Opt_cdpl2), -fsparam_flag ("mba_mpbs" , Opt_mba_mpbs), +fsparam_flag ("mba_MBps" , Opt_mba_mbps), {} };
@@ -2072,7 +2072,7 @@ static int rdt_parse_param(struct fs_context *fc, struct fs_parameter *param)case Opt_cdpl2: ctx->enable_cdpl2 = true;return 0 ; -case Opt_mba_mpbs: +case Opt_mba_mbps:if (boot_cpu_data.x86_vendor !=X86_VENDOR_INTEL )return -EINVAL ; ctx->enable_mba_mbps = true;
Signature · 1 line
1.8.3.1
tip-bot for Xiaochen Shen
merge bot[tip:x86/urgent] x86/resctrl: Fix typos in the mba_sc mount option
x86/resctrl: Fix typos in the mba_sc mount option
Commit-ID: faa3604eda325588451c9c1eb4c8a8d04c1cd633 Gitweb: https://git.kernel.org/tip/faa3604eda325588451c9c1eb4c8a8d04c1cd633 Author: Xiaochen Shen <[email protected]> AuthorDate: Sat, 30 Mar 2019 05:50:38 +0800 Committer: Borislav Petkov <[email protected]> CommitDate: Mon, 1 Apr 2019 18:45:27 +0200
x86/resctrl: Fix typos in the mba_sc mount option
The user can control the MBA memory bandwidth in MBps (Mega Bytes per second) units of the MBA Software Controller (mba_sc) by using the "mba_MBps" mount option. For details, see Documentation/x86/resctrl_ui.txt.
However, commit
23bf1b6be9c2 ("kernfs, sysfs, cgroup, intel_rdt: Support fs_context")
changed the mount option name from "mba_MBps" to "mba_mpbs" by mistake.
Change it back from to "mba_MBps" because it is user-visible, and correct "Opt_mba_mpbs" spelling to "Opt_mba_mbps".
[ bp: massage commit message. ]
--- arch/x86/kernel/cpu/resctrl/rdtgroup.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/x86/kernel/cpu/resctrl/rdtgroup.c +3 -3
@@ -2039,14 +2039,14 @@ out:enum rdt_param { Opt_cdp, Opt_cdpl2, - Opt_mba_mpbs, + Opt_mba_mbps, nr__rdt_params };static const struct fs_parameter_spec rdt_param_specs[] = {fsparam_flag ("cdp" , Opt_cdp),fsparam_flag ("cdpl2" , Opt_cdpl2), -fsparam_flag ("mba_mpbs" , Opt_mba_mpbs), +fsparam_flag ("mba_MBps" , Opt_mba_mbps), {} };
@@ -2072,7 +2072,7 @@ static int rdt_parse_param(struct fs_context *fc, struct fs_parameter *param)case Opt_cdpl2: ctx->enable_cdpl2 = true;return 0 ; -case Opt_mba_mpbs: +case Opt_mba_mbps:if (boot_cpu_data.x86_vendor !=X86_VENDOR_INTEL )return -EINVAL ; ctx->enable_mba_mbps = true;