drivers/staging: Fix styling of the comment related to SPDX-License-Identifier in vt6656/*.h
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH v2 1/1 drivers/staging: Fix styling of the comment related to SPDX-License-Identifier in vt6656/*.h
Fix checkpatch.pl styling error related to SPDX-License-Identifier comment in vt6656/*.h
* v2: fix patch styling
--- drivers/staging/vt6656/baseband.h | 2 +- drivers/staging/vt6656/card.h | 2 +- drivers/staging/vt6656/channel.h | 2 +- drivers/staging/vt6656/desc.h | 2 +- drivers/staging/vt6656/device.h | 2 +- drivers/staging/vt6656/dpc.h | 2 +- drivers/staging/vt6656/firmware.h | 2 +- drivers/staging/vt6656/int.h | 2 +- drivers/staging/vt6656/key.h | 2 +- drivers/staging/vt6656/power.h | 2 +- drivers/staging/vt6656/rf.h | 2 +- drivers/staging/vt6656/rxtx.h | 2 +- drivers/staging/vt6656/usbpipe.h | 2 +- drivers/staging/vt6656/wcmd.h | 2 +- 14 files changed, 14 insertions(+), 14 deletions(-)
drivers/staging/vt6656/baseband.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved.
drivers/staging/vt6656/card.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved.
drivers/staging/vt6656/channel.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved.
drivers/staging/vt6656/desc.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved.
drivers/staging/vt6656/device.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved.
drivers/staging/vt6656/dpc.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved.
drivers/staging/vt6656/firmware.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved.
drivers/staging/vt6656/int.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved.
drivers/staging/vt6656/key.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved.
drivers/staging/vt6656/power.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved.
drivers/staging/vt6656/rf.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved.
drivers/staging/vt6656/rxtx.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved.
drivers/staging/vt6656/usbpipe.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved.
drivers/staging/vt6656/wcmd.h +1 -1
@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved.
Signature · 1 line
2.7.4
Quoted 3 lines · Ojaswin Mujoo
Fix checkpatch.pl styling error related to SPDX-License-Identifier comment in vt6656/*.h
* v2: fix patch styling
Above line should be after ---.
Quoted 2 lines
Signed-off-by Ojaswin Mujoo <[email protected]>
Although, it looks ok to me. but this is spread through out the tree and a result of a copy paste.
But, i would want other to comment on this, whether we really want this kind of effort coming forward.
or can it be not done by some scripting?
Cheers,
-Mukesh
Quoted 157 lines
--- drivers/staging/vt6656/baseband.h | 2 +- drivers/staging/vt6656/card.h | 2 +- drivers/staging/vt6656/channel.h | 2 +- drivers/staging/vt6656/desc.h | 2 +- drivers/staging/vt6656/device.h | 2 +- drivers/staging/vt6656/dpc.h | 2 +- drivers/staging/vt6656/firmware.h | 2 +- drivers/staging/vt6656/int.h | 2 +- drivers/staging/vt6656/key.h | 2 +- drivers/staging/vt6656/power.h | 2 +- drivers/staging/vt6656/rf.h | 2 +- drivers/staging/vt6656/rxtx.h | 2 +- drivers/staging/vt6656/usbpipe.h | 2 +- drivers/staging/vt6656/wcmd.h | 2 +- 14 files changed, 14 insertions(+), 14 deletions(-)drivers/staging/vt6656/baseband.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/card.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/channel.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/desc.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/device.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/dpc.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/firmware.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/int.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/key.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/power.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/rf.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/rxtx.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/usbpipe.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/wcmd.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved.
Quoted 9 lines · Mukesh Ojha
Quoted 3 lines · Ojaswin Mujoo
Fix checkpatch.pl styling error related to SPDX-License-Identifier comment in vt6656/*.h
* v2: fix patch stylingAbove line should be after ---.
Quoted 2 lines
Signed-off-by Ojaswin Mujoo <[email protected]>
Quoted 7 lines
Although, it looks ok to me. but this is spread through out the tree and a result of a copy paste.
Reviewed-by Mukesh Ojha <[email protected]>But, i would want other to comment on this, whether we really want this kind of effort coming forward.
or can it be not done by some scripting?
Found the discussion and the script at https://lkml.org/lkml/2019/2/7/46.
Let's do that.
Quoted 163 lines
Cheers,
-MukeshQuoted 157 lines
---
drivers/staging/vt6656/baseband.h| 2 +-
drivers/staging/vt6656/card.h | 2 +-
drivers/staging/vt6656/channel.h | 2 +-
drivers/staging/vt6656/desc.h | 2 +-
drivers/staging/vt6656/device.h | 2 +-
drivers/staging/vt6656/dpc.h | 2 +-
drivers/staging/vt6656/firmware.h| 2 +-
drivers/staging/vt6656/int.h | 2 +-
drivers/staging/vt6656/key.h | 2 +-
drivers/staging/vt6656/power.h | 2 +-
drivers/staging/vt6656/rf.h | 2 +-
drivers/staging/vt6656/rxtx.h | 2 +-
drivers/staging/vt6656/usbpipe.h | 2 +-
drivers/staging/vt6656/wcmd.h | 2 +-14 files changed, 14 insertions(+), 14 deletions(-)drivers/staging/vt6656/baseband.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /** Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/card.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /** Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/channel.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /** Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/desc.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /** Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/device.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /** Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/dpc.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /** Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/firmware.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /** Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/int.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /** Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/key.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /** Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/power.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /** Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/rf.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /** Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/rxtx.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /** Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/usbpipe.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /** Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved. drivers/staging/vt6656/wcmd.h +1
-1@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /** Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. * All rights reserved.