watchdog: imx2_wdt: use devm_platform_ioremap_resource() to simplify code
Subsystems (2)
PATCH 1/1 watchdog: imx2_wdt: use devm_platform_ioremap_resource() to simplify code
Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code.
Signed-off-by Anson Huang <[email protected]>
--- drivers/watchdog/imx2_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/watchdog/imx2_wdt.c +1 -3
@@ -247,7 +247,6 @@ static int __init imx2_wdt_probe(struct platform_device *pdev) {struct imx2_wdt_device *wdev;struct watchdog_device *wdog; -struct resource *res;void __iomem *base;int ret;u32 val;
@@ -256,8 +255,7 @@ static int __init imx2_wdt_probe(struct platform_device *pdev)if (!wdev)return -ENOMEM ; - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - base =devm_ioremap_resource (&pdev->dev, res); + base =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (base))return PTR_ERR (base);
Signature · 1 line
2.7.4
Quoted 5 lines · Anson Huang
Use the new helper
devm_platform_ioremap_resource()which wraps theplatform_get_resource()anddevm_ioremap_resource()together, to simplify the code.Signed-off-by Anson Huang <[email protected]>
Reviewed-by Mukesh Ojha <[email protected]>
Cheers,
-Mukesh
Quoted 26 lines
--- drivers/watchdog/imx2_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/watchdog/imx2_wdt.c +1
-3@@ -247,7 +247,6 @@ static int __init imx2_wdt_probe(struct platform_device *pdev) {struct imx2_wdt_device *wdev;struct watchdog_device *wdog; -struct resource *res;void __iomem *base;int ret;u32 val;@@ -256,8 +255,7 @@ static int __init imx2_wdt_probe(struct platform_device *pdev)if (!wdev)return -ENOMEM ; - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - base =devm_ioremap_resource (&pdev->dev, res); + base =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (base))return PTR_ERR (base);
Quoted 5 lines · Anson Huang
Use the new helper
devm_platform_ioremap_resource()which wraps theplatform_get_resource()anddevm_ioremap_resource()together, to simplify the code.Signed-off-by Anson Huang <[email protected]>
Reviewed-by Guenter Roeck <[email protected]>
Quoted 29 lines
--- drivers/watchdog/imx2_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/watchdog/imx2_wdt.c +1
-3@@ -247,7 +247,6 @@ static int __init imx2_wdt_probe(struct platform_device *pdev) {struct imx2_wdt_device *wdev;struct watchdog_device *wdog; -struct resource *res;void __iomem *base;int ret;u32 val;@@ -256,8 +255,7 @@ static int __init imx2_wdt_probe(struct platform_device *pdev)if (!wdev)return -ENOMEM ; - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - base =devm_ioremap_resource (&pdev->dev, res); + base =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (base))return PTR_ERR (base);Signature · 1 line
2.7.4