drm/i915: FBC needs vblank before enable / disable.
Subsystems (2)
PATCH 1/1 drm/i915: FBC needs vblank before enable / disable.
From: Kiran Kumar S <[email protected]>
As per the display workaround #1200, FBC needs wait for vblank before enabling and before disabling FBC.
In some cases, depending on whether FBC was compressing in that frame, several control signals in the compression engine also will fail to properly recognize the final segment of the frame as a result of the missing last pixel indication. As a result of this, we're seeing corrupted cache line/compression indicators after FBC re-enables which causes underruns or corruption when they're used to decompress.
WA sequence as below:
1) Display enables plane 1A
2) Wait for 1 vblank
3) FBC gets enabled
4) Wait for 1 VBLANK
5) Turn off FBC
In GLK Chrome OS, if FBC is enabled by default, few top lines on the screen got corrupted. With the above WA, issue was resolved.
--- drivers/gpu/drm/i915/intel_display.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/gpu/drm/i915/intel_display.c +4 -0
@@ -12246,6 +12246,8 @@ static void intel_update_crtc(struct drm_crtc *crtc, }if (drm_atomic_get_existing_plane_state (state, crtc->primary)) { +/* Display WA #1200: GLK */ +intel_wait_for_vblank (dev_priv, intel_crtc->pipe);intel_fbc_enable ( intel_crtc, pipe_config,to_intel_plane_state (crtc->primary->state));
@@ -12419,6 +12421,8 @@ static void intel_atomic_commit_tail(struct drm_atomic_state *state)intel_crtc_disable_planes (crtc, old_crtc_state->plane_mask); dev_priv->display.crtc_disable (to_intel_crtc_state (old_crtc_state), state); intel_crtc->active = false; +/* Display WA #1200: GLK */ +intel_wait_for_vblank (dev_priv, intel_crtc->pipe);intel_fbc_disable (intel_crtc);intel_disable_shared_dpll (intel_crtc);
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for drm/i915: FBC needs vblank before enable / disable.
== Series Details ==
== Series Details ==
Series: drm/i915: FBC needs vblank before enable / disable.
URL : https://patchwork.freedesktop.org/series/58843/
State : failure
== Summary ==
Applying: drm/i915: FBC needs vblank before enable / disable.
error: sha1 information is lacking or useless (drivers/gpu/drm/i915/intel_display.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch' to see the failed patch
Patch failed at 0001 drm/i915: FBC needs vblank before enable / disable. When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx