ath10k: Fix encoding for protected management frames
PATCH 1/1 ath10k: Fix encoding for protected management frames
Currently the protected management frames are
not appended with the MIC_LEN which results in
the protected management frames being encoded
incorrectly.
Add the extra space at the end of the protected
management frames to fix this encoding error for
the protected management frames.
Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1
--- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/wireless/ath/ath10k/wmi-tlv.c +3 -1
@@ -2840,8 +2840,10 @@ ath10k_wmi_tlv_op_gen_mgmt_tx_send(struct ath10k *ar, struct sk_buff *msdu,if ((ieee80211_is_action (hdr->frame_control) ||ieee80211_is_deauth (hdr->frame_control) ||ieee80211_is_disassoc (hdr->frame_control)) && -ieee80211_has_protected (hdr->frame_control)) +ieee80211_has_protected (hdr->frame_control)) { +skb_put (msdu,IEEE80211_CCMP_MIC_LEN ); buf_len +=IEEE80211_CCMP_MIC_LEN ; + } buf_len =min_t (u32, buf_len,WMI_TLV_MGMT_TX_FRAME_MAX_LEN ); buf_len =round_up (buf_len,4 );
Signature · 7 lines
2.7.4 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 5 lines · Rakesh Pillai
Currently the protected management frames are not appended with the
MIC_LENwhich results in the protected management frames being encoded incorrectly.
Quoted 8 lines
Add the extra space at the end of the protected management frames to fix this encoding error for the protected management frames.
Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1Fixes 1807da49733e "ath10k: wmi: add management tx by reference support over wmi"
This should be:
But I can fix that.
Signature · 6 lines
Kalle Valo _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 9 lines · Rakesh Pillai
Currently the protected management frames are
not appended with theMIC_LENwhich results in
the protected management frames being encoded
incorrectly.Add the extra space at the end of the protected
management frames to fix this encoding error for
the protected management frames.
Quoted 6 lines
Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1Fixes 1807da49733e ("ath10k: wmi: add management tx by reference support over wmi")Signed-off-by Rakesh Pillai <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
42f1bc43e6a9 ath10k: Fix encoding for protected management frames
Signature · 3 lines
https://patchwork.kernel.org/patch/10881571/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 9 lines · Rakesh Pillai
Currently the protected management frames are
not appended with theMIC_LENwhich results in
the protected management frames being encoded
incorrectly.Add the extra space at the end of the protected
management frames to fix this encoding error for
the protected management frames.
Quoted 6 lines
Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1Fixes 1807da49733e ("ath10k: wmi: add management tx by reference support over wmi")Signed-off-by Rakesh Pillai <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
42f1bc43e6a9 ath10k: Fix encoding for protected management frames
Signature · 9 lines
https://patchwork.kernel.org/patch/10881571/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k