Skip to contentSkip to conversation

package/netsniff-ng: Fix build caused by extra 'install' target

PATCH New Vadim Kochan 3 participants 3 messages Apr 2, 2019 – Apr 3, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/netsniff-ng: Fix build caused by extra 'install' target

From: Vadim Kochan <[email protected]>

After commit:

b0f98d5 package/netsniff-ng: allow to build with uclibc but w/o mausezahn

the different build and install targets are specified depending if masuezahn tool is able to be selected or not. It works for the build case but for the install the old 'install' target was not removed from the make invocation and it still forces to install the mausezahn, so fix it by remove this target.

Fixes:

	http://autobuild.buildroot.net/results/cc44ed737799c9ac73628c82b86bd526b1c43310/
	http://autobuild.buildroot.net/results/72d0753532720604d51c05663af7fbfe37434339/
---
 package/netsniff-ng/netsniff-ng.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/netsniff-ng/netsniff-ng.mk +1 -1
index 8dd06b6..415e86d 100644
@@ -54,7 +54,7 @@ endef
 
 define NETSNIFF_NG_INSTALL_TARGET_CMDS
 	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
-		PREFIX=$(TARGET_DIR)/usr ETCDIR=$(TARGET_DIR)/etc install \
+		PREFIX=$(TARGET_DIR)/usr ETCDIR=$(TARGET_DIR)/etc \
 			-C $(@D) $(NETSNIFF_NG_INSTALL_MAKE_TARGET)
 endef
 
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 package/netsniff-ng: Fix build caused by extra 'install' target

Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Vadim" == Vadim Kochan <[email protected]> writes:

From: Vadim Kochan <[email protected]>
After commit:

b0f98d5 package/netsniff-ng: allow to build with uclibc but w/o mausezahn

the different build and install targets are specified depending if masuezahn tool is able to be selected or not. It works for the build case but for the install the old 'install' target was not removed from the make invocation and it still forces to install the mausezahn, so fix it by remove this target.

Quoted 5 lines

Fixes:

	http://autobuild.buildroot.net/results/cc44ed737799c9ac73628c82b86bd526b1c43310/
	http://autobuild.buildroot.net/results/72d0753532720604d51c05663af7fbfe37434339/

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 package/netsniff-ng: Fix build caused by extra 'install' target

In reply to Vadim Kochan

Hello,

Quoted 12 lines · On Tue, 2 Apr 2019 17:23:58 +0300 Vadim Kochan <[email protected]> wrote:

From: Vadim Kochan <[email protected]>

After commit:

b0f98d5 package/netsniff-ng: allow to build with uclibc but w/o mausezahn

the different build and install targets are specified depending if masuezahn tool is able to be selected or not. It works for the build case but for the install the old 'install' target was not removed from the make invocation and it still forces to install the mausezahn, so fix it by remove this target.

Quoted 5 lines

Fixes:

	http://autobuild.buildroot.net/results/cc44ed737799c9ac73628c82b86bd526b1c43310/
	http://autobuild.buildroot.net/results/72d0753532720604d51c05663af7fbfe37434339/

Gah, indeed. Thanks for fixing my mess :-/

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com