Skip to contentSkip to conversation

perf: Remove duplicate headers

PATCH In review Souptick Joarder 2 participants 4 messages Apr 6, 2019 – May 11, 2019 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf: Remove duplicate headers

Removed duplicate headers which are included twice.

---
 tools/perf/util/data.c                 | 1 -
 tools/perf/util/get_current_dir_name.c | 1 -
 tools/perf/util/stat-display.c         | 1 -
 3 files changed, 3 deletions(-)
tools/perf/util/data.c +0 -1
index 6a64f71..509a41e 100644
@@ -8,7 +8,6 @@
 #include <unistd.h>
 #include <string.h>
 #include <asm/bug.h>
-#include <sys/types.h>
 #include <dirent.h>
 
 #include "data.h"
tools/perf/util/get_current_dir_name.c +0 -1
index 267aa60..ebb80cd 100644
@@ -5,7 +5,6 @@
 #include "util.h"
 #include <unistd.h>
 #include <stdlib.h>
-#include <stdlib.h>
 
 /* Android's 'bionic' library, for one, doesn't have this */
 
tools/perf/util/stat-display.c +0 -1
index 6d043c7..7b3a16c 100644
@@ -12,7 +12,6 @@
 #include "string2.h"
 #include "sane_ctype.h"
 #include "cgroup.h"
-#include <math.h>
 #include <api/fs/fs.h>
 
 #define CNTR_NOT_SUPPORTED	"<not supported>"
Signature · 1 line
1.9.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Souptick Joarder

Removed duplicate headers which are included twice.

Cheers,
-Mukesh

Quoted 42 lines
---
  tools/perf/util/data.c                 | 1 -
  tools/perf/util/get_current_dir_name.c | 1 -
  tools/perf/util/stat-display.c         | 1 -
  3 files changed, 3 deletions(-)
tools/perf/util/data.c +0 -1
index 6a64f71..509a41e 100644
@@ -8,7 +8,6 @@
  #include <unistd.h>
  #include <string.h>
  #include <asm/bug.h>
-#include <sys/types.h>
  #include <dirent.h>
 
  #include "data.h"
tools/perf/util/get_current_dir_name.c +0 -1
index 267aa60..ebb80cd 100644
@@ -5,7 +5,6 @@
  #include "util.h"
  #include <unistd.h>
  #include <stdlib.h>
-#include <stdlib.h>
 
  /* Android's 'bionic' library, for one, doesn't have this */
 
tools/perf/util/stat-display.c +0 -1
index 6d043c7..7b3a16c 100644
@@ -12,7 +12,6 @@
  #include "string2.h"
  #include "sane_ctype.h"
  #include "cgroup.h"
-#include <math.h>
  #include <api/fs/fs.h>
 
  #define CNTR_NOT_SUPPORTED	"<not supported>"
#2 lore raw
Quoted 6 lines · Mukesh Ojha
Quoted 2 lines · Souptick Joarder

Removed duplicate headers which are included twice.

If no further comment, can we get this patch in queue for 5.2 ?

Quoted 46 lines

Cheers,
-Mukesh

Quoted 42 lines
---
  tools/perf/util/data.c                 | 1 -
  tools/perf/util/get_current_dir_name.c | 1 -
  tools/perf/util/stat-display.c         | 1 -
  3 files changed, 3 deletions(-)
tools/perf/util/data.c +0 -1
index 6a64f71..509a41e 100644
@@ -8,7 +8,6 @@
  #include <unistd.h>
  #include <string.h>
  #include <asm/bug.h>
-#include <sys/types.h>
  #include <dirent.h>
 
  #include "data.h"
tools/perf/util/get_current_dir_name.c +0 -1
index 267aa60..ebb80cd 100644
@@ -5,7 +5,6 @@
  #include "util.h"
  #include <unistd.h>
  #include <stdlib.h>
-#include <stdlib.h>
 
  /* Android's 'bionic' library, for one, doesn't have this */
 
tools/perf/util/stat-display.c +0 -1
index 6d043c7..7b3a16c 100644
@@ -12,7 +12,6 @@
  #include "string2.h"
  #include "sane_ctype.h"
  #include "cgroup.h"
-#include <math.h>
  #include <api/fs/fs.h>
 
  #define CNTR_NOT_SUPPORTED  "<not supported>"
#3 lore raw
Quoted 10 lines · Souptick Joarder
Quoted 6 lines · Mukesh Ojha
Quoted 2 lines · Souptick Joarder

Removed duplicate headers which are included twice.

If no further comment, can we get this patch in queue for 5.2 ?

Can we get this in queue for 5.2 ?

Quoted 47 lines
Quoted 47 lines

Cheers,
-Mukesh

Quoted 42 lines
---
  tools/perf/util/data.c                 | 1 -
  tools/perf/util/get_current_dir_name.c | 1 -
  tools/perf/util/stat-display.c         | 1 -
  3 files changed, 3 deletions(-)
tools/perf/util/data.c +0 -1
index 6a64f71..509a41e 100644
@@ -8,7 +8,6 @@
  #include <unistd.h>
  #include <string.h>
  #include <asm/bug.h>
-#include <sys/types.h>
  #include <dirent.h>
 
  #include "data.h"
tools/perf/util/get_current_dir_name.c +0 -1
index 267aa60..ebb80cd 100644
@@ -5,7 +5,6 @@
  #include "util.h"
  #include <unistd.h>
  #include <stdlib.h>
-#include <stdlib.h>
 
  /* Android's 'bionic' library, for one, doesn't have this */
 
tools/perf/util/stat-display.c +0 -1
index 6d043c7..7b3a16c 100644
@@ -12,7 +12,6 @@
  #include "string2.h"
  #include "sane_ctype.h"
  #include "cgroup.h"
-#include <math.h>
  #include <api/fs/fs.h>
 
  #define CNTR_NOT_SUPPORTED  "<not supported>"