Skip to contentSkip to conversation

Core-for-CI:ICL_only Disable ACPI idle driver

PATCH Superseded Anshuman Gupta 6 participants 10 messages Apr 8, 2019 – Apr 10, 2019 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Core-for-CI:ICL_only Disable ACPI idle driver

There were system hung observed while running i915_pm_rpm test. FDO https://bugs.freedesktop.org/show_bug.cgi?id=108840
Root cause is believed to due to page fault in ACPI idle (FDO comment 18) driver, it has been suggested by Daniel to disable ACPI idle driver for CI system, this patch only meant for ICL.

---
 drivers/acpi/processor_driver.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)
drivers/acpi/processor_driver.c +14 -1
index 9d6aff2..6e3ef2d 100644
@@ -35,6 +35,9 @@
 
 #include <acpi/processor.h>
 
+#include <asm/cpu_device_id.h>
+#include <asm/intel-family.h>
+
 #include "internal.h"
 
 #define ACPI_PROCESSOR_NOTIFY_PERFORMANCE 0x80
@@ -58,6 +61,13 @@ static const struct acpi_device_id processor_device_ids[] = {
 };
 MODULE_DEVICE_TABLE(acpi, processor_device_ids);
 
+#define ICPU(model)	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, }
+static const struct x86_cpu_id intel_cpu_ids[] = {
+	ICPU(INTEL_FAM6_ICELAKE_MOBILE),	/* ICL */
+	{}
+};
+MODULE_DEVICE_TABLE(x86cpu, intel_pmc_core_ids);
+
 static struct device_driver acpi_processor_driver = {
 	.name = "processor",
 	.bus = &cpu_subsys,
@@ -226,6 +236,7 @@ static inline void acpi_pss_perf_exit(struct acpi_processor *pr,
 static int __acpi_processor_start(struct acpi_device *device)
 {
 	struct acpi_processor *pr = acpi_driver_data(device);
+	const struct x86_cpu_id *id;
 	acpi_status status;
 	int result = 0;
 
@@ -239,7 +250,9 @@ static int __acpi_processor_start(struct acpi_device *device)
 	if (result && !IS_ENABLED(CONFIG_ACPI_CPU_FREQ_PSS))
 		dev_dbg(&device->dev, "CPPC data invalid or not present\n");
 
-	if (!cpuidle_get_driver() || cpuidle_get_driver() == &acpi_idle_driver)
+	id = x86_match_cpu(intel_cpu_ids);
+	if (!id && (!cpuidle_get_driver() || cpuidle_get_driver() ==
+		&acpi_idle_driver))
 		acpi_processor_power_init(pr);
 
 	result = acpi_pss_perf_init(pr, device);
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

+ Rafael, Mika.

Quoted 71 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Anshuman Gupta
Sent: maanantai 8. huhtikuuta 2019 15.22
To: [email protected]
Cc: Peres, Martin <[email protected]>; Vetter, Daniel <[email protected]>
Subject: [Intel-gfx] [PATCH] Core-for-CI:ICL_only Disable ACPI idle driver

There were system hung observed while running i915_pm_rpm test.
FDO https://bugs.freedesktop.org/show_bug.cgi?id=108840
Root cause is believed to due to page fault in ACPI idle (FDO comment 18) driver, it has been suggested by Daniel to disable ACPI idle driver for CI system, this patch only meant for ICL.

---
 drivers/acpi/processor_driver.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)
drivers/acpi/processor_driver.c index renamed from drivers/acpi/processor_driver.c +0 -0

9d6aff2..6e3ef2d 100644

drivers/acpi/processor_driver.c +3 -0
@@ -35,6 +35,9 @@
 
 #include <acpi/processor.h>
 
+#include <asm/cpu_device_id.h>
+#include <asm/intel-family.h>
+
 #include "internal.h"
 
 #define ACPI_PROCESSOR_NOTIFY_PERFORMANCE 0x80 @@ -58,6 +61,13 @@

static const struct acpi_device_id processor_device_ids[] = { }; MODULE_DEVICE_TABLE(acpi, processor_device_ids);

drivers/acpi/processor_driver.c +11 -2
+#define ICPU(model)	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, }
+static const struct x86_cpu_id intel_cpu_ids[] = {
+	ICPU(INTEL_FAM6_ICELAKE_MOBILE),	/* ICL */
+	{}
+};
+MODULE_DEVICE_TABLE(x86cpu, intel_pmc_core_ids);
+
 static struct device_driver acpi_processor_driver = {
 	.name = "processor",
 	.bus = &cpu_subsys,
@@ -226,6 +236,7 @@ static inline void acpi_pss_perf_exit(struct acpi_processor
 *pr,  static int __acpi_processor_start(struct acpi_device *device)  {
 	struct acpi_processor *pr = acpi_driver_data(device);
+	const struct x86_cpu_id *id;
 	acpi_status status;
 	int result = 0;
 
@@ -239,7 +250,9 @@ static int __acpi_processor_start(struct acpi_device *device)
 	if (result && !IS_ENABLED(CONFIG_ACPI_CPU_FREQ_PSS))
 		dev_dbg(&device->dev, "CPPC data invalid or not present\n");
 
-	if (!cpuidle_get_driver() || cpuidle_get_driver() == &acpi_idle_driver)
+	id = x86_match_cpu(intel_cpu_ids);
+	if (!id && (!cpuidle_get_driver() || cpuidle_get_driver() ==
+		&acpi_idle_driver))
 		acpi_processor_power_init(pr);
 
 	result = acpi_pss_perf_init(pr, device);
--

2.7.4

Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

✓ Fi.CI.BAT: success for Core-for-CI:ICL_only Disable ACPI idle driver

In reply to Anshuman Gupta
== Series Details ==

== Series Details ==

Series: Core-for-CI:ICL_only Disable ACPI idle driver
URL : https://patchwork.freedesktop.org/series/59170/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5888 -> Patchwork_12727
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/59170/revisions/1/mbox/

Known issues
------------

Here are the changes found in Patchwork_12727 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_basic@create-close:
- fi-icl-y: PASS -> INCOMPLETE [fdo#110246]

* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]

* igt@i915_selftest@live_uncore:
- fi-ivb-3770: PASS -> DMESG-FAIL [fdo#110210]

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]

#### Possible fixes ####

* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: FAIL [fdo#103167] -> PASS
- fi-byt-clapper: FAIL [fdo#103167] -> PASS

#### Warnings ####

* igt@i915_pm_rpm@module-reload:
- fi-glk-dsi: DMESG-WARN [fdo#105538] / [fdo#107732] / [fdo#109513] -> DMESG-FAIL [fdo#105538] / [fdo#107732] / [fdo#109513]

[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#105538]: https://bugs.freedesktop.org/show_bug.cgi?id=105538
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107732]: https://bugs.freedesktop.org/show_bug.cgi?id=107732
[fdo#109513]: https://bugs.freedesktop.org/show_bug.cgi?id=109513
[fdo#110210]: https://bugs.freedesktop.org/show_bug.cgi?id=110210
[fdo#110246]: https://bugs.freedesktop.org/show_bug.cgi?id=110246

Participating hosts (50 -> 44)
------------------------------

Missing (6): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-icl-u2 fi-ctg-p8600 fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_5888 -> Patchwork_12727

CI_DRM_5888: 381350f19ba1844d34105890169b1f1443f45879 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4932: 08cf63a8fac11e3594b57580331fb319241a0d69 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12727: bc51dc79f80e007134f9d7ddbabdafae59d402af @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

bc51dc79f80e Core-for-CI:ICL_only Disable ACPI idle driver

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12727/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

✓ Fi.CI.IGT: success for Core-for-CI:ICL_only Disable ACPI idle driver

In reply to Anshuman Gupta
== Series Details ==

== Series Details ==

Series: Core-for-CI:ICL_only Disable ACPI idle driver
URL : https://patchwork.freedesktop.org/series/59170/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5888_full -> Patchwork_12727_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_12727_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_store@pages-bsd1:
- shard-iclb: NOTRUN -> SKIP [fdo#109276] +3

* igt@gem_pread@pagefault-pread:
- shard-iclb: NOTRUN -> SKIP [fdo#109277]

* igt@i915_pm_rpm@i2c:
- shard-iclb: PASS -> DMESG-FAIL [fdo#110271]

* igt@i915_pm_rpm@modeset-pc8-residency-stress:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +232

* igt@i915_suspend@debugfs-reader:
- shard-skl: PASS -> INCOMPLETE [fdo#104108]

* igt@kms_atomic_transition@3x-modeset-transitions:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +3

* igt@kms_atomic_transition@6x-modeset-transitions:
- shard-iclb: NOTRUN -> SKIP [fdo#109278] +5

* igt@kms_atomic_transition@6x-modeset-transitions-nonblocking:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +19

* igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
- shard-apl: NOTRUN -> INCOMPLETE [fdo#103927]

* igt@kms_chamelium@hdmi-crc-argb1555:
- shard-iclb: NOTRUN -> SKIP [fdo#109284]

* igt@kms_content_protection@atomic-dpms:
- shard-apl: NOTRUN -> FAIL [fdo#110321] / [fdo#110336] +1

* igt@kms_cursor_crc@cursor-512x512-offscreen:
- shard-iclb: NOTRUN -> SKIP [fdo#109279]

* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-skl: NOTRUN -> INCOMPLETE [fdo#104108] / [fdo#107773]

* igt@kms_cursor_legacy@cursor-vs-flip-varying-size:
- shard-iclb: PASS -> FAIL [fdo#103355]

* igt@kms_fbcon_fbt@psr-suspend:
- shard-skl: NOTRUN -> FAIL [fdo#103833]

* igt@kms_flip@2x-flip-vs-wf_vblank-interruptible:
- shard-skl: NOTRUN -> SKIP [fdo#109271] +153

* igt@kms_flip@2x-nonexisting-fb:
- shard-iclb: NOTRUN -> SKIP [fdo#109274] +2

* igt@kms_force_connector_basic@prune-stale-modes:
- shard-iclb: NOTRUN -> SKIP [fdo#109285]

* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-pwrite:
- shard-iclb: PASS -> FAIL [fdo#103167] +2

* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-mmap-wc:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +12

* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-cpu:
- shard-iclb: PASS -> FAIL [fdo#105682] / [fdo#109247]

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-msflip-blt:
- shard-iclb: PASS -> FAIL [fdo#109247] +8

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-render:
- shard-iclb: NOTRUN -> SKIP [fdo#109280] +5

* igt@kms_lease@atomic_implicit_crtc:
- shard-skl: NOTRUN -> FAIL [fdo#110279]

* igt@kms_lease@cursor_implicit_plane:
- shard-apl: NOTRUN -> FAIL [fdo#110278]

* igt@kms_lease@setcrtc_implicit_plane:
- shard-skl: NOTRUN -> FAIL [fdo#110281] +1

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-e:
- shard-skl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +14

* igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
- shard-glk: PASS -> SKIP [fdo#109271]

* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-kbl: NOTRUN -> FAIL [fdo#108145] / [fdo#108590]

* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-apl: NOTRUN -> FAIL [fdo#108145] +5

* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145]

* igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb:
- shard-skl: NOTRUN -> FAIL [fdo#108145] +1

* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: PASS -> FAIL [fdo#103166]

* igt@kms_plane_scaling@pipe-c-scaler-with-rotation:
- shard-glk: PASS -> SKIP [fdo#109271] / [fdo#109278]

* igt@kms_psr@cursor_mmap_cpu:
- shard-iclb: PASS -> FAIL [fdo#107383] / [fdo#110215] +1

* igt@kms_vblank@pipe-b-ts-continuation-modeset-rpm:
- shard-apl: NOTRUN -> FAIL [fdo#104894] +1

* igt@prime_nv_pcopy@test3_2:
- shard-iclb: NOTRUN -> SKIP [fdo#109291]

#### Possible fixes ####

* igt@gem_tiled_pread_pwrite:
- shard-iclb: TIMEOUT [fdo#109673] -> PASS

* igt@i915_pm_rpm@debugfs-read:
- shard-skl: INCOMPLETE [fdo#107807] -> PASS

* igt@i915_suspend@sysfs-reader:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS

* igt@kms_fbcon_fbt@fbc:
- shard-iclb: DMESG-WARN [fdo#109593] -> PASS

* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: FAIL [fdo#105363] -> PASS +1

* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-gtt:
- shard-iclb: FAIL [fdo#109247] -> PASS +21

* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-wc:
- shard-iclb: FAIL [fdo#105682] / [fdo#109247] -> PASS

* igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
- shard-glk: SKIP [fdo#109271] / [fdo#109278] -> PASS

* igt@kms_plane_scaling@pipe-c-scaler-with-clipping-clamping:
- shard-iclb: INCOMPLETE [fdo#110041] -> PASS

* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: SKIP [fdo#109441] -> PASS +4

* igt@kms_psr@sprite_mmap_gtt:
- shard-iclb: FAIL [fdo#107383] / [fdo#110215] -> PASS +4

* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-kbl: DMESG-FAIL [fdo#105763] -> PASS

* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: FAIL [fdo#109016] -> PASS

* igt@kms_rotation_crc@primary-rotation-270:
- shard-iclb: FAIL [fdo#103925] -> PASS

* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-iclb: FAIL [fdo#104894] -> PASS

* igt@perf_pmu@rc6:
- shard-kbl: SKIP [fdo#109271] -> PASS

#### Warnings ####

* igt@kms_chamelium@vga-frame-dump:
- shard-apl: SKIP [fdo#109271] -> INCOMPLETE [fdo#103927]

* igt@kms_rotation_crc@multiplane-rotation:
- shard-kbl: INCOMPLETE [fdo#103665] -> FAIL [fdo#109016]

[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103833]: https://bugs.freedesktop.org/show_bug.cgi?id=103833
[fdo#103925]: https://bugs.freedesktop.org/show_bug.cgi?id=103925
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108590]: https://bugs.freedesktop.org/show_bug.cgi?id=108590
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109277]: https://bugs.freedesktop.org/show_bug.cgi?id=109277
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109593]: https://bugs.freedesktop.org/show_bug.cgi?id=109593
[fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673
[fdo#110041]: https://bugs.freedesktop.org/show_bug.cgi?id=110041
[fdo#110215]: https://bugs.freedesktop.org/show_bug.cgi?id=110215
[fdo#110271]: https://bugs.freedesktop.org/show_bug.cgi?id=110271
[fdo#110278]: https://bugs.freedesktop.org/show_bug.cgi?id=110278
[fdo#110279]: https://bugs.freedesktop.org/show_bug.cgi?id=110279
[fdo#110281]: https://bugs.freedesktop.org/show_bug.cgi?id=110281
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336

Participating hosts (10 -> 9)
------------------------------

Missing (1): shard-hsw

Build changes
-------------

* Linux: CI_DRM_5888 -> Patchwork_12727

CI_DRM_5888: 381350f19ba1844d34105890169b1f1443f45879 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4932: 08cf63a8fac11e3594b57580331fb319241a0d69 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12727: bc51dc79f80e007134f9d7ddbabdafae59d402af @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12727/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
In reply to Anshuman Gupta
Thank you for the patch! Yet something to improve:

Hi Anshuman,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pm/linux-next]
[also build test ERROR on v5.1-rc4 next-20190408]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Anshuman-Gupta/Core-for-CI-ICL_only-Disable-ACPI-idle-driver/20190409-081735
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: x86_64-randconfig-x006-201914 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

In file included from drivers//acpi/processor_driver.c:28:0:

>> drivers//acpi/processor_driver.c:69:29: error: 'intel_pmc_core_ids' undeclared here (not in a function); did you mean 'intel_cpu_ids'?
    MODULE_DEVICE_TABLE(x86cpu, intel_pmc_core_ids);
                                ^
   include/linux/module.h:229:15: note: in definition of macro 'MODULE_DEVICE_TABLE'
    extern typeof(name) __mod_##type##__##name##_device_table  \
                  ^~~~
>> include/linux/module.h:229:21: error: '__mod_x86cpu__intel_pmc_core_ids_device_table' aliased to undefined symbol 'intel_pmc_core_ids'
    extern typeof(name) __mod_##type##__##name##_device_table  \
                        ^
>> drivers//acpi/processor_driver.c:69:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
    MODULE_DEVICE_TABLE(x86cpu, intel_pmc_core_ids);
    ^~~~~~~~~~~~~~~~~~~
--
   In file included from drivers/acpi/processor_driver.c:28:0:
   drivers/acpi/processor_driver.c:69:29: error: 'intel_pmc_core_ids' undeclared here (not in a function); did you mean 'intel_cpu_ids'?
    MODULE_DEVICE_TABLE(x86cpu, intel_pmc_core_ids);
                                ^
   include/linux/module.h:229:15: note: in definition of macro 'MODULE_DEVICE_TABLE'
    extern typeof(name) __mod_##type##__##name##_device_table  \
                  ^~~~
>> include/linux/module.h:229:21: error: '__mod_x86cpu__intel_pmc_core_ids_device_table' aliased to undefined symbol 'intel_pmc_core_ids'
    extern typeof(name) __mod_##type##__##name##_device_table  \
                        ^
   drivers/acpi/processor_driver.c:69:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
    MODULE_DEVICE_TABLE(x86cpu, intel_pmc_core_ids);
    ^~~~~~~~~~~~~~~~~~~

vim +69 drivers//acpi/processor_driver.c

  > 28	#include <linux/module.h>
    29	#include <linux/init.h>
    30	#include <linux/cpufreq.h>
    31	#include <linux/cpu.h>
    32	#include <linux/cpuidle.h>
    33	#include <linux/slab.h>
    34	#include <linux/acpi.h>
    35	
    36	#include <acpi/processor.h>
    37	
    38	#include <asm/cpu_device_id.h>
    39	#include <asm/intel-family.h>
    40	
    41	#include "internal.h"
    42	
    43	#define ACPI_PROCESSOR_NOTIFY_PERFORMANCE 0x80
    44	#define ACPI_PROCESSOR_NOTIFY_POWER	0x81
    45	#define ACPI_PROCESSOR_NOTIFY_THROTTLING	0x82
    46	
    47	#define _COMPONENT		ACPI_PROCESSOR_COMPONENT
    48	ACPI_MODULE_NAME("processor_driver");
    49	
    50	MODULE_AUTHOR("Paul Diefenbaugh");
    51	MODULE_DESCRIPTION("ACPI Processor Driver");
    52	MODULE_LICENSE("GPL");
    53	
    54	static int acpi_processor_start(struct device *dev);
    55	static int acpi_processor_stop(struct device *dev);
    56	
    57	static const struct acpi_device_id processor_device_ids[] = {
    58		{ACPI_PROCESSOR_OBJECT_HID, 0},
    59		{ACPI_PROCESSOR_DEVICE_HID, 0},
    60		{"", 0},
    61	};
    62	MODULE_DEVICE_TABLE(acpi, processor_device_ids);
    63	
    64	#define ICPU(model)	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, }
    65	static const struct x86_cpu_id intel_cpu_ids[] = {
    66		ICPU(INTEL_FAM6_ICELAKE_MOBILE),	/* ICL */
    67		{}
    68	};
  > 69	MODULE_DEVICE_TABLE(x86cpu, intel_pmc_core_ids);
    70	

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw
In reply to Anshuman Gupta
Thank you for the patch! Yet something to improve:

Hi Anshuman,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pm/linux-next]
[also build test ERROR on v5.1-rc4 next-20190408]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Anshuman-Gupta/Core-for-CI-ICL_only-Disable-ACPI-idle-driver/20190409-081735
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 8.1.0

reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=8.1.0 make.cross ARCH=ia64

All errors (new ones prefixed by >>):

>> drivers//acpi/processor_driver.c:38:10: fatal error: asm/cpu_device_id.h: No such file or directory
    #include <asm/cpu_device_id.h>
             ^~~~~~~~~~~~~~~~~~~~~

compilation terminated.

vim +38 drivers//acpi/processor_driver.c

    37	
  > 38	#include <asm/cpu_device_id.h>
    39	#include <asm/intel-family.h>
    40	

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

PATCH v2 1/1 Core-for-CI:ICL_only Disable ACPI idle driver

In reply to Anshuman Gupta

There were few system hung observed while running i915_pm_rpm igt test. FDO https://bugs.freedesktop.org/show_bug.cgi?id=108840
Root cause is believed to due to page fault in ACPI idle driver. (FDO comment 18).
It has been suggested by Daniel Vetter to disable ACPI idle driver for Core-for-CI, only for ICL.

This hacky patch is only for ICL processor and for Core-for-CI branch.

v2: Fixed compilation errors raised by lkp.
commit message improvement.

---
 drivers/acpi/processor_driver.c | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)
drivers/acpi/processor_driver.c +17 -1
index 9d6aff2..ee842a2f 100644
@@ -35,6 +35,12 @@
 
 #include <acpi/processor.h>
 
+/* Only for Core-for-CI so don't want ia64 to fail compilation.*/
+#ifdef CONFIG_X86
+#include <asm/cpu_device_id.h>
+#include <asm/intel-family.h>
+#endif
+
 #include "internal.h"
 
 #define ACPI_PROCESSOR_NOTIFY_PERFORMANCE 0x80
@@ -58,6 +64,13 @@ static const struct acpi_device_id processor_device_ids[] = {
 };
 MODULE_DEVICE_TABLE(acpi, processor_device_ids);
 
+#define ICPU(model)	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, }
+static const struct x86_cpu_id intel_cpu_ids[] = {
+	ICPU(INTEL_FAM6_ICELAKE_MOBILE),	/* ICL */
+	{}
+};
+MODULE_DEVICE_TABLE(x86cpu, intel_cpu_ids);
+
 static struct device_driver acpi_processor_driver = {
 	.name = "processor",
 	.bus = &cpu_subsys,
@@ -226,6 +239,7 @@ static inline void acpi_pss_perf_exit(struct acpi_processor *pr,
 static int __acpi_processor_start(struct acpi_device *device)
 {
 	struct acpi_processor *pr = acpi_driver_data(device);
+	const struct x86_cpu_id *id;
 	acpi_status status;
 	int result = 0;
 
@@ -239,7 +253,9 @@ static int __acpi_processor_start(struct acpi_device *device)
 	if (result && !IS_ENABLED(CONFIG_ACPI_CPU_FREQ_PSS))
 		dev_dbg(&device->dev, "CPPC data invalid or not present\n");
 
-	if (!cpuidle_get_driver() || cpuidle_get_driver() == &acpi_idle_driver)
+	id = x86_match_cpu(intel_cpu_ids);
+	if (!id && (!cpuidle_get_driver() || cpuidle_get_driver() ==
+		&acpi_idle_driver))
 		acpi_processor_power_init(pr);
 
 	result = acpi_pss_perf_init(pr, device);
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#7 lore raw
Quoted 9 lines · Anshuman Gupta

There were few system hung observed while running i915_pm_rpm igt test. FDO https://bugs.freedesktop.org/show_bug.cgi?id=108840
Root cause is believed to due to page fault in ACPI idle driver. (FDO comment 18).
It has been suggested by Daniel Vetter to disable ACPI idle driver for Core-for-CI, only for ICL.

This hacky patch is only for ICL processor and for Core-for-CI branch.

Quoted 7 lines

v2: Fixed compilation errors raised by lkp.
commit message improvement.

This is fine only as long as it doesn't anywhere close to the mainline.

If ACPI idle crashes on new Intel HW, it needs to be fixed to work with it instead of refusing to work on it.

Quoted 44 lines
---
  drivers/acpi/processor_driver.c | 18 +++++++++++++++++-
  1 file changed, 17 insertions(+), 1 deletion(-)
drivers/acpi/processor_driver.c +14 -0
index 9d6aff2..ee842a2f 100644
@@ -35,6 +35,12 @@
 
  #include <acpi/processor.h>
 
+/* Only for Core-for-CI so don't want ia64 to fail compilation.*/
+#ifdef CONFIG_X86
+#include <asm/cpu_device_id.h>
+#include <asm/intel-family.h>
+#endif
+
  #include "internal.h"
 
  #define ACPI_PROCESSOR_NOTIFY_PERFORMANCE 0x80
@@ -58,6 +64,13 @@ static const struct acpi_device_id processor_device_ids[] = {
  };
  MODULE_DEVICE_TABLE(acpi, processor_device_ids);
 
+#define ICPU(model)	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, }
+static const struct x86_cpu_id intel_cpu_ids[] = {
+	ICPU(INTEL_FAM6_ICELAKE_MOBILE),	/* ICL */
+	{}
+};
+MODULE_DEVICE_TABLE(x86cpu, intel_cpu_ids);
+
  static struct device_driver acpi_processor_driver = {
  	.name = "processor",
  	.bus = &cpu_subsys,
@@ -226,6 +239,7 @@ static inline void acpi_pss_perf_exit(struct acpi_processor *pr,
  static int __acpi_processor_start(struct acpi_device *device)
  {
  	struct acpi_processor *pr = acpi_driver_data(device);
+	const struct x86_cpu_id *id;
  	acpi_status status;
  	int result = 0;
 

drivers/acpi/processor_driver.c static int __acpi_processor_start(struct acpi_device *device) · line 261

Quoted 10 lines
drivers/acpi/processor_driver.c +3 -1
@@ -239,7 +253,9 @@ static int __acpi_processor_start(struct acpi_device *device)
  	if (result && !IS_ENABLED(CONFIG_ACPI_CPU_FREQ_PSS))
  		dev_dbg(&device->dev, "CPPC data invalid or not present\n");
 
-	if (!cpuidle_get_driver() || cpuidle_get_driver() == &acpi_idle_driver)
+	id = x86_match_cpu(intel_cpu_ids);
+	if (!id && (!cpuidle_get_driver() || cpuidle_get_driver() ==
+		&acpi_idle_driver))
  		acpi_processor_power_init(pr);
 
  	result = acpi_pss_perf_init(pr, device);

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#8 lore raw
Quoted 16 lines · Rafael J
Quoted 15 lines · Anshuman Gupta

There were few system hung observed while running i915_pm_rpm igt test. FDO https://bugs.freedesktop.org/show_bug.cgi?id=108840
Root cause is believed to due to page fault in ACPI idle driver. (FDO comment 18).
It has been suggested by Daniel Vetter to disable ACPI idle driver for Core-for-CI, only for ICL.

This hacky patch is only for ICL processor and for Core-for-CI branch.

v2: Fixed compilation errors raised by lkp.
commit message improvement.

Quoted 6 lines
Quoted 1 line

This is fine only as long as it doesn't anywhere close to the mainline.

If ACPI idle crashes on new Intel HW, it needs to be fixed to work with it instead of refusing to work on it.\

Yes, this is the point of topic/core-for-ci:
https://cgit.freedesktop.org/drm/drm-intel/log/?h=topic/core-for-CI

I'll need to unblock the execution of the shards by filing a bug for the issue caught by BAT, and when we get a green FULL results, we'll be good to merge.

Martin

Quoted 48 lines
Quoted 48 lines
---
  drivers/acpi/processor_driver.c | 18 +++++++++++++++++-
  1 file changed, 17 insertions(+), 1 deletion(-)
drivers/acpi/processor_driver.c +14 -0
index 9d6aff2..ee842a2f 100644
@@ -35,6 +35,12 @@
 
  #include <acpi/processor.h>
 
+/* Only for Core-for-CI so don't want ia64 to fail compilation.*/
+#ifdef CONFIG_X86
+#include <asm/cpu_device_id.h>
+#include <asm/intel-family.h>
+#endif
+
  #include "internal.h"
 
  #define ACPI_PROCESSOR_NOTIFY_PERFORMANCE 0x80
@@ -58,6 +64,13 @@ static const struct acpi_device_id processor_device_ids[] = {
  };
  MODULE_DEVICE_TABLE(acpi, processor_device_ids);
 
+#define ICPU(model)	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, }
+static const struct x86_cpu_id intel_cpu_ids[] = {
+	ICPU(INTEL_FAM6_ICELAKE_MOBILE),	/* ICL */
+	{}
+};
+MODULE_DEVICE_TABLE(x86cpu, intel_cpu_ids);
+
  static struct device_driver acpi_processor_driver = {
  	.name = "processor",
  	.bus = &cpu_subsys,
@@ -226,6 +239,7 @@ static inline void acpi_pss_perf_exit(struct acpi_processor *pr,
  static int __acpi_processor_start(struct acpi_device *device)
  {
  	struct acpi_processor *pr = acpi_driver_data(device);
+	const struct x86_cpu_id *id;
  	acpi_status status;
  	int result = 0;
 
@@ -239,7 +253,9 @@ static int __acpi_processor_start(struct acpi_device *device)
  	if (result && !IS_ENABLED(CONFIG_ACPI_CPU_FREQ_PSS))
  		dev_dbg(&device->dev, "CPPC data invalid or not present\n");
 
Quoted 10 lines

drivers/acpi/processor_driver.c static int __acpi_processor_start(struct acpi_device *device) · line 261

Quoted 7 lines
drivers/acpi/processor_driver.c +3 -1
-	if (!cpuidle_get_driver() || cpuidle_get_driver() == &acpi_idle_driver)
+	id = x86_match_cpu(intel_cpu_ids);
+	if (!id && (!cpuidle_get_driver() || cpuidle_get_driver() ==
+		&acpi_idle_driver))
  		acpi_processor_power_init(pr);
 
  	result = acpi_pss_perf_init(pr, device);

---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#9 lore raw

✗ Fi.CI.BAT: failure for Core-for-CI:ICL_only Disable ACPI idle driver (rev2)

In reply to Anshuman Gupta
== Series Details ==

== Series Details ==

Series: Core-for-CI:ICL_only Disable ACPI idle driver (rev2)
URL : https://patchwork.freedesktop.org/series/59170/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5892 -> Patchwork_12735
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_12735 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_12735, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/59170/revisions/2/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_12735:

### IGT changes ###

#### Possible regressions ####

* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-glk-dsi: PASS -> FAIL

Known issues
------------

Here are the changes found in Patchwork_12735 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_cs_nop@fork-compute0:
- fi-icl-y: NOTRUN -> SKIP [fdo#109315] +17

* igt@gem_exec_basic@basic-bsd2:
- fi-icl-y: NOTRUN -> SKIP [fdo#109276] +7

* igt@gem_exec_parse@basic-rejected:
- fi-icl-y: NOTRUN -> SKIP [fdo#109289] +1

* igt@i915_module_load@reload:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]

* igt@i915_selftest@live_contexts:
- fi-icl-y: NOTRUN -> DMESG-FAIL [fdo#108569]

* igt@kms_chamelium@dp-crc-fast:
- fi-icl-y: NOTRUN -> SKIP [fdo#109284] +8

* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-y: NOTRUN -> SKIP [fdo#109285] +3

* igt@kms_psr@primary_mmap_gtt:
- fi-icl-y: NOTRUN -> SKIP [fdo#110189] +3

* igt@prime_vgem@basic-fence-flip:
- fi-icl-y: NOTRUN -> SKIP [fdo#109294]

#### Possible fixes ####

* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: FAIL [fdo#103167] -> PASS
- {fi-icl-u2}: FAIL [fdo#103167] -> PASS

#### Warnings ####

* igt@i915_pm_rpm@module-reload:
- fi-glk-dsi: DMESG-FAIL [fdo#105538] / [fdo#107732] / [fdo#109513] -> DMESG-WARN [fdo#105538] / [fdo#107732] / [fdo#109513]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#105538]: https://bugs.freedesktop.org/show_bug.cgi?id=105538
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107732]: https://bugs.freedesktop.org/show_bug.cgi?id=107732
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109513]: https://bugs.freedesktop.org/show_bug.cgi?id=109513
[fdo#109593]: https://bugs.freedesktop.org/show_bug.cgi?id=109593
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189

Participating hosts (46 -> 43)
------------------------------

Additional (2): fi-icl-y fi-icl-dsi
Missing (5): fi-ilk-m540 fi-byt-squawks fi-kbl-7500u fi-ctg-p8600 fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_5892 -> Patchwork_12735

CI_DRM_5892: 48cdcacb0060baa3474a80d68e1ea6829457add9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4932: 08cf63a8fac11e3594b57580331fb319241a0d69 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12735: 7ea82e502ddb448ea43fde65b78649b3d8cccfd0 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

7ea82e502ddb Core-for-CI:ICL_only Disable ACPI idle driver

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12735/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx