Skip to contentSkip to conversation

arm64: ptrace: Add function argument access API

PATCH New Masami Hiramatsu 1 participant 1 message Apr 12, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 arm64: ptrace: Add function argument access API

Add regs_get_argument() which returns N th argument of the function call. On arm64, it supports up to 8th argument.
Note that this chooses most probably assignment, in some case it can be incorrect (e.g. passing data structure or floating point etc.)

This enables ftrace kprobe events to access kernel function arguments via $argN syntax.

---
Changes in v2:
- Use pt_regs_read_reg()
- Update comment for the incorrect corner case.

---
 arch/arm64/Kconfig              |    1 +
 arch/arm64/include/asm/ptrace.h |   22 ++++++++++++++++++++++
 2 files changed, 23 insertions(+)
arch/arm64/Kconfig +1 -0
index 7e34b9eba5de..dad972cb8b65 100644
@@ -148,6 +148,7 @@ config ARM64
 	select HAVE_PERF_REGS
 	select HAVE_PERF_USER_STACK_DUMP
 	select HAVE_REGS_AND_STACK_ACCESS_API
+	select HAVE_FUNCTION_ARG_ACCESS_API
 	select HAVE_RCU_TABLE_FREE
 	select HAVE_RCU_TABLE_INVALIDATE
 	select HAVE_RSEQ
arch/arm64/include/asm/ptrace.h +22 -0
index ec60174c8c18..2038dca1e2c2 100644
@@ -305,6 +305,28 @@ static inline unsigned long regs_return_value(struct pt_regs *regs)
 	return regs->regs[0];
 }
 
+/**
+ * regs_get_kernel_argument() - get Nth function argument in kernel
+ * @regs:	pt_regs of that context
+ * @n:		function argument number (start from 0)
+ *
+ * regs_get_argument() returns @n th argument of the function call.
+ *
+ * Note that this chooses most probably assignment. In very rare case
+ * this may not return correct data, for example, one of the function
+ * parameter is 16bytes (128bits) or bigger. In such case, we can not
+ * get that big parameter correctly, but also register assignment of
+ * parameters after that will be shifted.
+ */
+static inline unsigned long regs_get_kernel_argument(struct pt_regs *regs,
+						     unsigned int n)
+{
+#define NR_REG_ARGUMENTS 8
+	if (n < NR_REG_ARGUMENTS)
+		return pt_regs_read_reg(regs, n);
+	return 0;
+}
+
 /* We must avoid circular header include via sched.h */
 struct task_struct;
 int valid_user_regs(struct user_pt_regs *regs, struct task_struct *task);