printk: tie printk_once / printk_deferred_once into .data.once for reset
Subsystems (2)
PATCH 1/1 printk: tie printk_once / printk_deferred_once into .data.once for reset
In commit b1fca27d384e ("kernel debug: support resetting WARN*_ONCE") we got the opportunity to reset state on the one shot messages, without having to reboot.
However printk_once (printk_deferred_once) live in a different file and didn't get the same kind of update/conversion, so they remain unconditionally one shot, until the system is rebooted.
For example, we currently have:
sched/rt.c: printk_deferred_once("sched: RT throttling activated\n");..which could reasonably be tripped as someone is testing and tuning a new system/workload and their task placements. For consistency, and to avoid reboots in the same vein as the original commit, we make these two instances of _once the same as the WARN*_ONCE instances are.
--- Documentation/clearing-warn-once.txt | 2 +- include/linux/printk.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
Documentation/clearing-warn-once.txt +1 -1
@@ -1,5 +1,5 @@ -WARN_ONCE / WARN_ON_ONCE only print a warning once. +WARN_ONCE / WARN_ON_ONCE / printk_once only emit a message once. echo 1 > /sys/kernel/debug/clear_warn_once
include/linux/printk.h +2 -2
@@ -347,7 +347,7 @@ extern int kptr_restrict;#ifdef CONFIG_PRINTK #define printk_once (fmt, ...) \ ({ \ - static bool __print_once __read_mostly; \ + static bool __section(.data.once) __print_once; \ bool __ret_print_once = !__print_once; \ \ if (!__print_once) { \
@@ -358,7 +358,7 @@ extern int kptr_restrict; })#define printk_deferred_once (fmt, ...) \ ({ \ - static bool __print_once __read_mostly; \ + static bool __section(.data.once) __print_once; \ bool __ret_print_once = !__print_once; \ \ if (!__print_once) { \
Signature · 1 line
2.7.4
Quoted 3 lines · Paul Gortmaker
In commit
b1fca27d384e("kernel debug: support resetting WARN*_ONCE") we got the opportunity to reset state on the one shot messages, without having to reboot.
Didn't know that.
Quoted 4 lines
However
printk_once(printk_deferred_once) live in a different file and didn't get the same kind of update/conversion, so they remain unconditionally one shot, until the system is rebooted.
Quoted 8 lines
For example, we currently have:
sched/rt.c: printk_deferred_once("sched: RT throttling activated\n");..which could reasonably be tripped as someone is testing and tuning a new system/workload and their task placements. For consistency, and to avoid reboots in the same vein as the original commit, we make these two instances of
_oncethe same as the WARN*_ONCE instances are.
Looks OK to me.
-ss
Petr Mladek
maintainerQuoted 15 lines · Sergey Senozhatsky
Quoted 3 lines · Paul Gortmaker
In commit
b1fca27d384e("kernel debug: support resetting WARN*_ONCE") we got the opportunity to reset state on the one shot messages, without having to reboot.Didn't know that.
Quoted 8 lines
However
printk_once(printk_deferred_once) live in a different file and didn't get the same kind of update/conversion, so they remain unconditionally one shot, until the system is rebooted.For example, we currently have:
sched/rt.c: printk_deferred_once("sched: RT throttling activated\n");
Quoted 8 lines
Quoted 4 lines
..which could reasonably be tripped as someone is testing and tuning a new system/workload and their task placements. For consistency, and to avoid reboots in the same vein as the original commit, we make these two instances of
_oncethe same as the WARN*_ONCE instances are.Looks OK to me.
Reviewed-by Sergey Senozhatsky <[email protected]>
The patch has been commited into printk.git, branch for-5.2.
Best Regards,
Petr