Skip to contentSkip to conversation

ARM: dts: imx6qdl-udoo: Add Pincfgs for OTG

PATCH Superseded Markus Kueffner 3 participants 7 messages Apr 6, 2019 – Sep 24, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: imx6qdl-udoo: Add Pincfgs for OTG

Add Pincfgs to enable the i.MX6's OTG feature for UDOO

---
 arch/arm/boot/dts/imx6qdl-udoo.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
arch/arm/boot/dts/imx6qdl-udoo.dtsi +16 -0
index 776bfc7..42954ee 100644
@@ -221,6 +221,14 @@
 			>;
 		};
 
+		pinctrl_usbotg: usbotg {
+			fsl,pins = <
+				MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059
+				MX6QDL_PAD_EIM_D22__USB_OTG_PWR 0x17059
+				MX6QDL_PAD_EIM_D21__USB_OTG_OC 0x17059
+			>;
+		};
+
 		pinctrl_ac97_running: ac97running {
 			fsl,pins = <
 				MX6QDL_PAD_DI0_PIN2__AUD6_TXD		0x1b0b0
@@ -294,6 +302,14 @@
 	status = "okay";
 };
 
+&usbotg {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usbotg>;
+	fsl,power-line-polarity-active-high;
+	fsl,over-current-polarity-active-low;
+	status = "okay";
+};
+
 &audmux {
 	status = "okay";
 };
Signature · 1 line
2.1.4
#1 lore raw
Quoted 13 lines · Markus Kueffner

Add Pincfgs to enable the i.MX6's OTG feature for UDOO

---
 arch/arm/boot/dts/imx6qdl-udoo.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
arch/arm/boot/dts/imx6qdl-udoo.dtsi +0 -0
index 776bfc7..42954ee 100644
@@ -221,6 +221,14 @@
 			>;

arch/arm/boot/dts/imx6qdl-udoo.dtsi line 231

Quoted 10 lines
arch/arm/boot/dts/imx6qdl-udoo.dtsi +8 -0
 		};
 
+		pinctrl_usbotg: usbotg {
+			fsl,pins = <
+				MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059
+				MX6QDL_PAD_EIM_D22__USB_OTG_PWR 0x17059
+				MX6QDL_PAD_EIM_D21__USB_OTG_OC 0x17059
+			>;
+		};
+

I know ac97 is out of order, but I still would like to keep pinctrl nodes sort alphabetically. That said, pinctrl_usbotg should go after pinctrl_usbh.

arch/arm/boot/dts/imx6qdl-udoo.dtsi line 309

Quoted 12 lines
arch/arm/boot/dts/imx6qdl-udoo.dtsi +5 -0
 		pinctrl_ac97_running: ac97running {
 			fsl,pins = <
 				MX6QDL_PAD_DI0_PIN2__AUD6_TXD		0x1b0b0
@@ -294,6 +302,14 @@
 	status = "okay";
 };
 
+&usbotg {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usbotg>;
+	fsl,power-line-polarity-active-high;
+	fsl,over-current-polarity-active-low;

Are these two properties supported by upstream bindings and driver?

Shawn

Quoted 9 lines
arch/arm/boot/dts/imx6qdl-udoo.dtsi +3 -0
+	status = "okay";
+};
+
 &audmux {
 	status = "okay";
 };
Signature · 1 line
2.1.4
#2 lore raw

PATCH v2 1/1 ARM: dts: imx6qdl-udoo: Add Pincfgs for OTG

Add Pincfgs to enable the i.MX6's OTG feature for UDOO

---
Changes in v2:
- put pinctrl_usbotg node after pinctrl_usbh as suggested
- remove unsupported properties from &usbotg

 arch/arm/boot/dts/imx6qdl-udoo.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/boot/dts/imx6qdl-udoo.dtsi +14 -0
index 776bfc7..828dd20 100644
@@ -210,6 +210,14 @@
 			>;
 		};
 
+		pinctrl_usbotg: usbotg {
+			fsl,pins = <
+				MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059
+				MX6QDL_PAD_EIM_D22__USB_OTG_PWR 0x17059
+				MX6QDL_PAD_EIM_D21__USB_OTG_OC 0x17059
+			>;
+		};
+
 		pinctrl_usdhc3: usdhc3grp {
 			fsl,pins = <
 				MX6QDL_PAD_SD3_CMD__SD3_CMD		0x17059
@@ -287,6 +295,12 @@
 	status = "okay";
 };
 
+&usbotg {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usbotg>;
+	status = "okay";
+};
+
 &usdhc3 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_usdhc3>;
Signature · 1 line
2.1.4
#5 lore raw
Quoted 6 lines · Shawn Guo
Quoted 3 lines · Markus Kueffner

Add Pincfgs to enable the i.MX6's OTG feature for UDOO

Applied, thanks.

Hello,

I was wondering when this might get merged into a release. Is there anything else I need to fix?

Best Regards,
Markus

#6 lore raw
Quoted 4 lines · Markus Kueffner
Quoted 3 lines · Shawn Guo
Quoted 2 lines · Markus Kueffner

Add Pincfgs to enable the i.MX6's OTG feature for UDOO

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Applied, thanks.

Hello,

I was wondering when this might get merged into a release. Is there anything else I need to fix?

I'm sorry, Markus. There was something wrong on my side, and the patch did not really get applied for 5.4. I just fixed it for the next release. Sorry about that!

Shawn