soundwire: intel: fix implicit header use of module.h/export.h
PATCH 1/1 soundwire: intel: fix implicit header use of module.h/export.h
These two files are implicitly relying on an instance of including module.h from <linux/acpi.h>.
Ideally, header files under include/linux shouldn't be adding includes of other headers, in anticipation of their consumers, but just the headers needed for the header itself to pass parsing with CPP.
The module.h is particularly bad in this sense, as it itself does include a whole bunch of other headers, due to the complexity of module support.
Here, we make those includes explicit, in order to allow a future removal of module.h from linux/acpi.h without causing build breakage.
drivers/soundwire/intel.c +1 -0
@@ -7,6 +7,7 @@#include <linux/acpi.h> #include <linux/delay.h> +#include <linux/module.h> #include <linux/interrupt.h> #include <linux/platform_device.h> #include <sound/pcm_params.h>
drivers/soundwire/intel_init.c +2 -0
@@ -8,6 +8,8 @@*/ #include <linux/acpi.h> +#include <linux/export.h> +#include <linux/module.h> #include <linux/platform_device.h> #include <linux/soundwire/sdw_intel.h> #include "intel.h"
Signature · 1 line
2.11.0
Quoted 8 lines · Paul Gortmaker
These two files are implicitly relying on an instance of including
module.hfrom <linux/acpi.h>.Ideally, header files under
include/linuxshouldn't be adding includes of other headers, in anticipation of their consumers, but just the headers needed for the header itself to pass parsing with CPP.
Quoted 6 lines
The
module.his particularly bad in this sense, as it itself does include a whole bunch of other headers, due to the complexity of module support.Here, we make those includes explicit, in order to allow a future removal of
module.hfromlinux/acpi.hwithout causing build breakage.
Applied, thanks
Signature · 1 line
~Vinod