sound: soc-acpi: fix implicit header use of module.h/export.h
PATCH 1/1 sound: soc-acpi: fix implicit header use of module.h/export.h
This file is implicitly relying on an instance of including module.h from <linux/acpi.h>.
Ideally, header files under include/linux shouldn't be adding includes of other headers, in anticipation of their consumers, but just the headers needed for the header itself to pass parsing with CPP.
The module.h is particularly bad in this sense, as it itself does include a whole bunch of other headers, due to the complexity of module support.
Here, we make the include explicit, in order to allow the future removal of module.h from linux/acpi.h without causing build breakage.
sound/soc/soc-acpi.c +2 -0
@@ -4,6 +4,8 @@// // Copyright (c) 2013-15, Intel Corporation. +#include <linux/export.h> +#include <linux/module.h> #include <sound/soc-acpi.h> struct snd_soc_acpi_mach *
Signature · 1 line
2.11.0
Mark Brown
maintainerApplied "sound: soc-acpi: fix implicit header use of module.h/export.h" to the asoc tree
The patch
sound: soc-acpi: fix implicit header use of module.h/export.h
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.3
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
473849e7f208b2d7de004c6c6c0eabe037d125acMon Sep 17 00:00:00 2001
From: Paul Gortmaker <[email protected]>
Date: Sat, 13 Apr 2019 11:15:18 -0400
Subject: [PATCH] sound: soc-acpi: fix implicit header use of module.h/export.h
This file is implicitly relying on an instance of including module.h from <linux/acpi.h>.
Ideally, header files under include/linux shouldn't be adding includes of other headers, in anticipation of their consumers, but just the headers needed for the header itself to pass parsing with CPP.
The module.h is particularly bad in this sense, as it itself does include a whole bunch of other headers, due to the complexity of module support.
Here, we make the include explicit, in order to allow the future removal of module.h from linux/acpi.h without causing build breakage.
--- sound/soc/soc-acpi.c | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/soc-acpi.c +2 -0
@@ -4,6 +4,8 @@// // Copyright (c) 2013-15, Intel Corporation. +#include <linux/export.h> +#include <linux/module.h> #include <sound/soc-acpi.h> struct snd_soc_acpi_mach *
Signature · 1 line
2.20.1
Mark Brown
maintainerQuoted 2 lines · Paul Gortmaker
This file is implicitly relying on an instance of including
module.hfrom <linux/acpi.h>.
Please use subject lines matching the style for the subsystem. This makes it easier for people to identify relevant patches.