Skip to contentSkip to conversation

mac80211: Fix kernel panic due to use of txq after free

PATCH In review Bhagavathi Perumal S 2 participants 2 messages Apr 16, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mac80211: Fix kernel panic due to use of txq after free

The txq of vif is added to active_txqs list for ATF TXQ scheduling in the function ieee80211_queue_skb(), but it was not properly removed before freeing the txq object. It was causing use after free of the txq objects from the active_txqs list, result was kernel panic due to invalid memory access.

Fix kernel invalid memory access by properly removing txq object from active_txqs list before free the object.

---
 net/mac80211/iface.c | 3 +++
 1 file changed, 3 insertions(+)
net/mac80211/iface.c +3 -0
index 94459b2..410685d 100644
@@ -1907,6 +1907,9 @@ void ieee80211_if_remove(struct ieee80211_sub_if_data *sdata)
 	list_del_rcu(&sdata->list);
 	mutex_unlock(&sdata->local->iflist_mtx);
 
+	if (sdata->vif.txq)
+		ieee80211_txq_purge(sdata->local, to_txq_info(sdata->vif.txq));
+
 	synchronize_rcu();
 
 	if (sdata->dev) {
Signature · 7 lines
1.9.1


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Bhagavathi Perumal S

The txq of vif is added to active_txqs list for ATF TXQ scheduling in the function ieee80211_queue_skb(), but it was not properly removed before freeing the txq object. It was causing use after free of the txq objects from the active_txqs list, result was kernel panic due to invalid memory access.

Fix kernel invalid memory access by properly removing txq object from active_txqs list before free the object.

Nice catch, thanks!

This should probably have a fixes tag:

Fixes 1866760096bf ("mac80211: Add TXQ scheduling API")

-Toke