Skip to contentSkip to conversation

igt/i915/i915_pm_lpsp enable pm_lpsp for platforms till Gen11 v3

PATCH Superseded Anshuman Gupta 4 participants 9 messages Apr 16, 2019 – Apr 24, 2019

v3 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

v3 cover igt/i915/i915_pm_lpsp enable pm_lpsp for platforms till Gen11 v3

i915_pm_lpsp patch, sending v3 version after adding few more pacthes to series in order fix CI IGT failures.
1. Check lpsp relevance on non edp panel which.
2. skip edp-panel-fitter test for Gen9 platfrom onwards.

This series has added i915_pm_lpsp subtests to CI fast feedback list in order to run cover these subtest on all affected platforms.

Revision 1 Link: https://patchwork.freedesktop.org/series/58051/

Anshuman Gupta (4):
igt/i915/i915_pm_lpsp enable pm_lpsp for platforms till Gen11. igt/i915/i915_pm_lpsp check lpsp relevance on non edp panel. igt/i915/i915_pm_lpsp skip edp-panel-fitter test. DO_NOT_MERGE add i915_pm_lpsp subtests to CI fast feedback list.

 tests/i915/i915_pm_lpsp.c             | 91 +++++++++++++++++++++++++++++++++--
 tests/intel-ci/fast-feedback.testlist |  4 ++
 2 files changed, 91 insertions(+), 4 deletions(-)
Signature · 6 lines
2.7.4

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

PATCH v3 1/4 igt/i915/i915_pm_lpsp enable pm_lpsp for platforms till Gen11.

Enabling i915_pm_lpsp igt tests for all platforms till Gen11. Earlier these test were enabled only on haswell and broadwell platforms.

---
 tests/i915/i915_pm_lpsp.c | 30 ++++++++++++++++++++++++++++--
 1 file changed, 28 insertions(+), 2 deletions(-)
tests/i915/i915_pm_lpsp.c +28 -2
index b319dbe..020f8b3 100644
@@ -30,18 +30,43 @@
 #include <fcntl.h>
 #include <unistd.h>
 
+#define   HSW_PW_CTL_IDX_GLOBAL                 15
+#define   SKL_PW_CTL_IDX_PW_2                   15
+#define   ICL_PW_CTL_IDX_PW_3                   2
+
+#define   HSW_PWR_WELL_CTL_REQ(pw_idx)          (0x2 << ((pw_idx) * 2))
+#define   HSW_PWR_WELL_CTL_STATE(pw_idx)        (0x1 << ((pw_idx) * 2))
+
+int no_lpsp_pw_idx;
 
 static bool supports_lpsp(uint32_t devid)
 {
-	return IS_HASWELL(devid) || IS_BROADWELL(devid);
+	return IS_HASWELL(devid) || IS_BROADWELL(devid)
+				 || AT_LEAST_GEN(devid, 9);
+}
+
+static bool get_no_lpsp_pw_idx(uint32_t devid)
+{
+	if (IS_HASWELL(devid) || IS_BROADWELL(devid))
+		no_lpsp_pw_idx = HSW_PW_CTL_IDX_GLOBAL;
+	else if (IS_GEN(devid, 11))
+		no_lpsp_pw_idx = ICL_PW_CTL_IDX_PW_3;
+	else if (AT_LEAST_GEN(devid, 9))
+		no_lpsp_pw_idx = SKL_PW_CTL_IDX_PW_2;
+	else
+		return false;
+
+	return true;
 }
 
 static bool lpsp_is_enabled(int drm_fd)
 {
 	uint32_t val;
+	uint32_t mask = HSW_PWR_WELL_CTL_REQ(no_lpsp_pw_idx) |
+			HSW_PWR_WELL_CTL_STATE(no_lpsp_pw_idx);
 
 	val = INREG(HSW_PWR_WELL_CTL2);
-	return !(val & HSW_PWR_WELL_STATE_ENABLED);
+	return !((val & mask) == mask);
 }
 
 /* The LPSP mode is all about an enabled pipe, but we expect to also be in the
@@ -212,6 +237,7 @@ igt_main
 
 		intel_register_access_init(intel_get_pci_device(), 0, drm_fd);
 
+		igt_require(get_no_lpsp_pw_idx(devid));
 		kmstest_set_vt_graphics_mode();
 	}
 
Signature · 6 lines
2.7.4

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#2 lore raw

Re: [igt-dev] [PATCH i-g-t v3 1/4] igt/i915/i915_pm_lpsp enable pm_lpsp for platforms till Gen11.

Hi,

Quoted 16 lines · Anshuman Gupta

Enabling i915_pm_lpsp igt tests for all platforms till Gen11. Earlier these test were enabled only on haswell and broadwell platforms.

---
  tests/i915/i915_pm_lpsp.c | 30 ++++++++++++++++++++++++++++--
  1 file changed, 28 insertions(+), 2 deletions(-)
tests/i915/i915_pm_lpsp.c +0 -0
index b319dbe..020f8b3 100644
@@ -30,18 +30,43 @@
  #include <fcntl.h>

tests/i915/i915_pm_lpsp.c line 40

Quoted 10 lines
tests/i915/i915_pm_lpsp.c +8 -0
  #include <unistd.h>
 
+#define   HSW_PW_CTL_IDX_GLOBAL                 15
+#define   SKL_PW_CTL_IDX_PW_2                   15
+#define   ICL_PW_CTL_IDX_PW_3                   2
+
+#define   HSW_PWR_WELL_CTL_REQ(pw_idx)          (0x2 << ((pw_idx) * 2))
+#define   HSW_PWR_WELL_CTL_STATE(pw_idx)        (0x1 << ((pw_idx) * 2))
+
+int no_lpsp_pw_idx;

Please add a code-comment about the purpose of using global variable if it is really needed.

tests/i915/i915_pm_lpsp.c line 48

Quoted 9 lines
tests/i915/i915_pm_lpsp.c +5 -1
  static bool supports_lpsp(uint32_t devid)
  {
-	return IS_HASWELL(devid) || IS_BROADWELL(devid);
+	return IS_HASWELL(devid) || IS_BROADWELL(devid)
+				 || AT_LEAST_GEN(devid, 9);
+}
+
+static bool get_no_lpsp_pw_idx(uint32_t devid)

This function return type is confusing to me.

tests/i915/i915_pm_lpsp.c line 59

Quoted 11 lines
tests/i915/i915_pm_lpsp.c +11 -0
+{
+	if (IS_HASWELL(devid) || IS_BROADWELL(devid))
+		no_lpsp_pw_idx = HSW_PW_CTL_IDX_GLOBAL;
+	else if (IS_GEN(devid, 11))
+		no_lpsp_pw_idx = ICL_PW_CTL_IDX_PW_3;
+	else if (AT_LEAST_GEN(devid, 9))
+		no_lpsp_pw_idx = SKL_PW_CTL_IDX_PW_2;
+	else
+		return false;
+
+	return true;

This function is updating the power well index and also checking lpsp is supported or not which is duplication of existing function supports_lpsp(). As per the above code "update" tag is more suitable than "get".

tests/i915/i915_pm_lpsp.c line 66

Quoted 7 lines
tests/i915/i915_pm_lpsp.c +2 -0
  }
 
  static bool lpsp_is_enabled(int drm_fd)
  {
  	uint32_t val;
+	uint32_t mask = HSW_PWR_WELL_CTL_REQ(no_lpsp_pw_idx) |
+			HSW_PWR_WELL_CTL_STATE(no_lpsp_pw_idx);

get_no_lpsp_pw_idx() can be used here to get the power-well index and then use it to create the mask, then global variable can be avoided.

tests/i915/i915_pm_lpsp.c line 69

Quoted 4 lines
tests/i915/i915_pm_lpsp.c +1 -1
  	val = INREG(HSW_PWR_WELL_CTL2);
-	return !(val & HSW_PWR_WELL_STATE_ENABLED);
+	return !((val & mask) == mask);

0 or non-zero should be the decision maker. Better not compare with "mask" after masking,

tests/i915/i915_pm_lpsp.c igt_main · line 240

Quoted 8 lines
tests/i915/i915_pm_lpsp.c +1 -0
  }
 
  /* The LPSP mode is all about an enabled pipe, but we expect to also be in the
@@ -212,6 +237,7 @@ igt_main
 
  		intel_register_access_init(intel_get_pci_device(), 0, drm_fd);
 
+		igt_require(get_no_lpsp_pw_idx(devid));

supports_lpsp() maybe appropriate here to check igt is required or not.

Regards,
Animesh

tests/i915/i915_pm_lpsp.c igt_main · line 243

Quoted 3 lines
tests/i915/i915_pm_lpsp.c +0 -0
  		kmstest_set_vt_graphics_mode();
  	}
 

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#3 lore raw

PATCH v3 2/4 igt/i915/i915_pm_lpsp check lpsp relevance on non edp panel.

In reply to Anshuman Gupta

Earlier on HSW/BDW it was assumed that only eDP panel will act as lpsp. But that is not true now.
So checking whether a non edp panel can act as lpsp or not.

---
 tests/i915/i915_pm_lpsp.c | 57 ++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 56 insertions(+), 1 deletion(-)
tests/i915/i915_pm_lpsp.c +56 -1
index 020f8b3..b09d9a0 100644
@@ -36,6 +36,7 @@
 
 #define   HSW_PWR_WELL_CTL_REQ(pw_idx)          (0x2 << ((pw_idx) * 2))
 #define   HSW_PWR_WELL_CTL_STATE(pw_idx)        (0x1 << ((pw_idx) * 2))
+#define   LPSP_PORT				'A'
 
 int no_lpsp_pw_idx;
 
@@ -69,6 +70,56 @@ static bool lpsp_is_enabled(int drm_fd)
 	return !((val & mask) == mask);
 }
 
+static bool parse_port(FILE *file, char *info, char port)
+{
+	int ret;
+	bool is_port_found = false;
+
+	while (fgets(info, 256, file)) {
+		if (strstr(info, "encoder") && strstr(info, "DDI")) {
+			ret = sscanf(info, "%*s %*s %*s %*s %c", &port);
+			igt_assert_eq(ret, 1);
+			is_port_found = true;
+			break;
+		}
+	}
+	return is_port_found;
+}
+
+static bool non_edp_lpsp_check(int device)
+{
+	char tmp[256];
+	char port;
+	FILE *file;
+	int line;
+	int fd;
+	bool is_lpsp = false;
+
+	fd = igt_debugfs_open(device, "i915_display_info", O_RDONLY);
+	file = fdopen(fd, "r");
+	igt_skip_on(!file);
+
+	line = 0;
+	while (fgets(tmp, 256, file)) {
+		if (strstr(tmp, "CRTC") && line > 0) {
+			if (strstr(tmp, "pipe: A") &&
+			    strstr(tmp, "active=yes")) {
+				igt_require(parse_port(file, tmp, port));
+				if (port == LPSP_PORT)
+					is_lpsp =  true;
+				else
+					is_lpsp = false;
+				break;
+			}
+		}
+		line++;
+	}
+
+	fclose(file);
+	close(fd);
+	return is_lpsp;
+}
+
 /* The LPSP mode is all about an enabled pipe, but we expect to also be in the
  * low power mode when no pipes are enabled, so do this check anyway. */
 static void screens_disabled_subtest(int drm_fd, drmModeResPtr drm_res)
@@ -203,7 +254,11 @@ static void non_edp_subtest(int drm_fd, drmModeResPtr drm_res,
 			    &connector->connector_id, 1, mode);
 	igt_assert_eq(rc, 0);
 
-	igt_assert(!lpsp_is_enabled(drm_fd));
+	if (non_edp_lpsp_check(drm_fd) ||
+	    connector->connector_type == DRM_MODE_CONNECTOR_DSI)
+		igt_assert(lpsp_is_enabled(drm_fd));
+	else
+		igt_assert(!lpsp_is_enabled(drm_fd));
 }
 
 #define MAX_CONNECTORS 32
Signature · 6 lines
2.7.4

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#4 lore raw

PATCH v3 3/4 igt/i915/i915_pm_lpsp skip edp-panel-fitter test.

In reply to Anshuman Gupta

Skip edp-panel-fitter test for Gen9 onwards platform.

---
 tests/i915/i915_pm_lpsp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
tests/i915/i915_pm_lpsp.c +3 -1
index b09d9a0..414413e 100644
@@ -300,8 +300,10 @@ igt_main
 		screens_disabled_subtest(drm_fd, drm_res);
 	igt_subtest("edp-native")
 		edp_subtest(drm_fd, drm_res, drm_connectors, devid, false);
-	igt_subtest("edp-panel-fitter")
+	igt_subtest("edp-panel-fitter") {
+		igt_skip_on(AT_LEAST_GEN(devid, 9));
 		edp_subtest(drm_fd, drm_res, drm_connectors, devid, true);
+		}
 	igt_subtest("non-edp")
 		non_edp_subtest(drm_fd, drm_res, drm_connectors);
 
Signature · 6 lines
2.7.4

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#5 lore raw

PATCH v3 4/4 DO_NOT_MERGE add i915_pm_lpsp subtests to CI fast feedback list.

In reply to Anshuman Gupta

This patch adds below i915_pm_lpsp subtests to CI fast feedback list in order to test these subtest on ICL
(which is affected platform).
Subtests:
screens-disabled
edp-native
edp-panel-fitter
non-edp

---
 tests/intel-ci/fast-feedback.testlist | 4 ++++
 1 file changed, 4 insertions(+)
tests/intel-ci/fast-feedback.testlist +4 -0
index 9b71194..f278e7e 100644
@@ -227,6 +227,10 @@ igt@kms_psr@sprite_plane_onoff
 igt@kms_psr@primary_mmap_gtt
 igt@kms_setmode@basic-clone-single-crtc
 igt@i915_pm_backlight@basic-brightness
+igt@i915_pm_lpsp@edp-native
+igt@i915_pm_lpsp@edp-panel-fitter
+igt@i915_pm_lpsp@non-edp
+igt@i915_pm_lpsp@screens-disabled
 igt@i915_pm_rpm@basic-pci-d3-state
 igt@i915_pm_rpm@basic-rte
 igt@i915_pm_rps@basic-api
Signature · 6 lines
2.7.4

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#6 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for igt/i915/i915_pm_lpsp enable pm_lpsp for platforms till Gen11 v3

In reply to Anshuman Gupta
== Series Details ==

== Series Details ==

Series: igt/i915/i915_pm_lpsp enable pm_lpsp for platforms till Gen11 v3
URL : https://patchwork.freedesktop.org/series/59581/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5938 -> IGTPW_2866
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_2866 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_2866, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/59581/revisions/1/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_2866:

### IGT changes ###

#### Possible regressions ####

* igt@i915_pm_lpsp@edp-panel-fitter:
- fi-icl-y: NOTRUN -> SKIP +1
- fi-icl-u3: NOTRUN -> SKIP

* igt@i915_pm_lpsp@non-edp:
- fi-bxt-j4205: NOTRUN -> FAIL

* igt@i915_pm_lpsp@screens-disabled:
- fi-cfl-8109u: NOTRUN -> FAIL

Known issues
------------

Here are the changes found in IGTPW_2866 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@semaphore:
- fi-bdw-5557u: NOTRUN -> SKIP [fdo#109271] +40

* igt@amdgpu/amd_cs_nop@fork-compute0:
- fi-icl-y: NOTRUN -> SKIP [fdo#109315] +17

* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109315] +17

* igt@gem_exec_basic@basic-bsd2:
- fi-icl-y: NOTRUN -> SKIP [fdo#109276] +7

* igt@gem_exec_basic@gtt-bsd1:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109276] +7

* igt@gem_exec_parse@basic-rejected:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109289] +1
- fi-icl-y: NOTRUN -> SKIP [fdo#109289] +1

* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]

* igt@i915_pm_lpsp@edp-native:

    - fi-hsw-4770r:       NOTRUN -> SKIP [fdo#109271] +1
    - fi-pnv-d510:        NOTRUN -> SKIP [fdo#109271] +3
    - fi-snb-2520m:       NOTRUN -> SKIP [fdo#109271] +3
    - fi-byt-clapper:     NOTRUN -> SKIP [fdo#109271] +3
    - fi-kbl-x1275:       NOTRUN -> SKIP [fdo#109271] +1
    - fi-skl-lmem:        NOTRUN -> SKIP [fdo#109271] +1
    - fi-bwr-2160:        NOTRUN -> SKIP [fdo#109271] +3
    - fi-skl-6770hq:      NOTRUN -> SKIP [fdo#109271] +1
    - fi-kbl-8809g:       NOTRUN -> SKIP [fdo#109271] +2
    - fi-kbl-guc:         NOTRUN -> SKIP [fdo#109271] +2
    - fi-hsw-4770:        NOTRUN -> SKIP [fdo#109271] +2
    - fi-skl-gvtdvm:      NOTRUN -> SKIP [fdo#109271] +1
    - fi-skl-6700k2:      NOTRUN -> SKIP [fdo#109271] +1
    - fi-bxt-dsi:         NOTRUN -> SKIP [fdo#109271] +2
    - fi-skl-iommu:       NOTRUN -> SKIP [fdo#109271] +1
    - fi-cfl-guc:         NOTRUN -> SKIP [fdo#109271] +1
    - fi-skl-guc:         NOTRUN -> SKIP [fdo#109271] +1
    - fi-cfl-8700k:       NOTRUN -> SKIP [fdo#109271] +1
    - fi-apl-guc:         NOTRUN -> SKIP [fdo#109271] +1
    - fi-cfl-8109u:       NOTRUN -> SKIP [fdo#109271] +1
    - fi-bxt-j4205:       NOTRUN -> SKIP [fdo#109271] +1

* igt@i915_pm_lpsp@edp-panel-fitter:

    - fi-ilk-650:         NOTRUN -> SKIP [fdo#109271] +3
    - fi-bdw-gvtdvm:      NOTRUN -> SKIP [fdo#109271] +1
    - fi-hsw-peppy:       NOTRUN -> FAIL [fdo#106602]
    - fi-skl-6600u:       NOTRUN -> SKIP [fdo#109271] +1

* igt@i915_pm_lpsp@non-edp:

    - fi-byt-n2820:       NOTRUN -> SKIP [fdo#109271] +3
    - fi-ivb-3770:        NOTRUN -> SKIP [fdo#109271] +3
    - fi-byt-j1900:       NOTRUN -> SKIP [fdo#109271] +3
    - fi-snb-2600:        NOTRUN -> SKIP [fdo#109271] +3
    - fi-kbl-r:           NOTRUN -> SKIP [fdo#109271] +1
    - fi-hsw-peppy:       NOTRUN -> SKIP [fdo#109271]
    - fi-whl-u:           NOTRUN -> SKIP [fdo#109271] +1

* igt@i915_pm_lpsp@screens-disabled:

    - fi-elk-e7500:       NOTRUN -> SKIP [fdo#109271] +3
    - fi-gdg-551:         NOTRUN -> SKIP [fdo#109271] +3
    - fi-bsw-kefka:       NOTRUN -> SKIP [fdo#109271] +3

* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: PASS -> DMESG-FAIL [fdo#110235 ]

* igt@kms_chamelium@dp-crc-fast:
- fi-icl-y: NOTRUN -> SKIP [fdo#109284] +8

* igt@kms_chamelium@hdmi-edid-read:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109284] +8

* igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
- fi-glk-dsi: PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]

* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-y: NOTRUN -> SKIP [fdo#109285] +3

* igt@kms_force_connector_basic@prune-stale-modes:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109285] +3

* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: NOTRUN -> FAIL [fdo#103167]

* igt@kms_psr@cursor_plane_move:
- fi-skl-6260u: NOTRUN -> SKIP [fdo#109271] +39

* igt@kms_psr@primary_mmap_gtt:
- fi-icl-y: NOTRUN -> SKIP [fdo#110189] +3

* igt@prime_vgem@basic-fence-flip:
- fi-icl-y: NOTRUN -> SKIP [fdo#109294]

#### Possible fixes ####

* igt@i915_selftest@live_execlists:
- fi-apl-guc: INCOMPLETE [fdo#103927] / [fdo#109720] -> PASS

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#106602]: https://bugs.freedesktop.org/show_bug.cgi?id=106602
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133

Participating hosts (47 -> 43)
------------------------------

Additional (3): fi-icl-y fi-bdw-5557u fi-skl-6260u
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-bsw-n3050 fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus

Build changes
-------------

* IGT: IGT_4951 -> IGTPW_2866

CI_DRM_5938: 61a332623362ea87cdde81115229b1b955335654 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2866: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2866/
IGT_4951: cc9a60c029432b5843724e4f2c57f9f815f7adbb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2866/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#7 lore raw

Re: [igt-dev] ✗ Fi.CI.BAT: failure for igt/i915/i915_pm_lpsp enable pm_lpsp for platforms till Gen11 v3

Hi Imre ,
Sometimes it has been observed on Gen9 that screens-disabled i915_pm_lpsp sub-test failed because power well 2 was not disabled when subtest checks its register value. It get disabled slightly later.

https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2866/fi-cfl-8109u/igt@[email protected]

I checked it locally and found similar behaviour (there were three screens connected in my test), below are the log snippet.

[  254.042328] [IGT] i915_pm_lpsp: starting subtest screens-disabled
[  254.042374] [drm:drm_mode_setcrtc] [CRTC:47:pipe A]
[  254.250784] [drm:intel_disable_pipe [i915]] disabling pipe A
[  254.421970] [drm:drm_mode_setcrtc] Returning [CRTC:47:pipe A]
(kernel instrumenting log to indicate drm_mode_setcrtc has returned)
[  254.421990] [drm:drm_mode_setcrtc] [CRTC:65:pipe B]
[  254.423605] [drm:intel_disable_pipe [i915]] disabling pipe B
[  254.437460] [drm:drm_mode_setcrtc] Returning [CRTC:65:pipe B]
[  254.437476] [drm:drm_mode_setcrtc] [CRTC:83:pipe C]
[  254.438526] [drm:intel_disable_pipe [i915]] disabling pipe C
[  254.456603] [drm:drm_mode_setcrtc] Returning [CRTC:83:pipe C]
[  254.464966] [drm:intel_power_well_disable [i915]] disabling power well 2

We can see power well 2 is getting disabled after 8ms of drm_mode_setcrtc() ioctl returned, which is sufficient to fail the test.

Do u see any issue with driver behaviour.

If it is expected behaviour from i915 driver then we may need to have some wait while checking the power well 2 for lpsp.

Thanks ,
Anshuman Gupta.

Quoted 189 lines · Patchwork

== Series Details ==

Series: igt/i915/i915_pm_lpsp enable pm_lpsp for platforms till Gen11 v3
URL : https://patchwork.freedesktop.org/series/59581/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5938 -> IGTPW_2866
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_2866 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_2866, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

   External URL: https://patchwork.freedesktop.org/api/1.0/series/59581/revisions/1/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_2866:

### IGT changes ###

#### Possible regressions ####

* igt@i915_pm_lpsp@edp-panel-fitter:
- fi-icl-y: NOTRUN -> SKIP +1
- fi-icl-u3: NOTRUN -> SKIP

* igt@i915_pm_lpsp@non-edp:
- fi-bxt-j4205: NOTRUN -> FAIL

* igt@i915_pm_lpsp@screens-disabled:
- fi-cfl-8109u: NOTRUN -> FAIL

Known issues
------------

Here are the changes found in IGTPW_2866 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@semaphore:
- fi-bdw-5557u: NOTRUN -> SKIP [fdo#109271] +40

* igt@amdgpu/amd_cs_nop@fork-compute0:
- fi-icl-y: NOTRUN -> SKIP [fdo#109315] +17

* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109315] +17

* igt@gem_exec_basic@basic-bsd2:
- fi-icl-y: NOTRUN -> SKIP [fdo#109276] +7

* igt@gem_exec_basic@gtt-bsd1:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109276] +7

* igt@gem_exec_parse@basic-rejected:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109289] +1
- fi-icl-y: NOTRUN -> SKIP [fdo#109289] +1

* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]

* igt@i915_pm_lpsp@edp-native:

     - fi-hsw-4770r:       NOTRUN -> SKIP [fdo#109271] +1
     - fi-pnv-d510:        NOTRUN -> SKIP [fdo#109271] +3
     - fi-snb-2520m:       NOTRUN -> SKIP [fdo#109271] +3
     - fi-byt-clapper:     NOTRUN -> SKIP [fdo#109271] +3
     - fi-kbl-x1275:       NOTRUN -> SKIP [fdo#109271] +1
     - fi-skl-lmem:        NOTRUN -> SKIP [fdo#109271] +1
     - fi-bwr-2160:        NOTRUN -> SKIP [fdo#109271] +3
     - fi-skl-6770hq:      NOTRUN -> SKIP [fdo#109271] +1
     - fi-kbl-8809g:       NOTRUN -> SKIP [fdo#109271] +2
     - fi-kbl-guc:         NOTRUN -> SKIP [fdo#109271] +2
     - fi-hsw-4770:        NOTRUN -> SKIP [fdo#109271] +2
     - fi-skl-gvtdvm:      NOTRUN -> SKIP [fdo#109271] +1
     - fi-skl-6700k2:      NOTRUN -> SKIP [fdo#109271] +1
     - fi-bxt-dsi:         NOTRUN -> SKIP [fdo#109271] +2
     - fi-skl-iommu:       NOTRUN -> SKIP [fdo#109271] +1
     - fi-cfl-guc:         NOTRUN -> SKIP [fdo#109271] +1
     - fi-skl-guc:         NOTRUN -> SKIP [fdo#109271] +1
     - fi-cfl-8700k:       NOTRUN -> SKIP [fdo#109271] +1
     - fi-apl-guc:         NOTRUN -> SKIP [fdo#109271] +1
     - fi-cfl-8109u:       NOTRUN -> SKIP [fdo#109271] +1
     - fi-bxt-j4205:       NOTRUN -> SKIP [fdo#109271] +1

* igt@i915_pm_lpsp@edp-panel-fitter:

     - fi-ilk-650:         NOTRUN -> SKIP [fdo#109271] +3
     - fi-bdw-gvtdvm:      NOTRUN -> SKIP [fdo#109271] +1
     - fi-hsw-peppy:       NOTRUN -> FAIL [fdo#106602]
     - fi-skl-6600u:       NOTRUN -> SKIP [fdo#109271] +1

* igt@i915_pm_lpsp@non-edp:

     - fi-byt-n2820:       NOTRUN -> SKIP [fdo#109271] +3
     - fi-ivb-3770:        NOTRUN -> SKIP [fdo#109271] +3
     - fi-byt-j1900:       NOTRUN -> SKIP [fdo#109271] +3
     - fi-snb-2600:        NOTRUN -> SKIP [fdo#109271] +3
     - fi-kbl-r:           NOTRUN -> SKIP [fdo#109271] +1
     - fi-hsw-peppy:       NOTRUN -> SKIP [fdo#109271]
     - fi-whl-u:           NOTRUN -> SKIP [fdo#109271] +1

* igt@i915_pm_lpsp@screens-disabled:

     - fi-elk-e7500:       NOTRUN -> SKIP [fdo#109271] +3
     - fi-gdg-551:         NOTRUN -> SKIP [fdo#109271] +3
     - fi-bsw-kefka:       NOTRUN -> SKIP [fdo#109271] +3

* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: PASS -> DMESG-FAIL [fdo#110235 ]

* igt@kms_chamelium@dp-crc-fast:
- fi-icl-y: NOTRUN -> SKIP [fdo#109284] +8

* igt@kms_chamelium@hdmi-edid-read:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109284] +8

* igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
- fi-glk-dsi: PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]

* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-y: NOTRUN -> SKIP [fdo#109285] +3

* igt@kms_force_connector_basic@prune-stale-modes:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109285] +3

* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: NOTRUN -> FAIL [fdo#103167]

* igt@kms_psr@cursor_plane_move:
- fi-skl-6260u: NOTRUN -> SKIP [fdo#109271] +39

* igt@kms_psr@primary_mmap_gtt:
- fi-icl-y: NOTRUN -> SKIP [fdo#110189] +3

* igt@prime_vgem@basic-fence-flip:
- fi-icl-y: NOTRUN -> SKIP [fdo#109294]

#### Possible fixes ####

   * igt@i915_selftest@live_execlists:
     - fi-apl-guc:         INCOMPLETE [fdo#103927] / [fdo#109720] -> PASS

   
   {name}: This element is suppressed. This means it is ignored when computing
           the status of the difference (SUCCESS, WARNING, or FAILURE).

   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
   [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
   [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
   [fdo#106602]: https://bugs.freedesktop.org/show_bug.cgi?id=106602
   [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
   [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
   [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
   [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
   [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
   [fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294
   [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
   [fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
   [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
   [fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
   [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133

Participating hosts (47 -> 43)
------------------------------

   Additional (3): fi-icl-y fi-bdw-5557u fi-skl-6260u
   Missing    (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-bsw-n3050 fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus

Build changes
-------------

* IGT: IGT_4951 -> IGTPW_2866

Quoted 8 lines
   CI_DRM_5938: 61a332623362ea87cdde81115229b1b955335654 @ git://anongit.freedesktop.org/gfx-ci/linux
   IGTPW_2866: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2866/
   IGT_4951: cc9a60c029432b5843724e4f2c57f9f815f7adbb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2866/

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#8 lore raw

Re: [igt-dev] ✗ Fi.CI.BAT: failure for igt/i915/i915_pm_lpsp enable pm_lpsp for platforms till Gen11 v3

Quoted 23 lines · Anshuman

Hi Imre ,
Sometimes it has been observed on Gen9 that screens-disabled i915_pm_lpsp sub-test failed because power well 2 was not disabled when subtest checks its register value. It get disabled slightly later.

https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2866/fi-cfl-8109u/igt@[email protected]

I checked it locally and found similar behaviour (there were three screens connected in my test), below are the log snippet.

[  254.042328] [IGT] i915_pm_lpsp: starting subtest screens-disabled
[  254.042374] [drm:drm_mode_setcrtc] [CRTC:47:pipe A]
[  254.250784] [drm:intel_disable_pipe [i915]] disabling pipe A
[  254.421970] [drm:drm_mode_setcrtc] Returning [CRTC:47:pipe A]
(kernel instrumenting log to indicate drm_mode_setcrtc has returned)
[  254.421990] [drm:drm_mode_setcrtc] [CRTC:65:pipe B]
[  254.423605] [drm:intel_disable_pipe [i915]] disabling pipe B
[  254.437460] [drm:drm_mode_setcrtc] Returning [CRTC:65:pipe B]
[  254.437476] [drm:drm_mode_setcrtc] [CRTC:83:pipe C]
[  254.438526] [drm:intel_disable_pipe [i915]] disabling pipe C
[  254.456603] [drm:drm_mode_setcrtc] Returning [CRTC:83:pipe C]
[  254.464966] [drm:intel_power_well_disable [i915]] disabling power well 2
Quoted 7 lines

We can see power well 2 is getting disabled after 8ms of drm_mode_setcrtc() ioctl returned, which is sufficient to fail the test.

Do u see any issue with driver behaviour.

If it is expected behaviour from i915 driver then we may need to have some wait while checking the power well 2 for lpsp.

I think the only reason can be delayed audio disabling. In the above CFL log I see, which would point to that:

<7> [235.044427] [drm:hsw_audio_codec_disable [i915]] Disable audio codec on pipe A

I haven't managed to track this down in the depths of the HDA runtime PM code, but I suspect it will result in a - delayed - runtime PM put on the HDA device which will end up calling i915_audio_component_put_power(), that drops the PW#2 reference.

You could prove this by dumping debugfs/i915_runtime_pm_status and i915_power_domain_info when you see PW#2 still on after the IOCTL returned. You should btw make this debug output part of the test, perhaps even making a generic helper that we could call in similar failing scenarios.

If that proves to be the case, the solution is to wait for PW#2 to go off with some timeout as you suggested.

Thanks for the investigate work!

Quoted 197 lines

Thanks ,
Anshuman Gupta.

Quoted 193 lines · Patchwork

== Series Details ==

Series: igt/i915/i915_pm_lpsp enable pm_lpsp for platforms till Gen11 v3
URL : https://patchwork.freedesktop.org/series/59581/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5938 -> IGTPW_2866
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_2866 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_2866, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

   External URL: https://patchwork.freedesktop.org/api/1.0/series/59581/revisions/1/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_2866:

### IGT changes ###

#### Possible regressions ####

* igt@i915_pm_lpsp@edp-panel-fitter:
- fi-icl-y: NOTRUN -> SKIP +1
- fi-icl-u3: NOTRUN -> SKIP

* igt@i915_pm_lpsp@non-edp:
- fi-bxt-j4205: NOTRUN -> FAIL

* igt@i915_pm_lpsp@screens-disabled:
- fi-cfl-8109u: NOTRUN -> FAIL

Known issues
------------

Here are the changes found in IGTPW_2866 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@semaphore:
- fi-bdw-5557u: NOTRUN -> SKIP [fdo#109271] +40

* igt@amdgpu/amd_cs_nop@fork-compute0:
- fi-icl-y: NOTRUN -> SKIP [fdo#109315] +17

* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109315] +17

* igt@gem_exec_basic@basic-bsd2:
- fi-icl-y: NOTRUN -> SKIP [fdo#109276] +7

* igt@gem_exec_basic@gtt-bsd1:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109276] +7

* igt@gem_exec_parse@basic-rejected:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109289] +1
- fi-icl-y: NOTRUN -> SKIP [fdo#109289] +1

* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]

* igt@i915_pm_lpsp@edp-native:

     - fi-hsw-4770r:       NOTRUN -> SKIP [fdo#109271] +1
     - fi-pnv-d510:        NOTRUN -> SKIP [fdo#109271] +3
     - fi-snb-2520m:       NOTRUN -> SKIP [fdo#109271] +3
     - fi-byt-clapper:     NOTRUN -> SKIP [fdo#109271] +3
     - fi-kbl-x1275:       NOTRUN -> SKIP [fdo#109271] +1
     - fi-skl-lmem:        NOTRUN -> SKIP [fdo#109271] +1
     - fi-bwr-2160:        NOTRUN -> SKIP [fdo#109271] +3
     - fi-skl-6770hq:      NOTRUN -> SKIP [fdo#109271] +1
     - fi-kbl-8809g:       NOTRUN -> SKIP [fdo#109271] +2
     - fi-kbl-guc:         NOTRUN -> SKIP [fdo#109271] +2
     - fi-hsw-4770:        NOTRUN -> SKIP [fdo#109271] +2
     - fi-skl-gvtdvm:      NOTRUN -> SKIP [fdo#109271] +1
     - fi-skl-6700k2:      NOTRUN -> SKIP [fdo#109271] +1
     - fi-bxt-dsi:         NOTRUN -> SKIP [fdo#109271] +2
     - fi-skl-iommu:       NOTRUN -> SKIP [fdo#109271] +1
     - fi-cfl-guc:         NOTRUN -> SKIP [fdo#109271] +1
     - fi-skl-guc:         NOTRUN -> SKIP [fdo#109271] +1
     - fi-cfl-8700k:       NOTRUN -> SKIP [fdo#109271] +1
     - fi-apl-guc:         NOTRUN -> SKIP [fdo#109271] +1
     - fi-cfl-8109u:       NOTRUN -> SKIP [fdo#109271] +1
     - fi-bxt-j4205:       NOTRUN -> SKIP [fdo#109271] +1

* igt@i915_pm_lpsp@edp-panel-fitter:

     - fi-ilk-650:         NOTRUN -> SKIP [fdo#109271] +3
     - fi-bdw-gvtdvm:      NOTRUN -> SKIP [fdo#109271] +1
     - fi-hsw-peppy:       NOTRUN -> FAIL [fdo#106602]
     - fi-skl-6600u:       NOTRUN -> SKIP [fdo#109271] +1

* igt@i915_pm_lpsp@non-edp:

     - fi-byt-n2820:       NOTRUN -> SKIP [fdo#109271] +3
     - fi-ivb-3770:        NOTRUN -> SKIP [fdo#109271] +3
     - fi-byt-j1900:       NOTRUN -> SKIP [fdo#109271] +3
     - fi-snb-2600:        NOTRUN -> SKIP [fdo#109271] +3
     - fi-kbl-r:           NOTRUN -> SKIP [fdo#109271] +1
     - fi-hsw-peppy:       NOTRUN -> SKIP [fdo#109271]
     - fi-whl-u:           NOTRUN -> SKIP [fdo#109271] +1

* igt@i915_pm_lpsp@screens-disabled:

     - fi-elk-e7500:       NOTRUN -> SKIP [fdo#109271] +3
     - fi-gdg-551:         NOTRUN -> SKIP [fdo#109271] +3
     - fi-bsw-kefka:       NOTRUN -> SKIP [fdo#109271] +3

* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: PASS -> DMESG-FAIL [fdo#110235 ]

* igt@kms_chamelium@dp-crc-fast:
- fi-icl-y: NOTRUN -> SKIP [fdo#109284] +8

* igt@kms_chamelium@hdmi-edid-read:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109284] +8

* igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
- fi-glk-dsi: PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]

* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-y: NOTRUN -> SKIP [fdo#109285] +3

* igt@kms_force_connector_basic@prune-stale-modes:
- fi-icl-u3: NOTRUN -> SKIP [fdo#109285] +3

* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: NOTRUN -> FAIL [fdo#103167]

* igt@kms_psr@cursor_plane_move:
- fi-skl-6260u: NOTRUN -> SKIP [fdo#109271] +39

* igt@kms_psr@primary_mmap_gtt:
- fi-icl-y: NOTRUN -> SKIP [fdo#110189] +3

* igt@prime_vgem@basic-fence-flip:
- fi-icl-y: NOTRUN -> SKIP [fdo#109294]

#### Possible fixes ####

   * igt@i915_selftest@live_execlists:
     - fi-apl-guc:         INCOMPLETE [fdo#103927] / [fdo#109720] -> PASS

   {name}: This element is suppressed. This means it is ignored when computing
           the status of the difference (SUCCESS, WARNING, or FAILURE).

   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
   [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
   [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
   [fdo#106602]: https://bugs.freedesktop.org/show_bug.cgi?id=106602
   [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
   [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
   [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
   [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
   [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
   [fdo#109294]: https://bugs.freedesktop.org/show_bug.cgi?id=109294
   [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
   [fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
   [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
   [fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
   [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133

Participating hosts (47 -> 43)
------------------------------

   Additional (3): fi-icl-y fi-bdw-5557u fi-skl-6260u
   Missing    (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-bsw-n3050 fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus

Build changes
-------------

* IGT: IGT_4951 -> IGTPW_2866

   CI_DRM_5938: 61a332623362ea87cdde81115229b1b955335654 @ git://anongit.freedesktop.org/gfx-ci/linux
   IGTPW_2866: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2866/
   IGT_4951: cc9a60c029432b5843724e4f2c57f9f815f7adbb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2866/

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev