Skip to contentSkip to conversation

brcmfmac: remove the duplicate line of sending mail box interrupt

PATCH In review Wright Feng 2 participants 4 messages Apr 22, 2019 – Apr 25, 2019 Broadcom BRCM80211 IEEE802.11 wireless drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 brcmfmac: remove the duplicate line of sending mail box interrupt

The line is duplicate so remove it from pcie.c. We don't need to send host to dongle mail box interrupt twice after writing data.

---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c +0 -1
index fd3968f..ca619a9 100644
@@ -698,7 +698,6 @@ brcmf_pcie_send_mb_data(struct brcmf_pciedev_info *devinfo, u32 htod_mb_data)
 
 	brcmf_pcie_write_tcm32(devinfo, addr, htod_mb_data);
 	pci_write_config_dword(devinfo->pdev, BRCMF_PCIE_REG_SBMBX, 1);
-	pci_write_config_dword(devinfo->pdev, BRCMF_PCIE_REG_SBMBX, 1);
 
 	return 0;
 }
Signature · 1 line
2.1.0
maintainer
#1 lore raw
Quoted 2 lines · Wright Feng

The line is duplicate so remove it from pcie.c. We don't need to send host to dongle mail box interrupt twice after writing data.

Hi Wright,

Thanks for the patch. I am a bit early as it is not uncommon that hardware requires an extra kick. Might be the case here for some chips. Will follow-up on it.

Regards,
Arend

Quoted 4 lines
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 1 -
 1 file changed, 1 deletion(-)
maintainer
#2 lore raw
Quoted 8 lines · Arend Van Spriel
Quoted 2 lines · Wright Feng

The line is duplicate so remove it from pcie.c. We don't need to send host to dongle mail box interrupt twice after writing data.

Hi Wright,

Thanks for the patch. I am a bit early as it is not uncommon that hardware requires an extra kick. Might be the case here for some chips. Will follow-up on it.

Hi Wright,

I checked in our dhd driver code and it also does a double write. Turns out to be a hardware workaround so we need to keep this. It is worth a comment though.

Thanks,
Arend

#3 lore raw
Quoted 12 lines · Arend Van Spriel
Quoted 10 lines · Arend Van Spriel
Quoted 2 lines · Wright Feng

The line is duplicate so remove it from pcie.c. We don't need to send host to dongle mail box interrupt twice after writing data.

Hi Wright,

Thanks for the patch. I am a bit early as it is not uncommon that hardware requires an extra kick. Might be the case here for some chips. Will follow-up on it.

Quoted 6 lines

Hi Wright,

I checked in our dhd driver code and it also does a double write. Turns out to be a hardware workaround so we need to keep this. It is worth a comment though.

Hi Arend,

Thanks for the information.
NXP and I worked on suspend/resume stress test issue with 1FD(4359b1) two months ago, and we found one of root cause is duplicate mailbox interrupt.
I've checked the history of the hardware issue internally, and it seems that the issue is only on PCIEGEN2 revision 1 to 13.
So is that okay we can skip the hardware workaround when PCIEGEN2 revision is greater than 13 and add the comment on it in my patch v2?

Regards,
Wright

Quoted 2 lines

Thanks,
Arend