spi: TI power management: add missing of table registration
PATCH 1/1 spi: TI power management: add missing of table registration
MODULE_DEVICE_TABLE(of, <of_match_table> should be called to complete DT OF mathing mechanism and register it.
Before this patch:
modinfo drivers/mfd/tps65912-spi.ko | grep alias
alias: spi:tps65912
After this patch:
modinfo drivers/mfd/tps65912-spi.ko | grep alias
alias: of:N*T*Cti,tps65912C* alias: of:N*T*Cti,tps65912 alias: spi:tps65912
--- drivers/mfd/tps65912-spi.c | 1 + 1 file changed, 1 insertion(+)
drivers/mfd/tps65912-spi.c +1 -0
@@ -27,6 +27,7 @@ static const struct of_device_id tps65912_spi_of_match_table[] = { { .compatible = "ti,tps65912", }, {/* sentinel */ } }; +MODULE_DEVICE_TABLE (of, tps65912_spi_of_match_table);static int tps65912_spi_probe (struct spi_device *spi) {
Signature · 1 line
2.7.4
Lee Jones
AppliedThe subject line is not correct. This is an MFD driver.
When submitting you should follow the convention for the subsystem you are patching against. The following command is helpful:
`git log --oneline -- <SUBSYSTEM>`
I will fix it for you this time (and for the other patch I see).
Quoted 13 lines · Daniel Gomez
MODULE_DEVICE_TABLE(of, <
of_match_table> should be called to complete DT OF mathing mechanism and register it.Before this patch:
modinfodrivers/mfd/tps65912-spi.ko| grep alias
alias: spi:tps65912After this patch:
modinfodrivers/mfd/tps65912-spi.ko| grep aliasalias: of:N*T*Cti,tps65912C* alias: of:N*T*Cti,tps65912 alias: spi:tps65912
Quoted 5 lines
Reported-by Javier Martinez Canillas <[email protected]>Signed-off-by Daniel Gomez <[email protected]>--- drivers/mfd/tps65912-spi.c | 1 + 1 file changed, 1 insertion(+)
Applied, thanks.
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Quoted 10 lines · Lee Jones
The subject line is not correct. This is an MFD driver.
When submitting you should follow the convention for the subsystem you are patching against. The following command is helpful:
`git log --oneline -- <SUBSYSTEM>`I will fix it for you this time (and for the other patch I see).
Sorry for that and thanks for rewriting the subject.
Quoted 28 lines · Daniel Gomez
Quoted 14 lines
MODULE_DEVICE_TABLE(of, <
of_match_table> should be called to complete DT OF mathing mechanism and register it.Before this patch:
modinfodrivers/mfd/tps65912-spi.ko| grep alias
alias: spi:tps65912After this patch:
modinfodrivers/mfd/tps65912-spi.ko| grep aliasalias: of:N*T*Cti,tps65912C* alias: of:N*T*Cti,tps65912 alias: spi:tps65912Quoted 5 lines
Reported-by Javier Martinez Canillas <[email protected]>Signed-off-by Daniel Gomez <[email protected]>--- drivers/mfd/tps65912-spi.c | 1 + 1 file changed, 1 insertion(+)Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical LeadLinaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog