x86/Kconfig: deprecate DISCONTIGMEM support for 32-bit
Subsystems (2)
cover x86/Kconfig: deprecate DISCONTIGMEM support for 32-bit
Hi,
During the recent discussion [1] about DISCONTIGMEM being effectively deprecated, Christoph suggested to mark it as BROKEN for x86-32.
These patches follow that suggestion and make SPARSEMEM the default for X86_32 && NUMA and mark DISCONTIGMEM as BROKEN.
[1] https://lore.kernel.org/lkml/[email protected]/
Mike Rapoport (2):
x86/Kconfig: make SPARSEMEM default for 32-bit x86/Kconfig: deprecate DISCONTIGMEM support for 32-bit
arch/x86/Kconfig | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
Signature · 1 line
2.7.4
PATCH 1/2 x86/Kconfig: make SPARSEMEM default for 32-bit
Sparsemem has been a default memory model for x86-64 for over a decade since the commit b263295dbffd ("x86: 64-bit, make sparsemem vmemmap the only memory model").
Make it the default for 32-bit NUMA systems (if there any left) as well.
--- arch/x86/Kconfig | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
arch/x86/Kconfig +1 -6
@@ -1609,10 +1609,6 @@ config ARCH_DISCONTIGMEM_ENABLE def_bool y depends on NUMA && X86_32 -config ARCH_DISCONTIGMEM_DEFAULT - def_bool y - depends on NUMA && X86_32 - config ARCH_SPARSEMEM_ENABLE def_bool y depends on X86_64 || NUMA || X86_32 || X86_32_NON_STANDARD
@@ -1620,8 +1616,7 @@ config ARCH_SPARSEMEM_ENABLE select SPARSEMEM_VMEMMAP_ENABLE if X86_64 config ARCH_SPARSEMEM_DEFAULT - def_bool y - depends on X86_64 + def_bool X86_64 || (NUMA && X86_32) config ARCH_SELECT_MEMORY_MODEL def_bool y
Signature · 1 line
2.7.4
Re: [PATCH 1/2] x86/Kconfig: make SPARSEMEM default for 32-bit
Quoted 7 lines · Mike Rapoport
Sparsemem has been a default memory model for x86-64 for over a decade since the commit
b263295dbffd("x86: 64-bit, make sparsemem vmemmap the only memory model").Make it the default for 32-bit NUMA systems (if there any left) as well.
Signed-off-by Mike Rapoport <[email protected]>
Signature · 2 lines
Mel Gorman SUSE Labs
tip-bot for Mike Rapoport
merge bot[tip:x86/mm] x86/Kconfig: Make SPARSEMEM default for 32-bit x86
In reply to Mike Rapoportx86/Kconfig: Make SPARSEMEM default for 32-bit x86
Commit-ID: 6ad57f7f2cbf65daced27f023cc99360742a24b9 Gitweb: https://git.kernel.org/tip/6ad57f7f2cbf65daced27f023cc99360742a24b9 Author: Mike Rapoport <[email protected]> AuthorDate: Wed, 24 Apr 2019 16:24:11 +0300 Committer: Ingo Molnar <[email protected]> CommitDate: Thu, 25 Apr 2019 09:02:17 +0200
x86/Kconfig: Make SPARSEMEM default for 32-bit x86
Sparsemem has been a default memory model for x86-64 for over a decade, since:
b263295dbffd ("x86: 64-bit, make sparsemem vmemmap the only memory model").
Make it the default for 32-bit NUMA systems (if there any left) as well.
--- arch/x86/Kconfig | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
arch/x86/Kconfig +1 -6
@@ -1609,10 +1609,6 @@ config ARCH_DISCONTIGMEM_ENABLE def_bool y depends on NUMA && X86_32 -config ARCH_DISCONTIGMEM_DEFAULT - def_bool y - depends on NUMA && X86_32 - config ARCH_SPARSEMEM_ENABLE def_bool y depends on X86_64 || NUMA || X86_32 || X86_32_NON_STANDARD
@@ -1620,8 +1616,7 @@ config ARCH_SPARSEMEM_ENABLE select SPARSEMEM_VMEMMAP_ENABLE if X86_64 config ARCH_SPARSEMEM_DEFAULT - def_bool y - depends on X86_64 + def_bool X86_64 || (NUMA && X86_32) config ARCH_SELECT_MEMORY_MODEL def_bool y
PATCH 2/2 x86/Kconfig: deprecate DISCONTIGMEM support for 32-bit
In reply to Mike RapoportMel Gorman says:
32-bit NUMA systems should be non-existent in practice. The last NUMA system I'm aware of that was both NUMA and 32-bit only died somewhere between 2004 and 2007. If someone is running a 64-bit capable system in 32-bit mode with NUMA, they really are just punishing themselves for fun.
Mark DISCONTIGMEM broken for now and remove it in a couple of releases.
--- arch/x86/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/x86/Kconfig +2 -1
@@ -1606,8 +1606,9 @@ config ARCH_FLATMEM_ENABLE depends on X86_32 && !NUMA config ARCH_DISCONTIGMEM_ENABLE - def_bool y + def_bool n depends on NUMA && X86_32 + depends on BROKEN config ARCH_SPARSEMEM_ENABLE def_bool y
Signature · 1 line
2.7.4
Quoted 11 lines · Mike Rapoport
Mel Gorman says:
32-bit NUMA systems should be non-existent in practice. The last NUMA system I'm aware of that was both NUMA and 32-bit only died somewhere between 2004 and 2007. If someone is running a 64-bit capable system in 32-bit mode with NUMA, they really are just punishing themselves for fun.Mark DISCONTIGMEM broken for now and remove it in a couple of releases.
Suggested-by Christoph Hellwig <[email protected]>Suggested-by Mel Gorman <[email protected]>Signed-off-by Mike Rapoport <[email protected]>
It was really Christoph that suggested marking it broken but I do agree that it should be marked broken to see if anyone complains and if not, there is no real reason to keep discontig available on x86.
Signature · 2 lines
Mel Gorman SUSE Labs
tip-bot for Mike Rapoport
merge bot[tip:x86/mm] x86/Kconfig: Deprecate DISCONTIGMEM support for 32-bit x86
In reply to Mike Rapoportx86/Kconfig: Deprecate DISCONTIGMEM support for 32-bit x86
Commit-ID: 2792107dc3af29ecc1a9b3dc5bc873dac4b61cd6 Gitweb: https://git.kernel.org/tip/2792107dc3af29ecc1a9b3dc5bc873dac4b61cd6 Author: Mike Rapoport <[email protected]> AuthorDate: Wed, 24 Apr 2019 16:24:12 +0300 Committer: Ingo Molnar <[email protected]> CommitDate: Thu, 25 Apr 2019 09:02:18 +0200
x86/Kconfig: Deprecate DISCONTIGMEM support for 32-bit x86
Mel Gorman says:
"32-bit NUMA systems should be non-existent in practice. The last NUMA
system I'm aware of that was both NUMA and 32-bit only died somewhere between 2004 and 2007. If someone is running a 64-bit capable system in 32-bit mode with NUMA, they really are just punishing themselves for fun."
Mark DISCONTIGMEM broken for now as suggested by Christoph Hellwig, and (hopefully) remove it in a couple of releases.
--- arch/x86/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/x86/Kconfig +2 -1
@@ -1606,8 +1606,9 @@ config ARCH_FLATMEM_ENABLE depends on X86_32 && !NUMA config ARCH_DISCONTIGMEM_ENABLE - def_bool y + def_bool n depends on NUMA && X86_32 + depends on BROKEN config ARCH_SPARSEMEM_ENABLE def_bool y