fs/proc: add VmTaskSize field to /proc/$$/status
Subsystems (3)
PATCH 1/1 fs/proc: add VmTaskSize field to /proc/$$/status
Currently, there is no fast mechanism to get the virtual memory size of the current process from userspace. This information is available to the user through several means, one being a linear search of the entire address space. This is the method used by a component of the libhugetlb kernel test, and using the mechanism proposed in this patch, the time complexity of that test would be upgraded to constant time from linear time. This is especially relevant on 64-bit architechtures where a linear search of the address space could take an absurd amount of time. Using this mechanism, the modification to the test component would be portable across all architechtures.
--- fs/proc/task_mmu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
fs/proc/task_mmu.c +4 -1
@@ -74,7 +74,10 @@ void task_mem(struct seq_file *m, struct mm_struct *mm)seq_put_decimal_ull_width (m," kB\nVmPTE:\t" ,mm_pgtables_bytes (mm) >>10 ,8 );SEQ_PUT_DEC (" kB\nVmSwap:\t" , swap); -seq_puts (m," kB\n" ); +SEQ_PUT_DEC (" kB\nVmSwap:\t" , swap); +seq_put_decimal_ull_width (m, +" kB\nVmTaskSize:\t" ,TASK_SIZE >>10 ,8 ); +seq_puts (m," kB\n" );hugetlb_report_usage (m, mm); }#undef SEQ_PUT_DEC
Signature · 1 line
2.18.1
Quoted 35 lines · Joel Savitz
Currently, there is no fast mechanism to get the virtual memory size of the current process from userspace. This information is available to the user through several means, one being a linear search of the entire address space. This is the method used by a component of the libhugetlb kernel test, and using the mechanism proposed in this patch, the time complexity of that test would be upgraded to constant time from linear time. This is especially relevant on 64-bit architechtures where a linear search of the address space could take an absurd amount of time. Using this mechanism, the modification to the test component would be portable across all architechtures.
Signed-off-by Joel Savitz <[email protected]>--- fs/proc/task_mmu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)fs/proc/task_mmu.c +4
-1@@ -74,7 +74,10 @@ void task_mem(struct seq_file *m, struct mm_struct *mm)seq_put_decimal_ull_width (m," kB\nVmPTE:\t" ,mm_pgtables_bytes (mm) >>10 ,8 );SEQ_PUT_DEC (" kB\nVmSwap:\t" , swap); -seq_puts (m," kB\n" ); +SEQ_PUT_DEC (" kB\nVmSwap:\t" , swap); +seq_put_decimal_ull_width (m, +" kB\nVmTaskSize:\t" ,TASK_SIZE >>10 ,8 ); +seq_puts (m," kB\n" );hugetlb_report_usage (m, mm); }#undef SEQ_PUT_DECSignature · 1 line
2.18.1
Quoted 6 lines · Joel Savitz
Currently, there is no fast mechanism to get the virtual memory size of the current process from userspace.
fs/proc/task_mmu.c void task_mem(struct seq_file *m, struct mm_struct *mm) · line 80
Quoted 8 lines
fs/proc/task_mmu.c +4
-1@@ -74,7 +74,10 @@ void task_mem(struct seq_file *m, struct mm_struct *mm)seq_put_decimal_ull_width (m," kB\nVmPTE:\t" ,mm_pgtables_bytes (mm) >>10 ,8 );SEQ_PUT_DEC (" kB\nVmSwap:\t" , swap); -seq_puts (m," kB\n" ); +SEQ_PUT_DEC (" kB\nVmSwap:\t" , swap); +seq_put_decimal_ull_width (m, +" kB\nVmTaskSize:\t" ,TASK_SIZE >>10 ,8 ); +seq_puts (m," kB\n" );
TASK_SIZE accesses "current", while this function accesses any ->mm.
Can you turn this into prctl(2) aka "current" refugee camp?
Andrew Morton
maintainerQuoted 10 lines · On Thu, 25 Apr 2019 16:57:47 -0400 Joel Savitz <[email protected]> wrote:
Currently, there is no fast mechanism to get the virtual memory size of the current process from userspace. This information is available to the user through several means, one being a linear search of the entire address space. This is the method used by a component of the libhugetlb kernel test, and using the mechanism proposed in this patch, the time complexity of that test would be upgraded to constant time from linear time. This is especially relevant on 64-bit architechtures where a linear search of the address space could take an absurd amount of time. Using this mechanism, the modification to the test component would be portable across all architechtures.
Please include all details on the observed performance improvements.
Quoted 2 lines
fs/proc/task_mmu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Please update Documentation/filesystems/proc.txt.