Skip to contentSkip to conversation

fit: Add support for printing more than one FPGA node name

PATCH In review tien.fong.chee at intel.com 3 participants 6 messages Feb 13, 2019 – May 19, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fit: Add support for printing more than one FPGA node name

From: Tien Fong Chee <[email protected]>

This would print out all the FPGA node names setting to fpga property.

---
 common/image-fit.c |   14 +++++++++++---
 1 files changed, 11 insertions(+), 3 deletions(-)
common/image-fit.c +11 -3
index ac901e1..816e17d 100644
@@ -263,6 +263,7 @@ static void fit_conf_print(const void *fit, int noffset, const char *p)
 	int ret;
 	int fdt_index, loadables_index;
 	int ndepth;
+	ulong count;
 
 	/* Mandatory properties */
 	ret = fit_get_desc(fit, noffset, &desc);
@@ -299,9 +300,16 @@ static void fit_conf_print(const void *fit, int noffset, const char *p)
 		printf("%s\n", uname);
 	}
 
-	uname = fdt_getprop(fit, noffset, FIT_FPGA_PROP, NULL);
-	if (uname)
-		printf("%s  FPGA:         %s\n", p, uname);
+	count = fit_conf_get_prop_node_count(fit, noffset, FIT_FPGA_PROP);
+
+	for (ndepth = 0; ndepth < count; ndepth++) {
+		int images_noffset = fit_conf_get_prop_node_index(fit, noffset,
+						FIT_FPGA_PROP, ndepth);
+		uname = fit_get_name(fit, images_noffset, NULL);
+
+		if (uname)
+			printf("%s  FPGA:         %s\n", p, uname);
+	}
 
 	/* Print out all of the specified loadables */
 	for (loadables_index = 0;
Signature · 1 line
1.7.7.4
#1 lore raw
Quoted 31 lines · tien.fong.chee at intel.com

From: Tien Fong Chee <[email protected]>

This would print out all the FPGA node names setting to fpga property.

---
 common/image-fit.c |   14 +++++++++++---
 1 files changed, 11 insertions(+), 3 deletions(-)
common/image-fit.c +4 -3
index ac901e1..816e17d 100644
@@ -263,6 +263,7 @@ static void fit_conf_print(const void *fit, int noffset, const char *p)
 	int ret;
 	int fdt_index, loadables_index;
 	int ndepth;
+	ulong count;
 
 	/* Mandatory properties */
 	ret = fit_get_desc(fit, noffset, &desc);
@@ -299,9 +300,16 @@ static void fit_conf_print(const void *fit, int noffset, const char *p)
 		printf("%s\n", uname);
 	}
 
-	uname = fdt_getprop(fit, noffset, FIT_FPGA_PROP, NULL);
-	if (uname)
-		printf("%s  FPGA:         %s\n", p, uname);
+	count = fit_conf_get_prop_node_count(fit, noffset, FIT_FPGA_PROP);
+
+	for (ndepth = 0; ndepth < count; ndepth++) {

common/image-fit.c static void fit_conf_print(const void *fit, int noffset, const char *p) · line 315

Quoted 10 lines
common/image-fit.c +7 -0
+		int images_noffset = fit_conf_get_prop_node_index(fit, noffset,
+						FIT_FPGA_PROP, ndepth);
+		uname = fit_get_name(fit, images_noffset, NULL);
+
+		if (uname)
+			printf("%s  FPGA:         %s\n", p, uname);
+	}
 
 	/* Print out all of the specified loadables */
 	for (loadables_index = 0;

While I'm fine with the conceptual change here, both fit_conf_get_prop_node_count / fit_conf_get_prop_node_index are defined later in the file and while public functions not documented in a header. Can you please do a patch that does so first, as we otherwise get a warning? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190422/4a9ae92b/attachment.sig>
#2 lore raw
Quoted 51 lines · Tom Rini
Quoted 48 lines · tien.fong.chee at intel.com

From: Tien Fong Chee <[email protected]>

This would print out all the FPGA node names setting to fpga property.

---
 common/image-fit.c |   14 +++++++++++---

 1 files changed, 11 insertions(+), 3 deletions(-)
common/image-fit.c +1 -0
index ac901e1..816e17d 100644
@@ -263,6 +263,7 @@ static void fit_conf_print(const void *fit, int
 noffset, const char *p)
  	int ret;
  	int fdt_index, loadables_index;
  	int ndepth;
+	ulong count;


  /* Mandatory properties */
  ret = fit_get_desc(fit, noffset, &desc);

common/image-fit.c +0 -0
@@ -299,9 +300,16 @@ static void fit_conf_print(const void *fit,
 int noffset, const char *p)
  		printf("%s\n", uname);
  	}

common/image-fit.c +1 -3
-	uname = fdt_getprop(fit, noffset, FIT_FPGA_PROP, NULL);
-	if (uname)
-		printf("%s  FPGA:         %s\n", p, uname);
+	count = fit_conf_get_prop_node_count(fit, noffset,

FIT_FPGA_PROP);

common/image-fit.c +3 -0
+
+	for (ndepth = 0; ndepth < count; ndepth++) {
+		int images_noffset =

fit_conf_get_prop_node_index(fit, noffset,

common/image-fit.c +1 -0
+						FIT_FPGA_PROP,

ndepth);

common/image-fit.c +4 -0
+		uname = fit_get_name(fit, images_noffset, NULL);
+
+		if (uname)
+			printf("%s  FPGA:         %s\n", p,

uname);

common/image-fit.c +1 -0
+	}


  /* Print out all of the specified loadables */

Quoted 8 lines
Quoted 1 line

  for (loadables_index = 0;

While I'm fine with the conceptual change here, both fit_conf_get_prop_node_count / fit_conf_get_prop_node_index are defined
later in the file and while public functions not documented in a header.
Can you please do a patch that does so first, as we otherwise get a warning?  Thanks!

The header file in this patch https://patchwork.ozlabs.org/patch/105828
9/ , unfortunately the review taking a bit longer than what i expected.

I would update you once the whole series patches are accepted.

Thanks a lot.

Quoted 1 line
#3 lore raw
Quoted 60 lines · Tien Fong
Quoted 51 lines · Tom Rini
Quoted 48 lines · tien.fong.chee at intel.com

From: Tien Fong Chee <[email protected]>

This would print out all the FPGA node names setting to fpga property.

---
 common/image-fit.c |   14 +++++++++++---

 1 files changed, 11 insertions(+), 3 deletions(-)
common/image-fit.c +1 -0
index ac901e1..816e17d 100644
@@ -263,6 +263,7 @@ static void fit_conf_print(const void *fit, int
 noffset, const char *p)
  	int ret;
  	int fdt_index, loadables_index;
  	int ndepth;
+	ulong count;


  /* Mandatory properties */
  ret = fit_get_desc(fit, noffset, &desc);

common/image-fit.c +0 -0
@@ -299,9 +300,16 @@ static void fit_conf_print(const void *fit,
 int noffset, const char *p)
  		printf("%s\n", uname);
  	}

common/image-fit.c +1 -3
-	uname = fdt_getprop(fit, noffset, FIT_FPGA_PROP, NULL);
-	if (uname)
-		printf("%s  FPGA:         %s\n", p, uname);
+	count = fit_conf_get_prop_node_count(fit, noffset,

FIT_FPGA_PROP);

common/image-fit.c +3 -0
+
+	for (ndepth = 0; ndepth < count; ndepth++) {
+		int images_noffset =

fit_conf_get_prop_node_index(fit, noffset,

common/image-fit.c +1 -0
+						FIT_FPGA_PROP,

ndepth);

common/image-fit.c +4 -0
+		uname = fit_get_name(fit, images_noffset, NULL);
+
+		if (uname)
+			printf("%s  FPGA:         %s\n", p,

uname);

common/image-fit.c +1 -0
+	}


  /* Print out all of the specified loadables */

Quoted 8 lines
Quoted 1 line

  for (loadables_index = 0;

While I'm fine with the conceptual change here, both fit_conf_get_prop_node_count / fit_conf_get_prop_node_index are defined
later in the file and while public functions not documented in a header.
Can you please do a patch that does so first, as we otherwise get a warning?  Thanks!

Quoted 4 lines

The header file in this patch https://patchwork.ozlabs.org/patch/1058289/,
unfortunately the review taking a bit longer than what i expected.

I would update you once the whole series patches are accepted.

Ah, OK, I'll hold off until the other series is complete.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190427/c5c09647/attachment.sig>
#4 lore raw
Quoted 70 lines · Tom Rini
Quoted 69 lines · Tien Fong
Quoted 67 lines · Tom Rini
Quoted 51 lines · tien.fong.chee at intel.co m

From: Tien Fong Chee <[email protected]>

This would print out all the FPGA node names setting to fpga property.

---
 common/image-fit.c |   14 +++++++++++---

 1 files changed, 11 insertions(+), 3 deletions(-)
common/image-fit.c +0 -0
index ac901e1..816e17d 100644
@@ -263,6 +263,7 @@ static void fit_conf_print(const void *fit,

int
noffset, const char *p)
  int ret;
  int fdt_index, loadables_index;
  int ndepth;

common/image-fit.c +1 -0
+	ulong count;


  /* Mandatory properties */
  ret = fit_get_desc(fit, noffset, &desc);

common/image-fit.c +0 -0
@@ -299,9 +300,16 @@ static void fit_conf_print(const void
 *fit,
 int noffset, const char *p)
  		printf("%s\n", uname);
  	}

common/image-fit.c +0 -1
-	uname = fdt_getprop(fit, noffset, FIT_FPGA_PROP,

NULL);

common/image-fit.c +1 -2
-	if (uname)
-		printf("%s  FPGA:         %s\n", p, uname);
+	count = fit_conf_get_prop_node_count(fit, noffset,

FIT_FPGA_PROP);

common/image-fit.c +3 -0
+
+	for (ndepth = 0; ndepth < count; ndepth++) {
+		int images_noffset =

fit_conf_get_prop_node_index(fit, noffset,

common/image-fit.c +1 -0
+						FIT_FPGA_PROP,

ndepth);

common/image-fit.c +1 -0
+		uname = fit_get_name(fit, images_noffset,

NULL);

common/image-fit.c +3 -0
+
+		if (uname)
+			printf("%s  FPGA:         %s\n", p,

uname);

common/image-fit.c +1 -0
+	}
Quoted 3 lines


  /* Print out all of the specified loadables */ for (loadables_index = 0;

While I'm fine with the conceptual change here, both fit_conf_get_prop_node_count / fit_conf_get_prop_node_index are defined
later in the file and while public functions not documented in a header.
Can you please do a patch that does so first, as we otherwise get a
warning?  Thanks!

Quoted 6 lines
Quoted 5 lines

The header file in this patch https://patchwork.ozlabs.org/patch/10
58289/,
unfortunately the review taking a bit longer than what i expected.

I would update you once the whole series patches are accepted.

Ah, OK, I'll hold off until the other series is complete.

The series is already in mainline master branch.

Thanks.

Quoted 1 line
#5 lore raw

PATCH 1/1 fit: Add support for printing more than one FPGA node name

In reply to tien.fong.chee at intel.com
Quoted 31 lines · tien.fong.chee at intel.com

From: Tien Fong Chee <[email protected]>

This would print out all the FPGA node names setting to fpga property.

---
 common/image-fit.c |   14 +++++++++++---
 1 files changed, 11 insertions(+), 3 deletions(-)
common/image-fit.c +4 -3
index ac901e1..816e17d 100644
@@ -263,6 +263,7 @@ static void fit_conf_print(const void *fit, int noffset, const char *p)
 	int ret;
 	int fdt_index, loadables_index;
 	int ndepth;
+	ulong count;
 
 	/* Mandatory properties */
 	ret = fit_get_desc(fit, noffset, &desc);
@@ -299,9 +300,16 @@ static void fit_conf_print(const void *fit, int noffset, const char *p)
 		printf("%s\n", uname);
 	}
 
-	uname = fdt_getprop(fit, noffset, FIT_FPGA_PROP, NULL);
-	if (uname)
-		printf("%s  FPGA:         %s\n", p, uname);
+	count = fit_conf_get_prop_node_count(fit, noffset, FIT_FPGA_PROP);
+
+	for (ndepth = 0; ndepth < count; ndepth++) {

common/image-fit.c static void fit_conf_print(const void *fit, int noffset, const char *p) · line 315

Quoted 10 lines
common/image-fit.c +7 -0
+		int images_noffset = fit_conf_get_prop_node_index(fit, noffset,
+						FIT_FPGA_PROP, ndepth);
+		uname = fit_get_name(fit, images_noffset, NULL);
+
+		if (uname)
+			printf("%s  FPGA:         %s\n", p, uname);
+	}
 
 	/* Print out all of the specified loadables */
 	for (loadables_index = 0;

There's a problem here. When I use buildman to make multiple boards (say 'arm', but something smaller should trigger it too), all of my builds get stuck on mkimage doing something. A build of a single board is fine.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190519/84c90e31/attachment.sig>