Skip to contentSkip to conversation

net/i40e: remove useless check for queue number

PATCH Applied Wei Zhao 3 participants 3 messages Apr 28, 2019 – Apr 29, 2019 Network drivers

lore
Share & tools
lore

Wei Zhao

author
#0 lore raw

PATCH 1/1 net/i40e: remove useless check for queue number

There is no need to do such a check of queue number, so remove it.

Fixes ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")
---
 drivers/net/i40e/i40e_ethdev.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/net/i40e/i40e_ethdev.c +0 -3
index dca61f0..5059bad 100644
@@ -12699,9 +12699,6 @@ i40e_config_rss_filter(struct i40e_pf *pf,
 		return -EINVAL;
 	}
 
-	if (rss_info->conf.queue_num)
-		return -EINVAL;
-
 	/* If both VMDQ and RSS enabled, not all of PF queues are configured.
 	 * It's necessary to calculate the actual PF queues that are configured.
 	 */
Signature · 1 line
2.7.5
Tested-by on v1 1/1
#1 lore raw

-----Original Message-----
From: Zhao1, Wei
Sent: Sunday, April 28, 2019 2:13 PM
To: [email protected]
Cc: [email protected]; Zhang, Qi Z <[email protected]>; Xiao, QimaiX <[email protected]>; Peng, Yuan <[email protected]>; Zhao1, Wei <[email protected]>
Subject: [PATCH] net/i40e: remove useless check for queue number

There is no need to do such a check of queue number, so remove it.

Fixes ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")
---
 drivers/net/i40e/i40e_ethdev.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/net/i40e/i40e_ethdev.c +0 -3
@@ -12699,9 +12699,6 @@ i40e_config_rss_filter(struct i40e_pf *pf,
 		return -EINVAL;
 	}
 
-	if (rss_info->conf.queue_num)
-		return -EINVAL;
-
 	/* If both VMDQ and RSS enabled, not all of PF queues are configured.
 	 * It's necessary to calculate the actual PF queues that are configured.
 	 */

--
2.7.5

Acked-by Applied
#2 lore raw
Quoted 21 lines

-----Original Message-----
From: Xiao, QimaiX
Sent: Sunday, April 28, 2019 2:51 PM
To: Zhao1, Wei <[email protected]>; [email protected]
Cc: [email protected]; Zhang, Qi Z <[email protected]>; Peng, Yuan <[email protected]>
Subject: RE: [PATCH] net/i40e: remove useless check for queue number

-----Original Message-----
From: Zhao1, Wei
Sent: Sunday, April 28, 2019 2:13 PM
To: [email protected]
Cc: [email protected]; Zhang, Qi Z <[email protected]>; Xiao, QimaiX <[email protected]>; Peng, Yuan <[email protected]>; Zhao1, Wei <[email protected]>
Subject: [PATCH] net/i40e: remove useless check for queue number

Quoted 5 lines

There is no need to do such a check of queue number, so remove it.

Fixes ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")

Applied to dpdk-next-net-intel.

Thanks
Qi