Skip to contentSkip to conversation

UAS: fix alignment of scatter/gather segments

DISCUSSION Oliver Neukum 1 participant 1 message Apr 29, 2019 USB

lore
Share & tools
lore
#0 lore raw
Quoted 11 lines · David Laight

From: Oliver Neukum

Review

Quoted 6 lines
(quoted diff) +5 -0
+	 * USB has unusual scatter-gather requirements: the length of each
+	 * scatterlist element except the last must be divisible by the
+	 * Bulk maxpacket value.  Fortunately this value is always a
+	 * power of 2.  Inform the block layer about this requirement.
+	 */

That isn't the correct restriction for XHCI. It has its own perverse restrictions.
I think they are all handled within the xhci driver.

Yes, but that does not matter. You just cannot assume that only XHCI will be used with UAS. In particular virtual drivers will be used.

Regards
Oliver